All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers
Date: Sun, 8 Jan 2006 13:57:00 +0100	[thread overview]
Message-ID: <20060108125700.GI3774@stusta.de> (raw)
In-Reply-To: <1136724072.30348.66.camel@pmac.infradead.org>

On Sun, Jan 08, 2006 at 12:41:12PM +0000, David Woodhouse wrote:
> On Sat, 2006-01-07 at 17:45 -0800, Andrew Morton wrote:
> > Hey, Adrian isn't an MTD developer
> 
> Indeed he is not. And while his minor nitpicks can sometimes be worth
> the effort, it's less useful for him to start making value judgements
> about removing drivers which have _theoretically_ been replaced by new
> code, but which are actually still being used in some cases.

I interpreted your "or just removed" in [1] as your approval for a patch 
to remove the non-compiling drivers.

I'm not a native English speaker, and therefore I might have 
misunderstood your email.

What I want for 2.6.16 is to remove the wrong dependency of MTD_SHARP on 
BROKEN and the non-compiling drivers either still hidden under BROKEN or 
removed.

If there is any way I can submit a patch achieving this that would be 
acceptable for you simply tell how exactly you want this patch.

> > What he's doing here is to poke other maintainers into getting the tree
> > cleaned up.  It's a useful thing to do.
> 
> I know what needs doing to clean the tree up -- and removing the older
> chip drivers is very far from the top of my todo list. If you really
> want to accelerate their demise, add a #warning and a printk saying "You
> should no longer be using this driver -- try using jedec_probe or
> cfi_probe instead and contact the linux-mtd list if that fails". 
>...

We are talking about drivers marked as BROKEN for one and a half years 
that do no longer compile.

> dwmw2

cu
Adrian

[1] http://lkml.org/lkml/2005/12/12/43

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers
Date: Sun, 8 Jan 2006 13:57:00 +0100	[thread overview]
Message-ID: <20060108125700.GI3774@stusta.de> (raw)
In-Reply-To: <1136724072.30348.66.camel@pmac.infradead.org>

On Sun, Jan 08, 2006 at 12:41:12PM +0000, David Woodhouse wrote:
> On Sat, 2006-01-07 at 17:45 -0800, Andrew Morton wrote:
> > Hey, Adrian isn't an MTD developer
> 
> Indeed he is not. And while his minor nitpicks can sometimes be worth
> the effort, it's less useful for him to start making value judgements
> about removing drivers which have _theoretically_ been replaced by new
> code, but which are actually still being used in some cases.

I interpreted your "or just removed" in [1] as your approval for a patch 
to remove the non-compiling drivers.

I'm not a native English speaker, and therefore I might have 
misunderstood your email.

What I want for 2.6.16 is to remove the wrong dependency of MTD_SHARP on 
BROKEN and the non-compiling drivers either still hidden under BROKEN or 
removed.

If there is any way I can submit a patch achieving this that would be 
acceptable for you simply tell how exactly you want this patch.

> > What he's doing here is to poke other maintainers into getting the tree
> > cleaned up.  It's a useful thing to do.
> 
> I know what needs doing to clean the tree up -- and removing the older
> chip drivers is very far from the top of my todo list. If you really
> want to accelerate their demise, add a #warning and a printk saying "You
> should no longer be using this driver -- try using jedec_probe or
> cfi_probe instead and contact the linux-mtd list if that fails". 
>...

We are talking about drivers marked as BROKEN for one and a half years 
that do no longer compile.

> dwmw2

cu
Adrian

[1] http://lkml.org/lkml/2005/12/12/43

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2006-01-08 12:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-07 22:07 [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers Adrian Bunk
2006-01-07 22:07 ` Adrian Bunk
2006-01-08  0:00 ` David Woodhouse
2006-01-08  0:00   ` David Woodhouse
2006-01-08  0:24   ` Adrian Bunk
2006-01-08  0:24     ` Adrian Bunk
2006-01-08  0:38     ` David Woodhouse
2006-01-08  0:38       ` David Woodhouse
2006-01-08  1:45       ` Andrew Morton
2006-01-08  1:45         ` Andrew Morton
2006-01-08 12:41         ` David Woodhouse
2006-01-08 12:41           ` David Woodhouse
2006-01-08 12:57           ` Adrian Bunk [this message]
2006-01-08 12:57             ` Adrian Bunk
2006-01-08 13:06             ` David Woodhouse
2006-01-08 13:06               ` David Woodhouse
2006-01-08 14:14               ` [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN Adrian Bunk
2006-01-08 14:14                 ` Adrian Bunk
2006-01-08 14:24                 ` David Woodhouse
2006-01-08 14:24                   ` David Woodhouse
  -- strict thread matches above, loose matches on Subject: below --
2006-01-06 18:14 [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers Adrian Bunk
2006-01-06 18:14 ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060108125700.GI3774@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.