All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN
Date: Sun, 8 Jan 2006 15:14:31 +0100	[thread overview]
Message-ID: <20060108141430.GJ3774@stusta.de> (raw)
In-Reply-To: <1136725580.30348.69.camel@pmac.infradead.org>

On Sun, Jan 08, 2006 at 01:06:20PM +0000, David Woodhouse wrote:
> On Sun, 2006-01-08 at 13:57 +0100, Adrian Bunk wrote:
> > What I want for 2.6.16 is to remove the wrong dependency of MTD_SHARP on 
> > BROKEN and the non-compiling drivers either still hidden under BROKEN or 
> > removed.
> > 
> > If there is any way I can submit a patch achieving this that would be 
> > acceptable for you simply tell how exactly you want this patch.
> 
> Remove the incorrect BROKEN dependency from MTD_OBSOLETE_CHIPS.
> 
> If you then want to add it again to any chip driver which really doesn't
> compile, feel free. But leave the map drivers alone. Those can be
> switched to use different chip back-ends. 

Patch below.

> dwmw2

cu
Adrian


<--  snip  -->


This patch removes the wrong dependency of MTD_OBSOLETE_CHIPS on BROKEN 
and marks the non-compiling MTD_AMDSTD and MTD_JEDEC drivers as BROKEN.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/mtd/chips/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.15-mm2-full/drivers/mtd/chips/Kconfig.old	2006-01-08 14:16:59.000000000 +0100
+++ linux-2.6.15-mm2-full/drivers/mtd/chips/Kconfig	2006-01-08 14:17:25.000000000 +0100
@@ -260,7 +260,7 @@
 	  with this driver will return -ENODEV upon access.
 
 config MTD_OBSOLETE_CHIPS
-	depends on MTD && BROKEN
+	depends on MTD
 	bool "Older (theoretically obsoleted now) drivers for non-CFI chips"
 	help
 	  This option does not enable any code directly, but will allow you to
@@ -273,7 +273,7 @@
 
 config MTD_AMDSTD
 	tristate "AMD compatible flash chip support (non-CFI)"
-	depends on MTD && MTD_OBSOLETE_CHIPS
+	depends on MTD && MTD_OBSOLETE_CHIPS && BROKEN
 	help
 	  This option enables support for flash chips using AMD-compatible
 	  commands, including some which are not CFI-compatible and hence
@@ -291,7 +291,7 @@
 
 config MTD_JEDEC
 	tristate "JEDEC device support"
-	depends on MTD && MTD_OBSOLETE_CHIPS
+	depends on MTD && MTD_OBSOLETE_CHIPS && BROKEN
 	help
 	  Enable older older JEDEC flash interface devices for self
 	  programming flash.  It is commonly used in older AMD chips.  It is

WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN
Date: Sun, 8 Jan 2006 15:14:31 +0100	[thread overview]
Message-ID: <20060108141430.GJ3774@stusta.de> (raw)
In-Reply-To: <1136725580.30348.69.camel@pmac.infradead.org>

On Sun, Jan 08, 2006 at 01:06:20PM +0000, David Woodhouse wrote:
> On Sun, 2006-01-08 at 13:57 +0100, Adrian Bunk wrote:
> > What I want for 2.6.16 is to remove the wrong dependency of MTD_SHARP on 
> > BROKEN and the non-compiling drivers either still hidden under BROKEN or 
> > removed.
> > 
> > If there is any way I can submit a patch achieving this that would be 
> > acceptable for you simply tell how exactly you want this patch.
> 
> Remove the incorrect BROKEN dependency from MTD_OBSOLETE_CHIPS.
> 
> If you then want to add it again to any chip driver which really doesn't
> compile, feel free. But leave the map drivers alone. Those can be
> switched to use different chip back-ends. 

Patch below.

> dwmw2

cu
Adrian


<--  snip  -->


This patch removes the wrong dependency of MTD_OBSOLETE_CHIPS on BROKEN 
and marks the non-compiling MTD_AMDSTD and MTD_JEDEC drivers as BROKEN.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/mtd/chips/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.15-mm2-full/drivers/mtd/chips/Kconfig.old	2006-01-08 14:16:59.000000000 +0100
+++ linux-2.6.15-mm2-full/drivers/mtd/chips/Kconfig	2006-01-08 14:17:25.000000000 +0100
@@ -260,7 +260,7 @@
 	  with this driver will return -ENODEV upon access.
 
 config MTD_OBSOLETE_CHIPS
-	depends on MTD && BROKEN
+	depends on MTD
 	bool "Older (theoretically obsoleted now) drivers for non-CFI chips"
 	help
 	  This option does not enable any code directly, but will allow you to
@@ -273,7 +273,7 @@
 
 config MTD_AMDSTD
 	tristate "AMD compatible flash chip support (non-CFI)"
-	depends on MTD && MTD_OBSOLETE_CHIPS
+	depends on MTD && MTD_OBSOLETE_CHIPS && BROKEN
 	help
 	  This option enables support for flash chips using AMD-compatible
 	  commands, including some which are not CFI-compatible and hence
@@ -291,7 +291,7 @@
 
 config MTD_JEDEC
 	tristate "JEDEC device support"
-	depends on MTD && MTD_OBSOLETE_CHIPS
+	depends on MTD && MTD_OBSOLETE_CHIPS && BROKEN
 	help
 	  Enable older older JEDEC flash interface devices for self
 	  programming flash.  It is commonly used in older AMD chips.  It is


  reply	other threads:[~2006-01-08 14:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-07 22:07 [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers Adrian Bunk
2006-01-07 22:07 ` Adrian Bunk
2006-01-08  0:00 ` David Woodhouse
2006-01-08  0:00   ` David Woodhouse
2006-01-08  0:24   ` Adrian Bunk
2006-01-08  0:24     ` Adrian Bunk
2006-01-08  0:38     ` David Woodhouse
2006-01-08  0:38       ` David Woodhouse
2006-01-08  1:45       ` Andrew Morton
2006-01-08  1:45         ` Andrew Morton
2006-01-08 12:41         ` David Woodhouse
2006-01-08 12:41           ` David Woodhouse
2006-01-08 12:57           ` Adrian Bunk
2006-01-08 12:57             ` Adrian Bunk
2006-01-08 13:06             ` David Woodhouse
2006-01-08 13:06               ` David Woodhouse
2006-01-08 14:14               ` Adrian Bunk [this message]
2006-01-08 14:14                 ` [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN Adrian Bunk
2006-01-08 14:24                 ` David Woodhouse
2006-01-08 14:24                   ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060108141430.GJ3774@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.