All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: maule@sgi.com, linuxppc64-dev@ozlabs.org,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	gregkh@suse.de
Subject: Re: Altix SN2 2.6.16-rc1-mm5 build breakage (was:  msi support)
Date: Thu, 23 Feb 2006 00:50:09 +0000	[thread overview]
Message-ID: <20060222165009.6493e6a1.pj@sgi.com> (raw)
In-Reply-To: <20060203202742.1e514fcc.akpm@osdl.org>

On Feb 3, Andrew wrote:
> Actually, gregkh-pci-altix-msi-support-git-ia64-fix.patch fix`es
> git-ia64.patch when gregkh-pci-altix-msi-support.patch

Is it time to reinsert that patch?

My ia64 sn build fails again, complaining:


=============  CC      arch/ia64/sn/pci/tioce_provider.o
arch/ia64/sn/pci/tioce_provider.c:720:46: macro "ATE_MAKE" requires 3 arguments, but only 2 given
=============

Your broken-out/series file (2.6.16-rc4-mm1) has the lines:

    # Need this when gregkh-pci-altix-msi-support.patch comes back
    #gregkh-pci-altix-msi-support-git-ia64-fix.patch

I guess that is this patch below, which fixes my sn build just fine.
Holler if you need it as a proper patch.


--- 2.6.16-rc4-mm1.orig/arch/ia64/sn/pci/tioce_provider.c       2006-02-22 16:21:52.054985166 -0800
+++ 2.6.16-rc4-mm1/arch/ia64/sn/pci/tioce_provider.c    2006-02-22 16:31:21.594755653 -0800
@@ -717,7 +717,7 @@ tioce_reserve_m32(struct tioce_kernel *c
        while (ate_index <= last_ate) {
                u64 ate;

-               ate = ATE_MAKE(0xdeadbeef, ps);
+               ate = ATE_MAKE(0xdeadbeef, ps, 0);
                ce_kern->ce_ate3240_shadow[ate_index] = ate;
                tioce_mmr_storei(ce_kern, &ce_mmr->ce_ure_ate3240[ate_index],
                                 ate);


-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

WARNING: multiple messages have this Message-ID (diff)
From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: maule@sgi.com, linuxppc64-dev@ozlabs.org,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	gregkh@suse.de
Subject: Re: Altix SN2 2.6.16-rc1-mm5 build breakage (was:  msi support)
Date: Wed, 22 Feb 2006 16:50:09 -0800	[thread overview]
Message-ID: <20060222165009.6493e6a1.pj@sgi.com> (raw)
In-Reply-To: <20060203202742.1e514fcc.akpm@osdl.org>

On Feb 3, Andrew wrote:
> Actually, gregkh-pci-altix-msi-support-git-ia64-fix.patch fix`es
> git-ia64.patch when gregkh-pci-altix-msi-support.patch

Is it time to reinsert that patch?

My ia64 sn build fails again, complaining:


===========================
  CC      arch/ia64/sn/pci/tioce_provider.o
arch/ia64/sn/pci/tioce_provider.c:720:46: macro "ATE_MAKE" requires 3 arguments, but only 2 given
===========================


Your broken-out/series file (2.6.16-rc4-mm1) has the lines:

    # Need this when gregkh-pci-altix-msi-support.patch comes back
    #gregkh-pci-altix-msi-support-git-ia64-fix.patch

I guess that is this patch below, which fixes my sn build just fine.
Holler if you need it as a proper patch.


--- 2.6.16-rc4-mm1.orig/arch/ia64/sn/pci/tioce_provider.c       2006-02-22 16:21:52.054985166 -0800
+++ 2.6.16-rc4-mm1/arch/ia64/sn/pci/tioce_provider.c    2006-02-22 16:31:21.594755653 -0800
@@ -717,7 +717,7 @@ tioce_reserve_m32(struct tioce_kernel *c
        while (ate_index <= last_ate) {
                u64 ate;

-               ate = ATE_MAKE(0xdeadbeef, ps);
+               ate = ATE_MAKE(0xdeadbeef, ps, 0);
                ce_kern->ce_ate3240_shadow[ate_index] = ate;
                tioce_mmr_storei(ce_kern, &ce_mmr->ce_ure_ate3240[ate_index],
                                 ate);


-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

  parent reply	other threads:[~2006-02-23  0:50 UTC|newest]

Thread overview: 162+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-22 17:15 [PATCH 0/3] msi abstractions and support for altix Mark Maule
2005-12-22 17:15 ` Mark Maule
2005-12-22 17:15 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2005-12-22 17:15   ` Mark Maule
2005-12-22 19:58   ` Greg KH
2005-12-22 19:58     ` Greg KH
2005-12-22 20:09     ` Mark Maule
2005-12-22 20:09       ` Mark Maule
2005-12-22 20:19       ` Greg KH
2005-12-22 20:19         ` Greg KH
2006-01-12 16:55   ` Joe Perches
2006-01-12 17:17   ` Greg KH
2006-01-14  7:34   ` Grant Grundler
2005-12-22 17:15 ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2005-12-22 17:15   ` Mark Maule
2005-12-22 20:01   ` Greg KH
2005-12-22 20:01     ` Greg KH
2005-12-22 20:06     ` Mark Maule
2005-12-22 20:06       ` Mark Maule
2005-12-22 17:15 ` [PATCH 2/3] altix: msi support Mark Maule
2005-12-22 17:15   ` Mark Maule
2005-12-22 20:15 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2005-12-22 20:15   ` Mark Maule
2005-12-22 20:15   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2005-12-22 20:15     ` Mark Maule
2006-01-03 22:39     ` Grant Grundler
2006-01-03 22:39       ` Grant Grundler
2006-01-03 23:50       ` Mark Maule
2006-01-03 23:50         ` Mark Maule
2006-01-04  0:20         ` Grant Grundler
2006-01-04  0:20           ` Grant Grundler
2006-01-04  0:27           ` Greg KH
2006-01-04  0:27             ` Greg KH
2006-01-04  3:52             ` Mark Maule
2006-01-04  3:52               ` Mark Maule
2005-12-22 20:15   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2005-12-22 20:15     ` Mark Maule
2006-01-04  0:01     ` Grant Grundler
2006-01-04  0:01       ` Grant Grundler
2005-12-22 20:16   ` [PATCH 2/3] altix: msi support Mark Maule
2005-12-22 20:16     ` Mark Maule
2005-12-22 20:22   ` [PATCH 0/3] msi abstractions and support for altix Greg KH
2005-12-22 20:22     ` Greg KH
2005-12-22 20:26     ` Mark Maule
2005-12-22 20:26       ` Mark Maule
2005-12-22 20:34       ` Greg KH
2005-12-22 20:34         ` Greg KH
2005-12-22 20:38         ` Mark Maule
2005-12-22 20:38           ` Mark Maule
2005-12-22 20:50           ` Matthew Wilcox
2005-12-22 20:50             ` Matthew Wilcox
2006-01-03  3:22             ` Mark Maule
2006-01-03  3:22               ` Mark Maule
2006-01-03  6:07               ` Greg KH
2006-01-03  6:07                 ` Greg KH
2006-01-10 17:00                 ` Mark Maule
2006-01-10 17:00                   ` Mark Maule
2006-01-10 17:03                   ` Christoph Hellwig
2006-01-10 17:11                     ` Greg KH
2006-01-10 17:11                       ` Greg KH
2005-12-22 21:44           ` Greg KH
2005-12-22 21:44             ` Greg KH
2005-12-23 15:32             ` Mark Maule
2005-12-23 15:32               ` Mark Maule
2005-12-23 16:32               ` Greg KH
2005-12-23 16:32                 ` Greg KH
2006-01-11 15:52 ` Mark Maule
2006-01-11 15:52   ` Mark Maule
2006-01-11 15:52   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-11 15:52     ` Mark Maule
2006-01-11 20:21     ` Greg KH
2006-01-11 20:21       ` Greg KH
2006-01-11 20:49       ` Mark Maule
2006-01-11 20:49         ` Mark Maule
2006-01-11 20:57         ` Greg KH
2006-01-11 20:57           ` Greg KH
2006-01-12  4:53     ` Grant Grundler
2006-01-12  5:02       ` Grant Grundler
2006-01-12  5:36       ` Greg KH
2006-01-12  5:36         ` Greg KH
2006-01-12  5:47       ` Paul Mackerras
2006-01-12  5:47         ` Paul Mackerras
2006-01-12  7:33         ` Grant Grundler
2006-01-12  7:33           ` Grant Grundler
2006-01-11 15:53   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-01-11 15:53     ` Mark Maule
2006-01-11 15:53   ` [PATCH 2/3] altix: msi support Mark Maule
2006-01-11 15:53     ` Mark Maule
2006-01-11 22:16 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-01-11 22:16   ` Mark Maule
2006-01-11 22:16   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-11 22:16     ` Mark Maule
2006-01-11 22:16   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-01-11 22:16     ` Mark Maule
2006-01-11 22:16   ` [PATCH 3/3] altix: msi support Mark Maule
2006-01-11 22:16     ` Mark Maule
2006-01-19 19:46 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-01-19 19:46   ` Mark Maule
2006-01-19 19:46   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-19 19:46     ` Mark Maule
2006-01-20  2:15     ` Greg KH
2006-01-20  2:15       ` Greg KH
2006-01-19 19:46   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-01-19 19:46     ` Mark Maule
2006-01-19 19:47   ` [PATCH 3/3] altix: msi support Mark Maule
2006-01-19 19:47     ` Mark Maule
2006-02-04  4:14     ` Altix SN2 2.6.16-rc1-mm5 build breakage (was: msi support) Paul Jackson
2006-02-04  4:14       ` Paul Jackson
2006-02-04  4:25       ` Andrew Morton
2006-02-04  4:25         ` Andrew Morton
2006-02-04  4:27         ` Andrew Morton
2006-02-04  4:27           ` Andrew Morton
2006-02-04  4:42           ` Mark Maule
2006-02-04  4:42             ` Mark Maule
2006-02-04  5:08             ` Andrew Morton
2006-02-04  5:08               ` Andrew Morton
2006-02-23  0:50           ` Paul Jackson [this message]
2006-02-23  0:50             ` Paul Jackson
2006-02-23  1:01             ` Andrew Morton
2006-02-23  1:01               ` Andrew Morton
2006-03-21 14:34 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-03-21 14:34   ` Mark Maule
2006-03-21 14:34   ` Mark Maule
2006-03-21 14:34   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 16:29     ` Jun'ichi Nomura
2006-03-21 16:29       ` Jun'ichi Nomura
2006-03-21 16:29       ` Jun'ichi Nomura
2006-03-21 16:38       ` Andreas Schwab
2006-03-21 16:38         ` Andreas Schwab
2006-03-21 16:38         ` Andreas Schwab
2006-03-21 19:14         ` Mark Maule
2006-03-21 19:14           ` Mark Maule
2006-03-21 19:14           ` Mark Maule
2006-03-21 19:23           ` Jun'ichi Nomura
2006-03-21 19:23             ` Jun'ichi Nomura
2006-03-21 19:23             ` Jun'ichi Nomura
2006-03-21 19:38             ` Mark Maule
2006-03-21 19:38               ` Mark Maule
2006-03-21 19:38               ` Mark Maule
2006-03-21 14:34   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34   ` [PATCH 3/3] altix: msi support Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 21:53   ` [PATCH 0/3] msi abstractions and support for altix David S. Miller
2006-03-21 21:53     ` David S. Miller
2006-03-21 21:53     ` David S. Miller
2006-03-29  2:31 ` Mark Maule
2006-03-29  2:31   ` Mark Maule
2006-03-29  2:31   ` Mark Maule
2006-03-29  2:31   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31   ` [PATCH 3/3] altix: msi support Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31     ` Mark Maule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060222165009.6493e6a1.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=maule@sgi.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.