Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register

[Adrian Bunk <bunk@stusta.de>]

On Tue, Mar 14, 2006 at 04:01:02PM -0500, Jun'ichi Nomura wrote:
> Hello,
> 
> In 2.6.16-rc6-mm1, I've seen tons of compiler warnings on ia64:
> 
> include2/asm/msi.h: In function `ia64_msi_init':
> include2/asm/msi.h:23: warning: implicit declaration of function `msi_register'
> In file included from include2/asm/machvec.h:408,
>                  from include2/asm/io.h:70,
>                  from include2/asm/smp.h:20,
>                  from /build/rc6/source/include/linux/smp.h:22,
> 
> The problem is that msi_register() is used in ia64_msi_init()
> without declaration.
> Since ia64_msi_init() is a part of machine vector, most of files
> hit this warning and may hide other important messages.
>...

To avoid any wrong impression:

This kind of warnings isn't harmless.

gcc tries to guess the prototype of the function, and if gcc guessed 
wrong this can cause nasty and hard to debug runtime errors.

> Thanks,
>...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed