From: Mark Maule <maule@sgi.com>
To: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Adrian Bunk <bunk@stusta.de>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
Greg KH <gregkh@suse.de>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
Date: Wed, 15 Mar 2006 00:09:23 +0000 [thread overview]
Message-ID: <20060315000923.GC25848@sgi.com> (raw)
In-Reply-To: <4417580B.2090205@ce.jp.nec.com>
On Tue, Mar 14, 2006 at 06:55:55PM -0500, Jun'ichi Nomura wrote:
> Adrian Bunk wrote:
> >>include2/asm/msi.h: In function `ia64_msi_init':
> >>include2/asm/msi.h:23: warning: implicit declaration of function
> >>`msi_register'
> >>In file included from include2/asm/machvec.h:408,
> >> from include2/asm/io.h:70,
> >> from include2/asm/smp.h:20,
> >> from /build/rc6/source/include/linux/smp.h:22,
> >>...
> >
> >To avoid any wrong impression:
> >
> >This kind of warnings isn't harmless.
> >
> >gcc tries to guess the prototype of the function, and if gcc guessed
> >wrong this can cause nasty and hard to debug runtime errors.
>
> Sure.
> But for this case, gcc emits the above warning for any files
> which includes, for example, include/linux/smp.h on ia64.
> So while the warning is harmless, it may cause other harmful
> warnings being overlooked.
>
Yes, this should be cleaned up. I'll take a look.
I thought though that we had all of this compiling cleanly ... guess not.
Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Maule <maule@sgi.com>
To: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
Cc: Adrian Bunk <bunk@stusta.de>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
Greg KH <gregkh@suse.de>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
Date: Tue, 14 Mar 2006 18:09:23 -0600 [thread overview]
Message-ID: <20060315000923.GC25848@sgi.com> (raw)
In-Reply-To: <4417580B.2090205@ce.jp.nec.com>
On Tue, Mar 14, 2006 at 06:55:55PM -0500, Jun'ichi Nomura wrote:
> Adrian Bunk wrote:
> >>include2/asm/msi.h: In function `ia64_msi_init':
> >>include2/asm/msi.h:23: warning: implicit declaration of function
> >>`msi_register'
> >>In file included from include2/asm/machvec.h:408,
> >> from include2/asm/io.h:70,
> >> from include2/asm/smp.h:20,
> >> from /build/rc6/source/include/linux/smp.h:22,
> >>...
> >
> >To avoid any wrong impression:
> >
> >This kind of warnings isn't harmless.
> >
> >gcc tries to guess the prototype of the function, and if gcc guessed
> >wrong this can cause nasty and hard to debug runtime errors.
>
> Sure.
> But for this case, gcc emits the above warning for any files
> which includes, for example, include/linux/smp.h on ia64.
> So while the warning is harmless, it may cause other harmful
> warnings being overlooked.
>
Yes, this should be cleaned up. I'll take a look.
I thought though that we had all of this compiling cleanly ... guess not.
Mark
next prev parent reply other threads:[~2006-03-15 0:09 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-14 21:01 [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register Jun'ichi Nomura
2006-03-14 21:01 ` Jun'ichi Nomura
2006-03-14 21:45 ` [PATCH] (-mm) drivers/pci/msi: explicit declaration of Andrew Morton
2006-03-14 21:45 ` [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register Andrew Morton
2006-03-14 21:59 ` Greg KH
2006-03-14 21:59 ` Greg KH
2006-03-14 22:25 ` Matthew Wilcox
2006-03-14 22:25 ` Matthew Wilcox
2006-03-15 0:51 ` Jun'ichi Nomura
2006-03-15 0:51 ` Jun'ichi Nomura
2006-03-15 23:55 ` Greg KH
2006-03-15 23:55 ` Greg KH
2006-03-16 15:19 ` Jun'ichi Nomura
2006-03-16 15:19 ` Jun'ichi Nomura
2006-03-16 18:19 ` Mark Maule
2006-03-16 18:19 ` Mark Maule
2006-03-16 19:32 ` Jun'ichi Nomura
2006-03-16 19:32 ` Jun'ichi Nomura
2006-03-16 19:41 ` Mark Maule
2006-03-16 19:41 ` Mark Maule
2006-03-16 23:28 ` Greg KH
2006-03-16 23:28 ` Greg KH
2006-03-16 23:37 ` Roland Dreier
2006-03-16 23:37 ` Roland Dreier
2006-03-16 23:45 ` Grant Grundler
2006-03-16 23:45 ` Grant Grundler
2006-03-16 23:47 ` Greg KH
2006-03-16 23:47 ` Greg KH
2006-03-16 23:41 ` Grant Grundler
2006-03-16 23:41 ` Grant Grundler
2006-03-16 23:49 ` Greg KH
2006-03-16 23:49 ` Greg KH
2006-03-17 0:41 ` Grant Grundler
2006-03-17 0:41 ` Grant Grundler
2006-03-17 1:18 ` Mark Maule
2006-03-17 1:18 ` Mark Maule
2006-03-16 15:29 ` Jun'ichi Nomura
2006-03-16 15:29 ` Jun'ichi Nomura
2006-03-14 21:57 ` Adrian Bunk
2006-03-14 21:57 ` Adrian Bunk
2006-03-14 23:55 ` Jun'ichi Nomura
2006-03-14 23:55 ` Jun'ichi Nomura
2006-03-15 0:09 ` Mark Maule [this message]
2006-03-15 0:09 ` Mark Maule
2006-03-15 1:04 ` Jun'ichi Nomura
2006-03-15 1:04 ` Jun'ichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060315000923.GC25848@sgi.com \
--to=maule@sgi.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.