From: Con Kolivas <kernel@kolivas.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux list <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] mm: cleanup swap unused warning
Date: Tue, 16 May 2006 20:55:36 +1000 [thread overview]
Message-ID: <200605162055.36957.kernel@kolivas.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0605101604330.7472@schroedinger.engr.sgi.com>
On Thursday 11 May 2006 09:04, Christoph Lameter wrote:
> On Wed, 10 May 2006, Con Kolivas wrote:
> > Are there any users of swp_entry_t when CONFIG_SWAP is not defined?
>
> Yes, a migration entry is a form of swap entry.
mm/vmscan.c: In function ‘remove_mapping’:
mm/vmscan.c:387: warning: unused variable ‘swap’
Ok so if we fix it by making swp_entry_t __attribute__((__unused__) we break
swap migration code?
If we make swap_free() an empty static inline function then gcc compiles in
the variable needlessly and we won't know it.
For the moment let's continue putting up with the warning.
--
-ck
WARNING: multiple messages have this Message-ID (diff)
From: Con Kolivas <kernel@kolivas.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux list <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] mm: cleanup swap unused warning
Date: Tue, 16 May 2006 20:55:36 +1000 [thread overview]
Message-ID: <200605162055.36957.kernel@kolivas.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0605101604330.7472@schroedinger.engr.sgi.com>
On Thursday 11 May 2006 09:04, Christoph Lameter wrote:
> On Wed, 10 May 2006, Con Kolivas wrote:
> > Are there any users of swp_entry_t when CONFIG_SWAP is not defined?
>
> Yes, a migration entry is a form of swap entry.
mm/vmscan.c: In function a??remove_mappinga??:
mm/vmscan.c:387: warning: unused variable a??swapa??
Ok so if we fix it by making swp_entry_t __attribute__((__unused__) we break
swap migration code?
If we make swap_free() an empty static inline function then gcc compiles in
the variable needlessly and we won't know it.
For the moment let's continue putting up with the warning.
--
-ck
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-05-16 10:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 11:32 [PATCH] mm: cleanup swap unused warning Con Kolivas
2006-05-10 11:32 ` Con Kolivas
2006-05-10 11:38 ` Andrew Morton
2006-05-10 11:38 ` Andrew Morton
2006-05-10 11:46 ` Con Kolivas
2006-05-10 11:46 ` Con Kolivas
2006-05-10 11:56 ` Con Kolivas
2006-05-10 11:56 ` Con Kolivas
2006-05-10 18:20 ` Daniel Walker
2006-05-10 18:20 ` Daniel Walker
2006-05-10 11:42 ` Pekka Enberg
2006-05-10 11:42 ` Pekka Enberg
2006-05-10 23:04 ` Christoph Lameter
2006-05-10 23:04 ` Christoph Lameter
2006-05-16 10:55 ` Con Kolivas [this message]
2006-05-16 10:55 ` Con Kolivas
2006-05-16 13:14 ` Con Kolivas
2006-05-16 13:14 ` Con Kolivas
2006-05-16 16:00 ` Christoph Lameter
2006-05-16 16:00 ` Christoph Lameter
2006-05-17 6:27 ` [PATCH][respin] " Con Kolivas
2006-05-17 6:27 ` Con Kolivas
2006-05-16 15:58 ` [PATCH] " Christoph Lameter
2006-05-16 11:24 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605162055.36957.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.