From: Andrew Morton <akpm@osdl.org>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: cleanup swap unused warning
Date: Wed, 10 May 2006 04:38:34 -0700 [thread overview]
Message-ID: <20060510043834.70f40ddc.akpm@osdl.org> (raw)
In-Reply-To: <200605102132.41217.kernel@kolivas.org>
Con Kolivas <kernel@kolivas.org> wrote:
>
> Are there any users of swp_entry_t when CONFIG_SWAP is not defined?
Well there shouldn't be. Making accesses to swp_entry_t.val fail to
compile if !CONFIG_SWAP might be useful.
> +/*
> + * A swap entry has to fit into a "unsigned long", as
> + * the entry is hidden in the "index" field of the
> + * swapper address space.
> + */
> +#ifdef CONFIG_SWAP
> typedef struct {
> unsigned long val;
> } swp_entry_t;
> +#else
> +typedef struct {
> + unsigned long val;
> +} swp_entry_t __attribute__((__unused__));
> +#endif
We have __attribute_used__, which hides a gcc oddity.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@osdl.org>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: cleanup swap unused warning
Date: Wed, 10 May 2006 04:38:34 -0700 [thread overview]
Message-ID: <20060510043834.70f40ddc.akpm@osdl.org> (raw)
In-Reply-To: <200605102132.41217.kernel@kolivas.org>
Con Kolivas <kernel@kolivas.org> wrote:
>
> Are there any users of swp_entry_t when CONFIG_SWAP is not defined?
Well there shouldn't be. Making accesses to swp_entry_t.val fail to
compile if !CONFIG_SWAP might be useful.
> +/*
> + * A swap entry has to fit into a "unsigned long", as
> + * the entry is hidden in the "index" field of the
> + * swapper address space.
> + */
> +#ifdef CONFIG_SWAP
> typedef struct {
> unsigned long val;
> } swp_entry_t;
> +#else
> +typedef struct {
> + unsigned long val;
> +} swp_entry_t __attribute__((__unused__));
> +#endif
We have __attribute_used__, which hides a gcc oddity.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-05-10 11:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 11:32 [PATCH] mm: cleanup swap unused warning Con Kolivas
2006-05-10 11:32 ` Con Kolivas
2006-05-10 11:38 ` Andrew Morton [this message]
2006-05-10 11:38 ` Andrew Morton
2006-05-10 11:46 ` Con Kolivas
2006-05-10 11:46 ` Con Kolivas
2006-05-10 11:56 ` Con Kolivas
2006-05-10 11:56 ` Con Kolivas
2006-05-10 18:20 ` Daniel Walker
2006-05-10 18:20 ` Daniel Walker
2006-05-10 11:42 ` Pekka Enberg
2006-05-10 11:42 ` Pekka Enberg
2006-05-10 23:04 ` Christoph Lameter
2006-05-10 23:04 ` Christoph Lameter
2006-05-16 10:55 ` Con Kolivas
2006-05-16 10:55 ` Con Kolivas
2006-05-16 13:14 ` Con Kolivas
2006-05-16 13:14 ` Con Kolivas
2006-05-16 16:00 ` Christoph Lameter
2006-05-16 16:00 ` Christoph Lameter
2006-05-17 6:27 ` [PATCH][respin] " Con Kolivas
2006-05-17 6:27 ` Con Kolivas
2006-05-16 15:58 ` [PATCH] " Christoph Lameter
2006-05-16 11:24 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060510043834.70f40ddc.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.