From: Joakim Axelsson <gozem@gozem.se>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] priv_data 0/2
Date: Fri, 21 Jul 2006 00:38:46 +0200 [thread overview]
Message-ID: <20060720223846.GV7194@kriss.csbnet.se> (raw)
In-Reply-To: <44A9B458.1030106@trash.net>
2006-07-04 02:20:40+0200, Patrick McHardy <kaber@trash.net> ->
> Sven Anders wrote:
> > If this is merged, I would like to see a negated limit...
> > I need some advice to preserve compatibility here.
>
> Once this is merged we can convert matches and targets to keep their
> private state outside of the structure shared with userspace and can
> start reusing the fields, since they are ignored by userspace anyway.
> I'm not sure, but I think currently userspace initializes them to 0,
> which should make this easy.
>
I wonder where all this priv_data changes ended? I have a few modules (that
I havn't submited, because i've been way to lazy :-/) that will benefit from
this. Among those a new limiter matcher simply called "lim". This match will
solve Sven Anders problem with negating match. It's also much more aqurate
and using a better limiter algoritm. Including being able to limit on packet
size etc etc. It has been working stable in large scale routers (several
100Mbit/s) for a year now I think.
So where did this end up. The reason I am asking is because I was working on
sending them in as patches. But they could really use this priv_data as they
are using alot of ugly things to work this problem around. Same goes for a
few target matches I have. They also need priv_data. Among them a "simple"
-j COUNT that presents counters in /proc in an easy and fancy way (for
scripts/rrdtool to read). I know hfpac wants this things they have droped
the counters built in for each rule.
next prev parent reply other threads:[~2006-07-20 22:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 14:41 [PATCH] priv_data 0/2 Massimiliano Hofer
2006-07-03 18:33 ` Patrick McHardy
2006-07-03 21:05 ` Massimiliano Hofer
2006-07-03 22:58 ` Sven Anders
2006-07-04 0:20 ` Patrick McHardy
2006-07-20 22:38 ` Joakim Axelsson [this message]
2006-07-20 23:25 ` Patrick McHardy
2006-07-21 9:29 ` Joakim Axelsson
2006-07-21 9:52 ` Amin Azez
2006-07-22 13:34 ` Patrick McHardy
2006-08-14 14:17 ` Joakim Axelsson
2006-08-14 14:22 ` Patrick McHardy
2006-08-14 15:35 ` Joakim Axelsson
2006-08-14 15:43 ` Patrick McHardy
2006-08-14 16:24 ` xt_quota (Was: [PATCH] priv_data 0/2) Joakim Axelsson
2006-08-14 16:39 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060720223846.GV7194@kriss.csbnet.se \
--to=gozem@gozem.se \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.