From: Patrick McHardy <kaber@trash.net>
To: Amin Azez <azez@ufomechanic.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] priv_data 0/2
Date: Sat, 22 Jul 2006 15:34:45 +0200 [thread overview]
Message-ID: <44C22975.5050504@trash.net> (raw)
In-Reply-To: <44C0A3CF.9020702@ufomechanic.net>
Amin Azez wrote:
> * Patrick McHardy wrote, On 04/07/06 01:20:
>
>>Sven Anders wrote:
>>
>>>If this is merged, I would like to see a negated limit...
>>>I need some advice to preserve compatibility here.
>>
>>Once this is merged we can convert matches and targets to keep their
>>private state outside of the structure shared with userspace and can
>>start reusing the fields, since they are ignored by userspace anyway.
>>I'm not sure, but I think currently userspace initializes them to 0,
>>which should make this easy.
>
>
> Relying on userspace to initialize kernel structures to 0 smells like
> danger, and a possible exploit point.
There is no difference here to a million other spots in the kernel.
If something can create trouble, it needs to be verified. In the
case of negation it just means "0 - don't negate", "1 - negate",
and the fact that it used to be 0 can be used to provide backwards
compatibility without introducing a new revision.
BTW, can you please fix your mailer so every mail doesn't go to the
list twice?
next prev parent reply other threads:[~2006-07-22 13:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 14:41 [PATCH] priv_data 0/2 Massimiliano Hofer
2006-07-03 18:33 ` Patrick McHardy
2006-07-03 21:05 ` Massimiliano Hofer
2006-07-03 22:58 ` Sven Anders
2006-07-04 0:20 ` Patrick McHardy
2006-07-20 22:38 ` Joakim Axelsson
2006-07-20 23:25 ` Patrick McHardy
2006-07-21 9:29 ` Joakim Axelsson
2006-07-21 9:52 ` Amin Azez
2006-07-22 13:34 ` Patrick McHardy [this message]
2006-08-14 14:17 ` Joakim Axelsson
2006-08-14 14:22 ` Patrick McHardy
2006-08-14 15:35 ` Joakim Axelsson
2006-08-14 15:43 ` Patrick McHardy
2006-08-14 16:24 ` xt_quota (Was: [PATCH] priv_data 0/2) Joakim Axelsson
2006-08-14 16:39 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C22975.5050504@trash.net \
--to=kaber@trash.net \
--cc=azez@ufomechanic.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.