Re: [PATCH] priv_data 0/2

[Patrick McHardy <kaber@trash.net>]

Joakim Axelsson wrote:
> 
> I'm currently porting some of my modules to use this API with priv_data.
> However, I ran into some troubles. For example i'm writing a revision 1 for
> the quota module which allows the count to go negative, and in the same time
> I'm porting it to use this API (as it's using the same stupid thing as -m
> limit with q->master = q;). However, having the quota counter in the
> priv_data struct makes it impossible to report the counter to userspace when
> the user issues iptables -L.

That is actually a bug in the current module IMO (I looked into fixing
this yesterday as well). iptables-save/restore won't work properly since
they will save the _remaining_ quota, not the one the rule was created
with. This might be useful as well, but it diverges from what other
modules do.

> "Hidden", kernel data only is good with priv_data, but sometimes it will be
> too hidden.
> 
> Do we have any good solution for this?

Not really, see the mail I just wrote.