Re: [PATCH] priv_data 0/2

[Patrick McHardy <kaber@trash.net>]

Joakim Axelsson wrote:
> 2006-07-04 02:20:40+0200, Patrick McHardy <kaber@trash.net> ->
> 
>>Sven Anders wrote:
>>
>>>If this is merged, I would like to see a negated limit...
>>>I need some advice to preserve compatibility here.
>>
>>Once this is merged we can convert matches and targets to keep their
>>private state outside of the structure shared with userspace and can
>>start reusing the fields, since they are ignored by userspace anyway.
>>I'm not sure, but I think currently userspace initializes them to 0,
>>which should make this easy.
>>
> 
> 
> I wonder where all this priv_data changes ended?

We missed the 2.6.18 merge window and I'm currently busy with a few
other things, so I delayed it a bit. It will go in 2.6.19, I'll post
the patches once I've merged them in my 2.6.19 tree.

> I have a few modules (that
> I havn't submited, because i've been way to lazy :-/) that will benefit from
> this. Among those a new limiter matcher simply called "lim". This match will
> solve Sven Anders problem with negating match. It's also much more aqurate
> and using a better limiter algoritm. Including being able to limit on packet
> size etc etc. It has been working stable in large scale routers (several
> 100Mbit/s) for a year now I think.

Please just post what you've got, I'd be interested in seeing why you
chose to introduce a new match instead of enhancing the existing limit
match.