* [uml-devel] [PATCH] UML - support checkstack
@ 2006-08-09 18:15 ` Jeff Dike
0 siblings, 0 replies; 14+ messages in thread
From: Jeff Dike @ 2006-08-09 18:15 UTC (permalink / raw)
To: akpm; +Cc: Joern Engel, linux-kernel, user-mode-linux-devel, Matt Mackall
Make checkstack work for UML. We need to pass the underlying architecture
name, rather than "um" to checkstack.pl.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Index: linux-2.6.18-mm/Makefile
===================================================================
--- linux-2.6.18-mm.orig/Makefile 2006-08-07 13:49:52.000000000 -0400
+++ linux-2.6.18-mm/Makefile 2006-08-07 13:53:34.000000000 -0400
@@ -1315,9 +1315,13 @@ endif #ifeq ($(config-targets),1)
endif #ifeq ($(mixed-targets),1)
PHONY += checkstack kernelrelease kernelversion
+
+# Use $(SUBARCH) here instead of $(ARCH) so that this works for UML.
+# In the UML case, $(SUBARCH) is the name of the underlying
+# architecture, while for all other arches, it is the same as $(ARCH).
checkstack:
$(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \
- $(PERL) $(src)/scripts/checkstack.pl $(ARCH)
+ $(PERL) $(src)/scripts/checkstack.pl $(SUBARCH)
kernelrelease:
$(if $(wildcard include/config/kernel.release), $(Q)echo $(KERNELRELEASE), \
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] UML - support checkstack
@ 2006-08-09 18:15 ` Jeff Dike
0 siblings, 0 replies; 14+ messages in thread
From: Jeff Dike @ 2006-08-09 18:15 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, user-mode-linux-devel, Matt Mackall, Joern Engel
Make checkstack work for UML. We need to pass the underlying architecture
name, rather than "um" to checkstack.pl.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Index: linux-2.6.18-mm/Makefile
===================================================================
--- linux-2.6.18-mm.orig/Makefile 2006-08-07 13:49:52.000000000 -0400
+++ linux-2.6.18-mm/Makefile 2006-08-07 13:53:34.000000000 -0400
@@ -1315,9 +1315,13 @@ endif #ifeq ($(config-targets),1)
endif #ifeq ($(mixed-targets),1)
PHONY += checkstack kernelrelease kernelversion
+
+# Use $(SUBARCH) here instead of $(ARCH) so that this works for UML.
+# In the UML case, $(SUBARCH) is the name of the underlying
+# architecture, while for all other arches, it is the same as $(ARCH).
checkstack:
$(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \
- $(PERL) $(src)/scripts/checkstack.pl $(ARCH)
+ $(PERL) $(src)/scripts/checkstack.pl $(SUBARCH)
kernelrelease:
$(if $(wildcard include/config/kernel.release), $(Q)echo $(KERNELRELEASE), \
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] [PATCH] UML - support checkstack
2006-08-09 18:15 ` Jeff Dike
@ 2006-08-10 2:09 ` Matt Mackall
-1 siblings, 0 replies; 14+ messages in thread
From: Matt Mackall @ 2006-08-10 2:09 UTC (permalink / raw)
To: Jeff Dike; +Cc: akpm, Joern Engel, linux-kernel, user-mode-linux-devel
On Wed, Aug 09, 2006 at 02:15:24PM -0400, Jeff Dike wrote:
> Make checkstack work for UML. We need to pass the underlying architecture
> name, rather than "um" to checkstack.pl.
Does this do the right thing with something like Voyager?
Or should we just get together a small fund to send the remaining
Voyager users proper computers?
--
Mathematics is the supreme nostalgia of our time.
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] UML - support checkstack
@ 2006-08-10 2:09 ` Matt Mackall
0 siblings, 0 replies; 14+ messages in thread
From: Matt Mackall @ 2006-08-10 2:09 UTC (permalink / raw)
To: Jeff Dike; +Cc: akpm, linux-kernel, user-mode-linux-devel, Joern Engel
On Wed, Aug 09, 2006 at 02:15:24PM -0400, Jeff Dike wrote:
> Make checkstack work for UML. We need to pass the underlying architecture
> name, rather than "um" to checkstack.pl.
Does this do the right thing with something like Voyager?
Or should we just get together a small fund to send the remaining
Voyager users proper computers?
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] [PATCH] UML - support checkstack
2006-08-10 2:09 ` Matt Mackall
@ 2006-08-10 4:22 ` Jeff Dike
-1 siblings, 0 replies; 14+ messages in thread
From: Jeff Dike @ 2006-08-10 4:22 UTC (permalink / raw)
To: Matt Mackall; +Cc: akpm, Joern Engel, linux-kernel, user-mode-linux-devel
On Wed, Aug 09, 2006 at 09:09:22PM -0500, Matt Mackall wrote:
> On Wed, Aug 09, 2006 at 02:15:24PM -0400, Jeff Dike wrote:
> > Make checkstack work for UML. We need to pass the underlying architecture
> > name, rather than "um" to checkstack.pl.
>
> Does this do the right thing with something like Voyager?
SUBARCH has a different meaning here. For UML, it's the underlying,
host, architecture, not a variant architecture like Voyager.
>
> Or should we just get together a small fund to send the remaining
> Voyager users proper computers?
Yeah, that's a plan :-)
Jeff
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] UML - support checkstack
@ 2006-08-10 4:22 ` Jeff Dike
0 siblings, 0 replies; 14+ messages in thread
From: Jeff Dike @ 2006-08-10 4:22 UTC (permalink / raw)
To: Matt Mackall; +Cc: akpm, linux-kernel, user-mode-linux-devel, Joern Engel
On Wed, Aug 09, 2006 at 09:09:22PM -0500, Matt Mackall wrote:
> On Wed, Aug 09, 2006 at 02:15:24PM -0400, Jeff Dike wrote:
> > Make checkstack work for UML. We need to pass the underlying architecture
> > name, rather than "um" to checkstack.pl.
>
> Does this do the right thing with something like Voyager?
SUBARCH has a different meaning here. For UML, it's the underlying,
host, architecture, not a variant architecture like Voyager.
>
> Or should we just get together a small fund to send the remaining
> Voyager users proper computers?
Yeah, that's a plan :-)
Jeff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] [PATCH] UML - support checkstack
2006-08-10 4:22 ` Jeff Dike
@ 2006-08-10 16:45 ` Matt Mackall
-1 siblings, 0 replies; 14+ messages in thread
From: Matt Mackall @ 2006-08-10 16:45 UTC (permalink / raw)
To: Jeff Dike; +Cc: akpm, Joern Engel, linux-kernel, user-mode-linux-devel
On Thu, Aug 10, 2006 at 12:22:16AM -0400, Jeff Dike wrote:
> On Wed, Aug 09, 2006 at 09:09:22PM -0500, Matt Mackall wrote:
> > On Wed, Aug 09, 2006 at 02:15:24PM -0400, Jeff Dike wrote:
> > > Make checkstack work for UML. We need to pass the underlying architecture
> > > name, rather than "um" to checkstack.pl.
> >
> > Does this do the right thing with something like Voyager?
>
> SUBARCH has a different meaning here. For UML, it's the underlying,
> host, architecture, not a variant architecture like Voyager.
Right, so it sounds like this breaks Voyager. Which I think means we
ought to pass ARCH and SUBARCH and do the right thing inside
checkstack.
--
Mathematics is the supreme nostalgia of our time.
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] UML - support checkstack
@ 2006-08-10 16:45 ` Matt Mackall
0 siblings, 0 replies; 14+ messages in thread
From: Matt Mackall @ 2006-08-10 16:45 UTC (permalink / raw)
To: Jeff Dike; +Cc: akpm, linux-kernel, user-mode-linux-devel, Joern Engel
On Thu, Aug 10, 2006 at 12:22:16AM -0400, Jeff Dike wrote:
> On Wed, Aug 09, 2006 at 09:09:22PM -0500, Matt Mackall wrote:
> > On Wed, Aug 09, 2006 at 02:15:24PM -0400, Jeff Dike wrote:
> > > Make checkstack work for UML. We need to pass the underlying architecture
> > > name, rather than "um" to checkstack.pl.
> >
> > Does this do the right thing with something like Voyager?
>
> SUBARCH has a different meaning here. For UML, it's the underlying,
> host, architecture, not a variant architecture like Voyager.
Right, so it sounds like this breaks Voyager. Which I think means we
ought to pass ARCH and SUBARCH and do the right thing inside
checkstack.
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] [PATCH] UML - support checkstack
2006-08-10 16:45 ` Matt Mackall
@ 2006-08-15 3:17 ` Jeff Dike
-1 siblings, 0 replies; 14+ messages in thread
From: Jeff Dike @ 2006-08-15 3:17 UTC (permalink / raw)
To: Matt Mackall; +Cc: akpm, Joern Engel, linux-kernel, user-mode-linux-devel
On Thu, Aug 10, 2006 at 11:45:48AM -0500, Matt Mackall wrote:
> > SUBARCH has a different meaning here. For UML, it's the underlying,
> > host, architecture, not a variant architecture like Voyager.
>
> Right, so it sounds like this breaks Voyager. Which I think means we
> ought to pass ARCH and SUBARCH and do the right thing inside
> checkstack.
There is no use of the symbol SUBARCH in arch/i386. While this may be
jarring to people who know and love Voyager, it doesn't break
anything.
We could do what you suggest, but that sounds unnecessary.
I'd rather either
leave things as they are
rename SUBARCH
Jeff
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] UML - support checkstack
@ 2006-08-15 3:17 ` Jeff Dike
0 siblings, 0 replies; 14+ messages in thread
From: Jeff Dike @ 2006-08-15 3:17 UTC (permalink / raw)
To: Matt Mackall; +Cc: akpm, linux-kernel, user-mode-linux-devel, Joern Engel
On Thu, Aug 10, 2006 at 11:45:48AM -0500, Matt Mackall wrote:
> > SUBARCH has a different meaning here. For UML, it's the underlying,
> > host, architecture, not a variant architecture like Voyager.
>
> Right, so it sounds like this breaks Voyager. Which I think means we
> ought to pass ARCH and SUBARCH and do the right thing inside
> checkstack.
There is no use of the symbol SUBARCH in arch/i386. While this may be
jarring to people who know and love Voyager, it doesn't break
anything.
We could do what you suggest, but that sounds unnecessary.
I'd rather either
leave things as they are
rename SUBARCH
Jeff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] [PATCH] UML - support checkstack
2006-08-15 3:17 ` Jeff Dike
@ 2006-08-15 17:57 ` Blaisorblade
-1 siblings, 0 replies; 14+ messages in thread
From: Blaisorblade @ 2006-08-15 17:57 UTC (permalink / raw)
To: user-mode-linux-devel
Cc: akpm, Jeff Dike, Joern Engel, linux-kernel, Matt Mackall
On Tuesday 15 August 2006 05:17, Jeff Dike wrote:
> On Thu, Aug 10, 2006 at 11:45:48AM -0500, Matt Mackall wrote:
> > > SUBARCH has a different meaning here. For UML, it's the underlying,
> > > host, architecture, not a variant architecture like Voyager.
> >
> > Right, so it sounds like this breaks Voyager. Which I think means we
> > ought to pass ARCH and SUBARCH and do the right thing inside
> > checkstack.
>
> There is no use of the symbol SUBARCH in arch/i386. While this may be
> jarring to people who know and love Voyager, it doesn't break
> anything.
>
> We could do what you suggest, but that sounds unnecessary.
>
> I'd rather either
> leave things as they are
Yes, and make the script check if it ARCH=um or not (which is obvious for
now - nobody really wants a clear abstraction here).
> rename SUBARCH
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale!
http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] [PATCH] UML - support checkstack
@ 2006-08-15 17:57 ` Blaisorblade
0 siblings, 0 replies; 14+ messages in thread
From: Blaisorblade @ 2006-08-15 17:57 UTC (permalink / raw)
To: user-mode-linux-devel
Cc: Jeff Dike, Matt Mackall, akpm, Joern Engel, linux-kernel
On Tuesday 15 August 2006 05:17, Jeff Dike wrote:
> On Thu, Aug 10, 2006 at 11:45:48AM -0500, Matt Mackall wrote:
> > > SUBARCH has a different meaning here. For UML, it's the underlying,
> > > host, architecture, not a variant architecture like Voyager.
> >
> > Right, so it sounds like this breaks Voyager. Which I think means we
> > ought to pass ARCH and SUBARCH and do the right thing inside
> > checkstack.
>
> There is no use of the symbol SUBARCH in arch/i386. While this may be
> jarring to people who know and love Voyager, it doesn't break
> anything.
>
> We could do what you suggest, but that sounds unnecessary.
>
> I'd rather either
> leave things as they are
Yes, and make the script check if it ARCH=um or not (which is obvious for
now - nobody really wants a clear abstraction here).
> rename SUBARCH
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale!
http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] [PATCH] UML - support checkstack
2006-08-09 18:15 ` Jeff Dike
@ 2006-08-10 11:10 ` Jörn Engel
-1 siblings, 0 replies; 14+ messages in thread
From: Jörn Engel @ 2006-08-10 11:10 UTC (permalink / raw)
To: Jeff Dike; +Cc: akpm, linux-kernel, user-mode-linux-devel, Matt Mackall
On Wed, 9 August 2006 14:15:24 -0400, Jeff Dike wrote:
>
> Make checkstack work for UML. We need to pass the underlying architecture
> name, rather than "um" to checkstack.pl.
>
> Signed-off-by: Jeff Dike <jdike@addtoit.com>
Acked-by: Joern Engel <joern@wohnheim.fh-wedel.de>
Jörn
--
Geld macht nicht glücklich.
Glück macht nicht satt.
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] UML - support checkstack
@ 2006-08-10 11:10 ` Jörn Engel
0 siblings, 0 replies; 14+ messages in thread
From: Jörn Engel @ 2006-08-10 11:10 UTC (permalink / raw)
To: Jeff Dike; +Cc: akpm, linux-kernel, user-mode-linux-devel, Matt Mackall
On Wed, 9 August 2006 14:15:24 -0400, Jeff Dike wrote:
>
> Make checkstack work for UML. We need to pass the underlying architecture
> name, rather than "um" to checkstack.pl.
>
> Signed-off-by: Jeff Dike <jdike@addtoit.com>
Acked-by: Joern Engel <joern@wohnheim.fh-wedel.de>
Jörn
--
Geld macht nicht glücklich.
Glück macht nicht satt.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2006-08-15 17:58 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-09 18:15 [uml-devel] [PATCH] UML - support checkstack Jeff Dike
2006-08-09 18:15 ` Jeff Dike
2006-08-10 2:09 ` [uml-devel] " Matt Mackall
2006-08-10 2:09 ` Matt Mackall
2006-08-10 4:22 ` [uml-devel] " Jeff Dike
2006-08-10 4:22 ` Jeff Dike
2006-08-10 16:45 ` [uml-devel] " Matt Mackall
2006-08-10 16:45 ` Matt Mackall
2006-08-15 3:17 ` [uml-devel] " Jeff Dike
2006-08-15 3:17 ` Jeff Dike
2006-08-15 17:57 ` [uml-devel] " Blaisorblade
2006-08-15 17:57 ` Blaisorblade
2006-08-10 11:10 ` Jörn Engel
2006-08-10 11:10 ` Jörn Engel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.