From: linas@austin.ibm.com (Linas Vepstas)
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: linuxppc-dev@ozlabs.org,
linux-pci maillist <linux-pci@atrey.karlin.mff.cuni.cz>,
Yanmin Zhang <yanmin.zhang@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Rajesh Shah <rajesh.shah@intel.com>
Subject: Re: pci error recovery procedure
Date: Fri, 1 Sep 2006 16:32:51 -0500 [thread overview]
Message-ID: <20060901213251.GT8704@austin.ibm.com> (raw)
In-Reply-To: <1157101449.20092.180.camel@ymzhang-perf.sh.intel.com>
On Fri, Sep 01, 2006 at 05:04:09PM +0800, Zhang, Yanmin wrote:
> One more comment: The second parameter of error_detected also could be deleted
> because recovery procedures will save error to pci_dev->error_state.
Yes, I beleive so.
> So, the err_handler pci_error_handlers could be:
> struct pci_error_handlers
> {
> pci_ers_result_t (*error_detected)(struct pci_dev *dev);
> pci_ers_result_t (*error_resume)(struct pci_dev *dev);
> };
No, as per other email, we still need a multi-step process for
multi-function cards, and for cards that may not want to get
a full electrical reset. Finally, there might be platforms
that cannot perform a per-slot electrical reset, and would
therefore require drivers that can recover on thier own.
--linas
WARNING: multiple messages have this Message-ID (diff)
From: linas@austin.ibm.com (Linas Vepstas)
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: Rajesh Shah <rajesh.shah@intel.com>,
Yanmin Zhang <yanmin.zhang@intel.com>,
linux-pci maillist <linux-pci@atrey.karlin.mff.cuni.cz>,
linuxppc-dev@ozlabs.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: pci error recovery procedure
Date: Fri, 1 Sep 2006 16:32:51 -0500 [thread overview]
Message-ID: <20060901213251.GT8704@austin.ibm.com> (raw)
In-Reply-To: <1157101449.20092.180.camel@ymzhang-perf.sh.intel.com>
On Fri, Sep 01, 2006 at 05:04:09PM +0800, Zhang, Yanmin wrote:
> One more comment: The second parameter of error_detected also could be deleted
> because recovery procedures will save error to pci_dev->error_state.
Yes, I beleive so.
> So, the err_handler pci_error_handlers could be:
> struct pci_error_handlers
> {
> pci_ers_result_t (*error_detected)(struct pci_dev *dev);
> pci_ers_result_t (*error_resume)(struct pci_dev *dev);
> };
No, as per other email, we still need a multi-step process for
multi-function cards, and for cards that may not want to get
a full electrical reset. Finally, there might be platforms
that cannot perform a per-slot electrical reset, and would
therefore require drivers that can recover on thier own.
--linas
--
VGER BF report: H 8.89398e-05
next prev parent reply other threads:[~2006-09-01 21:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1157008212.20092.36.camel@ymzhang-perf.sh.intel.com>
2006-08-31 17:50 ` pci error recovery procedure Linas Vepstas
2006-09-01 3:33 ` Zhang, Yanmin
2006-09-01 21:25 ` Linas Vepstas
2006-09-01 21:25 ` Linas Vepstas
2006-09-04 5:47 ` Zhang, Yanmin
2006-09-04 5:47 ` Zhang, Yanmin
2006-09-04 9:03 ` Benjamin Herrenschmidt
2006-09-04 9:03 ` Benjamin Herrenschmidt
2006-09-05 2:32 ` Zhang, Yanmin
2006-09-05 2:32 ` Zhang, Yanmin
2006-09-05 19:01 ` Linas Vepstas
2006-09-05 19:01 ` Linas Vepstas
2006-09-06 1:26 ` Zhang, Yanmin
2006-09-06 1:26 ` Zhang, Yanmin
2006-09-06 20:01 ` Linas Vepstas
2006-09-06 20:01 ` Linas Vepstas
2006-09-07 1:56 ` Zhang, Yanmin
2006-09-07 1:56 ` Zhang, Yanmin
2006-09-05 18:50 ` Linas Vepstas
2006-09-05 18:50 ` Linas Vepstas
2006-09-05 21:19 ` Benjamin Herrenschmidt
2006-09-05 21:19 ` Benjamin Herrenschmidt
2006-09-06 1:35 ` Zhang, Yanmin
2006-09-06 1:35 ` Zhang, Yanmin
2006-09-05 19:17 ` Linas Vepstas
2006-09-05 19:17 ` Linas Vepstas
2006-09-06 2:04 ` Zhang, Yanmin
2006-09-06 2:04 ` Zhang, Yanmin
2006-09-06 20:39 ` Linas Vepstas
2006-09-06 20:39 ` Linas Vepstas
2006-09-07 3:18 ` Zhang, Yanmin
2006-09-07 3:18 ` Zhang, Yanmin
2006-09-12 19:38 ` Linas Vepstas
2006-09-12 19:38 ` Linas Vepstas
2006-09-01 3:42 ` Zhang, Yanmin
2006-09-01 3:42 ` Zhang, Yanmin
2006-09-01 9:04 ` Zhang, Yanmin
2006-09-01 9:04 ` Zhang, Yanmin
2006-09-01 21:32 ` Linas Vepstas [this message]
2006-09-01 21:32 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060901213251.GT8704@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
--cc=rajesh.shah@intel.com \
--cc=yanmin.zhang@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.