All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: multiboot2: make multiboot header optional
Date: Sat, 25 Nov 2006 03:59:19 +0100	[thread overview]
Message-ID: <200611250359.19398.okuji@enbug.org> (raw)
In-Reply-To: <1163633935.455ba50fe2f56@imp8-g19.free.fr>

On Thursday 16 November 2006 00:38, tgingold@free.fr wrote:
> > I still would like an improvement in the kernel->GRUB communication.
> > What about reusing the tags structure? For example:
> >
> > multiboot_header:
> > 	.long MAGIC
> > 	.long MULTIBOOT_TAG_START [...]
> > 	.long MULTIBOOT_TAG_LOADADDR ; .long 12 ; .long _start
> > 	.long MULTIBOOT_TAG_ENTRYADDR ; .long 12 ; .long main
> > 	.long MULTIBOOT_TAG_END ; .long 8
> > etc?
> >
> > A cpp macro or two could make that a little more convenient.
> >
> > The fact that the START tag requires the number of tags and number of
> > bytes is inconvenient here. Do we really need that? Why not just:
> >
> >         while (tag->key != MULTIBOOT_TAG_END)
> >                 process_tag(tag);
>
> I really like such tags structure.
> Tags structure are *very* flexible: can be easily extended without breaking
> backward compatibility.

I don't like it very much. My first draft was exactly like this. But, after 
some discussion in the IRC, I decided to revert my idea, because specifying 
so many parameters by hand really sucks. It is too error-prone.

Okuji



  reply	other threads:[~2006-11-25  2:59 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-14 22:58 multiboot2: make multiboot header optional Hollis Blanchard
2006-11-15  8:57 ` Johan Rydberg
2006-11-15 18:42   ` Hollis Blanchard
2006-11-15 20:42     ` Yoshinori K. Okuji
2006-11-15 21:39       ` Hollis Blanchard
2006-11-15 23:38         ` tgingold
2006-11-25  2:59           ` Yoshinori K. Okuji [this message]
2006-11-25  3:35             ` Hollis Blanchard
2006-11-25  4:25               ` Yoshinori K. Okuji
2006-12-02 16:18                 ` Marco Gerards
2006-12-02 17:27                   ` Yoshinori K. Okuji
2006-12-04 16:43                     ` Hollis Blanchard
2006-12-05 20:23                       ` Yoshinori K. Okuji
2006-12-07 23:07                         ` multiboot2: using tags in the multiboot header Hollis Blanchard
2006-12-12 22:23                           ` Yoshinori K. Okuji
2006-12-04 20:35                     ` multiboot2: make multiboot header optional Marco Gerards
2006-12-05 19:09                       ` Hollis Blanchard
2006-12-05 20:04                         ` Yoshinori K. Okuji
2006-12-07 22:39                           ` Hollis Blanchard
2006-12-12 22:08                             ` Yoshinori K. Okuji
2006-12-13  4:18                               ` Hollis Blanchard
2006-12-13 20:56                                 ` Yoshinori K. Okuji
2006-12-13 12:28                         ` Marco Gerards
2006-12-02 16:15       ` Marco Gerards
2006-12-02 17:19         ` Yoshinori K. Okuji
2006-11-15 20:37 ` Yoshinori K. Okuji
2006-11-15 23:41   ` tgingold
2006-11-21 16:18     ` Hollis Blanchard
2006-11-21 17:35       ` tgingold
2006-11-25  3:05         ` Yoshinori K. Okuji
2006-11-25  3:00     ` Yoshinori K. Okuji
2006-11-25  6:12       ` Tristan Gingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611250359.19398.okuji@enbug.org \
    --to=okuji@enbug.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.