* [PATCH] kexec/kdump: fix grammar in comment
@ 2007-01-10 8:03 Horms
2007-01-10 9:29 ` Ian Campbell
2007-01-10 10:39 ` Keir Fraser
0 siblings, 2 replies; 5+ messages in thread
From: Horms @ 2007-01-10 8:03 UTC (permalink / raw)
To: xen-devel; +Cc: Magnus Damm, Ian Campbell
Hi, I am resending this patch, please consider.
--
Horms
Fix the grammar in the comment that features in
xen_machine_kexec_setup_resources(). The current
edition is a bit odd.
Signed-off-by: Simon Horman <horms@verge.net.au>
diff -r a9a43705f26b linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c
--- a/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c Wed Dec 27 00:38:01 2006 +0000
+++ b/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c Wed Dec 27 13:21:54 2006 +0900
@@ -99,7 +99,7 @@ void xen_machine_kexec_setup_resources(v
/*
* It isn't possible to free xen_phys_cpus this early in the
* boot. Since failure at this stage is unexpected and the
- * amount is small we leak the memory.
+ * amount of memory that we leak is small.
*/
xen_max_nr_phys_cpus = 0;
return;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] kexec/kdump: fix grammar in comment
2007-01-10 8:03 [PATCH] kexec/kdump: fix grammar in comment Horms
@ 2007-01-10 9:29 ` Ian Campbell
2007-01-11 3:35 ` Horms
2007-01-10 10:39 ` Keir Fraser
1 sibling, 1 reply; 5+ messages in thread
From: Ian Campbell @ 2007-01-10 9:29 UTC (permalink / raw)
To: Horms; +Cc: xen-devel, Magnus Damm
On Wed, 2007-01-10 at 17:03 +0900, Horms wrote:
> Fix the grammar in the comment that features in
> xen_machine_kexec_setup_resources(). The current
> edition is a bit odd.
What I was trying to say is that we allow a possible memory leak because
the failure is unexpected and the amount is small, your version doesn't
really convey that information.
I've changed it to:
* It isn't possible to free xen_phys_cpus this early in the
* boot. Failure at this stage is unexpected and the
* amount of memory is small therefore we tolerate the
* potential leak.
Ian.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] kexec/kdump: fix grammar in comment
2007-01-10 9:29 ` Ian Campbell
@ 2007-01-11 3:35 ` Horms
0 siblings, 0 replies; 5+ messages in thread
From: Horms @ 2007-01-11 3:35 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, Magnus Damm
On Wed, Jan 10, 2007 at 09:29:18AM +0000, Ian Campbell wrote:
> On Wed, 2007-01-10 at 17:03 +0900, Horms wrote:
> > Fix the grammar in the comment that features in
> > xen_machine_kexec_setup_resources(). The current
> > edition is a bit odd.
>
> What I was trying to say is that we allow a possible memory leak because
> the failure is unexpected and the amount is small, your version doesn't
> really convey that information.
>
> I've changed it to:
>
> * It isn't possible to free xen_phys_cpus this early in the
> * boot. Failure at this stage is unexpected and the
> * amount of memory is small therefore we tolerate the
> * potential leak.
Thanks.
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kexec/kdump: fix grammar in comment
2007-01-10 8:03 [PATCH] kexec/kdump: fix grammar in comment Horms
2007-01-10 9:29 ` Ian Campbell
@ 2007-01-10 10:39 ` Keir Fraser
1 sibling, 0 replies; 5+ messages in thread
From: Keir Fraser @ 2007-01-10 10:39 UTC (permalink / raw)
To: Horms, xen-devel; +Cc: Magnus Damm, Ian Campbell
The existing sentence is grammatically okay and fits better with the first
sentence.
K.
On 10/1/07 08:03, "Horms" <horms@verge.net.au> wrote:
> Hi, I am resending this patch, please consider.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] kexec/kdump: fix grammar in comment
@ 2006-12-27 4:29 Horms
0 siblings, 0 replies; 5+ messages in thread
From: Horms @ 2006-12-27 4:29 UTC (permalink / raw)
To: xen-devel
Fix the grammar in the comment that features in
xen_machine_kexec_setup_resources(). The current
edition is a bit odd.
Signed-off-by: Simon Horman <horms@verge.net.au>
diff -r a9a43705f26b linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c
--- a/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c Wed Dec 27 00:38:01 2006 +0000
+++ b/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c Wed Dec 27 13:21:54 2006 +0900
@@ -99,7 +99,7 @@ void xen_machine_kexec_setup_resources(v
/*
* It isn't possible to free xen_phys_cpus this early in the
* boot. Since failure at this stage is unexpected and the
- * amount is small we leak the memory.
+ * amount of memory that we leak is small.
*/
xen_max_nr_phys_cpus = 0;
return;
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-01-11 3:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-10 8:03 [PATCH] kexec/kdump: fix grammar in comment Horms
2007-01-10 9:29 ` Ian Campbell
2007-01-11 3:35 ` Horms
2007-01-10 10:39 ` Keir Fraser
-- strict thread matches above, loose matches on Subject: below --
2006-12-27 4:29 Horms
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.