All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] mm: remove global locks from mm/highmem.c
Date: Sun, 28 Jan 2007 19:19:09 +0100	[thread overview]
Message-ID: <20070128181909.GA12645@elte.hu> (raw)
In-Reply-To: <20070128155429.GA26855@infradead.org>


* Christoph Hellwig <hch@infradead.org> wrote:

> On Sun, Jan 28, 2007 at 04:48:06PM +0100, Ingo Molnar wrote:
> > i'm sorry, but do you realize that files_lock is a global lock, 
> > triggered by /every single/ file close?
> 
> Please check which thread you're in before you start such lengthy 
> rants.

my reply applies to the other thread too, you made a similar comment 
there too:

* Christoph Hellwig <hch@infradead.org> wrote:

> On Sun, Jan 28, 2007 at 12:51:18PM +0100, Peter Zijlstra wrote:
> > This patch-set breaks up the global file_list_lock which was found 
> > to be a severe contention point under basically any filesystem 
> > intensive workload.
>
> Benchmarks, please.  Where exactly do you see contention for this?

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] mm: remove global locks from mm/highmem.c
Date: Sun, 28 Jan 2007 19:19:09 +0100	[thread overview]
Message-ID: <20070128181909.GA12645@elte.hu> (raw)
In-Reply-To: <20070128155429.GA26855@infradead.org>

* Christoph Hellwig <hch@infradead.org> wrote:

> On Sun, Jan 28, 2007 at 04:48:06PM +0100, Ingo Molnar wrote:
> > i'm sorry, but do you realize that files_lock is a global lock, 
> > triggered by /every single/ file close?
> 
> Please check which thread you're in before you start such lengthy 
> rants.

my reply applies to the other thread too, you made a similar comment 
there too:

* Christoph Hellwig <hch@infradead.org> wrote:

> On Sun, Jan 28, 2007 at 12:51:18PM +0100, Peter Zijlstra wrote:
> > This patch-set breaks up the global file_list_lock which was found 
> > to be a severe contention point under basically any filesystem 
> > intensive workload.
>
> Benchmarks, please.  Where exactly do you see contention for this?

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-01-28 18:21 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-28 14:11 [PATCH] mm: remove global locks from mm/highmem.c Peter Zijlstra
2007-01-28 14:11 ` Peter Zijlstra
2007-01-28 14:49 ` Christoph Hellwig
2007-01-28 14:49   ` Christoph Hellwig
2007-01-28 15:17   ` Ingo Molnar
2007-01-28 15:17     ` Ingo Molnar
2007-01-28 15:28     ` Christoph Hellwig
2007-01-28 15:28       ` Christoph Hellwig
2007-01-28 15:48       ` Ingo Molnar
2007-01-28 15:48         ` Ingo Molnar
2007-01-28 15:54         ` Christoph Hellwig
2007-01-28 15:54           ` Christoph Hellwig
2007-01-28 18:19           ` Ingo Molnar [this message]
2007-01-28 18:19             ` Ingo Molnar
2007-01-28 22:29 ` Andrew Morton
2007-01-28 22:29   ` Andrew Morton
2007-01-29  2:52   ` Nick Piggin
2007-01-29  2:52     ` Nick Piggin
2007-01-29  9:44   ` Peter Zijlstra
2007-01-29  9:44     ` Peter Zijlstra
2007-01-30  1:31     ` Martin J. Bligh
2007-01-30  1:31       ` Martin J. Bligh
2007-01-30  1:41       ` Andrew Morton
2007-01-30  1:41         ` Andrew Morton
2007-01-30  1:49         ` Martin J. Bligh
2007-01-30  1:49           ` Martin J. Bligh
2007-01-30  2:15           ` Andrew Morton
2007-01-30  2:15             ` Andrew Morton
2007-01-31  0:44             ` David Chinner
2007-01-31  0:44               ` David Chinner
2007-01-31  1:11               ` Andrew Morton
2007-01-31  1:11                 ` Andrew Morton
2007-01-31  3:22                 ` David Chinner
2007-01-31  3:22                   ` David Chinner
2007-02-02 12:05                   ` Christoph Hellwig
2007-02-02 12:05                     ` Christoph Hellwig
2007-02-02 19:24                     ` Matt Mackall
2007-02-02 19:24                       ` Matt Mackall
2007-02-02 23:16                       ` David Chinner
2007-02-02 23:16                         ` David Chinner
2007-02-02 23:14                     ` David Chinner
2007-02-02 23:14                       ` David Chinner
2007-01-29 19:08   ` Ingo Molnar
2007-01-29 19:08     ` Ingo Molnar
2007-01-29 19:19     ` Hugh Dickins
2007-01-29 19:19       ` Hugh Dickins
2007-01-29 19:53       ` Ingo Molnar
2007-01-29 19:53         ` Ingo Molnar
2007-01-29 20:06     ` Ingo Molnar
2007-01-29 20:06       ` Ingo Molnar
2007-01-30  2:02     ` Nick Piggin
2007-01-30  2:02       ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070128181909.GA12645@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.