From: David Chinner <dgc@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Martin J. Bligh" <mbligh@mbligh.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ingo Molnar <mingo@elte.hu>, David Chinner <dgc@sgi.com>
Subject: Re: [PATCH] mm: remove global locks from mm/highmem.c
Date: Wed, 31 Jan 2007 11:44:36 +1100 [thread overview]
Message-ID: <20070131004436.GS44411608@melbourne.sgi.com> (raw)
In-Reply-To: <20070129181557.d4d17dd0.akpm@osdl.org>
On Mon, Jan 29, 2007 at 06:15:57PM -0800, Andrew Morton wrote:
> We still don't know what is the source of kmap() activity which
> necessitated this patch btw. AFAIK the busiest source is ext2 directories,
> but perhaps NFS under certain conditions?
>
> <looks at xfs_iozero>
>
> ->prepare_write no longer requires that the caller kmap the page.
Agreed, but don't we (xfs_iozero) have to map it first to zero it?
I think what you are saying here, Andrew, is that we can
do something like:
page = grab_cache_page
->prepare_write(page)
kaddr = kmap_atomic(page, KM_USER0)
memset(kaddr+offset, 0, bytes)
flush_dcache_page(page)
kunmap_atomic(kaddr, KM_USER0)
->commit_write(page)
to avoid using kmap() altogether?
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
WARNING: multiple messages have this Message-ID (diff)
From: David Chinner <dgc@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Martin J. Bligh" <mbligh@mbligh.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ingo Molnar <mingo@elte.hu>, David Chinner <dgc@sgi.com>
Subject: Re: [PATCH] mm: remove global locks from mm/highmem.c
Date: Wed, 31 Jan 2007 11:44:36 +1100 [thread overview]
Message-ID: <20070131004436.GS44411608@melbourne.sgi.com> (raw)
In-Reply-To: <20070129181557.d4d17dd0.akpm@osdl.org>
On Mon, Jan 29, 2007 at 06:15:57PM -0800, Andrew Morton wrote:
> We still don't know what is the source of kmap() activity which
> necessitated this patch btw. AFAIK the busiest source is ext2 directories,
> but perhaps NFS under certain conditions?
>
> <looks at xfs_iozero>
>
> ->prepare_write no longer requires that the caller kmap the page.
Agreed, but don't we (xfs_iozero) have to map it first to zero it?
I think what you are saying here, Andrew, is that we can
do something like:
page = grab_cache_page
->prepare_write(page)
kaddr = kmap_atomic(page, KM_USER0)
memset(kaddr+offset, 0, bytes)
flush_dcache_page(page)
kunmap_atomic(kaddr, KM_USER0)
->commit_write(page)
to avoid using kmap() altogether?
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-01-31 0:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-28 14:11 [PATCH] mm: remove global locks from mm/highmem.c Peter Zijlstra
2007-01-28 14:11 ` Peter Zijlstra
2007-01-28 14:49 ` Christoph Hellwig
2007-01-28 14:49 ` Christoph Hellwig
2007-01-28 15:17 ` Ingo Molnar
2007-01-28 15:17 ` Ingo Molnar
2007-01-28 15:28 ` Christoph Hellwig
2007-01-28 15:28 ` Christoph Hellwig
2007-01-28 15:48 ` Ingo Molnar
2007-01-28 15:48 ` Ingo Molnar
2007-01-28 15:54 ` Christoph Hellwig
2007-01-28 15:54 ` Christoph Hellwig
2007-01-28 18:19 ` Ingo Molnar
2007-01-28 18:19 ` Ingo Molnar
2007-01-28 22:29 ` Andrew Morton
2007-01-28 22:29 ` Andrew Morton
2007-01-29 2:52 ` Nick Piggin
2007-01-29 2:52 ` Nick Piggin
2007-01-29 9:44 ` Peter Zijlstra
2007-01-29 9:44 ` Peter Zijlstra
2007-01-30 1:31 ` Martin J. Bligh
2007-01-30 1:31 ` Martin J. Bligh
2007-01-30 1:41 ` Andrew Morton
2007-01-30 1:41 ` Andrew Morton
2007-01-30 1:49 ` Martin J. Bligh
2007-01-30 1:49 ` Martin J. Bligh
2007-01-30 2:15 ` Andrew Morton
2007-01-30 2:15 ` Andrew Morton
2007-01-31 0:44 ` David Chinner [this message]
2007-01-31 0:44 ` David Chinner
2007-01-31 1:11 ` Andrew Morton
2007-01-31 1:11 ` Andrew Morton
2007-01-31 3:22 ` David Chinner
2007-01-31 3:22 ` David Chinner
2007-02-02 12:05 ` Christoph Hellwig
2007-02-02 12:05 ` Christoph Hellwig
2007-02-02 19:24 ` Matt Mackall
2007-02-02 19:24 ` Matt Mackall
2007-02-02 23:16 ` David Chinner
2007-02-02 23:16 ` David Chinner
2007-02-02 23:14 ` David Chinner
2007-02-02 23:14 ` David Chinner
2007-01-29 19:08 ` Ingo Molnar
2007-01-29 19:08 ` Ingo Molnar
2007-01-29 19:19 ` Hugh Dickins
2007-01-29 19:19 ` Hugh Dickins
2007-01-29 19:53 ` Ingo Molnar
2007-01-29 19:53 ` Ingo Molnar
2007-01-29 20:06 ` Ingo Molnar
2007-01-29 20:06 ` Ingo Molnar
2007-01-30 2:02 ` Nick Piggin
2007-01-30 2:02 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070131004436.GS44411608@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@mbligh.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.