Re: [Cbe-oss-dev] [RFC, PATCH] CELL Oprofile SPU profiling updated patch

[Arnd Bergmann <arnd@arndb.de>]

On Thursday 15 February 2007 17:15, Maynard Johnson wrote:
> >>+void spu_set_profile_private(struct spu_context * ctx, void * profile_=
info,
> >>+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0 =
=A0 struct kref * prof_info_kref,
> >>+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0 =
=A0 void (* prof_info_release) (struct kref * kref))
> >>+{
> >>+=A0=A0=A0=A0=A0ctx->profile_private =3D profile_info;
> >>+=A0=A0=A0=A0=A0ctx->prof_priv_kref =3D prof_info_kref;
> >>+=A0=A0=A0=A0=A0ctx->prof_priv_release =3D prof_info_release;
> >>+}
> >>+EXPORT_SYMBOL_GPL(spu_set_profile_private);
> >> =A0 =A0
> >>
> >
> >I think you don't need the profile_private member here, if you just use
> >container_of with ctx->prof_priv_kref in all users.
> > =A0
> >
> Sorry, I don't follow. We want the profile_private to be stored in the=20
> spu_context, don't we? =A0How else would I be able to do that? =A0And=20
> besides, wouldn't container_of need the struct name of profile_private? =
=A0
> SPUFS doesn't have access to the type.

The idea was to have spu_get_profile_private return the kref pointer,
and then change the user of that to do

+       if (!spu_info[spu_num] && the_spu) {
+               spu_info[spu_num] =3D container_of(
+				spu_get_profile_private(the_spu->ctx),
+				struct cached_info, cache_kref);
+               if (spu_info[spu_num])
+                       kref_get(&spu_info[spu_num]->cache_ref);