All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Andi Drebes <lists-receive@programmierforen.de>
Cc: Richard Knutsson <ricknu-0@student.ltu.se>,
	kernel-janitors@lists.osdl.org, linux-acpi@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations
Date: Wed, 30 May 2007 19:25:05 +0000	[thread overview]
Message-ID: <200705301525.05905.lenb@kernel.org> (raw)
In-Reply-To: <200705261558.24912.lists-receive@programmierforen.de>

 
> > Any reason to not just replace ACPI_RSD_TABLE_SIZE with ARRAY_SIZE?

Probably because ARRAY_SIZE doesn't exist in ACPICA, which is
where this code comes from...

When we change syntax in ACPICA files in Linux to make it more "beautiful",
then it creates more work for me -- as forever on, that syntax difference
must be manually compared to upstream ACPICA and Linux -- and that syntax
difference causes upstream patches to no longer apply and require
hand merging.

If you can license your patches to ACPICA files (drivers/acpi/*/*)
back to Intel to re-distribute under _both_ licenses at the top
of the file, then I'll be happy to apply them.
Otherwise, I'm really not excited about creating work
for no functional benefit.

thanks,
-Len
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Len Brown <lenb@kernel.org>
To: Andi Drebes <lists-receive@programmierforen.de>
Cc: Richard Knutsson <ricknu-0@student.ltu.se>,
	kernel-janitors@lists.osdl.org, linux-acpi@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE
Date: Wed, 30 May 2007 15:25:05 -0400	[thread overview]
Message-ID: <200705301525.05905.lenb@kernel.org> (raw)
In-Reply-To: <200705261558.24912.lists-receive@programmierforen.de>

 
> > Any reason to not just replace ACPI_RSD_TABLE_SIZE with ARRAY_SIZE?

Probably because ARRAY_SIZE doesn't exist in ACPICA, which is
where this code comes from...

When we change syntax in ACPICA files in Linux to make it more "beautiful",
then it creates more work for me -- as forever on, that syntax difference
must be manually compared to upstream ACPICA and Linux -- and that syntax
difference causes upstream patches to no longer apply and require
hand merging.

If you can license your patches to ACPICA files (drivers/acpi/*/*)
back to Intel to re-distribute under _both_ licenses at the top
of the file, then I'll be happy to apply them.
Otherwise, I'm really not excited about creating work
for no functional benefit.

thanks,
-Len

  reply	other threads:[~2007-05-30 19:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-26 10:39 [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-05-26 10:39 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes
2007-05-26 11:28 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Robert P. J. Day
2007-05-26 11:28   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Robert P. J. Day
2007-05-26 13:53   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-05-26 13:53     ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes
2007-05-26 11:37 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Richard Knutsson
2007-05-26 11:37   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Richard Knutsson
2007-05-26 13:58   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-05-26 13:58     ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes
2007-05-30 19:25     ` Len Brown [this message]
2007-05-30 19:25       ` Len Brown
2007-05-31  9:56       ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Christoph Hellwig
2007-05-31  9:56         ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Christoph Hellwig
2007-06-10 10:57         ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Pavel Machek
2007-06-10 10:57           ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Pavel Machek
2007-06-10 21:44           ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Bjorn Helgaas
2007-06-10 21:44             ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Bjorn Helgaas
2007-06-12 18:41             ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-06-12 18:41               ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes
2007-06-12 18:53               ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Bjorn Helgaas
2007-06-12 18:53                 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Bjorn Helgaas
2007-06-13 21:21                 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-06-13 21:21                   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes
2007-06-15 17:56                 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-06-15 17:56                   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705301525.05905.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lists-receive@programmierforen.de \
    --cc=ricknu-0@student.ltu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.