All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Drebes <lists-receive@programmierforen.de>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	Christoph Hellwig <hch@infradead.org>,
	Len Brown <lenb@kernel.org>,
	kernel-janitors@lists.osdl.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations
Date: Wed, 13 Jun 2007 21:21:38 +0000	[thread overview]
Message-ID: <200706132321.39440.lists-receive@programmierforen.de> (raw)
In-Reply-To: <200706121253.07395.bjorn.helgaas@hp.com>

<snip>
> You found the right one.  The ACPI CA in Linux is really the same
> as the one from Intel.  Len integrates the Intel one into Linux
> periodically.  He uses scripts or something to format it so it looks
> more like Linux.
Ok. That's what I thought so far.

> I think Len sometimes takes patches against the "Linux-ized" ACPI CA.
> He probably has to apply those by hand to the Intel one, which is
> the real "upstream" in this case.  So it might be a bit easier for
> him if you generated a diff against the Intel version. 
OK. I will do this in the next time.

> In any event, you want to end up with one patch, not two.
Ok. I thought of two patches because I didn't know how strong
the sources from the  ACPI CA are modified.

> You probably would have to add something like:
> 
>   #ifndef ARRAY_SIZE
>   #define ARRAY_SIZE(x) ...
>   #endif
> 
> somewhere in the ACPI CA header files.  That way it will work in
> non-Linux OSes as well.

Thanks so far,
	Andi
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Andi Drebes <lists-receive@programmierforen.de>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	Christoph Hellwig <hch@infradead.org>,
	Len Brown <lenb@kernel.org>,
	kernel-janitors@lists.osdl.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE
Date: Wed, 13 Jun 2007 23:21:38 +0200	[thread overview]
Message-ID: <200706132321.39440.lists-receive@programmierforen.de> (raw)
In-Reply-To: <200706121253.07395.bjorn.helgaas@hp.com>

<snip>
> You found the right one.  The ACPI CA in Linux is really the same
> as the one from Intel.  Len integrates the Intel one into Linux
> periodically.  He uses scripts or something to format it so it looks
> more like Linux.
Ok. That's what I thought so far.

> I think Len sometimes takes patches against the "Linux-ized" ACPI CA.
> He probably has to apply those by hand to the Intel one, which is
> the real "upstream" in this case.  So it might be a bit easier for
> him if you generated a diff against the Intel version. 
OK. I will do this in the next time.

> In any event, you want to end up with one patch, not two.
Ok. I thought of two patches because I didn't know how strong
the sources from the  ACPI CA are modified.

> You probably would have to add something like:
> 
>   #ifndef ARRAY_SIZE
>   #define ARRAY_SIZE(x) ...
>   #endif
> 
> somewhere in the ACPI CA header files.  That way it will work in
> non-Linux OSes as well.

Thanks so far,
	Andi

  reply	other threads:[~2007-06-13 21:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-26 10:39 [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-05-26 10:39 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes
2007-05-26 11:28 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Robert P. J. Day
2007-05-26 11:28   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Robert P. J. Day
2007-05-26 13:53   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-05-26 13:53     ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes
2007-05-26 11:37 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Richard Knutsson
2007-05-26 11:37   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Richard Knutsson
2007-05-26 13:58   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-05-26 13:58     ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes
2007-05-30 19:25     ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Len Brown
2007-05-30 19:25       ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Len Brown
2007-05-31  9:56       ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Christoph Hellwig
2007-05-31  9:56         ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Christoph Hellwig
2007-06-10 10:57         ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Pavel Machek
2007-06-10 10:57           ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Pavel Machek
2007-06-10 21:44           ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Bjorn Helgaas
2007-06-10 21:44             ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Bjorn Helgaas
2007-06-12 18:41             ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-06-12 18:41               ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes
2007-06-12 18:53               ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Bjorn Helgaas
2007-06-12 18:53                 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Bjorn Helgaas
2007-06-13 21:21                 ` Andi Drebes [this message]
2007-06-13 21:21                   ` Andi Drebes
2007-06-15 17:56                 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations Andi Drebes
2007-06-15 17:56                   ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Andi Drebes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706132321.39440.lists-receive@programmierforen.de \
    --to=lists-receive@programmierforen.de \
    --cc=bjorn.helgaas@hp.com \
    --cc=hch@infradead.org \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.