From: David Brownell <david-b@pacbell.net>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 1/2] acpi choose sleep state help
Date: Thu, 21 Jun 2007 00:14:27 -0700 [thread overview]
Message-ID: <200706210014.28707.david-b@pacbell.net> (raw)
In-Reply-To: <1182320280.30540.4.camel@sli10-conroe.sh.intel.com>
On Tuesday 19 June 2007, Shaohua Li wrote:
> > > +int acpi_pm_choose_sleep_state(acpi_handle handle, pm_message_t state)
> > > +{
> >
> > The second argument doesn't seem to be used. Is that intentional and if so,
> > then why?
That's what the platform hook API uses. It is indeed a
useless parameter. Removing it should be a separate patch.
> I hope it gives the suspend state, but it appears it's not used.
Eventually the API should be fixed to not include a pm_message_t ...
which should be called a "message" not a "state" (in every driver!).
prev parent reply other threads:[~2007-06-21 7:34 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 2:33 [PATCH 1/2] acpi choose sleep state help Shaohua Li
2007-06-19 11:52 ` Rafael J. Wysocki
2007-06-19 22:00 ` Rafael J. Wysocki
2007-06-20 6:18 ` Shaohua Li
2007-06-20 11:32 ` [RFD] How to tell ACPI drivers what the target sleep state is (was: Re: [PATCH 1/2] acpi choose sleep state help) Rafael J. Wysocki
2007-06-20 11:32 ` Rafael J. Wysocki
2007-06-20 14:08 ` Alan Stern
2007-06-20 14:08 ` [linux-pm] " Alan Stern
2007-06-20 14:36 ` Rafael J. Wysocki
2007-06-20 14:36 ` Rafael J. Wysocki
2007-06-21 6:57 ` David Brownell
2007-06-21 1:51 ` Len Brown
2007-06-21 1:51 ` Len Brown
2007-06-21 7:10 ` David Brownell
2007-06-21 7:04 ` David Brownell
2007-06-21 12:42 ` Rafael J. Wysocki
2007-06-21 13:03 ` Pavel Machek
2007-06-21 13:03 ` Pavel Machek
2007-06-21 14:46 ` Rafael J. Wysocki
2007-06-21 14:46 ` Rafael J. Wysocki
2007-06-21 15:23 ` [linux-pm] " Alan Stern
2007-06-21 19:41 ` Rafael J. Wysocki
2007-06-21 19:41 ` Rafael J. Wysocki
2007-06-21 15:23 ` Alan Stern
2007-06-21 16:35 ` David Brownell
2007-06-21 19:42 ` Rafael J. Wysocki
2007-06-21 19:42 ` Rafael J. Wysocki
2007-06-21 16:35 ` David Brownell
2007-06-21 15:37 ` David Brownell
2007-06-21 18:59 ` [linux-pm] " Pavel Machek
2007-06-21 20:03 ` David Brownell
2007-06-21 20:03 ` [linux-pm] " David Brownell
2007-06-21 20:37 ` Rafael J. Wysocki
2007-06-21 20:37 ` [linux-pm] " Rafael J. Wysocki
2007-06-21 18:59 ` Pavel Machek
2007-06-21 19:52 ` Rafael J. Wysocki
2007-06-21 19:52 ` Rafael J. Wysocki
2007-06-21 15:37 ` David Brownell
2007-06-21 14:48 ` David Brownell
2007-06-21 14:48 ` David Brownell
2007-06-21 20:04 ` Rafael J. Wysocki
2007-06-21 20:22 ` David Brownell
2007-06-21 20:41 ` Rafael J. Wysocki
2007-06-21 20:41 ` Rafael J. Wysocki
2007-06-21 20:22 ` David Brownell
2007-06-21 20:04 ` Rafael J. Wysocki
2007-06-21 12:42 ` Rafael J. Wysocki
2007-06-21 15:56 ` Alan Stern
2007-06-21 16:35 ` David Brownell
2007-06-21 16:35 ` [linux-pm] " David Brownell
2007-06-21 17:11 ` Alan Stern
2007-06-21 17:11 ` [linux-pm] " Alan Stern
2007-06-21 18:02 ` David Brownell
2007-06-21 18:02 ` [linux-pm] " David Brownell
2007-06-21 18:51 ` Alan Stern
2007-06-21 19:51 ` David Brownell
2007-06-21 20:35 ` Rafael J. Wysocki
2007-06-21 20:46 ` David Brownell
2007-06-21 21:02 ` Rafael J. Wysocki
2007-06-21 21:04 ` Alan Stern
2007-06-21 21:04 ` [linux-pm] " Alan Stern
2007-06-23 22:00 ` [RFC][PATCH -mm] PM: Introduce set_target method in pm_ops Rafael J. Wysocki
2007-06-23 22:00 ` Rafael J. Wysocki
2007-06-23 23:46 ` Alan Stern
2007-06-23 23:46 ` Alan Stern
2007-06-24 0:03 ` Rafael J. Wysocki
2007-06-24 0:28 ` Alan Stern
2007-06-24 9:52 ` Johannes Berg
2007-06-24 9:52 ` [linux-pm] " Johannes Berg
2007-06-24 11:49 ` Igor Stoppa
2007-06-24 13:04 ` Rafael J. Wysocki
2007-06-24 13:04 ` [linux-pm] " Rafael J. Wysocki
2007-06-24 11:49 ` Igor Stoppa
2007-06-24 12:57 ` Rafael J. Wysocki
2007-06-25 0:01 ` David Brownell
2007-06-25 0:01 ` David Brownell
2007-06-25 22:14 ` Rafael J. Wysocki
2007-06-25 22:14 ` Rafael J. Wysocki
2007-06-24 12:57 ` Rafael J. Wysocki
2007-06-24 0:28 ` Alan Stern
2007-06-25 13:04 ` Pavel Machek
2007-06-25 13:57 ` [linux-pm] " Dmitry Krivoschekov
2007-06-25 19:28 ` Pavel Machek
2007-06-25 19:28 ` [linux-pm] " Pavel Machek
2007-06-25 22:16 ` Rafael J. Wysocki
2007-06-25 22:16 ` [linux-pm] " Rafael J. Wysocki
2007-06-25 13:57 ` Dmitry Krivoschekov
2007-06-25 13:04 ` Pavel Machek
2007-06-24 0:03 ` Rafael J. Wysocki
2007-06-21 21:02 ` Re: [RFD] How to tell ACPI drivers what the target sleep state is (was: Re: [PATCH 1/2] acpi choose sleep state help) Rafael J. Wysocki
2007-06-21 20:46 ` David Brownell
2007-06-21 20:35 ` Rafael J. Wysocki
2007-06-21 21:00 ` Platform-specific system power states Alan Stern
2007-06-22 19:49 ` David Brownell
2007-06-22 21:30 ` Rafael J. Wysocki
2007-06-23 1:32 ` Alan Stern
2007-06-23 20:20 ` Rafael J. Wysocki
2007-06-25 0:10 ` David Brownell
2007-06-25 22:59 ` Rafael J. Wysocki
2007-06-25 0:26 ` David Brownell
2007-06-25 23:04 ` Rafael J. Wysocki
2007-06-21 19:51 ` Re: [RFD] How to tell ACPI drivers what the target sleep state is (was: Re: [PATCH 1/2] acpi choose sleep state help) David Brownell
2007-06-21 20:19 ` Rafael J. Wysocki
2007-06-21 20:19 ` [linux-pm] " Rafael J. Wysocki
2007-06-21 20:32 ` David Brownell
2007-06-21 20:50 ` Rafael J. Wysocki
2007-06-21 20:50 ` Rafael J. Wysocki
2007-06-21 20:32 ` David Brownell
2007-06-21 18:51 ` Alan Stern
2007-06-20 11:32 ` Rafael J. Wysocki
2007-06-21 7:14 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706210014.28707.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.