From: David Brownell <david-b@pacbell.net>
To: Christoph Hellwig <hch@lst.de>
Cc: Domen Puncer <domen.puncer@telargo.com>,
linuxppc-dev@ozlabs.org, Sylvain Munaut <tnt@246tnt.com>,
linux-mips@linux-mips.org, Russell King <rmk@arm.linux.org.uk>
Subject: Re: [PATCH 1/3] powerpc clk.h interface for platforms
Date: Wed, 11 Jul 2007 08:56:58 -0700 [thread overview]
Message-ID: <200707110856.58463.david-b@pacbell.net> (raw)
In-Reply-To: <20070711103640.GB15536@lst.de>
On Wednesday 11 July 2007, Christoph Hellwig wrote:
> On Wed, Jul 11, 2007 at 11:32:20AM +0200, Domen Puncer wrote:
> > clk interface for arch/powerpc, platforms should fill
> > clk_functions.
>
> Umm, this is about the fifth almost identical implementation of
> the clk_ functions. Please, please put it into common code.
>
> And talk to the mips folks which just got a similar comment from me.
You mean like a lib/clock.c core, rather than an opsvector?
ISTR that allowing custom platform-specific implementations
was intended to be a feature. But it's also true that some
folks see lack of shared implementation code as a drawback;
so I've CC'd Russell King (who originated the interface for
ARM platforms).
- Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org, Domen Puncer <domen.puncer@telargo.com>,
Russell King <rmk@arm.linux.org.uk>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 1/3] powerpc clk.h interface for platforms
Date: Wed, 11 Jul 2007 08:56:58 -0700 [thread overview]
Message-ID: <200707110856.58463.david-b@pacbell.net> (raw)
In-Reply-To: <20070711103640.GB15536@lst.de>
On Wednesday 11 July 2007, Christoph Hellwig wrote:
> On Wed, Jul 11, 2007 at 11:32:20AM +0200, Domen Puncer wrote:
> > clk interface for arch/powerpc, platforms should fill
> > clk_functions.
>
> Umm, this is about the fifth almost identical implementation of
> the clk_ functions. Please, please put it into common code.
>
> And talk to the mips folks which just got a similar comment from me.
You mean like a lib/clock.c core, rather than an opsvector?
ISTR that allowing custom platform-specific implementations
was intended to be a feature. But it's also true that some
folks see lack of shared implementation code as a drawback;
so I've CC'd Russell King (who originated the interface for
ARM platforms).
- Dave
next prev parent reply other threads:[~2007-07-11 16:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 9:31 [PATCH 0/3] clock (clk.h) framework for mpc52xx Domen Puncer
2007-07-11 9:32 ` [PATCH 1/3] powerpc clk.h interface for platforms Domen Puncer
2007-07-11 10:36 ` Christoph Hellwig
2007-07-11 10:36 ` Christoph Hellwig
2007-07-11 15:56 ` David Brownell [this message]
2007-07-11 15:56 ` David Brownell
2007-07-11 16:16 ` Christoph Hellwig
2007-07-11 16:16 ` Christoph Hellwig
2007-07-11 17:02 ` David Brownell
2007-07-11 17:02 ` David Brownell
2007-07-11 20:34 ` Russell King
2007-07-11 20:34 ` Russell King
2007-07-11 20:52 ` David Brownell
2007-07-11 20:52 ` David Brownell
2007-07-13 9:12 ` Domen Puncer
2007-07-13 9:12 ` Domen Puncer
2007-08-01 7:28 ` Generic clk.h wrappers? [Was: Re: [PATCH 1/3] powerpc clk.h interface for platforms] Domen Puncer
2007-08-01 7:28 ` Domen Puncer
2007-08-01 12:57 ` Christoph Hellwig
2007-08-01 12:57 ` Christoph Hellwig
2007-08-02 23:32 ` David Brownell
2007-08-02 23:32 ` David Brownell
2007-08-03 8:36 ` Russell King
2007-08-03 8:36 ` Russell King
2007-08-06 6:58 ` [PATCH 1/3] powerpc clk.h interface for platforms Domen Puncer
2007-09-19 3:47 ` Paul Mackerras
2007-09-19 5:11 ` Domen Puncer
2007-09-20 5:07 ` Paul Mackerras
2007-09-20 14:00 ` [PATCH 1/3 v2] " Domen Puncer
2007-07-11 9:33 ` [PATCH 2/3] mpc52xx clk.h interface Domen Puncer
2007-07-11 9:34 ` [PATCH 3/3] mpc52xx_psc_spi: use clk.h subsystem Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707110856.58463.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=domen.puncer@telargo.com \
--cc=hch@lst.de \
--cc=linux-mips@linux-mips.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rmk@arm.linux.org.uk \
--cc=tnt@246tnt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.