From: Matthew Wilcox <matthew@wil.cx>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 8/24] advansys: Rewrite resource management
Date: Fri, 27 Jul 2007 08:43:20 -0600 [thread overview]
Message-ID: <20070727144320.GH21219@parisc-linux.org> (raw)
In-Reply-To: <46AA038A.2010203@garzik.org>
On Fri, Jul 27, 2007 at 10:39:06AM -0400, Jeff Garzik wrote:
> Ancillary comments:
>
> 1) It is a common style to
>
> #define DRV_NAME "advansys"
>
> at the top, and then use DRV_NAME in request_region() calls,
> request_irq() calls, struct eisa_driver, struct pci_driver, ...
Yup.
> 2) A future cleanup might add __FUNCTION__ to ASC_PRINTx, eliminating a
> lot of manual reproduction of same
Goodness, yes. Again, a can of worms I haven't had the heart to use the
opener on yet. Also ASC_DBG needs to be turned into pr_debug.
Thee's so much yuck in this driver, I've had a hard time staying focused
on cleaning up only one thing at a time.
Did you mention 'remove internal queueing' yet? If not, I beat you to
it ;-)
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-07-27 14:43 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 13:40 advansys update 2007-07-27 Matthew Wilcox
2007-07-27 13:42 ` [PATCH 2/24] advansys: Clean up proc_info implementation Matthew Wilcox
2007-07-27 13:42 ` [PATCH 3/24] advansys: version, copyright, etc Matthew Wilcox
2007-07-27 13:42 ` [PATCH 4/24] advansys: Make advansys_board_found a little more readable Matthew Wilcox
2007-07-27 14:04 ` Jeff Garzik
2007-07-27 14:07 ` Matthew Wilcox
2007-07-27 13:42 ` [PATCH 5/24] advansys: Move to scsi hotplug initialisation model Matthew Wilcox
2007-07-27 13:42 ` [PATCH 6/24] advansys: Convert to pci_register_driver interface Matthew Wilcox
2007-07-27 14:15 ` Jeff Garzik
2007-07-27 13:42 ` [PATCH 7/24] advansys: Convert to EISA driver model Matthew Wilcox
2007-07-27 14:17 ` Jeff Garzik
2007-07-27 14:22 ` Matthew Wilcox
2007-07-27 14:35 ` Jeff Garzik
2007-07-27 14:40 ` Matthew Wilcox
2007-07-27 13:42 ` [PATCH 8/24] advansys: Rewrite resource management Matthew Wilcox
2007-07-27 14:39 ` Jeff Garzik
2007-07-27 14:43 ` Matthew Wilcox [this message]
2007-07-27 13:42 ` [PATCH 9/24] advansys: More PCI cleanups Matthew Wilcox
2007-07-27 14:41 ` Jeff Garzik
2007-07-27 14:44 ` Matthew Wilcox
2007-07-27 13:42 ` [PATCH 10/24] advansys: remove AscCompareString() Matthew Wilcox
2007-07-27 13:42 ` [PATCH 11/24] Add QUANTUM XP34301 to the blacklist Matthew Wilcox
2007-07-27 13:42 ` [PATCH 12/24] advansys: remove INQUIRY sniffing Matthew Wilcox
2007-07-27 13:42 ` [PATCH 13/24] advansys: misc reformatting Matthew Wilcox
2007-07-27 14:42 ` Jeff Garzik
2007-07-27 14:46 ` Matthew Wilcox
2007-07-27 14:53 ` Jeff Garzik
2007-07-27 13:42 ` [PATCH 14/24] advansys: delete AscGetChipBusType Matthew Wilcox
2007-07-27 13:42 ` [PATCH 15/24] advansys: ioremap no longer needs page-aligned addresses Matthew Wilcox
2007-07-27 14:45 ` Jeff Garzik
2007-07-27 13:42 ` [PATCH 16/24] advansys: Stop using n_io_port in Scsi_Host structure Matthew Wilcox
2007-07-27 13:42 ` [PATCH 17/24] advansys: Move struct device out of the cfg structures Matthew Wilcox
2007-07-27 13:42 ` [PATCH 18/24] advansys: Remove library-style callback routines Matthew Wilcox
2007-07-27 13:42 ` [PATCH 19/24] advansys: Remove pci_slot_info Matthew Wilcox
2007-07-27 13:42 ` [PATCH 20/24] advansys: use memcpy instead of open-coded loop Matthew Wilcox
2007-07-27 13:42 ` [PATCH 21/24] advansys: Delete some I/O address defines Matthew Wilcox
2007-07-27 13:42 ` [PATCH 22/24] advansys: Move documentation to Documentation/scsi Matthew Wilcox
2007-07-27 13:42 ` [PATCH 23/24] advansys: Improve interrupt handler Matthew Wilcox
2007-07-27 14:49 ` Jeff Garzik
2007-07-27 14:53 ` Matthew Wilcox
2007-07-27 14:57 ` Jeff Garzik
2007-07-27 15:04 ` Matthew Wilcox
2007-07-27 15:12 ` Jeff Garzik
2007-07-27 15:25 ` Matthew Wilcox
2007-07-27 15:53 ` Jeff Garzik
2007-07-27 17:36 ` Matthew Wilcox
2007-07-27 17:39 ` Jeff Garzik
2007-07-27 18:04 ` Matthew Wilcox
2007-07-27 19:36 ` Jeff Garzik
2007-07-27 19:46 ` Matthew Wilcox
2007-07-27 19:59 ` Jeff Garzik
2007-07-27 20:24 ` Matthew Wilcox
2007-07-27 13:42 ` [PATCH 24/24] advansys: Remove array of all known hosts Matthew Wilcox
2007-07-27 14:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070727144320.GH21219@parisc-linux.org \
--to=matthew@wil.cx \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.