Re: [PATCH 23/24] advansys: Improve interrupt handler

[Jeff Garzik <jeff@garzik.org>]

OK, I think I misunderstood your explanation.  Rather than judging based 
on English emails, I went back and looked at the old and new code.

Looking at the old code, there is a clear 1-to-1-to-1-to-1 
correspondence between adapter, request_irq() call, scsi_host, and 
boardp.  So what the old code is doing during probe is quite normal.

I thought you were saying there were multiple request_irq() calls for a 
single adapter.

The only thing that's abnormal is the interrupt handler checking 
multiple boards for events, which you rightly removed.

There is absolutely no need to add IRQF_SHARED to non-PCI devices or 
anything like that.

At this point, looking at your new code, I would only add
	"replace spin_lock_irqsave with spin_lock in interrupt handler"
and
	"delete no-ops DvcEnterCritical and DvcLeaveCritical"
to the todo list.

	Jeff