Re: [PATCH 13/24] advansys: misc reformatting

[Matthew Wilcox <matthew@wil.cx>]

On Fri, Jul 27, 2007 at 10:42:50AM -0400, Jeff Garzik wrote:
> Matthew Wilcox wrote:
> >Remove some useless forward declarations
> >Reformat some comments, debug messages, and the occasional piece of real 
> >code
> >Removal of unnecessary braces
> >Remove duplicate setting of shost->irq
> 
> dumb question:  why set shost->irq at all?

Because I haven't killed it off yet.  I intend to stop the driver using
all of:

        /* legacy crap */
        unsigned long base;
        unsigned long io_port;
        unsigned char n_io_port;
        unsigned char dma_channel;
        unsigned int  irq;

in Scsi_Host.  Perhaps we can let the dust settle on this round of
patches before doing more of these cleanups?

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."