Re: [PATCH 9/24] advansys: More PCI cleanups

[Matthew Wilcox <matthew@wil.cx>]

On Fri, Jul 27, 2007 at 10:41:38AM -0400, Jeff Garzik wrote:
> Matthew Wilcox wrote:
> >-	if (asc_dvc->bus_type == ASC_IS_PCI) {
> >-		PCIVendorID = AscReadPCIConfigWord(asc_dvc,
> >-						   
> >AscPCIConfigVendorIDRegister);
> > 
> >-		PCIDeviceID = AscReadPCIConfigWord(asc_dvc,
> >-						   
> >AscPCIConfigDeviceIDRegister);
> >-
> >-		PCIRevisionID = DvcReadPCIConfigByte(asc_dvc,
> >-						     
> >AscPCIConfigRevisionIDRegister);
> >-
> >-		if (PCIVendorID != PCI_VENDOR_ID_ASP) {
> >-			warn_code |= ASC_WARN_SET_PCI_CONFIG_SPACE;
> >-		}
> 
> 
> That last test/bit-set disappeared.  What does that code do, and why it 
> is safe to remove?

It reads PCI config space to see if the PCI Vendor ID is Advansys's.
Linux PCI drivers don't second-guess their subsystem like this.

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."