Re: [patch 2.6.22-git5 3/4] MMC core learns about SPI

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Thursday 02 August 2007, Pierre Ossman wrote:
> 
> > So, move the param and mmc_spi_set_crc() into core.c then, and
> > leave the calls where they are?
> > 
> 
> mmc_spi_set_crc() fits quite nicely into mmc_ops.c, so no need for
> moving that. I was thinking more along the lines of:
> 
> extern int mmc_spi_crc_enabled;
> 
> mmc_spi_set_crc(host, mmc_spi_crc_enabled);

OK.


> > Can we do that as a separate patch?  You said below we can proceed,
> > which suggests to me that now's the time to convert to incrmentals.
> > I don't mind a few more update patches, but it'd be easier to do
> > them against say a git-mmc patch against 2.6.23-rc2 ...
> > 
> 
> Sure.
> 



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/