regression with rmtab handling in newer nfs-utils code

regression with rmtab handling in newer nfs-utils code

[Jeff Layton]

I just noticed that there seems to have been a regression with how the
rmtab is handled in the latest nfs-utils code. It seems to have gone
back to adding extra lines to the rmtab that contain the comma-delimited
domain string.

At first glance, it looks like the extra mountlist_add calls that went
in with the patch below are the culprit (though this code seems to have
changed a few times since then). I don't think there's any need to
have cache_export_ent or nfsd_fh call mountlist_add.

Can these calls just be removed, or am I missing something?

commit dbfcba5b03481d49f3e78946fe8fd066e2025545
Author: Kevin Coffman <kwc@citi.umich.edu>
Date:   Thu Feb 8 17:27:45 2007 -0500

    Remove duplicated code.
    
    Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
    Signed-off-by: Kevin Coffman <kwc@citi.umich.edu>
    
    Remove duplicated code.
    Signed-off-by: Neil Brown <neilb@suse.de>

-- 
Jeff Layton <jlayton@redhat.com>

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: regression with rmtab handling in newer nfs-utils code

[Kevin Coffman]

On 8/6/07, Jeff Layton <jlayton@redhat.com> wrote:
> I just noticed that there seems to have been a regression with how the
> rmtab is handled in the latest nfs-utils code. It seems to have gone
> back to adding extra lines to the rmtab that contain the comma-delimited
> domain string.
>
> At first glance, it looks like the extra mountlist_add calls that went
> in with the patch below are the culprit (though this code seems to have
> changed a few times since then). I don't think there's any need to
> have cache_export_ent or nfsd_fh call mountlist_add.
>
> Can these calls just be removed, or am I missing something?
>
> commit dbfcba5b03481d49f3e78946fe8fd066e2025545
> Author: Kevin Coffman <kwc@citi.umich.edu>
> Date:   Thu Feb 8 17:27:45 2007 -0500
>
>     Remove duplicated code.
>
>     Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
>     Signed-off-by: Kevin Coffman <kwc@citi.umich.edu>
>
>     Remove duplicated code.
>     Signed-off-by: Neil Brown <neilb@suse.de>
>

Sorry.  I assume this is my fault while "fixing" conflicts before
submitting these patches to Neil.

K.C.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

[PATCH] fix regression with rmtab handling in newer nfs-utils code

[Jeff Layton]

On Mon, 6 Aug 2007 18:01:27 -0400
"Kevin Coffman" <kwc@citi.umich.edu> wrote:

> On 8/6/07, Jeff Layton <jlayton@redhat.com> wrote:
> > I just noticed that there seems to have been a regression with how the
> > rmtab is handled in the latest nfs-utils code. It seems to have gone
> > back to adding extra lines to the rmtab that contain the comma-delimited
> > domain string.
> >
> > At first glance, it looks like the extra mountlist_add calls that went
> > in with the patch below are the culprit (though this code seems to have
> > changed a few times since then). I don't think there's any need to
> > have cache_export_ent or nfsd_fh call mountlist_add.
> >
> > Can these calls just be removed, or am I missing something?
> >
> > commit dbfcba5b03481d49f3e78946fe8fd066e2025545
> > Author: Kevin Coffman <kwc@citi.umich.edu>
> > Date:   Thu Feb 8 17:27:45 2007 -0500
> >
> >     Remove duplicated code.
> >
> >     Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
> >     Signed-off-by: Kevin Coffman <kwc@citi.umich.edu>
> >
> >     Remove duplicated code.
> >     Signed-off-by: Neil Brown <neilb@suse.de>
> >
> 
> Sorry.  I assume this is my fault while "fixing" conflicts before
> submitting these patches to Neil.
> 
> K.C.

No problem. I just wanted to make sure I wasn't missing something. I
think this patch against the current git tree should fix it:

Signed-off-by: Jeff Layton <jlayton@redhat.com>

diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index b686318..15100d4 100644
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -649,8 +649,7 @@ void nfsd_export(FILE *f)
 			     "Cannot export %s, possibly unsupported filesystem"
 			     " or fsid= required", path);
 			dump_to_cache(f, dom, path, NULL);
-		} else
-			mountlist_add(dom, path);
+		}
 	} else {
 		dump_to_cache(f, dom, path, NULL);
 	}
@@ -729,7 +728,6 @@ int cache_export_ent(char *domain, struct exportent *exp, char *path)
 		     "Cannot export %s, possibly unsupported filesystem or"
 		     " fsid= required", exp->e_path);
 	}
-	mountlist_add(domain, exp->e_path);
 
 	while (err == 0 && (exp->e_flags & NFSEXP_CROSSMOUNT) && path) {
 		/* really an 'if', but we can break out of

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: [PATCH] fix regression with rmtab handling in newer nfs-utils code

[Neil Brown]

On Monday August 6, jlayton@redhat.com wrote:
> 
> No problem. I just wanted to make sure I wasn't missing something. I
> think this patch against the current git tree should fix it:

Thanks.  Applied.

NeilBrown

> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> 
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index b686318..15100d4 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -649,8 +649,7 @@ void nfsd_export(FILE *f)
>  			     "Cannot export %s, possibly unsupported filesystem"
>  			     " or fsid= required", path);
>  			dump_to_cache(f, dom, path, NULL);
> -		} else
> -			mountlist_add(dom, path);
> +		}
>  	} else {
>  		dump_to_cache(f, dom, path, NULL);
>  	}
> @@ -729,7 +728,6 @@ int cache_export_ent(char *domain, struct exportent *exp, char *path)
>  		     "Cannot export %s, possibly unsupported filesystem or"
>  		     " fsid= required", exp->e_path);
>  	}
> -	mountlist_add(domain, exp->e_path);
>  
>  	while (err == 0 && (exp->e_flags & NFSEXP_CROSSMOUNT) && path) {
>  		/* really an 'if', but we can break out of

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs