From: Christoph Lameter <clameter@sgi.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org
Cc: dkegel@google.com
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: David Miller <davem@davemloft.net>
Cc: Nick Piggin <npiggin@suse.de>
Subject: [RFC 3/9] Make cond_rescheds conditional on __GFP_WAIT
Date: Tue, 14 Aug 2007 08:30:24 -0700 [thread overview]
Message-ID: <20070814153501.545101191@sgi.com> (raw)
In-Reply-To: 20070814153021.446917377@sgi.com
[-- Attachment #1: vmscan_reclaim_resched --]
[-- Type: text/plain, Size: 1594 bytes --]
We cannot reschedule if we are in atomic reclaim. So make
the calls to cond_resched depending on the __GFP_WAIT flag.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
---
mm/vmscan.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
Index: linux-2.6/mm/vmscan.c
===================================================================
--- linux-2.6.orig/mm/vmscan.c 2007-08-14 07:34:18.000000000 -0700
+++ linux-2.6/mm/vmscan.c 2007-08-14 07:34:25.000000000 -0700
@@ -258,6 +258,15 @@ static int may_write_to_queue(struct bac
}
/*
+ * Reschedule if we are not in atomic mode
+ */
+static void reclaim_resched(struct scan_control *sc)
+{
+ if (sc->gfp_mask & __GFP_WAIT)
+ cond_resched();
+}
+
+/*
* We detected a synchronous write error writing a page out. Probably
* -ENOSPC. We need to propagate that into the address_space for a subsequent
* fsync(), msync() or close().
@@ -437,7 +446,7 @@ static unsigned long shrink_page_list(st
int pgactivate = 0;
unsigned long nr_reclaimed = 0;
- cond_resched();
+ reclaim_resched(sc);
pagevec_init(&freed_pvec, 1);
while (!list_empty(page_list)) {
@@ -446,7 +455,7 @@ static unsigned long shrink_page_list(st
int may_enter_fs;
int referenced;
- cond_resched();
+ reclaim_resched(sc);
page = lru_to_page(page_list);
list_del(&page->lru);
@@ -938,7 +947,7 @@ force_reclaim_mapped:
spin_unlock_irq(&zone->lru_lock);
while (!list_empty(&l_hold)) {
- cond_resched();
+ reclaim_resched(sc);
page = lru_to_page(&l_hold);
list_del(&page->lru);
if (page_mapped(page)) {
--
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <clameter@sgi.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
dkegel@google.com, Peter Zijlstra <a.p.zijlstra@chello.nl>,
David Miller <davem@davemloft.net>, Nick Piggin <npiggin@suse.de>
Subject: [RFC 3/9] Make cond_rescheds conditional on __GFP_WAIT
Date: Tue, 14 Aug 2007 08:30:24 -0700 [thread overview]
Message-ID: <20070814153501.545101191@sgi.com> (raw)
In-Reply-To: 20070814153021.446917377@sgi.com
[-- Attachment #1: vmscan_reclaim_resched --]
[-- Type: text/plain, Size: 1820 bytes --]
We cannot reschedule if we are in atomic reclaim. So make
the calls to cond_resched depending on the __GFP_WAIT flag.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
---
mm/vmscan.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
Index: linux-2.6/mm/vmscan.c
===================================================================
--- linux-2.6.orig/mm/vmscan.c 2007-08-14 07:34:18.000000000 -0700
+++ linux-2.6/mm/vmscan.c 2007-08-14 07:34:25.000000000 -0700
@@ -258,6 +258,15 @@ static int may_write_to_queue(struct bac
}
/*
+ * Reschedule if we are not in atomic mode
+ */
+static void reclaim_resched(struct scan_control *sc)
+{
+ if (sc->gfp_mask & __GFP_WAIT)
+ cond_resched();
+}
+
+/*
* We detected a synchronous write error writing a page out. Probably
* -ENOSPC. We need to propagate that into the address_space for a subsequent
* fsync(), msync() or close().
@@ -437,7 +446,7 @@ static unsigned long shrink_page_list(st
int pgactivate = 0;
unsigned long nr_reclaimed = 0;
- cond_resched();
+ reclaim_resched(sc);
pagevec_init(&freed_pvec, 1);
while (!list_empty(page_list)) {
@@ -446,7 +455,7 @@ static unsigned long shrink_page_list(st
int may_enter_fs;
int referenced;
- cond_resched();
+ reclaim_resched(sc);
page = lru_to_page(page_list);
list_del(&page->lru);
@@ -938,7 +947,7 @@ force_reclaim_mapped:
spin_unlock_irq(&zone->lru_lock);
while (!list_empty(&l_hold)) {
- cond_resched();
+ reclaim_resched(sc);
page = lru_to_page(&l_hold);
list_del(&page->lru);
if (page_mapped(page)) {
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-14 15:38 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 15:30 [RFC 0/9] Reclaim during GFP_ATOMIC allocs Christoph Lameter
2007-08-14 15:30 ` Christoph Lameter
2007-08-14 15:30 ` [RFC 1/9] Allow reclaim via __GFP_NOMEMALLOC reclaim Christoph Lameter
2007-08-14 15:30 ` Christoph Lameter
2007-08-14 15:30 ` [RFC 2/9] Use NOMEMALLOC reclaim to allow reclaim if PF_MEMALLOC is set Christoph Lameter
2007-08-14 15:30 ` Christoph Lameter
2007-08-18 7:10 ` Pavel Machek
2007-08-18 7:10 ` Pavel Machek
2007-08-20 19:00 ` Christoph Lameter
2007-08-20 19:00 ` Christoph Lameter
2007-08-20 20:17 ` Peter Zijlstra
2007-08-20 20:17 ` Peter Zijlstra
2007-08-20 20:27 ` Christoph Lameter
2007-08-20 20:27 ` Christoph Lameter
2007-08-20 21:14 ` Peter Zijlstra
2007-08-20 21:14 ` Peter Zijlstra
2007-08-20 21:17 ` Christoph Lameter
2007-08-20 21:17 ` Christoph Lameter
2007-08-21 14:07 ` Peter Zijlstra
2007-08-21 0:39 ` Nick Piggin
2007-08-21 0:39 ` Nick Piggin
2007-08-21 14:07 ` Peter Zijlstra
2007-08-23 3:38 ` Nick Piggin
2007-08-23 3:38 ` Nick Piggin
2007-08-23 9:26 ` Peter Zijlstra
2007-08-23 10:11 ` Nikita Danilov
2007-08-23 10:11 ` Nikita Danilov
2007-08-23 13:58 ` Peter Zijlstra
2007-08-24 4:00 ` Nick Piggin
2007-08-24 4:00 ` Nick Piggin
2007-08-14 15:30 ` Christoph Lameter [this message]
2007-08-14 15:30 ` [RFC 3/9] Make cond_rescheds conditional on __GFP_WAIT Christoph Lameter
2007-08-14 15:30 ` [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c Christoph Lameter
2007-08-14 15:30 ` Christoph Lameter
2007-08-14 20:02 ` Andi Kleen
2007-08-14 20:02 ` Andi Kleen
2007-08-14 19:12 ` Christoph Lameter
2007-08-14 19:12 ` Christoph Lameter
2007-08-14 20:05 ` Peter Zijlstra
2007-08-14 20:05 ` Peter Zijlstra
2007-08-14 20:34 ` Andi Kleen
2007-08-14 20:34 ` Andi Kleen
2007-08-14 20:33 ` Andi Kleen
2007-08-14 20:33 ` Andi Kleen
2007-08-14 20:42 ` Christoph Lameter
2007-08-14 20:42 ` Christoph Lameter
2007-08-14 20:44 ` Andi Kleen
2007-08-14 20:44 ` Andi Kleen
2007-08-14 21:15 ` Christoph Lameter
2007-08-14 21:15 ` Christoph Lameter
2007-08-14 21:23 ` Andi Kleen
2007-08-14 21:23 ` Andi Kleen
2007-08-14 21:26 ` Christoph Lameter
2007-08-14 21:26 ` Christoph Lameter
2007-08-14 21:29 ` Andi Kleen
2007-08-14 21:29 ` Andi Kleen
2007-08-14 21:37 ` Christoph Lameter
2007-08-14 21:37 ` Christoph Lameter
2007-08-14 21:44 ` Andi Kleen
2007-08-14 21:44 ` Andi Kleen
2007-08-14 21:48 ` Christoph Lameter
2007-08-14 21:48 ` Christoph Lameter
2007-08-14 21:56 ` Andi Kleen
2007-08-14 21:56 ` Andi Kleen
2007-08-14 22:07 ` Christoph Lameter
2007-08-14 22:07 ` Christoph Lameter
2007-08-14 22:16 ` Andi Kleen
2007-08-14 22:16 ` Andi Kleen
2007-08-14 22:20 ` Christoph Lameter
2007-08-14 22:20 ` Christoph Lameter
2007-08-14 22:21 ` Andi Kleen
2007-08-14 22:21 ` Andi Kleen
2007-08-14 22:41 ` Christoph Lameter
2007-08-14 22:41 ` Christoph Lameter
2007-08-14 15:30 ` [RFC 5/9] Save irqflags on taking the mapping lock Christoph Lameter
2007-08-14 15:30 ` Christoph Lameter
2007-08-14 15:30 ` [RFC 6/9] Disable irqs on taking the private_lock Christoph Lameter
2007-08-14 15:30 ` Christoph Lameter
2007-08-14 15:30 ` [RFC 7/9] Save flags in swap.c Christoph Lameter
2007-08-14 15:30 ` Christoph Lameter
2007-08-14 15:30 ` [RFC 8/9] Reclaim on an atomic allocation if necessary Christoph Lameter
2007-08-14 15:30 ` Christoph Lameter
2007-08-14 15:30 ` [RFC 9/9] Testing: Perform GFP_ATOMIC overallocation Christoph Lameter
2007-08-14 15:30 ` Christoph Lameter
2007-08-16 2:49 ` [RFC 0/9] Reclaim during GFP_ATOMIC allocs Nick Piggin
2007-08-16 2:49 ` Nick Piggin
2007-08-16 20:24 ` Christoph Lameter
2007-08-16 20:24 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070814153501.545101191@sgi.com \
--to=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.