All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
Date: Wed, 15 Aug 2007 00:16:16 +0200	[thread overview]
Message-ID: <20070814221616.GG23308@one.firstfloor.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0708141504350.32420@schroedinger.engr.sgi.com>

On Tue, Aug 14, 2007 at 03:07:10PM -0700, Christoph Lameter wrote:
> There are more spinlocks needed. So we would just check the whole bunch 
> and fail if any of them are used?

Yes zone_flag would apply to all of them.

> 
> > 		do things with zone locks 
> > 	}
> > 
> > The interrupt handler shouldn't touch zone_flag. If it wants
> > to it would need to be converted to a local_t and incremented/decremented
> > (should be about the same cost at least on architectures with sane
> > local_t implementation) 
> 
> That would mean we need to fork the code for reclaim?

Not with the local_t increment.

-Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
Date: Wed, 15 Aug 2007 00:16:16 +0200	[thread overview]
Message-ID: <20070814221616.GG23308@one.firstfloor.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0708141504350.32420@schroedinger.engr.sgi.com>

On Tue, Aug 14, 2007 at 03:07:10PM -0700, Christoph Lameter wrote:
> There are more spinlocks needed. So we would just check the whole bunch 
> and fail if any of them are used?

Yes zone_flag would apply to all of them.

> 
> > 		do things with zone locks 
> > 	}
> > 
> > The interrupt handler shouldn't touch zone_flag. If it wants
> > to it would need to be converted to a local_t and incremented/decremented
> > (should be about the same cost at least on architectures with sane
> > local_t implementation) 
> 
> That would mean we need to fork the code for reclaim?

Not with the local_t increment.

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-08-14 22:22 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-14 15:30 [RFC 0/9] Reclaim during GFP_ATOMIC allocs Christoph Lameter
2007-08-14 15:30 ` Christoph Lameter
2007-08-14 15:30 ` [RFC 1/9] Allow reclaim via __GFP_NOMEMALLOC reclaim Christoph Lameter
2007-08-14 15:30   ` Christoph Lameter
2007-08-14 15:30 ` [RFC 2/9] Use NOMEMALLOC reclaim to allow reclaim if PF_MEMALLOC is set Christoph Lameter
2007-08-14 15:30   ` Christoph Lameter
2007-08-18  7:10   ` Pavel Machek
2007-08-18  7:10     ` Pavel Machek
2007-08-20 19:00     ` Christoph Lameter
2007-08-20 19:00       ` Christoph Lameter
2007-08-20 20:17       ` Peter Zijlstra
2007-08-20 20:17         ` Peter Zijlstra
2007-08-20 20:27         ` Christoph Lameter
2007-08-20 20:27           ` Christoph Lameter
2007-08-20 21:14           ` Peter Zijlstra
2007-08-20 21:14             ` Peter Zijlstra
2007-08-20 21:17             ` Christoph Lameter
2007-08-20 21:17               ` Christoph Lameter
2007-08-21 14:07               ` Peter Zijlstra
2007-08-21  0:39             ` Nick Piggin
2007-08-21  0:39               ` Nick Piggin
2007-08-21 14:07               ` Peter Zijlstra
2007-08-23  3:38                 ` Nick Piggin
2007-08-23  3:38                   ` Nick Piggin
2007-08-23  9:26                   ` Peter Zijlstra
2007-08-23 10:11                     ` Nikita Danilov
2007-08-23 10:11                       ` Nikita Danilov
2007-08-23 13:58                       ` Peter Zijlstra
2007-08-24  4:00                     ` Nick Piggin
2007-08-24  4:00                       ` Nick Piggin
2007-08-14 15:30 ` [RFC 3/9] Make cond_rescheds conditional on __GFP_WAIT Christoph Lameter
2007-08-14 15:30   ` Christoph Lameter
2007-08-14 15:30 ` [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c Christoph Lameter
2007-08-14 15:30   ` Christoph Lameter
2007-08-14 20:02   ` Andi Kleen
2007-08-14 20:02     ` Andi Kleen
2007-08-14 19:12     ` Christoph Lameter
2007-08-14 19:12       ` Christoph Lameter
2007-08-14 20:05       ` Peter Zijlstra
2007-08-14 20:05         ` Peter Zijlstra
2007-08-14 20:34         ` Andi Kleen
2007-08-14 20:34           ` Andi Kleen
2007-08-14 20:33       ` Andi Kleen
2007-08-14 20:33         ` Andi Kleen
2007-08-14 20:42         ` Christoph Lameter
2007-08-14 20:42           ` Christoph Lameter
2007-08-14 20:44           ` Andi Kleen
2007-08-14 20:44             ` Andi Kleen
2007-08-14 21:15             ` Christoph Lameter
2007-08-14 21:15               ` Christoph Lameter
2007-08-14 21:23               ` Andi Kleen
2007-08-14 21:23                 ` Andi Kleen
2007-08-14 21:26                 ` Christoph Lameter
2007-08-14 21:26                   ` Christoph Lameter
2007-08-14 21:29                   ` Andi Kleen
2007-08-14 21:29                     ` Andi Kleen
2007-08-14 21:37                     ` Christoph Lameter
2007-08-14 21:37                       ` Christoph Lameter
2007-08-14 21:44                       ` Andi Kleen
2007-08-14 21:44                         ` Andi Kleen
2007-08-14 21:48                         ` Christoph Lameter
2007-08-14 21:48                           ` Christoph Lameter
2007-08-14 21:56                           ` Andi Kleen
2007-08-14 21:56                             ` Andi Kleen
2007-08-14 22:07                             ` Christoph Lameter
2007-08-14 22:07                               ` Christoph Lameter
2007-08-14 22:16                               ` Andi Kleen [this message]
2007-08-14 22:16                                 ` Andi Kleen
2007-08-14 22:20                                 ` Christoph Lameter
2007-08-14 22:20                                   ` Christoph Lameter
2007-08-14 22:21                                   ` Andi Kleen
2007-08-14 22:21                                     ` Andi Kleen
2007-08-14 22:41                                     ` Christoph Lameter
2007-08-14 22:41                                       ` Christoph Lameter
2007-08-14 15:30 ` [RFC 5/9] Save irqflags on taking the mapping lock Christoph Lameter
2007-08-14 15:30   ` Christoph Lameter
2007-08-14 15:30 ` [RFC 6/9] Disable irqs on taking the private_lock Christoph Lameter
2007-08-14 15:30   ` Christoph Lameter
2007-08-14 15:30 ` [RFC 7/9] Save flags in swap.c Christoph Lameter
2007-08-14 15:30   ` Christoph Lameter
2007-08-14 15:30 ` [RFC 8/9] Reclaim on an atomic allocation if necessary Christoph Lameter
2007-08-14 15:30   ` Christoph Lameter
2007-08-14 15:30 ` [RFC 9/9] Testing: Perform GFP_ATOMIC overallocation Christoph Lameter
2007-08-14 15:30   ` Christoph Lameter
2007-08-16  2:49 ` [RFC 0/9] Reclaim during GFP_ATOMIC allocs Nick Piggin
2007-08-16  2:49   ` Nick Piggin
2007-08-16 20:24   ` Christoph Lameter
2007-08-16 20:24     ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070814221616.GG23308@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.