2.6.23-rc4-mm1

2.6.23-rc4-mm1

[Andrew Morton]

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/

- git-kbuild is broken and has been dropped

- git-ixgb is broken by git-net and has been dropped

- git-md-accel is broken by MD fixes and has been dropped

- git-v9fs breaks the build on all non-x86 and the fs has been disabled in
  config

- dynticks-for-x86_64 has returned



Changes since 2.6.23-rc3-mm1:


 origin.patch
 git-acpi.patch
 git-alsa.patch
 git-audit-master.patch
 git-avr32.patch
 git-cifs.patch
 git-cpufreq.patch
 git-powerpc.patch
 git-dvb.patch
 git-hwmon.patch
 git-gfs2-nmw.patch
 git-hid.patch
 git-ia64.patch
 git-ieee1394.patch
 git-infiniband.patch
 git-input.patch
 git-jfs.patch
 git-jg-misc.patch
 git-kvm.patch
 git-libata-all.patch
 git-m32r.patch
 git-mips.patch
 git-mmc.patch
 git-mtd.patch
 git-ubi.patch
 git-netdev-all.patch
 git-net.patch
 git-backlight.patch
 git-nfs.patch
 git-nfsd.patch
 git-ocfs2.patch
 git-r8169.patch
 git-selinux.patch
 git-s390.patch
 git-sched.patch
 git-sh.patch
 git-scsi-misc.patch
 git-scsi-rc-fixes.patch
 git-block.patch
 git-unionfs.patch
 git-v9fs.patch
 git-watchdog.patch
 git-wireless.patch
 git-ipwireless_cs.patch
 git-newsetup.patch
 git-xfs.patch
 git-cryptodev.patch
 git-xtensa.patch
 git-kgdb.patch

 git trees

-ecryptfs-fix-lookup-error-for-special-files.patch
-sparsemem-ensure-we-initialise-the-node-mapping-for-sparsemem_static.patch
-tpmdd-maintainers.patch
-kernel-auditscc-fix-an-off-by-one.patch
-document-linux-memory-policy-v3.patch
-futex_unlock_pi-hurts-my-brain-and-may-cause.patch
-dont-optimise-away-baud-rate-changes-when-bother-is-used.patch
-serial-add-support-for-ite-887x-chips.patch
-serial_txx9-fix-modem-control-line-handling.patch
-serial-8250-handle-saving-the-clear-on-read-bits-from-the-lsr.patch
-add-blacklisting-capability-to-serial_pci-to-avoid-misdetection.patch
-free_irq-fix-debug_shirq-handling.patch
-documentation-fix-getdelaysc-example-l-option-and-segv.patch
-h8300-missing-include.patch
-ensure-we-count-pages-transitioning-inactive-via-clear_active_flags.patch
-wait-for-page-writeback-when-directly-reclaiming-contiguous-areas.patch
-wait-for-page-writeback-when-directly-reclaiming-contiguous-areas-fix.patch
-correct-name-for-rtc-m41t80.patch
-fix-null-pointer-dereference-in-__vm_enough_memory.patch
-m68k-asm-pageh-needs-linux-compilerh.patch
-m68k-kill-superfluous-extern.patch
-m68k-remove-unnecessary-m68k_memoffset-export-and-init.patch
-remove-dead-code-in-via-pmu68k.patch
-m68k-use-_ac-instead-of-ifdef-__assembly__.patch
-m68k-enable-arbitary-speed-tty-support.patch
-m68k-dont-include-rodata-into-text-segment.patch
-m68k-fix-a-few-hickups-in-drivers-scsi-kconfig.patch
-zorro-make-sysfs-config-attribute-read-only.patch
-m68k-mac-make-mac_hid_mouse_emulate_buttons-declaration-visible.patch
-introduce-config_check_signature-was-re-uninline.patch
-posix-timers-fix-deletion-race.patch
-posix-timers-fix-creation-race.patch
-signalfd-fix-interaction-with-posix-timers.patch
-signalfd-make-it-group-wide-fix-posix-timers-scheduling.patch
-ipmi-fix-warning-in-ipmi_si_intfc.patch
-slab-skip-calling-cache_free_alien-when-the-platform-is-not-numa-capable.patch
-synclink_gt-fix-module-reference.patch
-fix-vm_fault-flags-conversion-for-hugetlb.patch
-w1-fix-w1_remove_master_device-searching.patch
-md-make-sure-a-re-add-after-a-restart-honours-bitmap-when-resyncing.patch
-md-correctly-update-sysfs-when-a-raid1-is-reshaped.patch
-uml-fix-previous-request-size-limit-fix.patch
-autofs4-deadlock-during-create.patch
-serial-add-pci-ids-for-pa-semi-pwrficient-onchip-uarts.patch
-cfag12864b-fix.patch
-slub-use-atomic_long_read-for-atomic_long-variables.patch
-slub-do-not-fail-on-broken-memory-configurations.patch
-rtc-max6902-minor-fixes.patch
-exec-kill-unsafe-bug_onsig-count-checks.patch
-xen-i386-xen-heads-fix-sections-mixup-update-2.patch
-check-for-ppc32-in-imsttfb.patch
-selectionh-add-tty_struct-forward-declaration.patch
-newport_con-warning-fix.patch
-i386-fix-lazy-mode-vmalloc-synchronization-for-paravirt.patch
-get_nodes-should-ignore-invalid-node.patch
-fix-ensure-we-dont-use-bootconsoles-after-init-has-been-released.patch
-au1100fb-move-au1100fb_fb_blank-beforce.patch
-pm-fix-dependencies-of-config_suspend-and-config_hibernation-updated-3x.patch
-remove-bdput-from-do_open-in-fs-block_devc.patch
-remove-bdput-from-do_open-in-fs-block_devc-fix.patch
-apply-memory-policies-to-top-two-highest-zones-when-highest-zone-is-zone_movable.patch
-enable-gpes-before-calling-_wak-on-resume.patch
-acpi-fix-a-warning-of-discarding-qualifiers-from-pointer-target-type.patch
-agk-dm-dm-rdac-fix-request-cmd_flags.patch
-gregkh-driver-sysfs-fix-locking-in-sysfs_lookup-and-sysfs_rename_dir.patch
-gregkh-driver-fix-off-by-one-in-sys-module-refcnt.patch
-gregkh-driver-howto-korean-translation-of-documentation-howto.patch
-gregkh-driver-howto-latest-lxr-url-address-changed.patch
-fix-gregkh-driver-driver-core-change-add_uevent_var-to-use-a-struct.patch
-fix-2-gregkh-driver-driver-core-change-add_uevent_var-to-use-a-struct.patch
-fix-3-gregkh-driver-driver-core-change-add_uevent_var-to-use-a-struct.patch
-fix-4-gregkh-driver-driver-core-change-add_uevent_var-to-use-a-struct.patch
-disable-ioat.patch
-jdelvare-i2c-i2c-piix4-fix-ati-pci-ids.patch
-sn-add-support-for-cpu-disable.patch
-clean-up-duplicate-includes-in-drivers-input.patch
-iforce-warning-fix.patch
-drivers-input-serio-gscps2c-kmalloc-memset-conversion-to-kzalloc.patch
-clean-modulessymvers-in-external-module-dirs.patch
-scripts-ver_linux-correct-printing-of-binutils-version.patch
-improve-scripts-gcc-versionsh-output-a-bit-when-called-without-args.patch
-ide-hpt366-fix-pci-clock-detection-for-hpt374.patch
-ide-hpt366-ultradma-filtering-for-sata-cards.patch
-mips-detect-bcm947xx-cpus.patch
-mips-bcm947xx-support.patch
-rfc-add-bcm947xx-to-kconfig.patch
-mips-add-bcm947xx-to-makefile.patch
-mips-irix_getcontext-will-always-fail-efault.patch
-drivers-mmc-core-busc-kmalloc-memset-conversion-to-kzalloc.patch
-drivers-mmc-core-hostc-kmalloc-memset-conversion-to-kzalloc.patch
-drivers-mmc-core-mmc_opsc-kmalloc-memset-conversion-to-kzalloc.patch
-git-mtd-fix-printk-warning-in-jffs2_block_check_erase.patch
-mtdoops-printk-warning-fixes.patch
-pci-x-pci-express-read-control-interfaces-myrinet.patch
-dont-use-gfp_dma-for-zone-allocation.patch
-dm9000-fix-interface-hang-under-load.patch
-gregkh-pci-pci-move-prototypes-for-pci_bus_find_capability-to-include-linux-pcih.patch
-gregkh-pci-pci-quirk_e100_interrupt-called-too-early.patch
-gregkh-pci-pci-document-pci_iomap.patch
-gregkh-pci-pci-hotplug-cpqphp_ctrlc-remove-stale-bkl-use.patch
-gregkh-pci-pci-lets-kill-the-pci-hidden-behind-bridge-message.patch
-gregkh-pci-pci-make-pcie_get_readrq-visible-in-pcih.patch
-gregkh-pci-pci-unhide-smbus-on-compaq-deskpro-ep-401963-001-motherboard-with-i810-chipset.patch
-pci-disable-decode-of-io-memory-during-bar-sizing.patch
-i386-add-support-for-picopower-irq-router.patch
-acpiphp_ibm-add-missing-n.patch
-sched-fix-broken-smt-mc-optimizations-with-cfs.patch
-sched-skip-updating-rqs-next_balance-under-null-sd.patch
-gregkh-usb-usb-cdc-acm-fix-sysfs-attribute-registration-bug.patch
-gregkh-usb-usb-visor-add-acer-s10-palm-device-id.patch
-gregkh-usb-usb-serial-garmin_gps-fixes-package-loss-if-used-from-gpsbabel.patch
-gregkh-usb-usb-stall-control-endpoint-when-file-storage-class-request-wvalue-0.patch
-gregkh-usb-usb-typo-usb_safe_padded-usb_serial_safe_padded.patch
-gregkh-usb-usb-u132-hcdc-fix-a-warning-when-config_pm-n.patch
-gregkh-usb-usb-fix-support-for-dell-wireless-broadband.patch
-gregkh-usb-usb-enable-hcd-support-on-sh-unconditionally.patch
-gregkh-usb-usb-r8a66597-hcd-fix-up-error-path.patch
-gregkh-usb-usb-quirks-multicard-reader-doesn-t-like-autosuspend.patch
-gregkh-usb-usb-support-for-the-evolution-scorpion-robots.patch
-gregkh-usb-usb-belkin_sa-avoid-divide-by-zero-error.patch
-gregkh-usb-usb-remove-debug-definition-from-dummy_hcd.patch
-gregkh-usb-usb-serial-fix-oti6858c-segfault-in-termios-handling.patch
-gregkh-usb-usb-blacklist-samsung-ml-2010-printer.patch
-gregkh-usb-usb-accept-1-byte-device-status-replies-fixing-some-b0rken-devices.patch
-gregkh-usb-usb-typo-in-usb-r8a66597-hcd-config.patch
-ohci-fix-oddball-gcc-warning.patch
-net-add-ath5k-wireless-driver.patch
-ath5k-printk-fix.patch
-ath5k-kconfig-fix.patch
-ath5k-needs-pci.patch
-x86_64-mm-install-unstripped-copies-on-disk.patch
-x86_64-mm-x86_64-ia32-vdso-install-unstripped-copies-on-disk.patch
-x86_64-mm-x86_64-vdso-install-unstripped-copies-on-disk.patch
-x86_64-mm-validate-against-acpi-motherboard-resources.patch
-x86_64-hpet-restore-vread.patch
-x86_64-restore-restore-nohpet-cmdline.patch
-x86_64-prep-idle-loop-for-dynticks.patch
-x86_64-enable-high-resolution-timers-and-dynticks.patch
-xtensa-enable-arbitary-tty-speed-setting-ioctls.patch
-xtensa-consolec-remove-duplicate-include.patch
-pci-align-bar-settings-for-legacy-mode-ide.patch
-accounting-regression-since-rc1.patch
-sysfs-dont-warn-on-removal-of-a-nonexistent-binary-file.patch
-usb-storage-fix-bugs-in-the-disconnect-pathway.patch
-g_file_storage-fix-bug-in-dma-buffer-handling.patch
-i386-pci_get_device-called-from-interrupt-in-reboot-fixups.patch
-pnp-fix-up-after-lindent.patch
-pnpacpi-simplify-irq_flags.patch
-pnpacpi-remove-unnecessary-casts-of-void.patch
-isapnp-removed-unused-isapnp_detected-and-isapnp_debug.patch
-pnp-remove-module-infrastructure.patch
-pnp-remove-null-pointer-checks.patch

 Merged into mainline or a subsystem tree

-check-for-pageslab-in-arch-flush_dcache_page-to-avoid-triggering-vm_bug_on.patch

 Dropped

+quote-fix-infinite-loop.patch
+spi_mpc83xx-hang-fix.patch
+drivers-edac-fix-printk-level-down-to-debug-from-emerg.patch
+drivers-edac-fix-e752x-correct-return-code.patch
+bcm1480-serial-build-fix.patch
+pnp-remove-smcf010-quirk.patch
+update-gitignore.patch
+md-fix-some-bugs-with-growing-raid5-raid6-arrays.patch
+mntput-called-before-dput-in-afs.patch
+fix-dac960-driver-on-machines-which-dont-support-64-bit-dma.patch
+documentation-00-index-notice-ecryptfstxt-moved.patch
+x86_64-add-parenthesis-to-irq-vector-macros.patch
+h8-300-fix-misnamed-config_blkdev_reserve_address-kconfig-variable.patch

 2.6.23 queue

+acpi-clean-up-acpi_enter_sleep_state_prep.patch

 ACP fix

+alsa-cs5535audio-correctly-set-dma-substream.patch
+alsa-cs5535audio-fix-prd-register-save-restore-power-management-race.patch
+alsa-cs5535audio-update-pci-device-handling-in-suspend-resume.patch
+alsa-cs5535audio-fix-acc_bm_cmd-register-handling.patch
+alsa-cs5535audio-drop-unused-bus-master-stuff.patch

 alsa stuff

+arm-extern-inline-static-inline.patch
+arm-cleanup-struct-irqaction-initializers.patch
+documentation-arm-00-index-add-missing-entries.patch

 ARM

+cpufreq-mark-hotplug-notifier-callback-as-__cpuinit.patch
+cpufreq-implement-config_cpu_freq-stub-for.patch
+cpufreq_stats-misc-cpuinit-section-annotations.patch

 cpufreq

+git-powerpc-fixup.patch
+ppc-remove-apus-support.patch

 powerpc

+gregkh-driver-platform-prefix-modalias-with-platform.patch
+gregkh-driver-sysdev-remove-global-sysdev-drivers-list.patch
+gregkh-driver-sysfs-fix-i_mutex-locking-in-sysfs_get_dentry.patch
+gregkh-driver-sysfs-move-all-of-inode-initialization-into-sysfs_init_inode.patch
+gregkh-driver-sysfs-remove-sysfs_instantiate.patch
+gregkh-driver-sysfs-use-kill_anon_super.patch
+gregkh-driver-sysfs-make-sysfs_mount-static.patch
+gregkh-driver-sysfs-in-sysfs_lookup-don-t-open-code-sysfs_find_dirent.patch
+gregkh-driver-sysfs-simplify-readdir.patch
+gregkh-driver-sysfs-rewrite-sysfs_drop_dentry.patch
+gregkh-driver-sysfs-introduce-sysfs_rename_mutex.patch
+gregkh-driver-sysfs-simply-sysfs_get_dentry.patch
+gregkh-driver-sysfs-remove-s_dentry.patch
+gregkh-driver-sysfs-kill-sysfs_flag_removed.patch
+gregkh-driver-sysfs-rewrite-rename-in-terms-of-sysfs-dirents.patch
+gregkh-driver-sysfs-rewrite-sysfs_move_dir-in-terms-of-sysfs-dirents.patch
+gregkh-driver-ptycount-parm.patch
+gregkh-driver-sysfs-crash-debugging.patch

 driver tree

+revert-gregkh-driver-warn-when-statically-allocated-kobjects-are-used.patch
+make-kobject-dynamic-allocation-check-use-kallsyms_lookup.patch
+fix-gregkh-driver-driver-core-change-add_uevent_var-to-use-a-struct.patch

 driver-tree fixes

-git-dma.patch

 Dropped

+drm-via-invalid-device-ids-removal.patch

 drm fix

+v4l-stk11xx-add-a-new-webcam-driver.patch
+ivtv-fbc-bugfix.patch
+v4l-stk11xx-use-array_size-in-another-2-cases.patch
+v4l-stk11xx-use-retval-from-stk11xx_check_device.patch
+v4l-stk11xx-add-static-to-tables.patch

 v4l things

+jdelvare-i2c-i2c-ibm_iic-numbered-adapter.patch
+jdelvare-i2c-i2c-davinci-new-bus-driver.patch

 i2c tree

+hwmon-coretemp-remove-bogus-__cpuinitdata-etc-cleanup.patch

 hwmon fix

+ia64-tree-wide-misc-__cpuinitdata-init-exit.patch

 ia64 fix

+ehca_irq-misc-cpuinit-section-annotations-and-ifdef-cleanups.patch

 infiniband fix

+de-dosify-iforce-protocoltxt.patch

 input fix

+libata-correct-handling-of-srst-reset-sequences.patch
+libata-add-a-drivers-ide-style-dma-disable.patch
+ata-add-the-sw-ncq-support-to-sata_nv-for-mcp51-mcp55-mcp61patch.patch
+ata-pata_marvell-use-ioread-for-iomap-ped-memory.patch

 ata things

+ide-mpc8xx-only-build-mpc8xx-on-arch_ppc.patch
+ide-ide-fix-pci-refcounting.patch
+ide-pdc202xx_new-fix-pci-refcounting.patch
+ide-pdc202xx_new-switch-to-using-pci_get_slot-take-2.patch
+ide-hpt366-fix-pci-clock-detection-for-hpt374-take-4.patch
+ide-ide-add-ide_dev_is_sata-helper-take-2.patch
+ide-hpt366-ultradma-filter-for-sata-cards-take-2.patch
+ide-amd74xx-via82cxxx-dont-initialize-drive-dn.patch
+ide-amd74xx-remove-ide-proc-amd74xx.patch
+ide-ide-add-ide-hflag-no-atapi-dma.patch
+ide-ide-pci-add-ide-hflag-bootable-flag.patch
+ide-ide-pci-add-ide-hflag-no-dma-and-no-autodma-flags.patch
+ide-ide-remove-init-setup-dma-from-ide-pci-device-t.patch
+ide-ide-add-ide-hflag-no-lba48-and-ide-hflag-no-lba48-dma.patch
+ide-pdc202xx_old-remove-broken-swdma-support.patch
+ide-ide-add-mwdma-mask-and-swdma-mask-to-ide-pci-device-t.patch
+ide-pdc202xx_new-pll-detection-fix.patch
+ide-amd74xx-omit-pci_revision_id-read.patch
+ide-cmd64x-use-dev-revision.patch

 IDE tree updates

+mips-replace-config_usb_ohci-with-config_usb_ohci_hcd-in-a-few-overlooked-files.patch

 MIPS fix

-git-mmc-fixup.patch

 Unneeded

+git-mmc-fixup2.patch

 fix git-mmc

+ioc3-program-uart-predividers.patch
+sky2-fe-chip-support.patch
+sky2-use-debugfs-rename.patch
+sky2-document-gphy_ctrl-bits.patch
+sky2-dont-restrict-config-space-access.patch
+sky2-advanced-error-reporting.patch
+sky2-use-pci_config-access-functions.patch
+sky2-use-net_device-internal-stats.patch
+ktime_sub_ns-analog-of-ktime_add_ns.patch
+export-reciprocal_value-for-modules.patch
+sky2-hardware-receive-timestamp-counter.patch
+sky2-avoid-divide-in-receive-path.patch
+sky2-118.patch

 netdev things

+git-net-fixup.patch

 fix git-net

+net-atm-lecc-printk-warning-fix.patch
+e1000e-incorporate-napi_struct-changes-from-net-2624git.patch

 net fixes

+ocfs2-warning-fix.patch

 Fix git-ocfs2.patch

+move-a-few-definitions-to-au1000_xxs1500c-fix.patch

 Fix move-a-few-definitions-to-au1000_xxs1500c.patch

+8250_pci-autodetect-mainpine-cards.patch
+8250_pci-autodetect-mainpine-cards-fix.patch

 serial

+gregkh-pci-pci-aer-fix-warnings-when-pcieaer-n.patch
+gregkh-pci-pci-remove-devinit-from-pci_read_bridge_bases.patch
+gregkh-pci-pci-remove-__devinit-from-pcibios_get_irq_routing_table.patch
+gregkh-pci-pci-unhide-smbus-on-compaq-deskpro-ep-401963-001-motherboard.patch
+gregkh-pci-pci-pci_get_device-call-from-interrupt-in-reboot-fixups.patch
+gregkh-pci-i386-add-support-for-picopower-irq-router.patch
+gregkh-pci-pci-disable-decode-of-io-memory-during-bar-sizing.patch
+gregkh-pci-pci-add-missing-pci-capability-ids.patch

 PCI tree updates

+fix-ide-legacy-mode-resources.patch
+fix-ide-legacy-mode-resources-fix.patch

 PCI fix

+sh-cleanup-struct-irqaction-initializers.patch
+sh64-cleanup-struct-irqaction-initializers.patch

 sh fixes

+drivers-scsi-advansysc-ld-error-re-2623-rc3-mm1.patch
+drivers-scsi-immc-fix-check-after-use.patch
+hptiop-add-new-firmware-interface-and-more-pci-device-ids.patch

 scsi

+git-block-fixup.patch
+git-block-fix-headers_check.patch
+ll_rw_blk-blk_cpu_notifier-should-be-__cpuinitdata.patch

 Fix git-block.patch

+gregkh-usb-usb-oti6858-remove-broken-ioctl-code-in-mm-tree-and-also-the-broken-fixes.patch
+gregkh-usb-usb-missing-test-for-eshutdown-in-adutux-driver.patch
+gregkh-usb-usb-ark3116c-fix-check-after-use.patch
+gregkh-usb-usb-remove-unnecessary-tests-in-isp116x-and-sl811.patch
+gregkh-usb-ueagle-eagle-iv-chipset-support.patch
+gregkh-usb-ueagle-devolo-and-elsa-chipsets-support.patch
+gregkh-usb-ueagle-allow-user-to-choose-input-interface-alternate-setting.patch
+gregkh-usb-ueagle-avoid-keyboard-driver-blocking.patch
+gregkh-usb-ueagle-do-not-sleep-when-device-is-disconnected.patch
+gregkh-usb-ueagle-cosmetic.patch
+gregkh-usb-usb-ehci-restart-speedup.patch
+gregkh-usb-usb-minor-fixes-for-r8a66597-driver.patch
+gregkh-usb-usb-remove-iso-status-value-in-uhci-hcd.patch
+gregkh-usb-usb-centralize-eremoteio-handling.patch
+gregkh-usb-usb-add-urb-unlinked-field.patch
+gregkh-usb-usb-ftdi_sio-handle-ft232rl-devices-like-ft232bm-devices.patch
+gregkh-usb-usb-fix-mistake-in-usb_hcd_giveback_urb.patch
+gregkh-usb-usb-avoid-the-donelist-after-an-error-in-ohci-hcd.patch
+gregkh-usb-usb-cp2101-coding-style-police.patch
+gregkh-usb-usb-kobil_sct-rework-driver.patch
+gregkh-usb-usb-less-restrictive-command-checking-in-g-file-storage.patch
+gregkh-usb-usb-berry-charge-memory-leak.patch
+gregkh-usb-usb-serial-show-port-number-in-sysfs.patch
+gregkh-usb-usb-usbmon-doc-update-mention-new-wildcard-bus.patch
+gregkh-usb-usb-avoid-redundant-cast-of-kmalloc-return-value-in-oti-6858-driver.patch
+gregkh-usb-usb-serial-pl2303-support-for-benq-siemens-mobile-phone-ef81.patch
+gregkh-usb-usb-reorganize-urb-status-use-in-dummy-hcd.patch
+gregkh-usb-usb-reorganize-urb-status-use-in-ehci-hcd.patch
+gregkh-usb-usb-reorganize-urb-status-use-in-ohci-hcd.patch
+gregkh-usb-usb-reorganize-urb-status-use-in-sl811-hcd.patch
+gregkh-usb-usb-reorganize-urb-status-use-in-r8a66597-hcd.patch
+gregkh-usb-usb-reorganize-urb-status-use-in-usbmon.patch
+gregkh-usb-usb-eliminate-urb-status-usage.patch
+gregkh-usb-usb-get-rid-of-urb-lock.patch
+gregkh-usb-usb-remove-traces-of-urb-status-from-usbcore.patch
+gregkh-usb-usb-driver-for-ch341-usb-serial-adaptor.patch
+gregkh-usb-usb-iphone-charge.patch

 USB tree updates

+9p-build-fix.patch
+9p-is-bust.patch
+9p-is-still-bust.patch

 git-v9fs.patch is busted

+x86_64-mm-cflags-probe.patch
+x86_64-mm-validate-against-acpi-motherboard-resources.patch
+x86_64-mm-vdso-install-unstripped-copies-on-disk.patch
+x86_64-mm-vdso-do-something-more-with-unstripped-copies-on-disk.patch
+x86_64-mm-fix-section-mismatch-warnings.patch
+x86_64-mm-mm-init-indent.patch
+x86_64-mm-fix-leak-of-__-kernel-from-top-level-directory-in-makefile.patch
+x86_64-mm-msr-cpuinit.patch
+x86_64-mm-cpuid-cpuinit.patch

 x86 tree updates

+fix-x86_64-mm-unwinder.patch

 Fix it

-x86_64-dynticks-disable-hpet_id_legsup-hpets.patch

 Dropped

+intel_cacheinfo-misc-section-annotation-fixes.patch
+intel_cacheinfo-misc-section-annotation-fixes-fix.patch
+intel_cacheinfo-call-cache_add_dev-from-cache_sysfs_init.patch
+x86-use-num_online_nodes-to-get-physical-cpus-numbers-for.patch
+i386-stop-bogus-nmi-softlockup-warnings-in-show_mem.patch
+clockevents-remove-unused-inline-function.patch
+clockevents-allow-build-without-runtime-use.patch
+x86_64-consolidate-tsc-calibration.patch
+i386-prepare-sharing-hpet-code.patch
+i386-hpet-add-x8664-hpet-bits.patch
+i386-prepare-sharing-pit-code.patch
+x86_64-use-i386-i8253-h.patch
+x86_64-preparatory-apic-set-lvtt.patch
+x86_64-apic-remove-bogus-pit-synchronization.patch
+x86_64-apic-shuffle-calibration-around.patch
+x86_64-apic-calibration-remove-divisor.patch
+x86_64-apic-change-setup-calling-convention.patch
+x86_64-apic-remove-nested-irq-disable.patch
+x86_64-prep-idle-loop-for-dynticks.patch
+x86_64-apic-add-clockevents-functions.patch
+x86_64-convert-to-clockevents.patch
+x86_64-remove-unused-code.patch
+x86_64-cleanup-apic-c.patch
+jiffies-remove-unused-macros.patch
+acpi-remove-the-useless-ifdef-code.patch
+i386-pit-remove-the-useless-ifdefs.patch
+i386-hpet-sharing-optimize.patch
+ich-force-hpet-make-generic-time-capable-of-switching-broadcast-timer.patch
+ich-force-hpet-restructure-hpet-generic-clock-code.patch
+ich-force-hpet-ich7-or-later-quirk-to-force-detect-enable.patch
+ich-force-hpet-ich7-or-later-quirk-to-force-detect-enable-fix.patch
+ich-force-hpet-late-initialization-of-hpet-after-quirk.patch
+ich-force-hpet-ich5-quirk-to-force-detect-enable.patch
+ich-force-hpet-ich5-quirk-to-force-detect-enable-fix.patch
+ich-force-hpet-ich5-fix-a-bug-with-suspend-resume.patch
+ich-force-hpet-add-ich7_0-pciid-to-quirk-list.patch
+hpet-force-enable-on-ich34.patch
+hpet-force-enable-on-vt8235-37-chipsets.patch
+hpet-force-enable-on-vt8235-37-chipsets-fix.patch
+x86-fix-cpu_to_node-references.patch
+x86-convert-cpu_core_map-to-be-a-per-cpu-variable.patch
+x86-convert-cpu_sibling_map-to-be-a-per-cpu-variable.patch
+x86-convert-cpu_sibling_map-to-be-a-per-cpu-variable-broke-ia64.patch
+x86-convert-x86_cpu_to_apicid-to-be-a-per-cpu-variable.patch
+x86-convert-cpu_llc_id-to-be-a-per-cpu-variable.patch
+x86-acpi-use-cpu_physical_id.patch
+i386-visws-extern-inline-static-inline.patch
+i386-cleanup-struct-irqaction-initializers.patch
+x86_64-cleanup-struct-irqaction-initializers.patch

 x86 things

+git-xfs-build-fix.patch

 Fix git-xfs.patch

+enforce-noreplace-smp-in-alternative_instructions.patch
+paravirt-fix-preemptible-lazy-mode-bug.patch
+i386-apic-fix-4-bit-apicid-assumption-of-mach-default.patch

 probable 2.6.23 queue

+fix-the-max-path-calculation-in-radix-treec-update.patch

 Fix fix-the-max-path-calculation-in-radix-treec.patch

+mm-no-need-to-cast-vmalloc-return-value-in-zone_wait_table_init.patch
+introduce-write_begin-write_end-aops-fix2.patch
+implement-simple-fs-aops-fix.patch
+ext2-convert-to-new-aops-fix2.patch
+ext3-convert-to-new-aops-fix-fix.patch
+ext4-convert-to-new-aops-fix-fix.patch
+gfs2-convert-to-new-aops-fix.patch
+reiserfs-convert-to-new-aops-fix2.patch
+hostfs-convert-to-new-aops-fix-fix.patch
+ufs-convert-to-new-aops-fix2.patch
+sysv-convert-to-new-aops-fix2.patch
+minix-convert-to-new-aops-fix2.patch
+affs-convert-to-new-aops-fix-fix.patch
+memoryless-nodes-add-n_cpu-node-state-move-setup-of-n_cpu-node-state-mask.patch
+memoryless-nodes-fixup-uses-of-node_online_map-in-generic-code-fix.patch
+memoryless-nodes-fixup-uses-of-node_online_map-in-generic-code-fix-2.patch
+update-n_high_memory-node-state-for-memory-hotadd.patch
+slub-avoid-page-struct-cacheline-bouncing-due-to-remote-frees-to-cpu-slab.patch
+slub-do-not-use-page-mapping.patch
+slub-move-page-offset-to-kmem_cache_cpu-offset.patch
+slub-avoid-touching-page-struct-when-freeing-to-per-cpu-slab.patch
+slub-place-kmem_cache_cpu-structures-in-a-numa-aware-way.patch
+slub-optimize-cacheline-use-for-zeroing.patch
+memory-hotplug-hot-add-with-sparsemem-vmemmap-update.patch
+capabilities-reset-current-pdeath_signal-when-increasing-capabilities.patch

 MM stuff

+frv-cleanup-struct-irqaction-initializers.patch

 frv cleanup

+hibernation-arbitrary-boot-kernel-support-generic-code-rev-2.patch
+hibernation-arbitrary-boot-kernel-support-on-x86_64-rev-2.patch
+hibernation-pass-cr3-in-the-image-header-on-x86_64-rev-2.patch
+hibernation-use-temporary-page-tables-for-kernel-text-mapping-on-x86_64.patch

 power management

+m32r-cleanup-struct-irqaction-initializers.patch

 m32r cleanup

+cris-cleanup-struct-irqaction-initializers.patch

 cris cleanup

+uml-dont-use-glibc-asm-userh.patch
+uml-floating-point-signal-delivery-fixes.patch
+uml-ptrace-floating-point-fixes.patch
+uml-coredumping-floating-point-fixes.patch
+uml-sysrq-and-mconsole-fixes.patch
+uml-style-fixes-in-fp-code.patch
+uml-eliminate-floating-point-state-from-register-file.patch

 uml update

+v850-cleanup-struct-irqaction-initializers.patch

 v850 cleanup

+i-oat-new-device-ids.patch
+i-oat-rename-the-source-file.patch
+i-oat-code-cleanup-from-checkpatch-output.patch
+i-oat-split-pci-startup-from-dma-handling-code.patch
+i-oat-add-support-for-msi-and-msi-x.patch
+dca-add-direct-cache-access-driver.patch
+i-oat-add-dca-services.patch

 ioat tree

+pcmcia-compactflash-driver-for-pa-semi-electra-boards-fix.patch

 Fix pcmcia-compactflash-driver-for-pa-semi-electra-boards.patch

+jsm-remove-further-unneeded-crud-fix.patch

 Fix jsm-remove-further-unneeded-crud.patch

+pie-executable-randomization-fix-3.patch

 Fix pie-executable-randomization.patch even more

+use-erestart_restartblock-if-poll-is-interrupted-by-a-signal-fix.patch

 Fix use-erestart_restartblock-if-poll-is-interrupted-by-a-signal.patch

+autofs4-reinstate-negatitive-timeout-of-mount-fails-fix.patch

 Fix autofs4-reinstate-negatitive-timeout-of-mount-fails.patch

+wait_task_stopped-continued-remove-unneeded-p-signal-=-null-check.patch
+console-events-and-accessibility.patch
+console-events-and-accessibility-fix.patch
+add-vmcoreinfo.patch
+maintainters-use-our-mail-list-as-blackfin-arch-maintainters.patch
+shrink-task_struct-if-config_futex=n.patch
+ttyh-remove-dead-define.patch
+fix-a-trivial-typo-in-scripts-checkstackpl.patch
+move-preempt_notifiers-into-an-always-included-kconfig.patch
+floppy-tolerate-dma-channel-unavailability.patch
+cleanup-floppyh.patch
+remove-superfluous-definition-of-__setup_null_param-macro-and-broken-for-module-__setup_param.patch
+codingstyle-relax-the-80-cole-rule.patch
+script-to-check-for-undefined-kconfig-symbols.patch
+nbd-set-uninitialized-devices-to-size-0.patch
+nbd-allow-hung-network-i-o-to-be-cancelled.patch
+cciss-fix-error-reporting-for-sg_io.patch
+drop-some-headers-from-mmh.patch
+remove-include-asm-ipch.patch
+n_hdlcc-fix-check-after-use.patch
+kernel-sys_nic-add-dummy-sys_ni_syscall-prototype.patch
+make-kernel-profilectime_hook-static.patch
+drivers-block-ccissc-fix-check-after-use.patch
+#track-accurate-idle-time-with-tick_schedidle_sleeptime.patch: needs acks
+track-accurate-idle-time-with-tick_schedidle_sleeptime.patch
+remove-valueless-definition-of-hard-selected-ramfs-option.patch
+local_t-documentation-update-2.patch
+atomic_opstxt-mention-local_t.patch
+local_t-update-documentation.patch
+docs-ramdisk-initrd-initramfs-corrections.patch
+remove-final-traces-of-long-deprecated-ramdisk-kernel.patch
+send-quota-messages-via-netlink.patch
+make-dmapool-code-use-__set_current_state.patch
+add-a-rounddown_pow_of_two-routine-to-log2h.patch
+fix-discrepancy-between-vdso-based-gettimeofday-and-sys_gettimeofday.patch

 misc

+spi-driver-runtime-footprint-shrinkage.patch

 spi tweak

+kprobes-support-kretprobe-blacklist.patch

 kprobes update

+drivers-video-geode-lxfb_corec-fix-lxfb_setup-warning-fix.patch

 Fix drivers-video-geode-lxfb_corec-fix-lxfb_setup-warning.patch

+atyfb-atyfb-unshare-pseudo_palette.patch
+fbcon-convert-struct-font_desc-to-use-iso-c-initializers.patch
+fbcon-convert-struct-font_desc-to-use-iso-c-initializers-update.patch
+vt-fix-warnings-in-selectionh.patch
+fbdev-change-asm-uaccessh-to-linux-uaccessh.patch
+s3c2410fb-source-code-improvements.patch
+s3c2410fb-adds-pixclock-to-s3c2410fb_display.patch
+s3c2410fb-removes-lcdcon1-register-value-from-s3c2410fb_display.patch
+s3c2410fb-make-use-of-default_display-settings.patch
+cirrusfb-checkpatchpl-cleanup.patch
+cirrusfb-checkpatchpl-cleanup-ppc-fix.patch
+cirrusfb-remove-typedefs.patch
+cirrusfb-remove-fields-from-cirrusfb_info.patch
+cirrusfb-code-improvements.patch
+cirrusfb-code-improvement-2nd-part.patch
+pm3fb-header-file-cleanup.patch
+pm2fb-hardware-cursor-support-for-the-permedia2.patch
+pm2fb-panning-and-hardware-cursor-fixes.patch
+vfb-make-virtual-framebuffer-mmapable.patch

 fbdev

+md-software-raid-autodetect-dev-list-not-array.patch
+md-software-raid-autodetect-dev-list-not-array-fix.patch

 RAID

+do-cpu_dead-migrating-under-read_locktasklist-instead-of-write_lock_irqtasklist.patch
+migration_callcpu_dead-use-spin_lock_irq-instead-of-task_rq_lock.patch

 fix cpu hotplug patches in -mm

+pnp-dont-fail-device-init-if-no-dma-channel.patch

 pnp fix

-mm-implement-swap-prefetching.patch
-memoryless-nodes-fixup-uses-of-node_online_map-in-generic-code-prefetch.patch
 #
-add-__gfp_movable-for-callers-to-flag-allocations-from-high-memory-that-may-be-migrated-swap-prefetch.patch
-rename-gfp_high_movable-to-gfp_highuser_movable-prefetch.patch

 dropped

-sysctl-error-on-bad-sysctl-tables.patch
-sysctl-error-on-bad-sysctl-tables-kernel-sysctl_checkc-must-include-linux-stringh.patch
 #
-sysctl-update-sysctl_check_table.patch
+sysctl-parport-remove-binary-paths-fix.patch
-sysctl-clean-up-the-sched-debug-sysctl-usage.patch
-sysctl-update-sysctl_checks-list-of-binary-paths.patch
+sysctl-properly-register-the-irda-binary-sysctl-numbers.patch
+sysctl-error-on-bad-sysctl-tables.patch
+sysctl-error-on-bad-sysctl-tables-kernel-sysctl_checkc-must-include-linux-stringh.patch
+sysctl-update-sysctl_check_table.patch
+sysctl-update-sysctl_checks-list-of-binary-paths.patch
+sysctl-update-sysctl_check_table-sysctl-update-sysctl_check-to-handle-compiled-out-code.patch
+sysctl-for-irda-update-sysctl_checks-list-of-binary-paths.patch
+sysctl-deprecate-sys_sysctl-in-a-user-space-visible-fashion.patch

 udpate -mm sysctl patches

+mxser-remove-commented-crap.patch

 mxser cleanup

+task-containersv11-shared-container-subsystem-group-arrays-avoid-lockdep-warning.patch
+task-containersv11-shared-container-subsystem-group-arrays-include-fix.patch

 Fix task-containersv11-shared-container-subsystem-group-arrays.patch

+pid-namespaces-changes-to-show-virtual-ids-to-user-sys_getsid-sys_getpgid-return-wrong-id-for-task-from-another.patch
+pid-namespaces-changes-to-show-virtual-ids-to-user-fix-the-sys_setpgrp-to-work-between-namespaces.patch
+isolate-some-explicit-usage-of-task-tgid-fix.patch
+isolate-some-explicit-usage-of-task-tgid-fix-fix.patch

 fix other container stuff

+memory-controller-add-documentation.patch
+memory-controller-resource-counters-v7.patch
+memory-controller-resource-counters-v7-fix.patch
+memory-controller-containers-setup-v7.patch
+memory-controller-accounting-setup-v7.patch
+memory-controller-memory-accounting-v7.patch
+memory-controller-task-migration-v7.patch
+memory-controller-add-per-container-lru-and-reclaim-v7.patch
+memory-controller-add-per-container-lru-and-reclaim-v7-fix.patch
+memory-controller-oom-handling-v7.patch
+memory-controller-add-switch-to-control-what-type-of-pages-to-limit-v7.patch
+memory-controller-make-page_referenced-container-aware-v7.patch

 memory containment

+char-moxa-cleanup-prints.patch
+char-moxa-function-names-cleanup.patch
+char-moxa-remove-sleep_on.patch

 char driver cleanups

+remove-bits_to_type-macro.patch
+remove-bits_to_type-macro-fix.patch

 cleanup

+use-helpers-to-obtain-task-pid-in-printks.patch
+use-helpers-to-obtain-task-pid-in-printks-arch-code.patch
+remove-unused-variables-from-fs-proc-basec.patch
+use-task_pid_nr-in-ip_vs_syncc.patch
+redefine-unregister_hotcpu_notifier-hotplug_cpu-stubs.patch
+x86-msr-driver-misc-cpuinit-annotations.patch
+i386-cpuid-misc-cpuinit-annotations.patch
+hotplug-cpu-migrate-a-task-within-its-cpuset.patch
+hotplug-cpu-migrate-a-task-within-its-cpuset-fix.patch
+hotplug-cpu-migrate-a-task-within-its-cpuset-doc.patch
+bitops-introduce-lock-ops.patch
+alpha-fix-bitops.patch
+alpha-lock-bitops.patch
+ia64-lock-bitops.patch
+mips-fix-bitops.patch
+mips-lock-bitops.patch
+powerpc-lock-bitops.patch
+bit_spin_lock-use-lock-bitops.patch
+fs-cramfs-inodec-remove-unused-variable.patch
+fs-cramfs-inodec-replace-hardcoded-value-with-preprocessor-constant.patch
+fs-cramfs-inodec-remove-error-variable.patch
+reiser4-use-helpers-to-obtain-task-pid-in-printks.patch

 various stuff

-acpi_format_exception-debug.patch

 dropped



All 1628 patches:

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/patch-list

Re: 2.6.23-rc4-mm1

[KAMEZAWA Hiroyuki]

I met 2 troubles while I compiled rc4-mm1 on x86/UP system,

One on pcnet32.c (patch is attaced below).
One on crypto CONFIG.

== compile log ==
drivers/net/pcnet32.c: In function 'pcnet32_netif_stop':
drivers/net/pcnet32.c:445: warning: unused variable 'lp'
drivers/net/pcnet32.c: In function 'pcnet32_netif_start':
drivers/net/pcnet32.c:455: warning: unused variable 'lp'
drivers/net/pcnet32.c: In function 'pcnet32_interrupt':
drivers/net/pcnet32.c:2622: error: 'struct net_device' has no member named 'napi'
....
crypto/built-in.o: In function `update2':
digest.c:(.text+0x94a): undefined reference to `crypto_km_types'
digest.c:(.text+0x9bf): undefined reference to `crypto_km_types'

digest.c (CONFIG_CRYPTO) uses crypto/scatterwalk.c's object (CONFIG_CRYPTO_ALGAPI)
I meet this when CONFIG_CRYPTO_ALGAPI=m. I need to make CONFIG_CRYPTO_ALGAPI=y.

Regards,
-Kame.
== cut from here ==

 tiny bug fix for pcnet32.c (maybe works well. please confirm.)

 Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

 drivers/net/pcnet32.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: devel-2.6.23-rc4-mm1/drivers/net/pcnet32.c
===================================================================
--- devel-2.6.23-rc4-mm1.orig/drivers/net/pcnet32.c
+++ devel-2.6.23-rc4-mm1/drivers/net/pcnet32.c
@@ -2619,7 +2619,7 @@ pcnet32_interrupt(int irq, void *dev_id)
 			break;
 		}
 #else
-		pcnet32_rx(dev, dev->napi.weight);
+		pcnet32_rx(dev, lp->napi.weight);
 		if (pcnet32_tx(dev)) {
 			/* reset the chip to clear the error condition, then restart */
 			lp->a.reset(ioaddr);

Re: 2.6.23-rc4-mm1

[Andrew Morton]

> On Sat, 1 Sep 2007 15:53:53 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> I met 2 troubles while I compiled rc4-mm1 on x86/UP system,
> 
> One on pcnet32.c (patch is attaced below).
> One on crypto CONFIG.
> 
> == compile log ==
> drivers/net/pcnet32.c: In function 'pcnet32_netif_stop':
> drivers/net/pcnet32.c:445: warning: unused variable 'lp'
> drivers/net/pcnet32.c: In function 'pcnet32_netif_start':
> drivers/net/pcnet32.c:455: warning: unused variable 'lp'
> drivers/net/pcnet32.c: In function 'pcnet32_interrupt':
> drivers/net/pcnet32.c:2622: error: 'struct net_device' has no member named 'napi'

Only git-net touches pcnet32.c

> crypto/built-in.o: In function `update2':
> digest.c:(.text+0x94a): undefined reference to `crypto_km_types'
> digest.c:(.text+0x9bf): undefined reference to `crypto_km_types'
> 
> digest.c (CONFIG_CRYPTO) uses crypto/scatterwalk.c's object (CONFIG_CRYPTO_ALGAPI)
> I meet this when CONFIG_CRYPTO_ALGAPI=m. I need to make CONFIG_CRYPTO_ALGAPI=y.

cc herbert..

> Regards,
> -Kame.
> == cut from here ==
> 
>  tiny bug fix for pcnet32.c (maybe works well. please confirm.)
> 
>  Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> 
>  drivers/net/pcnet32.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: devel-2.6.23-rc4-mm1/drivers/net/pcnet32.c
> ===================================================================
> --- devel-2.6.23-rc4-mm1.orig/drivers/net/pcnet32.c
> +++ devel-2.6.23-rc4-mm1/drivers/net/pcnet32.c
> @@ -2619,7 +2619,7 @@ pcnet32_interrupt(int irq, void *dev_id)
>  			break;
>  		}
>  #else
> -		pcnet32_rx(dev, dev->napi.weight);
> +		pcnet32_rx(dev, lp->napi.weight);
>  		if (pcnet32_tx(dev)) {
>  			/* reset the chip to clear the error condition, then restart */
>  			lp->a.reset(ioaddr);

cc netdev, thanks.

Re: 2.6.23-rc4-mm1

[Herbert Xu]

On Fri, Aug 31, 2007 at 11:58:15PM -0700, Andrew Morton wrote:
> 
> > crypto/built-in.o: In function `update2':
> > digest.c:(.text+0x94a): undefined reference to `crypto_km_types'
> > digest.c:(.text+0x9bf): undefined reference to `crypto_km_types'
> > 
> > digest.c (CONFIG_CRYPTO) uses crypto/scatterwalk.c's object (CONFIG_CRYPTO_ALGAPI)
> > I meet this when CONFIG_CRYPTO_ALGAPI=m. I need to make CONFIG_CRYPTO_ALGAPI=y.
> 
> cc herbert..

Sorry, only tested on x86-64 which doesn't have HIGHMEM.

I've just pushed the following fix into cryptodev-2.6.

commit 25531e010a2a1d0099b62d473244d09e72402ce5
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Sat Sep 1 16:52:13 2007 +0800

    [CRYPTO] api: Kill crypto_km_types

    When scatterwalk is built as a module digest.c was broken because it
    requires the crypto_km_types structure which is in scatterwalk.  This
    patch removes the crypto_km_types structure by encoding the logic into
    crypto_kmap_type directly.

    In fact, this even saves a few bytes of code (not to mention the data
    structure itself) on i386 which is about the only place where it's
    needed.

    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/crypto/internal.h b/crypto/internal.h
index 60acad9..abb01f7 100644
--- a/crypto/internal.h
+++ b/crypto/internal.h
@@ -50,11 +50,16 @@ extern struct list_head crypto_alg_list;
 extern struct rw_semaphore crypto_alg_sem;
 extern struct blocking_notifier_head crypto_chain;
 
-extern enum km_type crypto_km_types[];
-
 static inline enum km_type crypto_kmap_type(int out)
 {
-	return crypto_km_types[(in_softirq() ? 2 : 0) + out];
+	enum km_type type;
+
+	if (in_softirq())
+		type = out * (KM_SOFTIRQ1 - KM_SOFTIRQ0) + KM_SOFTIRQ0;
+	else
+		type = out * (KM_USER1 - KM_USER0) + KM_USER0;
+
+	return type;
 }
 
 static inline void *crypto_kmap(struct page *page, int out)

Re: 2.6.23-rc4-mm1

[Kamalesh Babulal]

Andrew Morton wrote:
>> On Sat, 1 Sep 2007 15:53:53 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> I met 2 troubles while I compiled rc4-mm1 on x86/UP system,
>>
>> One on pcnet32.c (patch is attaced below).
>> One on crypto CONFIG.
>>
>> == compile log ==
>> drivers/net/pcnet32.c: In function 'pcnet32_netif_stop':
>> drivers/net/pcnet32.c:445: warning: unused variable 'lp'
>> drivers/net/pcnet32.c: In function 'pcnet32_netif_start':
>> drivers/net/pcnet32.c:455: warning: unused variable 'lp'
>> drivers/net/pcnet32.c: In function 'pcnet32_interrupt':
>> drivers/net/pcnet32.c:2622: error: 'struct net_device' has no member named 'napi'
>>     
>
> Only git-net touches pcnet32.c
>
>   
<snip>
Hi Kamezawa,

I got the pcnet32.c compile failure and after applying the patch compile 
does not fails.

Thanks & Regards,
Kamalesh Babulal.

Re: 2.6.23-rc4-mm1

[Torsten Kaiser]

On 9/1/07, Andrew Morton <akpm@linux-foundation.org> wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/

The good:
> +hpet-force-enable-on-vt8235-37-chipsets.patch
> +hpet-force-enable-on-vt8235-37-chipsets-fix.patch

Kernel 2.6.23-rc4-mm1 works on one of my systems with:
00:00.0 Host bridge: VIA Technologies, Inc. VT8385 [K8T800 AGP] Host
Bridge (rev 01)
00:01.0 PCI bridge: VIA Technologies, Inc. VT8237 PCI bridge
[K8T800/K8T890 South]
00:0e.0 FireWire (IEEE 1394): VIA Technologies, Inc. IEEE 1394 Host
Controller (rev 80)
00:0f.0 RAID bus controller: VIA Technologies, Inc. VIA VT6420 SATA
RAID Controller (rev 80)
00:0f.1 IDE interface: VIA Technologies, Inc.
VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE (rev 06)
00:10.0 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1
Controller (rev 81)
00:10.1 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1
Controller (rev 81)
00:10.2 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1
Controller (rev 81)
00:10.3 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1
Controller (rev 81)
00:10.4 USB Controller: VIA Technologies, Inc. USB 2.0 (rev 86)
00:11.0 ISA bridge: VIA Technologies, Inc. VT8237 ISA bridge
[KT600/K8T800/K8T890 South]
00:11.5 Multimedia audio controller: VIA Technologies, Inc.
VT8233/A/8235/8237 AC97 Audio Controller (rev 60)

It now has a working HPET.

The bad:
sata_sil24 and/or libata are broken.
On my second system (MCP55 + SiI 3132) I see this:
[    3.890000] scsi0 : sata_sil24
[    3.900000] scsi1 : sata_sil24
[    3.900000] ata1: SATA max UDMA/100 host m128@0xefeffc00 port
0xefef8000 irq 16
[    3.920000] ata2: SATA max UDMA/100 host m128@0xefeffc00 port
0xefefa000 irq 16
[    4.300000] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
[    4.360000] ata1.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
[    4.370000] ata1.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
[    4.430000] ata1.00: configured for UDMA/100
[    4.500000] ieee1394: Node added: ID:BUS[0-00:1023]  GUID[0010dc00005cc354]
[    4.500000] ieee1394: Host added: ID:BUS[0-01:1023]  GUID[0011d80000c4c261]
[    4.790000] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
[    4.850000] ata2.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
[    4.860000] ata2.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
[    4.920000] ata2.00: configured for UDMA/100
[    4.930000] scsi 0:0:0:0: Direct-Access     ATA      MAXTOR
STM332082 3.AA PQ: 0 ANSI: 5
[    4.960000] sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
[    4.980000] sd 0:0:0:0: [sda] Write Protect is off
[    4.990000] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
[    4.990000] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[    5.020000] sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
[    5.040000] sd 0:0:0:0: [sda] Write Protect is off
[    5.050000] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
[    5.050000] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[    5.080000]  sda: sda1 sda2
[    5.110000] sd 0:0:0:0: [sda] Attached SCSI disk
[    5.120000] scsi 1:0:0:0: Direct-Access     ATA      MAXTOR
STM332082 3.AA PQ: 0 ANSI: 5
[    5.140000] sd 1:0:0:0: [sdb] 625142448 512-byte hardware sectors (320073 MB)
[    5.170000] sd 1:0:0:0: [sdb] Write Protect is off
[    5.180000] sd 1:0:0:0: [sdb] Mode Sense: 00 3a 00 00
[    5.180000] sd 1:0:0:0: [sdb] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[    5.210000] sd 1:0:0:0: [sdb] 625142448 512-byte hardware sectors (320073 MB)
[    5.230000] sd 1:0:0:0: [sdb] Write Protect is off
[    5.240000] sd 1:0:0:0: [sdb] Mode Sense: 00 3a 00 00
[    5.240000] sd 1:0:0:0: [sdb] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[    5.270000]  sdb: sdb1 sdb2
[    5.300000] sd 1:0:0:0: [sdb] Attached SCSI disk
[snip]
[   12.120000] Freeing unused kernel memory: 340k freed
[   33.210000] md: Autodetecting RAID arrays.
[   33.300000] md: Scanned 5 and added 5 devices.
[   33.300000] md: autorun ...
[   33.300000] md: considering sdc2 ...
[   33.300000] md:  adding sdc2 ...
[   33.300000] md:  adding sdb2 ...
[   33.300000] md: sdb1 has different UUID to sdc2
[   33.300000] md:  adding sda2 ...
[   33.300000] md: sda1 has different UUID to sdc2
[   33.300000] md: created md1
[   33.300000] md: bind<sda2>
[   33.300000] md: bind<sdb2>
[   33.300000] md: bind<sdc2>
[   33.300000] md: running: <sdc2><sdb2><sda2>
[   33.310000] raid5: device sdc2 operational as raid disk 2
[   33.310000] raid5: device sdb2 operational as raid disk 1
[   33.310000] raid5: device sda2 operational as raid disk 0
[   33.310000] raid5: allocated 3224kB for md1
[   33.310000] raid5: raid level 5 set md1 active with 3 out of 3
devices, algorithm 2
[   33.310000] RAID5 conf printout:
[   33.310000]  --- rd:3 wd:3
[   33.310000]  disk 0, o:1, dev:sda2
[   33.310000]  disk 1, o:1, dev:sdb2
[   33.310000]  disk 2, o:1, dev:sdc2
[   33.320000] md1: bitmap initialized from disk: read 10/10 pages, set 115 bits
[   33.320000] created bitmap (145 pages) for device md1
[   63.420000] ata2.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x6 frozen
[   63.420000] ata2.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0
cdb 0x0 data 4096 out
[   63.420000]          res 40/00:00:00:00:00/00:00:00:00:00/00 Emask
0x4 (timeout)
[   63.420000] ata2.00: status: {DRDY }
[   63.420000] ata2: hard resetting link
[   65.720000] ata2: softreset failed (port not ready)
[   65.720000] ata2: reset failed (errno=-5), retrying in 8 secs
[   73.420000] ata2: hard resetting link
[   75.720000] ata2: softreset failed (port not ready)
[   75.720000] ata2: reset failed (errno=-5), retrying in 8 secs
[   83.420000] ata2: hard resetting link
[   85.720000] ata2: softreset failed (port not ready)
[   85.720000] ata2: reset failed (errno=-5), retrying in 33 secs
[  118.420000] ata2: limiting SATA link speed to 1.5 Gbps
[  118.420000] ata2: hard resetting link
[  120.720000] ata2: softreset failed (port not ready)
[  120.720000] ata2: reset failed, giving up
[  120.720000] ata2.00: disabled
[  120.720000] ata2: EH complete
[  120.720000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.720000] end_request: I/O error, dev sdb, sector 625137161
[  120.720000] md: super_written gets error=-5, uptodate=0
[  120.720000] raid5: Disk failure on sdb2, disabling device.
Operation continuing on 2 devices
[  120.750000] md: considering sdb1 ...
[  120.750000] RAID5 conf printout:
[  120.750000]  --- rd:3 wd:2
[  120.750000] md:  adding sdb1 ...
[  120.750000]  disk 0, o:1, dev:sda2
[  120.750000]  disk 1, o:0, dev:sdb2
[  120.750000]  disk 2, o:1, dev:sdc2
[  120.750000] md:  adding sda1 ...
[  120.750000] md: created md0
[  120.750000] md: bind<sda1>
[  120.750000] md: bind<sdb1>
[  120.750000] md: running: <sdb1><sda1>
[  120.760000] raid1: raid set md0 active with 2 out of 2 mirrors
[  120.760000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.760000] end_request: I/O error, dev sdb, sector 19550919
[  120.780000] RAID5 conf printout:
[  120.780000]  --- rd:3 wd:2
[  120.780000]  disk 0, o:1, dev:sda2
[  120.780000]  disk 2, o:1, dev:sdc2
[  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.780000] end_request: I/O error, dev sdb, sector 19550927
[  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.780000] end_request: I/O error, dev sdb, sector 19550935
[  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.780000] end_request: I/O error, dev sdb, sector 19550943
[  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.780000] end_request: I/O error, dev sdb, sector 19550951
[  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.780000] end_request: I/O error, dev sdb, sector 19550959
[  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.780000] end_request: I/O error, dev sdb, sector 19550967
[  120.790000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.790000] end_request: I/O error, dev sdb, sector 19550975
[  120.790000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.790000] end_request: I/O error, dev sdb, sector 19550983
[  120.790000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.790000] end_request: I/O error, dev sdb, sector 19550991
[  120.790000] md0: bitmap initialized from disk: read 10/10 pages, set 0 bits
[  120.790000] created bitmap (150 pages) for device md0
[  120.790000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.790000] end_request: I/O error, dev sdb, sector 19550919
[  120.790000] md: super_written gets error=-5, uptodate=0
[  120.790000] raid1: Disk failure on sdb1, disabling device.
[  120.790000]  Operation continuing on 1 devices
[  120.810000] md: ... autorun DONE.
[  120.810000] RAID1 conf printout:
[  120.810000]  --- wd:1 rd:2
[  120.810000]  disk 0, wo:0, o:1, dev:sda1
[  120.810000]  disk 1, wo:1, o:0, dev:sdb1
[  120.860000] RAID1 conf printout:
[  120.860000]  --- wd:1 rd:2
[  120.860000]  disk 0, wo:0, o:1, dev:sda1
[  129.360000] Filesystem "dm-0": Disabling barriers, trial barrier write failed
[  129.390000] XFS mounting filesystem dm-0
[  129.600000] Ending clean XFS mount for filesystem: dm-0
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 625137153
[  132.850000] Buffer I/O error on device sdb2, logical block 75698256
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 625137153
[  132.850000] Buffer I/O error on device sdb2, logical block 75698256
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 625137153
[  132.850000] Buffer I/O error on device sdb2, logical block 75698256
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 19551105
[  132.850000] Buffer I/O error on device sdb2, logical block 0
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 19551113
[  132.850000] Buffer I/O error on device sdb2, logical block 1
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 19551105
[  132.850000] Buffer I/O error on device sdb2, logical block 0
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 19551105
[  132.850000] Buffer I/O error on device sdb2, logical block 0
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 625137337
[  132.850000] Buffer I/O error on device sdb2, logical block 75698279
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 625137337
[  132.850000] Buffer I/O error on device sdb2, logical block 75698279
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 625137337
[  132.850000] Buffer I/O error on device sdb2, logical block 75698279
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 625137337
[  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  132.850000] end_request: I/O error, dev sdb, sector 625137337
...

After that the system booted up fine, only running with the two of
three RAID drives.
(sda is on sata_sil24, sdc on sata_nv. I used the sata_nv.swncq=1 switch)

The ugly:
I wanted to verify that this was not a onetime bug and rebooted the system.
This time md kicked sdb because it was stale and then also kicked sda
with an error similar to the above. Which killed the RAID5 completely.
:(
At least I was able to resurrect it with mdadm --force.

So the sata_sil24 error seems repeatable, but also not limited to one
specific port.

The system is now up again running 2.6.23-rc3-mm1 with all three drives.

Torsten

Re: 2.6.23-rc4-mm1

[Andrew Morton]

> On Sat, 1 Sep 2007 18:07:48 +0200 "Torsten Kaiser" <just.for.lkml@googlemail.com> wrote:
> On 9/1/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/
> 
> The good:
> > +hpet-force-enable-on-vt8235-37-chipsets.patch
> > +hpet-force-enable-on-vt8235-37-chipsets-fix.patch
> 
> Kernel 2.6.23-rc4-mm1 works on one of my systems with:
> ...
> It now has a working HPET.

Great, thanks.

> The bad:
> sata_sil24 and/or libata are broken.

yup.  Let's cc linux-ide.

> On my second system (MCP55 + SiI 3132) I see this:
> [    3.890000] scsi0 : sata_sil24
> [    3.900000] scsi1 : sata_sil24
> [    3.900000] ata1: SATA max UDMA/100 host m128@0xefeffc00 port
> 0xefef8000 irq 16
> [    3.920000] ata2: SATA max UDMA/100 host m128@0xefeffc00 port
> 0xefefa000 irq 16
> [    4.300000] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> [    4.360000] ata1.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
> [    4.370000] ata1.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
> [    4.430000] ata1.00: configured for UDMA/100
> [    4.500000] ieee1394: Node added: ID:BUS[0-00:1023]  GUID[0010dc00005cc354]
> [    4.500000] ieee1394: Host added: ID:BUS[0-01:1023]  GUID[0011d80000c4c261]
> [    4.790000] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> [    4.850000] ata2.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
> [    4.860000] ata2.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
> [    4.920000] ata2.00: configured for UDMA/100
> [    4.930000] scsi 0:0:0:0: Direct-Access     ATA      MAXTOR
> STM332082 3.AA PQ: 0 ANSI: 5
> [    4.960000] sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> [    4.980000] sd 0:0:0:0: [sda] Write Protect is off
> [    4.990000] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> [    4.990000] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
> enabled, doesn't support DPO or FUA
> [    5.020000] sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> [    5.040000] sd 0:0:0:0: [sda] Write Protect is off
> [    5.050000] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> [    5.050000] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
> enabled, doesn't support DPO or FUA
> [    5.080000]  sda: sda1 sda2
> [    5.110000] sd 0:0:0:0: [sda] Attached SCSI disk
> [    5.120000] scsi 1:0:0:0: Direct-Access     ATA      MAXTOR
> STM332082 3.AA PQ: 0 ANSI: 5
> [    5.140000] sd 1:0:0:0: [sdb] 625142448 512-byte hardware sectors (320073 MB)
> [    5.170000] sd 1:0:0:0: [sdb] Write Protect is off
> [    5.180000] sd 1:0:0:0: [sdb] Mode Sense: 00 3a 00 00
> [    5.180000] sd 1:0:0:0: [sdb] Write cache: enabled, read cache:
> enabled, doesn't support DPO or FUA
> [    5.210000] sd 1:0:0:0: [sdb] 625142448 512-byte hardware sectors (320073 MB)
> [    5.230000] sd 1:0:0:0: [sdb] Write Protect is off
> [    5.240000] sd 1:0:0:0: [sdb] Mode Sense: 00 3a 00 00
> [    5.240000] sd 1:0:0:0: [sdb] Write cache: enabled, read cache:
> enabled, doesn't support DPO or FUA
> [    5.270000]  sdb: sdb1 sdb2
> [    5.300000] sd 1:0:0:0: [sdb] Attached SCSI disk
> [snip]
> [   12.120000] Freeing unused kernel memory: 340k freed
> [   33.210000] md: Autodetecting RAID arrays.
> [   33.300000] md: Scanned 5 and added 5 devices.
> [   33.300000] md: autorun ...
> [   33.300000] md: considering sdc2 ...
> [   33.300000] md:  adding sdc2 ...
> [   33.300000] md:  adding sdb2 ...
> [   33.300000] md: sdb1 has different UUID to sdc2
> [   33.300000] md:  adding sda2 ...
> [   33.300000] md: sda1 has different UUID to sdc2
> [   33.300000] md: created md1
> [   33.300000] md: bind<sda2>
> [   33.300000] md: bind<sdb2>
> [   33.300000] md: bind<sdc2>
> [   33.300000] md: running: <sdc2><sdb2><sda2>
> [   33.310000] raid5: device sdc2 operational as raid disk 2
> [   33.310000] raid5: device sdb2 operational as raid disk 1
> [   33.310000] raid5: device sda2 operational as raid disk 0
> [   33.310000] raid5: allocated 3224kB for md1
> [   33.310000] raid5: raid level 5 set md1 active with 3 out of 3
> devices, algorithm 2
> [   33.310000] RAID5 conf printout:
> [   33.310000]  --- rd:3 wd:3
> [   33.310000]  disk 0, o:1, dev:sda2
> [   33.310000]  disk 1, o:1, dev:sdb2
> [   33.310000]  disk 2, o:1, dev:sdc2
> [   33.320000] md1: bitmap initialized from disk: read 10/10 pages, set 115 bits
> [   33.320000] created bitmap (145 pages) for device md1
> [   63.420000] ata2.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x6 frozen
> [   63.420000] ata2.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0
> cdb 0x0 data 4096 out
> [   63.420000]          res 40/00:00:00:00:00/00:00:00:00:00/00 Emask
> 0x4 (timeout)
> [   63.420000] ata2.00: status: {DRDY }
> [   63.420000] ata2: hard resetting link
> [   65.720000] ata2: softreset failed (port not ready)
> [   65.720000] ata2: reset failed (errno=-5), retrying in 8 secs
> [   73.420000] ata2: hard resetting link
> [   75.720000] ata2: softreset failed (port not ready)
> [   75.720000] ata2: reset failed (errno=-5), retrying in 8 secs
> [   83.420000] ata2: hard resetting link
> [   85.720000] ata2: softreset failed (port not ready)
> [   85.720000] ata2: reset failed (errno=-5), retrying in 33 secs
> [  118.420000] ata2: limiting SATA link speed to 1.5 Gbps
> [  118.420000] ata2: hard resetting link
> [  120.720000] ata2: softreset failed (port not ready)
> [  120.720000] ata2: reset failed, giving up
> [  120.720000] ata2.00: disabled
> [  120.720000] ata2: EH complete
> [  120.720000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.720000] end_request: I/O error, dev sdb, sector 625137161
> [  120.720000] md: super_written gets error=-5, uptodate=0
> [  120.720000] raid5: Disk failure on sdb2, disabling device.
> Operation continuing on 2 devices
> [  120.750000] md: considering sdb1 ...
> [  120.750000] RAID5 conf printout:
> [  120.750000]  --- rd:3 wd:2
> [  120.750000] md:  adding sdb1 ...
> [  120.750000]  disk 0, o:1, dev:sda2
> [  120.750000]  disk 1, o:0, dev:sdb2
> [  120.750000]  disk 2, o:1, dev:sdc2
> [  120.750000] md:  adding sda1 ...
> [  120.750000] md: created md0
> [  120.750000] md: bind<sda1>
> [  120.750000] md: bind<sdb1>
> [  120.750000] md: running: <sdb1><sda1>
> [  120.760000] raid1: raid set md0 active with 2 out of 2 mirrors
> [  120.760000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.760000] end_request: I/O error, dev sdb, sector 19550919
> [  120.780000] RAID5 conf printout:
> [  120.780000]  --- rd:3 wd:2
> [  120.780000]  disk 0, o:1, dev:sda2
> [  120.780000]  disk 2, o:1, dev:sdc2
> [  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.780000] end_request: I/O error, dev sdb, sector 19550927
> [  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.780000] end_request: I/O error, dev sdb, sector 19550935
> [  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.780000] end_request: I/O error, dev sdb, sector 19550943
> [  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.780000] end_request: I/O error, dev sdb, sector 19550951
> [  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.780000] end_request: I/O error, dev sdb, sector 19550959
> [  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.780000] end_request: I/O error, dev sdb, sector 19550967
> [  120.790000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.790000] end_request: I/O error, dev sdb, sector 19550975
> [  120.790000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.790000] end_request: I/O error, dev sdb, sector 19550983
> [  120.790000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.790000] end_request: I/O error, dev sdb, sector 19550991
> [  120.790000] md0: bitmap initialized from disk: read 10/10 pages, set 0 bits
> [  120.790000] created bitmap (150 pages) for device md0
> [  120.790000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.790000] end_request: I/O error, dev sdb, sector 19550919
> [  120.790000] md: super_written gets error=-5, uptodate=0
> [  120.790000] raid1: Disk failure on sdb1, disabling device.
> [  120.790000]  Operation continuing on 1 devices
> [  120.810000] md: ... autorun DONE.
> [  120.810000] RAID1 conf printout:
> [  120.810000]  --- wd:1 rd:2
> [  120.810000]  disk 0, wo:0, o:1, dev:sda1
> [  120.810000]  disk 1, wo:1, o:0, dev:sdb1
> [  120.860000] RAID1 conf printout:
> [  120.860000]  --- wd:1 rd:2
> [  120.860000]  disk 0, wo:0, o:1, dev:sda1
> [  129.360000] Filesystem "dm-0": Disabling barriers, trial barrier write failed
> [  129.390000] XFS mounting filesystem dm-0
> [  129.600000] Ending clean XFS mount for filesystem: dm-0
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 625137153
> [  132.850000] Buffer I/O error on device sdb2, logical block 75698256
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 625137153
> [  132.850000] Buffer I/O error on device sdb2, logical block 75698256
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 625137153
> [  132.850000] Buffer I/O error on device sdb2, logical block 75698256
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 19551105
> [  132.850000] Buffer I/O error on device sdb2, logical block 0
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 19551113
> [  132.850000] Buffer I/O error on device sdb2, logical block 1
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 19551105
> [  132.850000] Buffer I/O error on device sdb2, logical block 0
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 19551105
> [  132.850000] Buffer I/O error on device sdb2, logical block 0
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 625137337
> [  132.850000] Buffer I/O error on device sdb2, logical block 75698279
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 625137337
> [  132.850000] Buffer I/O error on device sdb2, logical block 75698279
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 625137337
> [  132.850000] Buffer I/O error on device sdb2, logical block 75698279
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 625137337
> [  132.850000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  132.850000] end_request: I/O error, dev sdb, sector 625137337
> ...
> 
> After that the system booted up fine, only running with the two of
> three RAID drives.
> (sda is on sata_sil24, sdc on sata_nv. I used the sata_nv.swncq=1 switch)
> 
> The ugly:
> I wanted to verify that this was not a onetime bug and rebooted the system.
> This time md kicked sdb because it was stale and then also kicked sda
> with an error similar to the above. Which killed the RAID5 completely.
> :(
> At least I was able to resurrect it with mdadm --force.
> 
> So the sata_sil24 error seems repeatable, but also not limited to one
> specific port.
> 
> The system is now up again running 2.6.23-rc3-mm1 with all three drives.
> 
> Torsten

Re: 2.6.23-rc4-mm1

[Satyam Sharma]

On Sat, 1 Sep 2007, Herbert Xu wrote:

> On Fri, Aug 31, 2007 at 11:58:15PM -0700, Andrew Morton wrote:
> > 
> > > crypto/built-in.o: In function `update2':
> > > digest.c:(.text+0x94a): undefined reference to `crypto_km_types'
> > > digest.c:(.text+0x9bf): undefined reference to `crypto_km_types'
> > > 
> > > digest.c (CONFIG_CRYPTO) uses crypto/scatterwalk.c's object (CONFIG_CRYPTO_ALGAPI)
> > > I meet this when CONFIG_CRYPTO_ALGAPI=m. I need to make CONFIG_CRYPTO_ALGAPI=y.

Tangential, but I've often wondered what are the upsides of keeping
CONFIG_CRYPTO_ALGAPI as a separate config option in the first place? Every
single item in crypto/ ends up "select"ing it (directly or transitively)
so it makes all sense to just do away with it and keep it == CONFIG_CRYPTO
in the Makefile, thusly:


[PATCH] crypto: Remove CONFIG_CRYPTO_ALGAPI config option

Because all other options in crypto/ end up selecting it anyway. So let's
make it a default part of the rest of "core" crypto stuff, that gets built
whenever CONFIG_CRYPTO == y.

Signed-off-by: Satyam Sharma <satyam@infradead.org>

---

 arch/s390/crypto/Kconfig |    4 ----
 crypto/Kconfig           |   37 -------------------------------------
 crypto/Makefile          |    7 ++-----
 drivers/crypto/Kconfig   |    2 --
 4 files changed, 2 insertions(+), 48 deletions(-)

diff --git a/arch/s390/crypto/Kconfig b/arch/s390/crypto/Kconfig
index d1defbb..d35f901 100644
--- a/arch/s390/crypto/Kconfig
+++ b/arch/s390/crypto/Kconfig
@@ -1,7 +1,6 @@
 config CRYPTO_SHA1_S390
 	tristate "SHA1 digest algorithm"
 	depends on S390
-	select CRYPTO_ALGAPI
 	help
 	  This is the s390 hardware accelerated implementation of the
 	  SHA-1 secure hash standard (FIPS 180-1/DFIPS 180-2).
@@ -9,7 +8,6 @@ config CRYPTO_SHA1_S390
 config CRYPTO_SHA256_S390
 	tristate "SHA256 digest algorithm"
 	depends on S390
-	select CRYPTO_ALGAPI
 	help
 	  This is the s390 hardware accelerated implementation of the
 	  SHA256 secure hash standard (DFIPS 180-2).
@@ -20,7 +18,6 @@ config CRYPTO_SHA256_S390
 config CRYPTO_DES_S390
 	tristate "DES and Triple DES cipher algorithms"
 	depends on S390
-	select CRYPTO_ALGAPI
 	select CRYPTO_BLKCIPHER
 	help
 	  This us the s390 hardware accelerated implementation of the
@@ -29,7 +26,6 @@ config CRYPTO_DES_S390
 config CRYPTO_AES_S390
 	tristate "AES cipher algorithms"
 	depends on S390
-	select CRYPTO_ALGAPI
 	select CRYPTO_BLKCIPHER
 	help
 	  This is the s390 hardware accelerated implementation of the
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 3d1a1e2..0a52118 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -19,26 +19,18 @@ menuconfig CRYPTO
 
 if CRYPTO
 
-config CRYPTO_ALGAPI
-	tristate
-	help
-	  This option provides the API for cryptographic algorithms.
-
 config CRYPTO_ABLKCIPHER
 	tristate
 	select CRYPTO_BLKCIPHER
 
 config CRYPTO_BLKCIPHER
 	tristate
-	select CRYPTO_ALGAPI
 
 config CRYPTO_HASH
 	tristate
-	select CRYPTO_ALGAPI
 
 config CRYPTO_MANAGER
 	tristate "Cryptographic algorithm manager"
-	select CRYPTO_ALGAPI
 	help
 	  Create default cryptographic template instantiations such as
 	  cbc(aes).
@@ -64,31 +56,26 @@ config CRYPTO_XCBC
 
 config CRYPTO_NULL
 	tristate "Null algorithms"
-	select CRYPTO_ALGAPI
 	help
 	  These are 'Null' algorithms, used by IPsec, which do nothing.
 
 config CRYPTO_MD4
 	tristate "MD4 digest algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  MD4 message digest algorithm (RFC1320).
 
 config CRYPTO_MD5
 	tristate "MD5 digest algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  MD5 message digest algorithm (RFC1321).
 
 config CRYPTO_SHA1
 	tristate "SHA1 digest algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  SHA-1 secure hash standard (FIPS 180-1/DFIPS 180-2).
 
 config CRYPTO_SHA256
 	tristate "SHA256 digest algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  SHA256 secure hash standard (DFIPS 180-2).
 	  
@@ -97,7 +84,6 @@ config CRYPTO_SHA256
 
 config CRYPTO_SHA512
 	tristate "SHA384 and SHA512 digest algorithms"
-	select CRYPTO_ALGAPI
 	help
 	  SHA512 secure hash standard (DFIPS 180-2).
 	  
@@ -109,7 +95,6 @@ config CRYPTO_SHA512
 
 config CRYPTO_WP512
 	tristate "Whirlpool digest algorithms"
-	select CRYPTO_ALGAPI
 	help
 	  Whirlpool hash algorithm 512, 384 and 256-bit hashes
 
@@ -121,7 +106,6 @@ config CRYPTO_WP512
 
 config CRYPTO_TGR192
 	tristate "Tiger digest algorithms"
-	select CRYPTO_ALGAPI
 	help
 	  Tiger hash algorithm 192, 160 and 128-bit hashes
 
@@ -194,20 +178,17 @@ config CRYPTO_CRYPTD
 
 config CRYPTO_DES
 	tristate "DES and Triple DES EDE cipher algorithms"
-	select CRYPTO_ALGAPI
 	help
 	  DES cipher algorithm (FIPS 46-2), and Triple DES EDE (FIPS 46-3).
 
 config CRYPTO_FCRYPT
 	tristate "FCrypt cipher algorithm"
-	select CRYPTO_ALGAPI
 	select CRYPTO_BLKCIPHER
 	help
 	  FCrypt algorithm used by RxRPC.
 
 config CRYPTO_BLOWFISH
 	tristate "Blowfish cipher algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  Blowfish cipher algorithm, by Bruce Schneier.
 	  
@@ -220,7 +201,6 @@ config CRYPTO_BLOWFISH
 
 config CRYPTO_TWOFISH
 	tristate "Twofish cipher algorithm"
-	select CRYPTO_ALGAPI
 	select CRYPTO_TWOFISH_COMMON
 	help
 	  Twofish cipher algorithm.
@@ -242,7 +222,6 @@ config CRYPTO_TWOFISH_COMMON
 config CRYPTO_TWOFISH_586
 	tristate "Twofish cipher algorithms (i586)"
 	depends on (X86 || UML_X86) && !64BIT
-	select CRYPTO_ALGAPI
 	select CRYPTO_TWOFISH_COMMON
 	help
 	  Twofish cipher algorithm.
@@ -258,7 +237,6 @@ config CRYPTO_TWOFISH_586
 config CRYPTO_TWOFISH_X86_64
 	tristate "Twofish cipher algorithm (x86_64)"
 	depends on (X86 || UML_X86) && 64BIT
-	select CRYPTO_ALGAPI
 	select CRYPTO_TWOFISH_COMMON
 	help
 	  Twofish cipher algorithm (x86_64).
@@ -273,7 +251,6 @@ config CRYPTO_TWOFISH_X86_64
 
 config CRYPTO_SERPENT
 	tristate "Serpent cipher algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  Serpent cipher algorithm, by Anderson, Biham & Knudsen.
 
@@ -286,7 +263,6 @@ config CRYPTO_SERPENT
 
 config CRYPTO_AES
 	tristate "AES cipher algorithms"
-	select CRYPTO_ALGAPI
 	help
 	  AES cipher algorithms (FIPS-197). AES uses the Rijndael 
 	  algorithm.
@@ -307,7 +283,6 @@ config CRYPTO_AES
 config CRYPTO_AES_586
 	tristate "AES cipher algorithms (i586)"
 	depends on (X86 || UML_X86) && !64BIT
-	select CRYPTO_ALGAPI
 	help
 	  AES cipher algorithms (FIPS-197). AES uses the Rijndael 
 	  algorithm.
@@ -328,7 +303,6 @@ config CRYPTO_AES_586
 config CRYPTO_AES_X86_64
 	tristate "AES cipher algorithms (x86_64)"
 	depends on (X86 || UML_X86) && 64BIT
-	select CRYPTO_ALGAPI
 	help
 	  AES cipher algorithms (FIPS-197). AES uses the Rijndael 
 	  algorithm.
@@ -348,21 +322,18 @@ config CRYPTO_AES_X86_64
 
 config CRYPTO_CAST5
 	tristate "CAST5 (CAST-128) cipher algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  The CAST5 encryption algorithm (synonymous with CAST-128) is
 	  described in RFC2144.
 
 config CRYPTO_CAST6
 	tristate "CAST6 (CAST-256) cipher algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  The CAST6 encryption algorithm (synonymous with CAST-256) is
 	  described in RFC2612.
 
 config CRYPTO_TEA
 	tristate "TEA, XTEA and XETA cipher algorithms"
-	select CRYPTO_ALGAPI
 	help
 	  TEA cipher algorithm.
 
@@ -379,7 +350,6 @@ config CRYPTO_TEA
 
 config CRYPTO_ARC4
 	tristate "ARC4 cipher algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  ARC4 cipher algorithm.
 
@@ -390,7 +360,6 @@ config CRYPTO_ARC4
 
 config CRYPTO_KHAZAD
 	tristate "Khazad cipher algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  Khazad cipher algorithm.
 
@@ -403,7 +372,6 @@ config CRYPTO_KHAZAD
 
 config CRYPTO_ANUBIS
 	tristate "Anubis cipher algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  Anubis cipher algorithm.
 
@@ -418,7 +386,6 @@ config CRYPTO_ANUBIS
 
 config CRYPTO_DEFLATE
 	tristate "Deflate compression algorithm"
-	select CRYPTO_ALGAPI
 	select ZLIB_INFLATE
 	select ZLIB_DEFLATE
 	help
@@ -429,7 +396,6 @@ config CRYPTO_DEFLATE
 
 config CRYPTO_MICHAEL_MIC
 	tristate "Michael MIC keyed digest algorithm"
-	select CRYPTO_ALGAPI
 	help
 	  Michael MIC is used for message integrity protection in TKIP
 	  (IEEE 802.11i). This algorithm is required for TKIP, but it
@@ -438,7 +404,6 @@ config CRYPTO_MICHAEL_MIC
 
 config CRYPTO_CRC32C
 	tristate "CRC32c CRC algorithm"
-	select CRYPTO_ALGAPI
 	select LIBCRC32C
 	help
 	  Castagnoli, et al Cyclic Redundancy-Check Algorithm.  Used
@@ -449,7 +414,6 @@ config CRYPTO_CRC32C
 config CRYPTO_CAMELLIA
 	tristate "Camellia cipher algorithms"
 	depends on CRYPTO
-	select CRYPTO_ALGAPI
 	help
 	  Camellia cipher algorithms module.
 
@@ -464,7 +428,6 @@ config CRYPTO_CAMELLIA
 config CRYPTO_TEST
 	tristate "Testing module"
 	depends on m
-	select CRYPTO_ALGAPI
 	help
 	  Quick & dirty crypto test module.
 
diff --git a/crypto/Makefile b/crypto/Makefile
index 0cf17f1..a8ea4f6 100644
--- a/crypto/Makefile
+++ b/crypto/Makefile
@@ -2,11 +2,8 @@
 # Cryptographic API
 #
 
-obj-$(CONFIG_CRYPTO) += api.o scatterwalk.o cipher.o digest.o compress.o
-
-crypto_algapi-$(CONFIG_PROC_FS) += proc.o
-crypto_algapi-objs := algapi.o $(crypto_algapi-y)
-obj-$(CONFIG_CRYPTO_ALGAPI) += crypto_algapi.o
+obj-$(CONFIG_CRYPTO) += api.o scatterwalk.o cipher.o digest.o compress.o algapi.o
+obj-$(CONFIG_PROC_FS) += proc.o
 
 obj-$(CONFIG_CRYPTO_ABLKCIPHER) += ablkcipher.o
 obj-$(CONFIG_CRYPTO_BLKCIPHER) += blkcipher.o
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index c0fc4ae..90f6c6d 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -13,7 +13,6 @@ if CRYPTO_HW
 config CRYPTO_DEV_PADLOCK
 	tristate "Support for VIA PadLock ACE"
 	depends on X86_32
-	select CRYPTO_ALGAPI
 	default m
 	help
 	  Some VIA processors come with an integrated crypto engine
@@ -56,7 +55,6 @@ source "arch/s390/crypto/Kconfig"
 config CRYPTO_DEV_GEODE
 	tristate "Support for the Geode LX AES engine"
 	depends on X86_32 && PCI
-	select CRYPTO_ALGAPI
 	select CRYPTO_BLKCIPHER
 	default m
 	help

Re: 2.6.23-rc4-mm1

[Herbert Xu]

On Sun, Sep 02, 2007 at 02:39:15AM +0530, Satyam Sharma wrote:
> 
> Tangential, but I've often wondered what are the upsides of keeping
> CONFIG_CRYPTO_ALGAPI as a separate config option in the first place? Every
> single item in crypto/ ends up "select"ing it (directly or transitively)
> so it makes all sense to just do away with it and keep it == CONFIG_CRYPTO
> in the Makefile, thusly:

NACK.  ALGAPI exists so that it can be built as a module, as
opposed to CRYPTO which is always built-in.  It's already
invisible to the user so I don't see why you have a problem
with it.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: 2.6.23-rc4-mm1

[Satyam Sharma]

On Sun, 2 Sep 2007, Herbert Xu wrote:
> 
> On Sun, Sep 02, 2007 at 02:39:15AM +0530, Satyam Sharma wrote:
> > 
> > Tangential, but I've often wondered what are the upsides of keeping
> > CONFIG_CRYPTO_ALGAPI as a separate config option in the first place? Every
> > single item in crypto/ ends up "select"ing it (directly or transitively)
> > so it makes all sense to just do away with it and keep it == CONFIG_CRYPTO
> > in the Makefile, thusly:
> 
> NACK.  ALGAPI exists so that it can be built as a module, as
> opposed to CRYPTO which is always built-in.

I had already noticed that, and was even *expecting* you to reply with
*exactly* this ;-)

[ BTW CRYPTO is _not_ always built-in -- but only when CONFIG_CRYPTO=y ]

Anyway, the natural follow-up to your argument is -- why is the other
stuff in CRYPTO always built-in too ?

Take the crypto_alloc_xxx() callchain for example (I chose it because
it is the _first_ call any cryptoapi user ever has to make, and hence
it's the one that deals with module-loading stuff).

So what finally got exported out of crypto/ to the rest of the kernel
was just the crypto_alloc_xxx() wrapper. That resolves to a call to
crypto_alloc_base() in crypto/api.c, which first loads the specific
low-level algo modules, and then proceeds to crypto_init_ops(), which
itself may, say, resolve to a crypto_init_digest_ops() -- the only
interface exported from digest.c.

The point is, because the module-loading (if necessary) already takes
place before the call to digest.c is made, there is _no_ reason why
even digest.c can't be made modular -- or _any_ of the other CRYPTO
stuff (with the exception of api.c itself, of course) that "always
gets built-in" as you mentioned above.

And so caring about the optimization of making ALGAPI modular rather
than simply built-in with rest of "core" crypto stuff such as digest.c
(which could _also_ have been made modular by the same logic but wasn't)
sounds like a bogus argument to me. [ BTW did you notice that the
__crypto_alloc_tfm() has been EXPORT_SYMBOL'ed _only_ because of one
solitary modular-callsite in algapi.c ? ]


Satyam

Re: 2.6.23-rc4-mm1

[Mats Johannesson]

On 2007-09-01 16:07:48 Torsten Kaiser wrote:
[...]
> The good:
>> +hpet-force-enable-on-vt8235-37-chipsets.patch
>> +hpet-force-enable-on-vt8235-37-chipsets-fix.patch
>
> Kernel 2.6.23-rc4-mm1 works on one of my systems with:
> 00:00.0 Host bridge: VIA Technologies, Inc. VT8385 [K8T800 AGP] Host
> Bridge (rev 01)
> 00:01.0 PCI bridge: VIA Technologies, Inc. VT8237 PCI bridge
> [K8T800/K8T890 South]

And glory, glory, my Acer Aspire 1520 (1524) AMD64 notebook with the
old vt8235 chipset got a good kick in the behind as well. I didn't
even enable anything hpet related in the .config:

root@sleipner:~# grep -i hpet /var/log/kern.log
Sep  2 05:36:59 sleipner kernel: Force enabled HPET at base address
0xfed00000
Sep  2 05:36:59 sleipner kernel: hpet clockevent registered
Sep  2 05:37:13 sleipner kernel: Time: hpet clocksource has been
installed.

root@sleipner:~# cat /proc/timer_list
[...]
Tick Device: mode:     1
Clock Event Device: hpet
 max_delta_ns:   149983015715
 min_delta_ns:   3352
 mult:           61496110
 shift:          32
 mode:           1
 next_event:     9223372036854775807 nsecs
 set_next_event: <ffffffff8021198a>
 set_mode:       <ffffffff802119be>
 event_handler:  <ffffffff80242c6a>
tick_broadcast_mask: 00000000
tick_broadcast_oneshot_mask: 00000000

For the benefit of Andreas Mohr (and other interested parties) I now
follow the instructions in "HPET force-enable investigations on Via
VT8235 (was: Re: extra"
http://marc.info/?l=linux-kernel&m=118643307224094&w=2

Diff for easy comparison:

--- lspci-d-1106-3177-xxx-23-rc4.txt
+++ lspci-d-1106-3177-xxx-23-rc4-mm1.txt
@@ -5,10 +5,10 @@
 30: 00 00 00 00 c0 00 00 00 00 00 00 00 00 00 00 00
 40: 44 80 f0 0b a0 0b 10 00 8c 20 00 00 04 00 00 08
 50: 01 08 09 00 00 00 00 00 43 9e 00 0a 10 fe 00 fe
-60: 00 00 60 00 01 60 0b 04 00 00 00 00 00 00 00 00
+60: 00 00 60 00 01 60 0b 04 80 00 d0 fe 00 00 00 00
 70: 06 11 77 31 00 00 00 00 00 00 00 00 20 00 00 00
 80: 00 84 59 00 da 40 00 00 01 40 00 00 00 18 00 00
-90: 00 75 0f 00 90 c1 07 00 00 3d 0f 00 00 00 00 00
+90: 00 75 0f 00 90 c1 07 00 00 3d 10 00 00 00 00 00
 a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 c0: 01 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00

Full dumps:

(On 2.6.23-rc4): lspci -d 1106:3177 -xxx
00:11.0 ISA bridge: VIA Technologies, Inc. VT8235 ISA Bridge
00: 06 11 77 31 87 00 10 02 00 00 01 06 00 00 80 00
10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 06 11 77 31
30: 00 00 00 00 c0 00 00 00 00 00 00 00 00 00 00 00
40: 44 80 f0 0b a0 0b 10 00 8c 20 00 00 04 00 00 08
50: 01 08 09 00 00 00 00 00 43 9e 00 0a 10 fe 00 fe
60: 00 00 60 00 01 60 0b 04 00 00 00 00 00 00 00 00
70: 06 11 77 31 00 00 00 00 00 00 00 00 20 00 00 00
80: 00 84 59 00 da 40 00 00 01 40 00 00 00 18 00 00
90: 00 75 0f 00 90 c1 07 00 00 3d 0f 00 00 00 00 00
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
c0: 01 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00
d0: 01 81 01 00 00 00 00 00 00 00 00 00 00 00 00 00
e0: 00 00 00 00 44 00 00 00 00 00 00 00 04 00 00 00
f0: 00 00 00 00 00 00 1b 00 00 00 00 00 01 00 00 00

(On 2.6.23-rc4-mm1): lspci -d 1106:3177 -xxx
00:11.0 ISA bridge: VIA Technologies, Inc. VT8235 ISA Bridge
00: 06 11 77 31 87 00 10 02 00 00 01 06 00 00 80 00
10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 06 11 77 31
30: 00 00 00 00 c0 00 00 00 00 00 00 00 00 00 00 00
40: 44 80 f0 0b a0 0b 10 00 8c 20 00 00 04 00 00 08
50: 01 08 09 00 00 00 00 00 43 9e 00 0a 10 fe 00 fe
60: 00 00 60 00 01 60 0b 04 80 00 d0 fe 00 00 00 00
70: 06 11 77 31 00 00 00 00 00 00 00 00 20 00 00 00
80: 00 84 59 00 da 40 00 00 01 40 00 00 00 18 00 00
90: 00 75 0f 00 90 c1 07 00 00 3d 10 00 00 00 00 00
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
c0: 01 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00
d0: 01 81 01 00 00 00 00 00 00 00 00 00 00 00 00 00
e0: 00 00 00 00 44 00 00 00 00 00 00 00 04 00 00 00
f0: 00 00 00 00 00 00 1b 00 00 00 00 00 01 00 00 00

And a full "lspci -nn":

00:00.0 Host bridge [0600]: VIA Technologies, Inc. K8M800 Host Bridge
[1106:0204]
00:00.1 Host bridge [0600]: VIA Technologies, Inc. K8M800 Host Bridge
[1106:1204]
00:00.2 Host bridge [0600]: VIA Technologies, Inc. K8M800 Host Bridge
[1106:2204]
00:00.3 Host bridge [0600]: VIA Technologies, Inc. K8M800 Host Bridge
[1106:3204]
00:00.4 Host bridge [0600]: VIA Technologies, Inc. K8M800 Host Bridge
[1106:4204]
00:00.7 Host bridge [0600]: VIA Technologies, Inc. K8M800 Host Bridge
[1106:7204]
00:01.0 PCI bridge [0604]: VIA Technologies, Inc. VT8237 PCI bridge
[K8T800/K8T890 South] [1106:b188]
00:0a.0 Ethernet controller [0200]: Linksys, A Division of Cisco
Systems [AirConn] INPROCOMM IPN 2220 Wireless LAN Adapter (rev 01)
[17fe:2220]
00:0b.0 CardBus bridge [0607]: Texas Instruments PCI7420 CardBus
Controller [104c:ac8e]
00:0b.1 CardBus bridge [0607]: Texas Instruments PCI7420 CardBus
Controller [104c:ac8e]
00:0b.2 FireWire (IEEE 1394) [0c00]: Texas Instruments PCI7x20
1394a-2000 OHCI Two-Port PHY/Link-Layer Controller [104c:802e]
00:0c.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
RTL-8169 Gigabit Ethernet [10ec:8169] (rev 10)
00:10.0 USB Controller [0c03]: VIA Technologies, Inc. VT82xxxxx UHCI
USB 1.1 Controller [1106:3038] (rev 80)
00:10.1 USB Controller [0c03]: VIA Technologies, Inc. VT82xxxxx UHCI
USB 1.1 Controller [1106:3038] (rev 80)
00:10.2 USB Controller [0c03]: VIA Technologies, Inc. VT82xxxxx UHCI
USB 1.1 Controller [1106:3038] (rev 80)
00:10.3 USB Controller [0c03]: VIA Technologies, Inc. USB 2.0
[1106:3104] (rev 82)
00:11.0 ISA bridge [0601]: VIA Technologies, Inc. VT8235 ISA Bridge
[1106:3177]
00:11.1 IDE interface [0101]: VIA Technologies, Inc.
VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE [1106:0571]
(rev 06)
00:11.5 Multimedia audio controller [0401]: VIA Technologies, Inc.
VT8233/A/8235/8237 AC97 Audio Controller [1106:3059] (rev 50)
00:11.6 Communication controller [0780]: VIA Technologies, Inc. AC'97
Modem Controller [1106:3068] (rev 80)
00:18.0 Host bridge [0600]: Advanced Micro Devices [AMD] K8
[Athlon64/Opteron] HyperTransport Technology Configuration [1022:1100]
00:18.1 Host bridge [0600]: Advanced Micro Devices [AMD] K8
[Athlon64/Opteron] Address Map [1022:1101]
00:18.2 Host bridge [0600]: Advanced Micro Devices [AMD] K8
[Athlon64/Opteron] DRAM Controller [1022:1102]
00:18.3 Host bridge [0600]: Advanced Micro Devices [AMD] K8
[Athlon64/Opteron] Miscellaneous Control [1022:1103]
01:00.0 VGA compatible controller [0300]: nVidia Corporation NV36
[GeForce FX Go5700] [10de:0347] (rev a1)

Mvh
Mats Johannesson

Re: 2.6.23-rc4-mm1

[Herbert Xu]

On Sun, Sep 02, 2007 at 08:22:42AM +0530, Satyam Sharma wrote:
>
> So what finally got exported out of crypto/ to the rest of the kernel
> was just the crypto_alloc_xxx() wrapper. That resolves to a call to
> crypto_alloc_base() in crypto/api.c, which first loads the specific
> low-level algo modules, and then proceeds to crypto_init_ops(), which
> itself may, say, resolve to a crypto_init_digest_ops() -- the only
> interface exported from digest.c.

The mid-level code such as digest.c are only built-in because
they are legacy code.  All the new mid-level code such as
blkcipher/hash are registered dynamically.

Once all the digest stuff have been converted to hash digest.c
will be removed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: 2.6.23-rc4-mm1

[Randy Dunlap]

On Fri, 31 Aug 2007 21:58:22 -0700 Andrew Morton wrote:

> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/
> 
> Changes since 2.6.23-rc3-mm1:
> 
>  git-watchdog.patch


on x86_64:
drivers/watchdog/core/watchdog_dev.c:84: warning: format '%i' expects type 'int', but argument 5 has type 'size_t'


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: 2.6.23-rc4-mm1

[Nicolas Mailhot]

Mats Johannesson <spamcan <at> bredband.net> writes:

> 
> On 2007-09-01 16:07:48 Torsten Kaiser wrote:
> [...]
> > The good:
> >> +hpet-force-enable-on-vt8235-37-chipsets.patch
> >> +hpet-force-enable-on-vt8235-37-chipsets-fix.patch
> >
> > Kernel 2.6.23-rc4-mm1 works on one of my systems with:
> > 00:00.0 Host bridge: VIA Technologies, Inc. VT8385 [K8T800 AGP] Host
> > Bridge (rev 01)
> > 00:01.0 PCI bridge: VIA Technologies, Inc. VT8237 PCI bridge
> > [K8T800/K8T890 South]
> 
> And glory, glory, my Acer Aspire 1520 (1524) AMD64 notebook with the
> old vt8235 chipset got a good kick in the behind as well. 

Now we have working HPET override for Intel and Via, could Nvidia users be
considered too? The required info has been known for ages:

http://marc.info/?l=linux-kernel&m=117679014505031

Regards,

-- 
Nicolas Mailhot

Re: 2.6.23-rc4-mm1

[Wim Van Sebroeck]

Hi Randy,

> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/
> > 
> > Changes since 2.6.23-rc3-mm1:
> > 
> >  git-watchdog.patch
> 
> 
> on x86_64:
> drivers/watchdog/core/watchdog_dev.c:84: warning: format '%i' expects type 'int', but argument 5 has type 'size_t'

I'll have a look at it.

Greetings,
Wim.

Re: 2.6.23-rc4-mm1

[Satyam Sharma]

Hi,


On Mon, 3 Sep 2007, Wim Van Sebroeck wrote:
> 
> > 
> > on x86_64:
> > drivers/watchdog/core/watchdog_dev.c:84:
> > warning: format '%i' expects type 'int', but argument 5 has type 'size_t'

Hmm, a warning I missed during my Sunday evening pastime.

> I'll have a look at it.

How about ... (unrelated cleanup thrown in, but SCNR)



* Fix this warning:

  drivers/watchdog/core/watchdog_dev.c:84:
  warning: format '%i' expects type 'int', but argument 5 has type 'size_t'

* CONFIG_xxx options are directly usable by preprocessor directives.

Signed-off-by: Satyam Sharma <satyam@infradead.org>

---

 drivers/watchdog/core/Makefile       |    5 -----
 drivers/watchdog/core/watchdog_dev.c |    6 +++---
 2 files changed, 3 insertions(+), 8 deletions(-)

--- linux-2.6.23-rc4-mm1/drivers/watchdog/core/Makefile~fix	2007-09-04 03:12:27.000000000 +0530
+++ linux-2.6.23-rc4-mm1/drivers/watchdog/core/Makefile	2007-09-04 03:12:45.000000000 +0530
@@ -4,8 +4,3 @@
 
 # The Generic Watchdog Driver
 obj-$(CONFIG_WATCHDOG_CORE)		+= watchdog_core.o watchdog_dev.o
-
-ifeq ($(CONFIG_WATCHDOG_DEBUG_CORE), y)
-EXTRA_CFLAGS += -DDEBUG
-endif
-
--- linux-2.6.23-rc4-mm1/drivers/watchdog/core/watchdog_dev.c~fix	2007-09-04 02:37:12.000000000 +0530
+++ linux-2.6.23-rc4-mm1/drivers/watchdog/core/watchdog_dev.c	2007-09-04 03:10:58.000000000 +0530
@@ -36,7 +36,7 @@
 #include <linux/init.h>		/* For __init/__exit/... */
 #include <linux/uaccess.h>	/* For copy_to_user/put_user/... */
 
-#ifdef DEBUG
+#ifdef CONFIG_WATCHDOG_DEBUG_CORE
 #define trace(format, args...) \
 	printk(KERN_INFO "%s(" format ")\n", __FUNCTION__ , ## args)
 #define dbg(format, arg...) \
@@ -81,7 +81,7 @@ static DEFINE_MUTEX(watchdog_register_mt
 static ssize_t watchdog_write(struct file *file, const char __user *data,
 				size_t len, loff_t *ppos)
 {
-	trace("%p, %p, %i, %p", file, data, len, ppos);
+	trace("%p, %p, %zu, %p", file, data, len, ppos);
 
 	if (!watchdogdev ||
 	    !watchdogdev->watchdog_ops ||
@@ -144,7 +144,7 @@ static int watchdog_ioctl(struct inode *
 		.identity =		"Watchdog Device",
 	};
 
-	trace("%p, %p, %i, %li", inode, file, cmd, arg);
+	trace("%p, %p, %u, %li", inode, file, cmd, arg);
 
 	if (!watchdogdev || !watchdogdev->watchdog_ops)
 		return -ENODEV;

Re: 2.6.23-rc4-mm1

[Alistair John Strachan]

On Monday 03 September 2007 09:06:25 Nicolas Mailhot wrote:
> Mats Johannesson <spamcan <at> bredband.net> writes:
> > On 2007-09-01 16:07:48 Torsten Kaiser wrote:
> > [...]
> >
> > > The good:
> > >> +hpet-force-enable-on-vt8235-37-chipsets.patch
> > >> +hpet-force-enable-on-vt8235-37-chipsets-fix.patch
> > >
> > > Kernel 2.6.23-rc4-mm1 works on one of my systems with:
> > > 00:00.0 Host bridge: VIA Technologies, Inc. VT8385 [K8T800 AGP] Host
> > > Bridge (rev 01)
> > > 00:01.0 PCI bridge: VIA Technologies, Inc. VT8237 PCI bridge
> > > [K8T800/K8T890 South]
> >
> > And glory, glory, my Acer Aspire 1520 (1524) AMD64 notebook with the
> > old vt8235 chipset got a good kick in the behind as well.
>
> Now we have working HPET override for Intel and Via, could Nvidia users be
> considered too? The required info has been known for ages:
>
> http://marc.info/?l=linux-kernel&m=117679014505031

Seconded. It's been largely ignored which is annoying because the HPET works 
perfectly on this board. I assume the reason is still that nobody from NVIDIA 
verified hardward support for the hack.

-- 
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.

Re: 2.6.23-rc4-mm1

[Andi Kleen]

> Seconded. It's been largely ignored which is annoying because the HPET
> works perfectly on this board. I assume the reason is still that nobody
> from NVIDIA verified hardward support for the hack.

It's IMHO a bad idea to add any overrides without access to data sheets
and errata sheets. The hardware might be broken and do bad
(subtle) bad things with HPET.  That's not a theoretical case.
There used to be at least one case where a chipset would occasionally
destroy the BIOS flash when HPET was force enabled.

That means for Intel it's fine to do (because errata sheets are public); but 
for Nvidia and VIA it's dangerous and should not be done.

-Andi

Re: 2.6.23-rc4-mm1

[Alistair John Strachan]

On Tuesday 04 September 2007 16:26:27 Andi Kleen wrote:
> > Seconded. It's been largely ignored which is annoying because the HPET
> > works perfectly on this board. I assume the reason is still that nobody
> > from NVIDIA verified hardward support for the hack.
>
> It's IMHO a bad idea to add any overrides without access to data sheets
> and errata sheets. The hardware might be broken and do bad
> (subtle) bad things with HPET.  That's not a theoretical case.
> There used to be at least one case where a chipset would occasionally
> destroy the BIOS flash when HPET was force enabled.

I haven't used any CK804 with an HPET which is BIOS enabled by default, so 
it's probably most likely that the reference BIOS didn't enable it.

As this technology is quite antiquated, the usual "well Vista uses HPET, so 
maybe vendors will enable it" probably won't apply. I know for my board, no 
BIOS has been released since early 2006.

> That means for Intel it's fine to do (because errata sheets are public);
> but for Nvidia and VIA it's dangerous and should not be done.

I don't disagree with you and I think you're right in the general case, but 
even if we could pin somebody down from NVIDIA (which is seeming unlikely, 
considering the right people have already been CCed), it would still be a 
BIOS override.

In this case,  there's a perfectly good HPET masked behind what I can only 
speculate is a BIOS misfeature (my kernel's behaved itself with Mikko's patch 
applied and Thomas's HRT patchset on x86-64).

What about an expert option which could force the HPET on (rather than "find" 
and enable it)? Are you opposed to this too?

-- 
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.

Re: 2.6.23-rc4-mm1

[Zach Carter]

> +ioc3-program-uart-predividers.patch
> +sky2-fe-chip-support.patch
> +sky2-use-debugfs-rename.patch
> +sky2-document-gphy_ctrl-bits.patch
> +sky2-dont-restrict-config-space-access.patch
> +sky2-advanced-error-reporting.patch
> +sky2-use-pci_config-access-functions.patch
> +sky2-use-net_device-internal-stats.patch
> +ktime_sub_ns-analog-of-ktime_add_ns.patch
> +export-reciprocal_value-for-modules.patch
> +sky2-hardware-receive-timestamp-counter.patch
> +sky2-avoid-divide-in-receive-path.patch
> +sky2-118.patch

Folks,

I've got these messages since installing 2.6.23-rc4-mm1:

sky2 0000:07:00.0: error interrupt status=0x80000000
printk: 4 messages suppressed.
sky2 0000:07:00.0: error interrupt status=0x80000000
printk: 4 messages suppressed.
sky2 0000:07:00.0: error interrupt status=0x80000000
printk: 4 messages suppressed.
sky2 0000:07:00.0: error interrupt status=0x80000000
printk: 4 messages suppressed.
sky2 0000:07:00.0: error interrupt status=0x80000000
printk: 5 messages suppressed.
sky2 0000:07:00.0: error interrupt status=0x80000000
printk: 5 messages suppressed.
sky2 0000:07:00.0: error interrupt status=0x80000000
printk: 4 messages suppressed.
sky2 0000:07:00.0: error interrupt status=0x80000000
printk: 4 messages suppressed.
sky2 0000:07:00.0: error interrupt status=0x80000000
printk: 4 messages suppressed.
sky2 0000:07:00.0: error interrupt status=0x80000000

The laptop is a Sony VAIO SZ430N/B

Despite the errors, the interface appears to be working well enough.

I'd be happy to supply additional information, try out patches, or 
submit a bugzilla if needed.

thanks!

-Zach

Re: 2.6.23-rc4-mm1

[Wim Van Sebroeck]

Hi,

> * Fix this warning:
> 
>   drivers/watchdog/core/watchdog_dev.c:84:
>   warning: format '%i' expects type 'int', but argument 5 has type 'size_t'
> 
> * CONFIG_xxx options are directly usable by preprocessor directives.

Patch works for me. I applied it to the linux-2.6-watchdog-mm tree.

Greetings,
Wim.

Re: 2.6.23-rc4-mm1

[Stephen Hemminger]

On Tue, 4 Sep 2007 10:54:32 -0700
Zach Carter <linux@zachcarter.com> wrote:

> 
> > +ioc3-program-uart-predividers.patch
> > +sky2-fe-chip-support.patch
> > +sky2-use-debugfs-rename.patch
> > +sky2-document-gphy_ctrl-bits.patch
> > +sky2-dont-restrict-config-space-access.patch
> > +sky2-advanced-error-reporting.patch
> > +sky2-use-pci_config-access-functions.patch
> > +sky2-use-net_device-internal-stats.patch
> > +ktime_sub_ns-analog-of-ktime_add_ns.patch
> > +export-reciprocal_value-for-modules.patch
> > +sky2-hardware-receive-timestamp-counter.patch

I already told Andrew to please drop this last patch, because
it causes interrupt messages. It seems masking off the IRQ
in hardware doesn't prevent that interrupt!

Re: 2.6.23-rc4-mm1

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 2786 bytes --]

On Fri, 31 Aug 2007 21:58:22 PDT, Andrew Morton said:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/

(Warning - if discussion of binary modules bothers you, hit delete now..)

Dell Latitude D840, x86_64 kernel

memory-controller-memory-accounting-v7.patch causes the NVidia graphics driver
to go into a soft-lockup:

BUG: soft lockup - CPU#0 stuck for 11s! [X:2733]
CPU 0:
Modules linked in: irnet ppp_generic slhc irtty_sir sir_dev ircomm_tty ircomm irda crc_ccitt nf_conntrack_ftp xt_pkttype ipt_REJECT ipt_osf nf_conntrack_ipv4 xt_ipisforif ipt_recent ipt_LOG xt_u32 iptable_filter ip_tables xt_tcpudp nf_conntrack_ipv6 xt_state nf_conntrack nfnetlink ip6t_LOG xt_limit ip6table_filter ip6_tables x_tables vmnet(P)(U) vmmon(U) sha256 aes fan container bay acpi_cpufreq nvram arc4 ecb pcmcia iwl3945 firmware_class yenta_socket nvidia(P)(U) mac80211 iTCO_wdt rsrc_nonstatic iTCO_vendor_support ohci1394 watchdog_core ieee1394 watchdog_dev pcmcia_core cfg80211 video thermal output button battery processor ac intel_agp rtc
Pid: 2733, comm: X Tainted: P        2.6.23-rc4-mm1 #1
RIP: 0010:[<ffffffff80520e16>]  [<ffffffff80520e16>] _spin_lock+0x5b/0x75
RSP: 0018:ffff810007ecdcf8  EFLAGS: 00000202
RAX: 0000000000000000 RBX: ffff810007ecdd08 RCX: 0000000000000173
RDX: ffff8100040fe000 RSI: 00007f3cbf672000 RDI: ffff81000111ec90
RBP: 0000000000000006 R08: ffffffff80687d85 R09: 0000000000010000
R10: ffff810007ecdd60 R11: 00000001000355e8 R12: 00000000000002c7
R13: 0000000000000000 R14: 000000000000000a R15: 0000000000000002
FS:  00007f3cbf65f780(0000) GS:ffffffff806c6000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 00007f3cbc83d540 CR3: 00000000046af000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400

Call Trace:
[<ffffffff8027b358>] get_locked_pte+0x100/0x114
[<ffffffff8027b3d5>] vm_insert_page+0x69/0x100
[<ffffffff8841e5f8>] :nvidia:nv_kern_mmap+0x712/0x7c0
[<ffffffff8027ec71>] mmap_region+0x222/0x426
[<ffffffff80327dc6>] selinux_file_mmap+0x7d/0x8a
[<ffffffff8027f489>] do_mmap_pgoff+0x2c6/0x32d
[<ffffffff805204ce>] __down_write_nested+0x3d/0xab
[<ffffffff80211d3f>] sys_mmap+0x90/0x119
[<ffffffff8020c2ec>] tracesys+0xdc/0xe1

The only reason that it's at all noteworthy is because the kernel is built
with CONFIG_CONTAINERS=n and the patch *looks* like it tries very hard to
make zero changes in code logic in that case.  I've been looking at it for
a few days and totally failing to see what changed behavior is causing the
problem.  There's a change to unuse_pte() to return a -ENOMEM, but that's
conditioned off a mem_container_charge() that should optimize itself to '0'.


[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.23-rc4-mm1

[Andrew Morton]

> On Wed, 05 Sep 2007 10:37:40 -0400 Valdis.Kletnieks@vt.edu wrote:
> On Fri, 31 Aug 2007 21:58:22 PDT, Andrew Morton said:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/
> 
> (Warning - if discussion of binary modules bothers you, hit delete now..)

It's legitimate.  That change was supposed to be a no-op.

Thanks for reporting.

> Dell Latitude D840, x86_64 kernel
> 
> memory-controller-memory-accounting-v7.patch causes the NVidia graphics driver
> to go into a soft-lockup:

(is it not a bit weird from a namin POV that we have
mem_container_charge(page, mm) and mem_container_uncharge_page(page)?)


> BUG: soft lockup - CPU#0 stuck for 11s! [X:2733]
> CPU 0:
> Modules linked in: irnet ppp_generic slhc irtty_sir sir_dev ircomm_tty ircomm irda crc_ccitt nf_conntrack_ftp xt_pkttype ipt_REJECT ipt_osf nf_conntrack_ipv4 xt_ipisforif ipt_recent ipt_LOG xt_u32 iptable_filter ip_tables xt_tcpudp nf_conntrack_ipv6 xt_state nf_conntrack nfnetlink ip6t_LOG xt_limit ip6table_filter ip6_tables x_tables vmnet(P)(U) vmmon(U) sha256 aes fan container bay acpi_cpufreq nvram arc4 ecb pcmcia iwl3945 firmware_class yenta_socket nvidia(P)(U) mac80211 iTCO_wdt rsrc_nonstatic iTCO_vendor_support ohci1394 watchdog_core ieee1394 watchdog_dev pcmcia_core cfg80211 video thermal output button battery processor ac intel_agp rtc

Seems to me that there's a missing pte_unmap_lock() in insert_page().

Also, a hunk in do_anonymous_page() is indented one tabstop too far, which
makes me suspect that patch(1) might have put it in the wrong place. 
Balbir, can you please check that?

diff -puN mm/memory.c~memory-controller-memory-accounting-v7-fix mm/memory.c
--- a/mm/memory.c~memory-controller-memory-accounting-v7-fix
+++ a/mm/memory.c
@@ -1135,7 +1135,7 @@ static int insert_page(struct mm_struct 
 {
 	int retval;
 	pte_t *pte;
-	spinlock_t *ptl;  
+	spinlock_t *ptl;
 
 	retval = mem_container_charge(page, mm);
 	if (retval)
@@ -1160,6 +1160,7 @@ static int insert_page(struct mm_struct 
 	set_pte_at(mm, addr, pte, mk_pte(page, prot));
 
 	retval = 0;
+	pte_unmap_unlock(pte, ptl);
 	return retval;
 out_unlock:
 	pte_unmap_unlock(pte, ptl);
@@ -2184,8 +2185,8 @@ static int do_anonymous_page(struct mm_s
 	if (!page)
 		goto oom;
 
-		if (mem_container_charge(page, mm))
-			goto oom_free_page;
+	if (mem_container_charge(page, mm))
+		goto oom_free_page;
 
 	entry = mk_pte(page, vma->vm_page_prot);
 	entry = maybe_mkwrite(pte_mkdirty(entry), vma);
_

Re: 2.6.23-rc4-mm1

[Balbir Singh]

Andrew Morton wrote:
>> On Wed, 05 Sep 2007 10:37:40 -0400 Valdis.Kletnieks@vt.edu wrote:
>> On Fri, 31 Aug 2007 21:58:22 PDT, Andrew Morton said:
>>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/
>> (Warning - if discussion of binary modules bothers you, hit delete now..)
> 
> It's legitimate.  That change was supposed to be a no-op.
> 
> Thanks for reporting.
> 
>> Dell Latitude D840, x86_64 kernel
>>
>> memory-controller-memory-accounting-v7.patch causes the NVidia graphics driver
>> to go into a soft-lockup:
> 
> (is it not a bit weird from a namin POV that we have
> mem_container_charge(page, mm) and mem_container_uncharge_page(page)?)
> 
> 
>> BUG: soft lockup - CPU#0 stuck for 11s! [X:2733]
>> CPU 0:
>> Modules linked in: irnet ppp_generic slhc irtty_sir sir_dev ircomm_tty ircomm irda crc_ccitt nf_conntrack_ftp xt_pkttype ipt_REJECT ipt_osf nf_conntrack_ipv4 xt_ipisforif ipt_recent ipt_LOG xt_u32 iptable_filter ip_tables xt_tcpudp nf_conntrack_ipv6 xt_state nf_conntrack nfnetlink ip6t_LOG xt_limit ip6table_filter ip6_tables x_tables vmnet(P)(U) vmmon(U) sha256 aes fan container bay acpi_cpufreq nvram arc4 ecb pcmcia iwl3945 firmware_class yenta_socket nvidia(P)(U) mac80211 iTCO_wdt rsrc_nonstatic iTCO_vendor_support ohci1394 watchdog_core ieee1394 watchdog_dev pcmcia_core cfg80211 video thermal output button battery processor ac intel_agp rtc
> 
> Seems to me that there's a missing pte_unmap_lock() in insert_page().
> 
> Also, a hunk in do_anonymous_page() is indented one tabstop too far, which
> makes me suspect that patch(1) might have put it in the wrong place. 
> Balbir, can you please check that?
> 
> diff -puN mm/memory.c~memory-controller-memory-accounting-v7-fix mm/memory.c
> --- a/mm/memory.c~memory-controller-memory-accounting-v7-fix
> +++ a/mm/memory.c
> @@ -1135,7 +1135,7 @@ static int insert_page(struct mm_struct 
>  {
>  	int retval;
>  	pte_t *pte;
> -	spinlock_t *ptl;  
> +	spinlock_t *ptl;
> 
>  	retval = mem_container_charge(page, mm);
>  	if (retval)
> @@ -1160,6 +1160,7 @@ static int insert_page(struct mm_struct 
>  	set_pte_at(mm, addr, pte, mk_pte(page, prot));
> 
>  	retval = 0;
> +	pte_unmap_unlock(pte, ptl);
>  	return retval;

Wonderful! Thanks Andrew!

>  out_unlock:
>  	pte_unmap_unlock(pte, ptl);
> @@ -2184,8 +2185,8 @@ static int do_anonymous_page(struct mm_s
>  	if (!page)
>  		goto oom;
> 
> -		if (mem_container_charge(page, mm))
> -			goto oom_free_page;
> +	if (mem_container_charge(page, mm))
> +		goto oom_free_page;
> 
>  	entry = mk_pte(page, vma->vm_page_prot);
>  	entry = maybe_mkwrite(pte_mkdirty(entry), vma);
> _
> 

Yes, this fix looks right as well.

Thanks for catching them so quickly.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

Re: 2.6.23-rc4-mm1

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

On Wed, 05 Sep 2007 08:12:07 PDT, Andrew Morton said:

> Seems to me that there's a missing pte_unmap_lock() in insert_page().
> 
> Also, a hunk in do_anonymous_page() is indented one tabstop too far, which
> makes me suspect that patch(1) might have put it in the wrong place. 
> Balbir, can you please check that?
> 
> diff -puN mm/memory.c~memory-controller-memory-accounting-v7-fix mm/memory.c
> --- a/mm/memory.c~memory-controller-memory-accounting-v7-fix
> +++ a/mm/memory.c
> @@ -1135,7 +1135,7 @@ static int insert_page(struct mm_struct 

Confirming that this patch fixes things.

Tested-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.23-rc4-mm1

[Mel Gorman]

(To list based on CC's in net-add-ath5k-wireless-driver-fix.patch . If
that is in error, apologies)

On (31/08/07 21:58), Andrew Morton didst pronounce:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/
> 

I thought I would give the ath5k driver a shot on my Thinkpad T60p to see
what happened but it wasn't particularly successful. lspci -v shows

03:00.0 Ethernet controller: Atheros Communications, Inc. AR5212 802.11abg NIC (rev 01)
        Subsystem: IBM ThinkPad 11a/b/g Wireless LAN Mini Express Adapter (AR5BXB6)
        Flags: bus master, fast devsel, latency 0, IRQ 22
        Memory at edf00000 (64-bit, non-prefetchable) [size=64K]
        Capabilities: [40] Power Management version 2
        Capabilities: [50] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
        Capabilities: [60] Express Legacy Endpoint IRQ 0
        Capabilities: [90] MSI-X: Enable- Mask- TabSize=1
        Capabilities: [100] Advanced Error Reporting
        Capabilities: [140] Virtual Channel

During boot, the following relevant information in dmesg shows up;

ACPI: PCI Interrupt 0000:03:00.0[A] -> GSI 17 (level, low) -> IRQ 21
PCI: Setting latency timer of device 0000:03:00.0 to 64
Uhhuh. NMI received for unknown reason b1 on CPU 0.
You have some hardware problem, likely on the PCI bus.
Dazed and confused, but trying to continue
ath5k_hw_nic_wakeup: failed to resume the MAC Chip
ACPI: PCI interrupt for device 0000:03:00.0 disabled
ath_pci: probe of 0000:03:00.0 failed with error -5

Needless to say, it fails to bring up networking later. I have no real idea
how to debug something like this. Any suggestions?

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

Re: 2.6.23-rc4-mm1

[Andy Whitcroft]

I have a couple of old NUMA-Q systems which are unable to read their
boot disks with 2.6.23-rc4-mm1.  The disks appear to be recognised and
even the partition tables read correctly, and then they go pop:

  qla1280: QLA1040 found on PCI bus 0, dev 10
  Clocksource tsc unstable (delta = 99922590 ns)
  Time: jiffies clocksource has been installed.
  scsi(0:0): Resetting SCSI BUS
  scsi0 : QLogic QLA1040 PCI to SCSI Host Adapter
         Firmware version:  7.65.06, Driver version 3.26
  scsi 0:0:0:0: Direct-Access     IBM      DGHS18X          0360 PQ: 0 ANSI: 3
  scsi(0:0:0:0): Sync: period 10, offset 12, Wide
  scsi 0:0:1:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
  scsi(0:0:1:0): Sync: period 10, offset 12, Wide
  scsi 0:0:2:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
  scsi(0:0:2:0): Sync: period 10, offset 12, Wide
  scsi 0:0:3:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
  scsi(0:0:3:0): Sync: period 10, offset 12, Wide
  scsi 0:0:4:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
  scsi(0:0:4:0): Sync: period 10, offset 12, Wide
  st: Version 20070203, fixed bufsize 32768, s/g segs 256
  sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
  sd 0:0:0:0: [sda] Write Protect is off
  sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
  sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
  sd 0:0:0:0: [sda] Write Protect is off
  sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
   sda: sda1
  sd 0:0:0:0: [sda] Attached SCSI disk
  sd 0:0:1:0: [sdb] 17796077 512-byte hardware sectors (9112 MB)
  sd 0:0:1:0: [sdb] Write Protect is off
  sd 0:0:1:0: [sdb] Write cache: disabled, read cache: enabled, supports DPO and FUA
  sd 0:0:1:0: [sdb] 17796077 512-byte hardware sectors (9112 MB)
  sd 0:0:1:0: [sdb] Write Protect is off
  sd 0:0:1:0: [sdb] Write cache: disabled, read cache: enabled, supports DPO and FUA
   sdb: unknown partition table
  sd 0:0:1:0: [sdb] Attached SCSI disk
  sd 0:0:2:0: [sdc] 17796077 512-byte hardware sectors (9112 MB)
  sd 0:0:2:0: [sdc] Write Protect is off
  sd 0:0:2:0: [sdc] Write cache: disabled, read cache: enabled, supports DPO and FUA
  sd 0:0:2:0: [sdc] 17796077 512-byte hardware sectors (9112 MB)
  sd 0:0:2:0: [sdc] Write Protect is off
  sd 0:0:2:0: [sdc] Write cache: disabled, read cache: enabled, supports DPO and FUA
   sdc: sdc1
  sd 0:0:2:0: [sdc] Attached SCSI disk
  sd 0:0:3:0: [sdd] 17796077 512-byte hardware sectors (9112 MB)
  sd 0:0:3:0: [sdd] Write Protect is off
  sd 0:0:3:0: [sdd] Write cache: disabled, read cache: enabled, supports DPO and FUA
  sd 0:0:3:0: [sdd] 17796077 512-byte hardware sectors (9112 MB)
  sd 0:0:3:0: [sdd] Write Protect is off
  sd 0:0:3:0: [sdd] Write cache: disabled, read cache: enabled, supports DPO and FUA
   sdd: sdd1
  sd 0:0:3:0: [sdd] Attached SCSI disk
  sd 0:0:4:0: [sde] 17796077 512-byte hardware sectors (9112 MB)
  sd 0:0:4:0: [sde] Write Protect is off
  sd 0:0:4:0: [sde] Write cache: disabled, read cache: enabled, supports DPO and FUA
  sd 0:0:4:0: [sde] 17796077 512-byte hardware sectors (9112 MB)
  sd 0:0:4:0: [sde] Write Protect is off
  sd 0:0:4:0: [sde] Write cache: disabled, read cache: enabled, supports DPO and FUA
   sde: unknown partition table
  sd 0:0:4:0: [sde] Attached SCSI disk
  sd 0:0:0:0: Attached scsi generic sg0 type 0
  sd 0:0:1:0: Attached scsi generic sg1 type 0
  sd 0:0:2:0: Attached scsi generic sg2 type 0
  sd 0:0:3:0: Attached scsi generic sg3 type 0
  sd 0:0:4:0: Attached scsi generic sg4 type 0
  serio: i8042 KBD port at 0x60,0x64 irq 1
  serio: i8042 AUX port at 0x60,0x64 irq 12
  mice: PS/2 mouse device common for all mice
  input: AT Translated Set 2 keyboard as /class/input/input0
  oprofile: using NMI interrupt.
  TCP cubic registered
  NET: Registered protocol family 1
  NET: Registered protocol family 17
  Using IPI Shortcut mode
  input: PS/2 Logitech Mouse as /class/input/input1
  RAMDISK: cramfs filesystem found at block 0
  RAMDISK: Loading 1244KiB [1 disk] into ram disk... |/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/done.
  VFS: Mounted root (cramfs filesystem) readonly.
  Freeing unused kernel memory: 220k freed
  initrd-tools: 0.1.81.1
  mount: fs type devfs not supported by kernel
  FATAL: Module sd_mod not found.
  umount: devfs: not mounted
  ext3: No journal on filesystem on sda1
  sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
  end_request: I/O error, dev sda, sector 63
  Buffer I/O error on device sda1, logical block 0
  Buffer I/O error on device sda1, logical block 1
  Buffer I/O error on device sda1, logical block 2
  Buffer I/O error on device sda1, logical block 3
  mount: fs type devfs not supported by kernel
  ext3: No journal on filesystem on sda1
  umount: devfs: not mounted
  sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
  end_request: I/O error, dev sda, sector 28010831
  sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
  end_request: I/O error, dev sda, sector 31080815
  sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
  end_request: I/O error, dev sda, sector 31080855
  sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
  end_request: I/O error, dev sda, sector 31080919
  Buffer I/O error on device sda1, logical block 3885107
  sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
  end_request: I/O error, dev sda, sector 28411047
  sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
  end_request: I/O error, dev sda, sector 31135687
  sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
  end_request: I/O error, dev sda, sector 31138007
  sd 0:0:0:0: [sda] <6>sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00

-apw

Re: 2.6.23-rc4-mm1

[Andrew Morton]

On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <apw@shadowen.org> wrote:

> I have a couple of old NUMA-Q systems which are unable to read their
> boot disks with 2.6.23-rc4-mm1.  The disks appear to be recognised and
> even the partition tables read correctly, and then they go pop:
> 
>   qla1280: QLA1040 found on PCI bus 0, dev 10

cc's added.

>   Clocksource tsc unstable (delta = 99922590 ns)
>   Time: jiffies clocksource has been installed.
>   scsi(0:0): Resetting SCSI BUS
>   scsi0 : QLogic QLA1040 PCI to SCSI Host Adapter
>          Firmware version:  7.65.06, Driver version 3.26
>   scsi 0:0:0:0: Direct-Access     IBM      DGHS18X          0360 PQ: 0 ANSI: 3
>   scsi(0:0:0:0): Sync: period 10, offset 12, Wide
>   scsi 0:0:1:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
>   scsi(0:0:1:0): Sync: period 10, offset 12, Wide
>   scsi 0:0:2:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
>   scsi(0:0:2:0): Sync: period 10, offset 12, Wide
>   scsi 0:0:3:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
>   scsi(0:0:3:0): Sync: period 10, offset 12, Wide
>   scsi 0:0:4:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
>   scsi(0:0:4:0): Sync: period 10, offset 12, Wide
>   st: Version 20070203, fixed bufsize 32768, s/g segs 256
>   sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
>   sd 0:0:0:0: [sda] Write Protect is off
>   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
>   sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
>   sd 0:0:0:0: [sda] Write Protect is off
>   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
>    sda: sda1
>   sd 0:0:0:0: [sda] Attached SCSI disk
>   sd 0:0:1:0: [sdb] 17796077 512-byte hardware sectors (9112 MB)
>   sd 0:0:1:0: [sdb] Write Protect is off
>   sd 0:0:1:0: [sdb] Write cache: disabled, read cache: enabled, supports DPO and FUA
>   sd 0:0:1:0: [sdb] 17796077 512-byte hardware sectors (9112 MB)
>   sd 0:0:1:0: [sdb] Write Protect is off
>   sd 0:0:1:0: [sdb] Write cache: disabled, read cache: enabled, supports DPO and FUA
>    sdb: unknown partition table
>   sd 0:0:1:0: [sdb] Attached SCSI disk
>   sd 0:0:2:0: [sdc] 17796077 512-byte hardware sectors (9112 MB)
>   sd 0:0:2:0: [sdc] Write Protect is off
>   sd 0:0:2:0: [sdc] Write cache: disabled, read cache: enabled, supports DPO and FUA
>   sd 0:0:2:0: [sdc] 17796077 512-byte hardware sectors (9112 MB)
>   sd 0:0:2:0: [sdc] Write Protect is off
>   sd 0:0:2:0: [sdc] Write cache: disabled, read cache: enabled, supports DPO and FUA
>    sdc: sdc1
>   sd 0:0:2:0: [sdc] Attached SCSI disk
>   sd 0:0:3:0: [sdd] 17796077 512-byte hardware sectors (9112 MB)
>   sd 0:0:3:0: [sdd] Write Protect is off
>   sd 0:0:3:0: [sdd] Write cache: disabled, read cache: enabled, supports DPO and FUA
>   sd 0:0:3:0: [sdd] 17796077 512-byte hardware sectors (9112 MB)
>   sd 0:0:3:0: [sdd] Write Protect is off
>   sd 0:0:3:0: [sdd] Write cache: disabled, read cache: enabled, supports DPO and FUA
>    sdd: sdd1
>   sd 0:0:3:0: [sdd] Attached SCSI disk
>   sd 0:0:4:0: [sde] 17796077 512-byte hardware sectors (9112 MB)
>   sd 0:0:4:0: [sde] Write Protect is off
>   sd 0:0:4:0: [sde] Write cache: disabled, read cache: enabled, supports DPO and FUA
>   sd 0:0:4:0: [sde] 17796077 512-byte hardware sectors (9112 MB)
>   sd 0:0:4:0: [sde] Write Protect is off
>   sd 0:0:4:0: [sde] Write cache: disabled, read cache: enabled, supports DPO and FUA
>    sde: unknown partition table
>   sd 0:0:4:0: [sde] Attached SCSI disk
>   sd 0:0:0:0: Attached scsi generic sg0 type 0
>   sd 0:0:1:0: Attached scsi generic sg1 type 0
>   sd 0:0:2:0: Attached scsi generic sg2 type 0
>   sd 0:0:3:0: Attached scsi generic sg3 type 0
>   sd 0:0:4:0: Attached scsi generic sg4 type 0
>   serio: i8042 KBD port at 0x60,0x64 irq 1
>   serio: i8042 AUX port at 0x60,0x64 irq 12
>   mice: PS/2 mouse device common for all mice
>   input: AT Translated Set 2 keyboard as /class/input/input0
>   oprofile: using NMI interrupt.
>   TCP cubic registered
>   NET: Registered protocol family 1
>   NET: Registered protocol family 17
>   Using IPI Shortcut mode
>   input: PS/2 Logitech Mouse as /class/input/input1
>   RAMDISK: cramfs filesystem found at block 0
>   RAMDISK: Loading 1244KiB [1 disk] into ram disk... |/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/done.
>   VFS: Mounted root (cramfs filesystem) readonly.
>   Freeing unused kernel memory: 220k freed
>   initrd-tools: 0.1.81.1
>   mount: fs type devfs not supported by kernel
>   FATAL: Module sd_mod not found.
>   umount: devfs: not mounted
>   ext3: No journal on filesystem on sda1
>   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
>   end_request: I/O error, dev sda, sector 63
>   Buffer I/O error on device sda1, logical block 0
>   Buffer I/O error on device sda1, logical block 1
>   Buffer I/O error on device sda1, logical block 2
>   Buffer I/O error on device sda1, logical block 3
>   mount: fs type devfs not supported by kernel
>   ext3: No journal on filesystem on sda1
>   umount: devfs: not mounted
>   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
>   end_request: I/O error, dev sda, sector 28010831
>   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
>   end_request: I/O error, dev sda, sector 31080815
>   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
>   end_request: I/O error, dev sda, sector 31080855
>   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
>   end_request: I/O error, dev sda, sector 31080919
>   Buffer I/O error on device sda1, logical block 3885107
>   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
>   end_request: I/O error, dev sda, sector 28411047
>   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
>   end_request: I/O error, dev sda, sector 31135687
>   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
>   end_request: I/O error, dev sda, sector 31138007
>   sd 0:0:0:0: [sda] <6>sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> 

The only patch which touches qla1280 is git-block.patch.  From a quick
squizz the change looks OK, although it's tricky and something might have
broken.

(the dprintk at line 2929 needs to print remseg, not seg_cnt).

Can you retest with that change reverted (below)?  If it's not that then
perhaps something in scsi core broke, dunno.


diff -puN drivers/scsi/qla1280.c~revert-1 drivers/scsi/qla1280.c
--- a/drivers/scsi/qla1280.c~revert-1
+++ a/drivers/scsi/qla1280.c
@@ -2775,7 +2775,7 @@ qla1280_64bit_start_scsi(struct scsi_qla
 	struct device_reg __iomem *reg = ha->iobase;
 	struct scsi_cmnd *cmd = sp->cmd;
 	cmd_a64_entry_t *pkt;
-	struct scatterlist *sg = NULL, *s;
+	struct scatterlist *sg = NULL;
 	__le32 *dword_ptr;
 	dma_addr_t dma_handle;
 	int status = 0;
@@ -2889,16 +2889,13 @@ qla1280_64bit_start_scsi(struct scsi_qla
 	 * Load data segments.
 	 */
 	if (seg_cnt) {	/* If data transfer. */
-		int remseg = seg_cnt;
 		/* Setup packet address segment pointer. */
 		dword_ptr = (u32 *)&pkt->dseg_0_address;
 
 		if (cmd->use_sg) {	/* If scatter gather */
 			/* Load command entry data segments. */
-			for_each_sg(sg, s, seg_cnt, cnt) {
-				if (cnt == 2)
-					break;
-				dma_handle = sg_dma_address(s);
+			for (cnt = 0; cnt < 2 && seg_cnt; cnt++, seg_cnt--) {
+				dma_handle = sg_dma_address(sg);
 #if defined(CONFIG_IA64_GENERIC) || defined(CONFIG_IA64_SGI_SN2)
 				if (ha->flags.use_pci_vchannel)
 					sn_pci_set_vchan(ha->pdev,
@@ -2909,12 +2906,12 @@ qla1280_64bit_start_scsi(struct scsi_qla
 					cpu_to_le32(pci_dma_lo32(dma_handle));
 				*dword_ptr++ =
 					cpu_to_le32(pci_dma_hi32(dma_handle));
-				*dword_ptr++ = cpu_to_le32(sg_dma_len(s));
+				*dword_ptr++ = cpu_to_le32(sg_dma_len(sg));
+				sg++;
 				dprintk(3, "S/G Segment phys_addr=%x %x, len=0x%x\n",
 					cpu_to_le32(pci_dma_hi32(dma_handle)),
 					cpu_to_le32(pci_dma_lo32(dma_handle)),
-					cpu_to_le32(sg_dma_len(sg_next(s))));
-				remseg--;
+					cpu_to_le32(sg_dma_len(sg)));
 			}
 			dprintk(5, "qla1280_64bit_start_scsi: Scatter/gather "
 				"command packet data - b %i, t %i, l %i \n",
@@ -2929,9 +2926,7 @@ qla1280_64bit_start_scsi(struct scsi_qla
 			dprintk(3, "S/G Building Continuation...seg_cnt=0x%x "
 				"remains\n", seg_cnt);
 
-			while (remseg > 0) {
-				/* Update sg start */
-				sg = s;
+			while (seg_cnt > 0) {
 				/* Adjust ring index. */
 				ha->req_ring_index++;
 				if (ha->req_ring_index == REQUEST_ENTRY_CNT) {
@@ -2957,10 +2952,9 @@ qla1280_64bit_start_scsi(struct scsi_qla
 					(u32 *)&((struct cont_a64_entry *) pkt)->dseg_0_address;
 
 				/* Load continuation entry data segments. */
-				for_each_sg(sg, s, remseg, cnt) {
-					if (cnt == 5)
-						break;
-					dma_handle = sg_dma_address(s);
+				for (cnt = 0; cnt < 5 && seg_cnt;
+				     cnt++, seg_cnt--) {
+					dma_handle = sg_dma_address(sg);
 #if defined(CONFIG_IA64_GENERIC) || defined(CONFIG_IA64_SGI_SN2)
 				if (ha->flags.use_pci_vchannel)
 					sn_pci_set_vchan(ha->pdev, 
@@ -2972,12 +2966,12 @@ qla1280_64bit_start_scsi(struct scsi_qla
 					*dword_ptr++ =
 						cpu_to_le32(pci_dma_hi32(dma_handle));
 					*dword_ptr++ =
-						cpu_to_le32(sg_dma_len(s));
+						cpu_to_le32(sg_dma_len(sg));
 					dprintk(3, "S/G Segment Cont. phys_addr=%x %x, len=0x%x\n",
 						cpu_to_le32(pci_dma_hi32(dma_handle)),
 						cpu_to_le32(pci_dma_lo32(dma_handle)),
-						cpu_to_le32(sg_dma_len(s)));
-					remseg--;
+						cpu_to_le32(sg_dma_len(sg)));
+					sg++;
 				}
 				dprintk(5, "qla1280_64bit_start_scsi: "
 					"continuation packet data - b %i, t "
@@ -3068,7 +3062,7 @@ qla1280_32bit_start_scsi(struct scsi_qla
 	struct device_reg __iomem *reg = ha->iobase;
 	struct scsi_cmnd *cmd = sp->cmd;
 	struct cmd_entry *pkt;
-	struct scatterlist *sg = NULL, *s;
+	struct scatterlist *sg = NULL;
 	__le32 *dword_ptr;
 	int status = 0;
 	int cnt;
@@ -3194,7 +3188,6 @@ qla1280_32bit_start_scsi(struct scsi_qla
 	 * Load data segments.
 	 */
 	if (seg_cnt) {
-		int remseg = seg_cnt;
 		/* Setup packet address segment pointer. */
 		dword_ptr = &pkt->dseg_0_address;
 
@@ -3203,25 +3196,22 @@ qla1280_32bit_start_scsi(struct scsi_qla
 			qla1280_dump_buffer(1, (char *)sg, 4 * 16);
 
 			/* Load command entry data segments. */
-			for_each_sg(sg, s, seg_cnt, cnt) {
-				if (cnt == 4)
-					break;
+			for (cnt = 0; cnt < 4 && seg_cnt; cnt++, seg_cnt--) {
 				*dword_ptr++ =
-					cpu_to_le32(pci_dma_lo32(sg_dma_address(s)));
-				*dword_ptr++ = cpu_to_le32(sg_dma_len(s));
+					cpu_to_le32(pci_dma_lo32(sg_dma_address(sg)));
+				*dword_ptr++ =
+					cpu_to_le32(sg_dma_len(sg));
 				dprintk(3, "S/G Segment phys_addr=0x%lx, len=0x%x\n",
-					(pci_dma_lo32(sg_dma_address(s))),
-					(sg_dma_len(s)));
-				remseg--;
+					(pci_dma_lo32(sg_dma_address(sg))),
+					(sg_dma_len(sg)));
+				sg++;
 			}
 			/*
 			 * Build continuation packets.
 			 */
 			dprintk(3, "S/G Building Continuation"
 				"...seg_cnt=0x%x remains\n", seg_cnt);
-			while (remseg > 0) {
-				/* Continue from end point */
-				sg = s;
+			while (seg_cnt > 0) {
 				/* Adjust ring index. */
 				ha->req_ring_index++;
 				if (ha->req_ring_index == REQUEST_ENTRY_CNT) {
@@ -3249,16 +3239,18 @@ qla1280_32bit_start_scsi(struct scsi_qla
 					&((struct cont_entry *) pkt)->dseg_0_address;
 
 				/* Load continuation entry data segments. */
-				for_each_sg(sg, s, remseg, cnt) {
+				for (cnt = 0; cnt < 7 && seg_cnt;
+				     cnt++, seg_cnt--) {
 					*dword_ptr++ =
-						cpu_to_le32(pci_dma_lo32(sg_dma_address(s)));
+						cpu_to_le32(pci_dma_lo32(sg_dma_address(sg)));
 					*dword_ptr++ =
-						cpu_to_le32(sg_dma_len(s));
+						cpu_to_le32(sg_dma_len(sg));
 					dprintk(1,
 						"S/G Segment Cont. phys_addr=0x%x, "
 						"len=0x%x\n",
-						cpu_to_le32(pci_dma_lo32(sg_dma_address(s))),
-						cpu_to_le32(sg_dma_len(s)));
+						cpu_to_le32(pci_dma_lo32(sg_dma_address(sg))),
+						cpu_to_le32(sg_dma_len(sg)));
+					sg++;
 				}
 				dprintk(5, "qla1280_32bit_start_scsi: "
 					"continuation packet data - "
_

Re: 2.6.23-rc4-mm1

[Torsten Kaiser]

On 9/10/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
>
> > I have a couple of old NUMA-Q systems which are unable to read their
> > boot disks with 2.6.23-rc4-mm1.  The disks appear to be recognised and
> > even the partition tables read correctly, and then they go pop:

I reported a similar problem on Sep 1, but until now got no response.
The system boots, reads the partition tables, starts the RAID and then
kicks one drive out because of errors.

> >   qla1280: QLA1040 found on PCI bus 0, dev 10
> >   Clocksource tsc unstable (delta = 99922590 ns)
> >   Time: jiffies clocksource has been installed.
> >   scsi(0:0): Resetting SCSI BUS
> >   scsi0 : QLogic QLA1040 PCI to SCSI Host Adapter
> >          Firmware version:  7.65.06, Driver version 3.26
> >   scsi 0:0:0:0: Direct-Access     IBM      DGHS18X          0360 PQ: 0 ANSI: 3
> >   scsi(0:0:0:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:1:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:1:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:2:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:2:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:3:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:3:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:4:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:4:0): Sync: period 10, offset 12, Wide
> >   st: Version 20070203, fixed bufsize 32768, s/g segs 256
> >   sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
> >   sd 0:0:0:0: [sda] Write Protect is off
> >   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
> >   sd 0:0:0:0: [sda] Write Protect is off
> >   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sda: sda1
[snip]
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 63
> >   Buffer I/O error on device sda1, logical block 0
> >   Buffer I/O error on device sda1, logical block 1
> >   Buffer I/O error on device sda1, logical block 2
> >   Buffer I/O error on device sda1, logical block 3
> >   mount: fs type devfs not supported by kernel
> >   ext3: No journal on filesystem on sda1
> >   umount: devfs: not mounted
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 28010831
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31080815

>From my log:
[    3.890000] scsi0 : sata_sil24
[    3.900000] scsi1 : sata_sil24
[    3.900000] ata1: SATA max UDMA/100 host m128@0xefeffc00 port
0xefef8000 irq 16
[    3.920000] ata2: SATA max UDMA/100 host m128@0xefeffc00 port
0xefefa000 irq 16
[    4.300000] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
[    4.360000] ata1.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
[    4.370000] ata1.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
[    4.430000] ata1.00: configured for UDMA/100
[    4.500000] ieee1394: Node added: ID:BUS[0-00:1023]  GUID[0010dc00005cc354]
[    4.500000] ieee1394: Host added: ID:BUS[0-01:1023]  GUID[0011d80000c4c261]
[    4.790000] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
[    4.850000] ata2.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
[    4.860000] ata2.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
[    4.920000] ata2.00: configured for UDMA/100
[    4.930000] scsi 0:0:0:0: Direct-Access     ATA      MAXTOR
STM332082 3.AA PQ: 0 ANSI: 5
[    4.960000] sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
[    4.980000] sd 0:0:0:0: [sda] Write Protect is off
[    4.990000] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
[    4.990000] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[    5.020000] sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
[    5.040000] sd 0:0:0:0: [sda] Write Protect is off
[    5.050000] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
[    5.050000] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[    5.080000]  sda: sda1 sda2
[    5.110000] sd 0:0:0:0: [sda] Attached SCSI disk
[    5.120000] scsi 1:0:0:0: Direct-Access     ATA      MAXTOR
STM332082 3.AA PQ: 0 ANSI: 5
[    5.140000] sd 1:0:0:0: [sdb] 625142448 512-byte hardware sectors (320073 MB)
[    5.170000] sd 1:0:0:0: [sdb] Write Protect is off
[    5.180000] sd 1:0:0:0: [sdb] Mode Sense: 00 3a 00 00
[    5.180000] sd 1:0:0:0: [sdb] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[    5.210000] sd 1:0:0:0: [sdb] 625142448 512-byte hardware sectors (320073 MB)
[    5.230000] sd 1:0:0:0: [sdb] Write Protect is off
[    5.240000] sd 1:0:0:0: [sdb] Mode Sense: 00 3a 00 00
[    5.240000] sd 1:0:0:0: [sdb] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[    5.270000]  sdb: sdb1 sdb2
[    5.300000] sd 1:0:0:0: [sdb] Attached SCSI disk
[more normal boot messaged, 3-disk RAID5 starts]
[   63.420000] ata2.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x6 frozen
[   63.420000] ata2.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0
cdb 0x0 data 4096 out
[   63.420000]          res 40/00:00:00:00:00/00:00:00:00:00/00 Emask
0x4 (timeout)
[   63.420000] ata2.00: status: {DRDY }
[   63.420000] ata2: hard resetting link
[   65.720000] ata2: softreset failed (port not ready)
[   65.720000] ata2: reset failed (errno=-5), retrying in 8 secs
[   73.420000] ata2: hard resetting link
[   75.720000] ata2: softreset failed (port not ready)
[   75.720000] ata2: reset failed (errno=-5), retrying in 8 secs
[   83.420000] ata2: hard resetting link
[   85.720000] ata2: softreset failed (port not ready)
[   85.720000] ata2: reset failed (errno=-5), retrying in 33 secs
[snip, disk gets kicked]
[  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.780000] end_request: I/O error, dev sdb, sector 19550927
[  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.780000] end_request: I/O error, dev sdb, sector 19550935
[  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK
[  120.780000] end_request: I/O error, dev sdb, sector 19550943
[  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK,SUGGEST_OK

More similar error messages in the old my LKML-mail.

After sdb was removed from the array the system worked normal with
only two drives.
But on the next boot it kicked the second sata_sil24 disk from the
array killing it.

Torsten

Re: 2.6.23-rc4-mm1

[FUJITA Tomonori]

On Mon, 10 Sep 2007 11:19:26 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
> 
> > I have a couple of old NUMA-Q systems which are unable to read their
> > boot disks with 2.6.23-rc4-mm1.  The disks appear to be recognised and
> > even the partition tables read correctly, and then they go pop:
> > 
> >   qla1280: QLA1040 found on PCI bus 0, dev 10
> 
> cc's added.
> 
> >   Clocksource tsc unstable (delta = 99922590 ns)
> >   Time: jiffies clocksource has been installed.
> >   scsi(0:0): Resetting SCSI BUS
> >   scsi0 : QLogic QLA1040 PCI to SCSI Host Adapter
> >          Firmware version:  7.65.06, Driver version 3.26
> >   scsi 0:0:0:0: Direct-Access     IBM      DGHS18X          0360 PQ: 0 ANSI: 3
> >   scsi(0:0:0:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:1:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:1:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:2:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:2:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:3:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:3:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:4:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:4:0): Sync: period 10, offset 12, Wide
> >   st: Version 20070203, fixed bufsize 32768, s/g segs 256
> >   sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
> >   sd 0:0:0:0: [sda] Write Protect is off
> >   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
> >   sd 0:0:0:0: [sda] Write Protect is off
> >   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sda: sda1
> >   sd 0:0:0:0: [sda] Attached SCSI disk
> >   sd 0:0:1:0: [sdb] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:1:0: [sdb] Write Protect is off
> >   sd 0:0:1:0: [sdb] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:1:0: [sdb] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:1:0: [sdb] Write Protect is off
> >   sd 0:0:1:0: [sdb] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sdb: unknown partition table
> >   sd 0:0:1:0: [sdb] Attached SCSI disk
> >   sd 0:0:2:0: [sdc] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:2:0: [sdc] Write Protect is off
> >   sd 0:0:2:0: [sdc] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:2:0: [sdc] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:2:0: [sdc] Write Protect is off
> >   sd 0:0:2:0: [sdc] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sdc: sdc1
> >   sd 0:0:2:0: [sdc] Attached SCSI disk
> >   sd 0:0:3:0: [sdd] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:3:0: [sdd] Write Protect is off
> >   sd 0:0:3:0: [sdd] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:3:0: [sdd] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:3:0: [sdd] Write Protect is off
> >   sd 0:0:3:0: [sdd] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sdd: sdd1
> >   sd 0:0:3:0: [sdd] Attached SCSI disk
> >   sd 0:0:4:0: [sde] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:4:0: [sde] Write Protect is off
> >   sd 0:0:4:0: [sde] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:4:0: [sde] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:4:0: [sde] Write Protect is off
> >   sd 0:0:4:0: [sde] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sde: unknown partition table
> >   sd 0:0:4:0: [sde] Attached SCSI disk
> >   sd 0:0:0:0: Attached scsi generic sg0 type 0
> >   sd 0:0:1:0: Attached scsi generic sg1 type 0
> >   sd 0:0:2:0: Attached scsi generic sg2 type 0
> >   sd 0:0:3:0: Attached scsi generic sg3 type 0
> >   sd 0:0:4:0: Attached scsi generic sg4 type 0
> >   serio: i8042 KBD port at 0x60,0x64 irq 1
> >   serio: i8042 AUX port at 0x60,0x64 irq 12
> >   mice: PS/2 mouse device common for all mice
> >   input: AT Translated Set 2 keyboard as /class/input/input0
> >   oprofile: using NMI interrupt.
> >   TCP cubic registered
> >   NET: Registered protocol family 1
> >   NET: Registered protocol family 17
> >   Using IPI Shortcut mode
> >   input: PS/2 Logitech Mouse as /class/input/input1
> >   RAMDISK: cramfs filesystem found at block 0
> >   RAMDISK: Loading 1244KiB [1 disk] into ram disk... |/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/done.
> >   VFS: Mounted root (cramfs filesystem) readonly.
> >   Freeing unused kernel memory: 220k freed
> >   initrd-tools: 0.1.81.1
> >   mount: fs type devfs not supported by kernel
> >   FATAL: Module sd_mod not found.
> >   umount: devfs: not mounted
> >   ext3: No journal on filesystem on sda1
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 63
> >   Buffer I/O error on device sda1, logical block 0
> >   Buffer I/O error on device sda1, logical block 1
> >   Buffer I/O error on device sda1, logical block 2
> >   Buffer I/O error on device sda1, logical block 3
> >   mount: fs type devfs not supported by kernel
> >   ext3: No journal on filesystem on sda1
> >   umount: devfs: not mounted
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 28010831
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31080815
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31080855
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31080919
> >   Buffer I/O error on device sda1, logical block 3885107
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 28411047
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31135687
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31138007
> >   sd 0:0:0:0: [sda] <6>sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> > 
> 
> The only patch which touches qla1280 is git-block.patch.  From a quick
> squizz the change looks OK, although it's tricky and something might have
> broken.

Can you try this patch (against 2.6.23-rc4-mm1)?

>From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Mon, 10 Sep 2007 04:17:13 +0100
Subject: [PATCH] qla1280: sg chaining fixes

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
 drivers/scsi/qla1280.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index bd805ec..7c1eaec 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -2977,8 +2977,8 @@ qla1280_64bit_start_scsi(struct scsi_qla_host *ha, struct srb * sp)
 						cpu_to_le32(pci_dma_hi32(dma_handle)),
 						cpu_to_le32(pci_dma_lo32(dma_handle)),
 						cpu_to_le32(sg_dma_len(s)));
-					remseg--;
 				}
+				remseg -= cnt;
 				dprintk(5, "qla1280_64bit_start_scsi: "
 					"continuation packet data - b %i, t "
 					"%i, l %i \n", SCSI_BUS_32(cmd),
@@ -3250,6 +3250,8 @@ qla1280_32bit_start_scsi(struct scsi_qla_host *ha, struct srb * sp)
 
 				/* Load continuation entry data segments. */
 				for_each_sg(sg, s, remseg, cnt) {
+					if (cnt == 7)
+						break;
 					*dword_ptr++ =
 						cpu_to_le32(pci_dma_lo32(sg_dma_address(s)));
 					*dword_ptr++ =
@@ -3260,6 +3262,7 @@ qla1280_32bit_start_scsi(struct scsi_qla_host *ha, struct srb * sp)
 						cpu_to_le32(pci_dma_lo32(sg_dma_address(s))),
 						cpu_to_le32(sg_dma_len(s)));
 				}
+				remseg -= cnt;
 				dprintk(5, "qla1280_32bit_start_scsi: "
 					"continuation packet data - "
 					"scsi(%i:%i:%i)\n", SCSI_BUS_32(cmd),
-- 
1.5.2.4

Re: 2.6.23-rc4-mm1

[Andrew Morton]

On Mon, 10 Sep 2007 20:59:49 +0200 "Torsten Kaiser" <just.for.lkml@googlemail.com> wrote:

> On 9/10/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
> >
> > > I have a couple of old NUMA-Q systems which are unable to read their
> > > boot disks with 2.6.23-rc4-mm1.  The disks appear to be recognised and
> > > even the partition tables read correctly, and then they go pop:
> 
> I reported a similar problem on Sep 1, but until now got no response.

You still haven't had a response ;)  Let's add a cc.

Oh, you reported it against 2.6.23-rc4-mm1
(http://lkml.org/lkml/2007/9/1/92) and I did cc linux-ide in my response.

I'll continue to point out where this sort of thing occurs because last
week I was told that a reson why so many bug reports are ignored is because
"linux-kernel has too much traffic".

> The system boots, reads the partition tables, starts the RAID and then
> kicks one drive out because of errors.

Andy is using qla1280.  You're using sata.  So it's probably a different
bug, with the same symptoms.

> > >   qla1280: QLA1040 found on PCI bus 0, dev 10
> > >   Clocksource tsc unstable (delta = 99922590 ns)
> > >   Time: jiffies clocksource has been installed.
> > >   scsi(0:0): Resetting SCSI BUS
> > >   scsi0 : QLogic QLA1040 PCI to SCSI Host Adapter
> > >          Firmware version:  7.65.06, Driver version 3.26
> > >   scsi 0:0:0:0: Direct-Access     IBM      DGHS18X          0360 PQ: 0 ANSI: 3
> > >   scsi(0:0:0:0): Sync: period 10, offset 12, Wide
> > >   scsi 0:0:1:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> > >   scsi(0:0:1:0): Sync: period 10, offset 12, Wide
> > >   scsi 0:0:2:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> > >   scsi(0:0:2:0): Sync: period 10, offset 12, Wide
> > >   scsi 0:0:3:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> > >   scsi(0:0:3:0): Sync: period 10, offset 12, Wide
> > >   scsi 0:0:4:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> > >   scsi(0:0:4:0): Sync: period 10, offset 12, Wide
> > >   st: Version 20070203, fixed bufsize 32768, s/g segs 256
> > >   sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
> > >   sd 0:0:0:0: [sda] Write Protect is off
> > >   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
> > >   sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
> > >   sd 0:0:0:0: [sda] Write Protect is off
> > >   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
> > >    sda: sda1
> [snip]
> > >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> > >   end_request: I/O error, dev sda, sector 63
> > >   Buffer I/O error on device sda1, logical block 0
> > >   Buffer I/O error on device sda1, logical block 1
> > >   Buffer I/O error on device sda1, logical block 2
> > >   Buffer I/O error on device sda1, logical block 3
> > >   mount: fs type devfs not supported by kernel
> > >   ext3: No journal on filesystem on sda1
> > >   umount: devfs: not mounted
> > >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> > >   end_request: I/O error, dev sda, sector 28010831
> > >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> > >   end_request: I/O error, dev sda, sector 31080815
> 
> >From my log:
> [    3.890000] scsi0 : sata_sil24
> [    3.900000] scsi1 : sata_sil24
> [    3.900000] ata1: SATA max UDMA/100 host m128@0xefeffc00 port
> 0xefef8000 irq 16
> [    3.920000] ata2: SATA max UDMA/100 host m128@0xefeffc00 port
> 0xefefa000 irq 16
> [    4.300000] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> [    4.360000] ata1.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
> [    4.370000] ata1.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
> [    4.430000] ata1.00: configured for UDMA/100
> [    4.500000] ieee1394: Node added: ID:BUS[0-00:1023]  GUID[0010dc00005cc354]
> [    4.500000] ieee1394: Host added: ID:BUS[0-01:1023]  GUID[0011d80000c4c261]
> [    4.790000] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> [    4.850000] ata2.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max UDMA/133
> [    4.860000] ata2.00: 625142448 sectors, multi 0: LBA48 NCQ (depth 31/32)
> [    4.920000] ata2.00: configured for UDMA/100
> [    4.930000] scsi 0:0:0:0: Direct-Access     ATA      MAXTOR
> STM332082 3.AA PQ: 0 ANSI: 5
> [    4.960000] sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> [    4.980000] sd 0:0:0:0: [sda] Write Protect is off
> [    4.990000] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> [    4.990000] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
> enabled, doesn't support DPO or FUA
> [    5.020000] sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> [    5.040000] sd 0:0:0:0: [sda] Write Protect is off
> [    5.050000] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> [    5.050000] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
> enabled, doesn't support DPO or FUA
> [    5.080000]  sda: sda1 sda2
> [    5.110000] sd 0:0:0:0: [sda] Attached SCSI disk
> [    5.120000] scsi 1:0:0:0: Direct-Access     ATA      MAXTOR
> STM332082 3.AA PQ: 0 ANSI: 5
> [    5.140000] sd 1:0:0:0: [sdb] 625142448 512-byte hardware sectors (320073 MB)
> [    5.170000] sd 1:0:0:0: [sdb] Write Protect is off
> [    5.180000] sd 1:0:0:0: [sdb] Mode Sense: 00 3a 00 00
> [    5.180000] sd 1:0:0:0: [sdb] Write cache: enabled, read cache:
> enabled, doesn't support DPO or FUA
> [    5.210000] sd 1:0:0:0: [sdb] 625142448 512-byte hardware sectors (320073 MB)
> [    5.230000] sd 1:0:0:0: [sdb] Write Protect is off
> [    5.240000] sd 1:0:0:0: [sdb] Mode Sense: 00 3a 00 00
> [    5.240000] sd 1:0:0:0: [sdb] Write cache: enabled, read cache:
> enabled, doesn't support DPO or FUA
> [    5.270000]  sdb: sdb1 sdb2
> [    5.300000] sd 1:0:0:0: [sdb] Attached SCSI disk
> [more normal boot messaged, 3-disk RAID5 starts]
> [   63.420000] ata2.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x6 frozen
> [   63.420000] ata2.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0
> cdb 0x0 data 4096 out
> [   63.420000]          res 40/00:00:00:00:00/00:00:00:00:00/00 Emask
> 0x4 (timeout)
> [   63.420000] ata2.00: status: {DRDY }
> [   63.420000] ata2: hard resetting link
> [   65.720000] ata2: softreset failed (port not ready)
> [   65.720000] ata2: reset failed (errno=-5), retrying in 8 secs
> [   73.420000] ata2: hard resetting link
> [   75.720000] ata2: softreset failed (port not ready)
> [   75.720000] ata2: reset failed (errno=-5), retrying in 8 secs
> [   83.420000] ata2: hard resetting link
> [   85.720000] ata2: softreset failed (port not ready)
> [   85.720000] ata2: reset failed (errno=-5), retrying in 33 secs
> [snip, disk gets kicked]
> [  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.780000] end_request: I/O error, dev sdb, sector 19550927
> [  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.780000] end_request: I/O error, dev sdb, sector 19550935
> [  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> [  120.780000] end_request: I/O error, dev sdb, sector 19550943
> [  120.780000] sd 1:0:0:0: [sdb] Result: hostbyte=DID_BAD_TARGET
> driverbyte=DRIVER_OK,SUGGEST_OK
> 
> More similar error messages in the old my LKML-mail.
> 
> After sdb was removed from the array the system worked normal with
> only two drives.
> But on the next boot it kicked the second sata_sil24 disk from the
> array killing it.

Can you please confirm that this bug is present in -mm and not present in
mainline (yet)?

Thanks.

Re: 2.6.23-rc4-mm1

[FUJITA Tomonori]

On Mon, 10 Sep 2007 11:19:26 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
> 
> > I have a couple of old NUMA-Q systems which are unable to read their
> > boot disks with 2.6.23-rc4-mm1.  The disks appear to be recognised and
> > even the partition tables read correctly, and then they go pop:
> > 
> >   qla1280: QLA1040 found on PCI bus 0, dev 10
> 
> cc's added.
> 
> >   Clocksource tsc unstable (delta = 99922590 ns)
> >   Time: jiffies clocksource has been installed.
> >   scsi(0:0): Resetting SCSI BUS
> >   scsi0 : QLogic QLA1040 PCI to SCSI Host Adapter
> >          Firmware version:  7.65.06, Driver version 3.26
> >   scsi 0:0:0:0: Direct-Access     IBM      DGHS18X          0360 PQ: 0 ANSI: 3
> >   scsi(0:0:0:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:1:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:1:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:2:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:2:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:3:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:3:0): Sync: period 10, offset 12, Wide
> >   scsi 0:0:4:0: Direct-Access     IBM OEM  DCHS09X          5454 PQ: 0 ANSI: 2
> >   scsi(0:0:4:0): Sync: period 10, offset 12, Wide
> >   st: Version 20070203, fixed bufsize 32768, s/g segs 256
> >   sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
> >   sd 0:0:0:0: [sda] Write Protect is off
> >   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:0:0: [sda] 35843670 512-byte hardware sectors (18352 MB)
> >   sd 0:0:0:0: [sda] Write Protect is off
> >   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sda: sda1
> >   sd 0:0:0:0: [sda] Attached SCSI disk
> >   sd 0:0:1:0: [sdb] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:1:0: [sdb] Write Protect is off
> >   sd 0:0:1:0: [sdb] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:1:0: [sdb] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:1:0: [sdb] Write Protect is off
> >   sd 0:0:1:0: [sdb] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sdb: unknown partition table
> >   sd 0:0:1:0: [sdb] Attached SCSI disk
> >   sd 0:0:2:0: [sdc] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:2:0: [sdc] Write Protect is off
> >   sd 0:0:2:0: [sdc] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:2:0: [sdc] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:2:0: [sdc] Write Protect is off
> >   sd 0:0:2:0: [sdc] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sdc: sdc1
> >   sd 0:0:2:0: [sdc] Attached SCSI disk
> >   sd 0:0:3:0: [sdd] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:3:0: [sdd] Write Protect is off
> >   sd 0:0:3:0: [sdd] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:3:0: [sdd] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:3:0: [sdd] Write Protect is off
> >   sd 0:0:3:0: [sdd] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sdd: sdd1
> >   sd 0:0:3:0: [sdd] Attached SCSI disk
> >   sd 0:0:4:0: [sde] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:4:0: [sde] Write Protect is off
> >   sd 0:0:4:0: [sde] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >   sd 0:0:4:0: [sde] 17796077 512-byte hardware sectors (9112 MB)
> >   sd 0:0:4:0: [sde] Write Protect is off
> >   sd 0:0:4:0: [sde] Write cache: disabled, read cache: enabled, supports DPO and FUA
> >    sde: unknown partition table
> >   sd 0:0:4:0: [sde] Attached SCSI disk
> >   sd 0:0:0:0: Attached scsi generic sg0 type 0
> >   sd 0:0:1:0: Attached scsi generic sg1 type 0
> >   sd 0:0:2:0: Attached scsi generic sg2 type 0
> >   sd 0:0:3:0: Attached scsi generic sg3 type 0
> >   sd 0:0:4:0: Attached scsi generic sg4 type 0
> >   serio: i8042 KBD port at 0x60,0x64 irq 1
> >   serio: i8042 AUX port at 0x60,0x64 irq 12
> >   mice: PS/2 mouse device common for all mice
> >   input: AT Translated Set 2 keyboard as /class/input/input0
> >   oprofile: using NMI interrupt.
> >   TCP cubic registered
> >   NET: Registered protocol family 1
> >   NET: Registered protocol family 17
> >   Using IPI Shortcut mode
> >   input: PS/2 Logitech Mouse as /class/input/input1
> >   RAMDISK: cramfs filesystem found at block 0
> >   RAMDISK: Loading 1244KiB [1 disk] into ram disk... |/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/done.
> >   VFS: Mounted root (cramfs filesystem) readonly.
> >   Freeing unused kernel memory: 220k freed
> >   initrd-tools: 0.1.81.1
> >   mount: fs type devfs not supported by kernel
> >   FATAL: Module sd_mod not found.
> >   umount: devfs: not mounted
> >   ext3: No journal on filesystem on sda1
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 63
> >   Buffer I/O error on device sda1, logical block 0
> >   Buffer I/O error on device sda1, logical block 1
> >   Buffer I/O error on device sda1, logical block 2
> >   Buffer I/O error on device sda1, logical block 3
> >   mount: fs type devfs not supported by kernel
> >   ext3: No journal on filesystem on sda1
> >   umount: devfs: not mounted
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 28010831
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31080815
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31080855
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31080919
> >   Buffer I/O error on device sda1, logical block 3885107
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 28411047
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31135687
> >   sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> >   end_request: I/O error, dev sda, sector 31138007
> >   sd 0:0:0:0: [sda] <6>sd 0:0:0:0: [sda] Result: hostbyte=0x07 driverbyte=0x00
> > 
> 
> The only patch which touches qla1280 is git-block.patch.  From a quick
> squizz the change looks OK, although it's tricky and something might have
> broken.
> 
> (the dprintk at line 2929 needs to print remseg, not seg_cnt).
> 
> Can you retest with that change reverted (below)?  If it's not that then
> perhaps something in scsi core broke, dunno.

Even if we revert the qla1280 patch, scsi-ml still sends chaining sg
list. So it doesn't work.

The following patch disables chaining sg list for qla1280. If the fix
that I've just sent doesn't work, please try this.

-
From: FUJITA Tomonori <tomof@acm.org>
Subject: [PATCH] add use_sg_chaining option to scsi_host_template

This option is true if a low-level driver can support sg
chaining. This will be removed eventually when all the drivers are
converted to support sg chaining. q->max_phys_segments is set to
SCSI_MAX_SG_SEGMENTS if false.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
 arch/ia64/hp/sim/simscsi.c            |    1 +
 drivers/scsi/3w-9xxx.c                |    1 +
 drivers/scsi/3w-xxxx.c                |    1 +
 drivers/scsi/BusLogic.c               |    1 +
 drivers/scsi/NCR53c406a.c             |    3 ++-
 drivers/scsi/a100u2w.c                |    1 +
 drivers/scsi/aacraid/linit.c          |    1 +
 drivers/scsi/aha1740.c                |    1 +
 drivers/scsi/aic7xxx/aic79xx_osm.c    |    1 +
 drivers/scsi/aic7xxx/aic7xxx_osm.c    |    1 +
 drivers/scsi/aic7xxx_old.c            |    1 +
 drivers/scsi/arcmsr/arcmsr_hba.c      |    1 +
 drivers/scsi/dc395x.c                 |    1 +
 drivers/scsi/dpt_i2o.c                |    1 +
 drivers/scsi/eata.c                   |    3 ++-
 drivers/scsi/hosts.c                  |    1 +
 drivers/scsi/hptiop.c                 |    1 +
 drivers/scsi/ibmmca.c                 |    1 +
 drivers/scsi/ibmvscsi/ibmvscsi.c      |    1 +
 drivers/scsi/initio.c                 |    1 +
 drivers/scsi/ipr.c                    |    1 +
 drivers/scsi/lpfc/lpfc_scsi.c         |    2 ++
 drivers/scsi/mac53c94.c               |    1 +
 drivers/scsi/megaraid.c               |    1 +
 drivers/scsi/megaraid/megaraid_mbox.c |    1 +
 drivers/scsi/megaraid/megaraid_sas.c  |    1 +
 drivers/scsi/mesh.c                   |    1 +
 drivers/scsi/nsp32.c                  |    1 +
 drivers/scsi/pcmcia/sym53c500_cs.c    |    1 +
 drivers/scsi/qla2xxx/qla_os.c         |    2 ++
 drivers/scsi/qla4xxx/ql4_os.c         |    1 +
 drivers/scsi/qlogicfas.c              |    1 +
 drivers/scsi/scsi_lib.c               |    5 ++++-
 drivers/scsi/stex.c                   |    1 +
 drivers/scsi/sym53c416.c              |    1 +
 drivers/scsi/sym53c8xx_2/sym_glue.c   |    1 +
 drivers/scsi/u14-34f.c                |    1 +
 drivers/scsi/ultrastor.c              |    1 +
 drivers/scsi/wd7000.c                 |    1 +
 include/scsi/scsi_host.h              |   13 +++++++++++++
 40 files changed, 59 insertions(+), 3 deletions(-)

diff --git a/arch/ia64/hp/sim/simscsi.c b/arch/ia64/hp/sim/simscsi.c
index 4552a1c..e711657 100644
--- a/arch/ia64/hp/sim/simscsi.c
+++ b/arch/ia64/hp/sim/simscsi.c
@@ -360,6 +360,7 @@ static struct scsi_host_template driver_template = {
 	.max_sectors		= 1024,
 	.cmd_per_lun		= SIMSCSI_REQ_QUEUE_LEN,
 	.use_clustering		= DISABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 };
 
 static int __init
diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c
index efd9d8d..fb14014 100644
--- a/drivers/scsi/3w-9xxx.c
+++ b/drivers/scsi/3w-9xxx.c
@@ -1990,6 +1990,7 @@ static struct scsi_host_template driver_template = {
 	.max_sectors		= TW_MAX_SECTORS,
 	.cmd_per_lun		= TW_MAX_CMDS_PER_LUN,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.shost_attrs		= twa_host_attrs,
 	.emulated		= 1
 };
diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c
index c7995fc..a64153b 100644
--- a/drivers/scsi/3w-xxxx.c
+++ b/drivers/scsi/3w-xxxx.c
@@ -2261,6 +2261,7 @@ static struct scsi_host_template driver_template = {
 	.max_sectors		= TW_MAX_SECTORS,
 	.cmd_per_lun		= TW_MAX_CMDS_PER_LUN,	
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.shost_attrs		= tw_host_attrs,
 	.emulated		= 1
 };
diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
index 9b20617..49e1ffa 100644
--- a/drivers/scsi/BusLogic.c
+++ b/drivers/scsi/BusLogic.c
@@ -3575,6 +3575,7 @@ static struct scsi_host_template Bus_Logic_template = {
 	.unchecked_isa_dma = 1,
 	.max_sectors = 128,
 	.use_clustering = ENABLE_CLUSTERING,
+	.use_sg_chaining = ENABLE_SG_CHAINING,
 };
 
 /*
diff --git a/drivers/scsi/NCR53c406a.c b/drivers/scsi/NCR53c406a.c
index eda8c48..3168a17 100644
--- a/drivers/scsi/NCR53c406a.c
+++ b/drivers/scsi/NCR53c406a.c
@@ -1066,7 +1066,8 @@ static struct scsi_host_template driver_template =
      .sg_tablesize      	= 32			/*SG_ALL*/ /*SG_NONE*/, 
      .cmd_per_lun       	= 1			/* commands per lun */, 
      .unchecked_isa_dma 	= 1			/* unchecked_isa_dma */,
-     .use_clustering    	= ENABLE_CLUSTERING                               
+     .use_clustering    	= ENABLE_CLUSTERING,
+     .use_sg_chaining           = ENABLE_SG_CHAINING,
 };
 
 #include "scsi_module.c"
diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
index f608d4a..d3a6d15 100644
--- a/drivers/scsi/a100u2w.c
+++ b/drivers/scsi/a100u2w.c
@@ -1071,6 +1071,7 @@ static struct scsi_host_template inia100_template = {
 	.sg_tablesize		= SG_ALL,
 	.cmd_per_lun 		= 1,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 };
 
 static int __devinit inia100_probe_one(struct pci_dev *pdev,
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index a7f42a1..038980b 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -944,6 +944,7 @@ static struct scsi_host_template aac_driver_template = {
 	.cmd_per_lun    		= AAC_NUM_IO_FIB, 
 #endif	
 	.use_clustering			= ENABLE_CLUSTERING,
+	.use_sg_chaining		= ENABLE_SG_CHAINING,
 	.emulated                       = 1,
 };
 
diff --git a/drivers/scsi/aha1740.c b/drivers/scsi/aha1740.c
index e4a4f3a..f6722fd 100644
--- a/drivers/scsi/aha1740.c
+++ b/drivers/scsi/aha1740.c
@@ -563,6 +563,7 @@ static struct scsi_host_template aha1740_template = {
 	.sg_tablesize     = AHA1740_SCATTER,
 	.cmd_per_lun      = AHA1740_CMDLUN,
 	.use_clustering   = ENABLE_CLUSTERING,
+	.use_sg_chaining  = ENABLE_SG_CHAINING,
 	.eh_abort_handler = aha1740_eh_abort_handler,
 };
 
diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c
index a055a96..42c0f14 100644
--- a/drivers/scsi/aic7xxx/aic79xx_osm.c
+++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
@@ -766,6 +766,7 @@ struct scsi_host_template aic79xx_driver_template = {
 	.max_sectors		= 8192,
 	.cmd_per_lun		= 2,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.slave_alloc		= ahd_linux_slave_alloc,
 	.slave_configure	= ahd_linux_slave_configure,
 	.target_alloc		= ahd_linux_target_alloc,
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
index 2e9c38f..7770bef 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
@@ -747,6 +747,7 @@ struct scsi_host_template aic7xxx_driver_template = {
 	.max_sectors		= 8192,
 	.cmd_per_lun		= 2,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.slave_alloc		= ahc_linux_slave_alloc,
 	.slave_configure	= ahc_linux_slave_configure,
 	.target_alloc		= ahc_linux_target_alloc,
diff --git a/drivers/scsi/aic7xxx_old.c b/drivers/scsi/aic7xxx_old.c
index 1a71b02..4025608 100644
--- a/drivers/scsi/aic7xxx_old.c
+++ b/drivers/scsi/aic7xxx_old.c
@@ -11142,6 +11142,7 @@ static struct scsi_host_template driver_template = {
 	.max_sectors		= 2048,
 	.cmd_per_lun		= 3,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 };
 
 #include "scsi_module.c"
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index 0ddfc21..d5039f3 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -121,6 +121,7 @@ static struct scsi_host_template arcmsr_scsi_host_template = {
 	.max_sectors    	= ARCMSR_MAX_XFER_SECTORS,
 	.cmd_per_lun		= ARCMSR_MAX_CMD_PERLUN,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.shost_attrs		= arcmsr_host_attrs,
 };
 static struct pci_error_handlers arcmsr_pci_error_handlers = {
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 7b8a345..d2a2026 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -4765,6 +4765,7 @@ static struct scsi_host_template dc395x_driver_template = {
 	.eh_bus_reset_handler   = dc395x_eh_bus_reset,
 	.unchecked_isa_dma      = 0,
 	.use_clustering         = DISABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 };
 
 
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index bea9d65..8258506 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -3295,6 +3295,7 @@ static struct scsi_host_template adpt_template = {
 	.this_id		= 7,
 	.cmd_per_lun		= 1,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 };
 
 static s32 adpt_scsi_register(adpt_hba* pHba)
diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c
index a83e9f1..2f685cf 100644
--- a/drivers/scsi/eata.c
+++ b/drivers/scsi/eata.c
@@ -523,7 +523,8 @@ static struct scsi_host_template driver_template = {
 	.slave_configure = eata2x_slave_configure,
 	.this_id = 7,
 	.unchecked_isa_dma = 1,
-	.use_clustering = ENABLE_CLUSTERING
+	.use_clustering = ENABLE_CLUSTERING,
+	.use_sg_chaining = ENABLE_SG_CHAINING,
 };
 
 #if !defined(__BIG_ENDIAN_BITFIELD) && !defined(__LITTLE_ENDIAN_BITFIELD)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 96bc312..8c42539 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -342,6 +342,7 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
 	shost->unchecked_isa_dma = sht->unchecked_isa_dma;
 	shost->use_clustering = sht->use_clustering;
 	shost->ordered_tag = sht->ordered_tag;
+	shost->use_sg_chaining = sht->use_sg_chaining;
 
 	if (sht->max_host_blocked)
 		shost->max_host_blocked = sht->max_host_blocked;
diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c
index 8b384fa..8515054 100644
--- a/drivers/scsi/hptiop.c
+++ b/drivers/scsi/hptiop.c
@@ -655,6 +655,7 @@ static struct scsi_host_template driver_template = {
 	.unchecked_isa_dma          = 0,
 	.emulated                   = 0,
 	.use_clustering             = ENABLE_CLUSTERING,
+	.use_sg_chaining            = ENABLE_SG_CHAINING,
 	.proc_name                  = driver_name,
 	.shost_attrs                = hptiop_attrs,
 	.this_id                    = -1,
diff --git a/drivers/scsi/ibmmca.c b/drivers/scsi/ibmmca.c
index bff8252..695941a 100644
--- a/drivers/scsi/ibmmca.c
+++ b/drivers/scsi/ibmmca.c
@@ -1501,6 +1501,7 @@ static struct scsi_host_template ibmmca_driver_template = {
           .sg_tablesize   = 16,
           .cmd_per_lun    = 1,
           .use_clustering = ENABLE_CLUSTERING,
+          .use_sg_chaining = ENABLE_SG_CHAINING,
 };
 
 static int ibmmca_probe(struct device *dev)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 93bd01b..084488c 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -1545,6 +1545,7 @@ static struct scsi_host_template driver_template = {
 	.this_id = -1,
 	.sg_tablesize = SG_ALL,
 	.use_clustering = ENABLE_CLUSTERING,
+	.use_sg_chaining = ENABLE_SG_CHAINING,
 	.shost_attrs = ibmvscsi_attrs,
 };
 
diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
index d9dfb69..22d40fd 100644
--- a/drivers/scsi/initio.c
+++ b/drivers/scsi/initio.c
@@ -2831,6 +2831,7 @@ static struct scsi_host_template initio_template = {
 	.sg_tablesize		= SG_ALL,
 	.cmd_per_lun		= 1,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 };
 
 static int initio_probe_one(struct pci_dev *pdev,
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index b41dfb5..ba7b567 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -4949,6 +4949,7 @@ static struct scsi_host_template driver_template = {
 	.max_sectors = IPR_IOA_MAX_SECTORS,
 	.cmd_per_lun = IPR_MAX_CMD_PER_LUN,
 	.use_clustering = ENABLE_CLUSTERING,
+	.use_sg_chaining = ENABLE_SG_CHAINING,
 	.shost_attrs = ipr_ioa_attrs,
 	.sdev_attrs = ipr_dev_attrs,
 	.proc_name = IPR_NAME
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index cd67493..c075556 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -1438,6 +1438,7 @@ struct scsi_host_template lpfc_template = {
 	.scan_finished		= lpfc_scan_finished,
 	.this_id		= -1,
 	.sg_tablesize		= LPFC_SG_SEG_CNT,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.cmd_per_lun		= LPFC_CMD_PER_LUN,
 	.use_clustering		= ENABLE_CLUSTERING,
 	.shost_attrs		= lpfc_hba_attrs,
@@ -1460,6 +1461,7 @@ struct scsi_host_template lpfc_vport_template = {
 	.sg_tablesize		= LPFC_SG_SEG_CNT,
 	.cmd_per_lun		= LPFC_CMD_PER_LUN,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.shost_attrs		= lpfc_vport_attrs,
 	.max_sectors		= 0xFFFF,
 };
diff --git a/drivers/scsi/mac53c94.c b/drivers/scsi/mac53c94.c
index b12ad7c..a035001 100644
--- a/drivers/scsi/mac53c94.c
+++ b/drivers/scsi/mac53c94.c
@@ -402,6 +402,7 @@ static struct scsi_host_template mac53c94_template = {
 	.sg_tablesize	= SG_ALL,
 	.cmd_per_lun	= 1,
 	.use_clustering	= DISABLE_CLUSTERING,
+	.use_sg_chaining = ENABLE_SG_CHAINING,
 };
 
 static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *match)
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 9023ec6..a0133b5 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -4484,6 +4484,7 @@ static struct scsi_host_template megaraid_template = {
 	.sg_tablesize			= MAX_SGLIST,
 	.cmd_per_lun			= DEF_CMD_PER_LUN,
 	.use_clustering			= ENABLE_CLUSTERING,
+	.use_sg_chaining		= ENABLE_SG_CHAINING,
 	.eh_abort_handler		= megaraid_abort,
 	.eh_device_reset_handler	= megaraid_reset,
 	.eh_bus_reset_handler		= megaraid_reset,
diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c
index c6a53dc..e4e4c6a 100644
--- a/drivers/scsi/megaraid/megaraid_mbox.c
+++ b/drivers/scsi/megaraid/megaraid_mbox.c
@@ -361,6 +361,7 @@ static struct scsi_host_template megaraid_template_g = {
 	.eh_host_reset_handler		= megaraid_reset_handler,
 	.change_queue_depth		= megaraid_change_queue_depth,
 	.use_clustering			= ENABLE_CLUSTERING,
+	.use_sg_chaining		= ENABLE_SG_CHAINING,
 	.sdev_attrs			= megaraid_sdev_attrs,
 	.shost_attrs			= megaraid_shost_attrs,
 };
diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c
index ebb948c..e3c5c52 100644
--- a/drivers/scsi/megaraid/megaraid_sas.c
+++ b/drivers/scsi/megaraid/megaraid_sas.c
@@ -1110,6 +1110,7 @@ static struct scsi_host_template megasas_template = {
 	.eh_timed_out = megasas_reset_timer,
 	.bios_param = megasas_bios_param,
 	.use_clustering = ENABLE_CLUSTERING,
+	.use_sg_chaining = ENABLE_SG_CHAINING,
 };
 
 /**
diff --git a/drivers/scsi/mesh.c b/drivers/scsi/mesh.c
index 651d09b..7470ff3 100644
--- a/drivers/scsi/mesh.c
+++ b/drivers/scsi/mesh.c
@@ -1843,6 +1843,7 @@ static struct scsi_host_template mesh_template = {
 	.sg_tablesize			= SG_ALL,
 	.cmd_per_lun			= 2,
 	.use_clustering			= DISABLE_CLUSTERING,
+	.use_sg_chaining		= ENABLE_SG_CHAINING,
 };
 
 static int mesh_probe(struct macio_dev *mdev, const struct of_device_id *match)
diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
index 4215f3b..6da1504 100644
--- a/drivers/scsi/nsp32.c
+++ b/drivers/scsi/nsp32.c
@@ -281,6 +281,7 @@ static struct scsi_host_template nsp32_template = {
 	.cmd_per_lun			= 1,
 	.this_id			= NSP32_HOST_SCSIID,
 	.use_clustering			= DISABLE_CLUSTERING,
+	.use_sg_chaining		= ENABLE_SG_CHAINING,
 	.eh_abort_handler       	= nsp32_eh_abort,
 	.eh_bus_reset_handler		= nsp32_eh_bus_reset,
 	.eh_host_reset_handler		= nsp32_eh_host_reset,
diff --git a/drivers/scsi/pcmcia/sym53c500_cs.c b/drivers/scsi/pcmcia/sym53c500_cs.c
index 961839e..190e2a7 100644
--- a/drivers/scsi/pcmcia/sym53c500_cs.c
+++ b/drivers/scsi/pcmcia/sym53c500_cs.c
@@ -694,6 +694,7 @@ static struct scsi_host_template sym53c500_driver_template = {
      .sg_tablesize		= 32,
      .cmd_per_lun		= 1,
      .use_clustering		= ENABLE_CLUSTERING,
+     .use_sg_chaining		= ENABLE_SG_CHAINING,
      .shost_attrs		= SYM53C500_shost_attrs
 };
 
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index acca898..3abbbc0 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -132,6 +132,7 @@ struct scsi_host_template qla2x00_driver_template = {
 	.this_id		= -1,
 	.cmd_per_lun		= 3,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.sg_tablesize		= SG_ALL,
 
 	/*
@@ -163,6 +164,7 @@ struct scsi_host_template qla24xx_driver_template = {
 	.this_id		= -1,
 	.cmd_per_lun		= 3,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.sg_tablesize		= SG_ALL,
 
 	.max_sectors		= 0xFFFF,
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 8fa5aea..89460d2 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -94,6 +94,7 @@ static struct scsi_host_template qla4xxx_driver_template = {
 	.this_id		= -1,
 	.cmd_per_lun		= 3,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.sg_tablesize		= SG_ALL,
 
 	.max_sectors		= 0xFFFF,
diff --git a/drivers/scsi/qlogicfas.c b/drivers/scsi/qlogicfas.c
index 94baca8..2268ca1 100644
--- a/drivers/scsi/qlogicfas.c
+++ b/drivers/scsi/qlogicfas.c
@@ -197,6 +197,7 @@ static struct scsi_host_template qlogicfas_driver_template = {
 	.sg_tablesize		= SG_ALL,
 	.cmd_per_lun		= 1,
 	.use_clustering		= DISABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 };
 
 static __init int qlogicfas_init(void)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index d0a1028..38eec00 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1685,7 +1685,10 @@ struct request_queue *__scsi_alloc_queue(struct Scsi_Host *shost,
 	 * converted, so better keep it safe.
 	 */
 #ifdef ARCH_HAS_SG_CHAIN
-	blk_queue_max_phys_segments(q, SCSI_MAX_SG_CHAIN_SEGMENTS);
+	if (shost->use_sg_chaining)
+		blk_queue_max_phys_segments(q, SCSI_MAX_SG_CHAIN_SEGMENTS);
+	else
+		blk_queue_max_phys_segments(q, SCSI_MAX_SG_SEGMENTS);
 #else
 	blk_queue_max_phys_segments(q, SCSI_MAX_SG_SEGMENTS);
 #endif
diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 72f6d80..e3fab3a 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -1123,6 +1123,7 @@ static struct scsi_host_template driver_template = {
 	.this_id			= -1,
 	.sg_tablesize			= ST_MAX_SG,
 	.cmd_per_lun			= ST_CMD_PER_LUN,
+	.use_sg_chaining		= ENABLE_SG_CHAINING,
 };
 
 static int stex_set_dma_mask(struct pci_dev * pdev)
diff --git a/drivers/scsi/sym53c416.c b/drivers/scsi/sym53c416.c
index 92bfaea..8befab7 100644
--- a/drivers/scsi/sym53c416.c
+++ b/drivers/scsi/sym53c416.c
@@ -854,5 +854,6 @@ static struct scsi_host_template driver_template = {
 	.cmd_per_lun =		1,
 	.unchecked_isa_dma =	1,
 	.use_clustering =	ENABLE_CLUSTERING,
+	.use_sg_chaining =	ENABLE_SG_CHAINING,
 };
 #include "scsi_module.c"
diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c
index 764490e..7576c99 100644
--- a/drivers/scsi/sym53c8xx_2/sym_glue.c
+++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
@@ -1827,6 +1827,7 @@ static struct scsi_host_template sym2_template = {
 	.eh_host_reset_handler	= sym53c8xx_eh_host_reset_handler,
 	.this_id		= 7,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 	.max_sectors		= 0xFFFF,
 #ifdef SYM_LINUX_PROC_INFO_SUPPORT
 	.proc_info		= sym53c8xx_proc_info,
diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
index 9e8232a..a0d9ef4 100644
--- a/drivers/scsi/u14-34f.c
+++ b/drivers/scsi/u14-34f.c
@@ -451,6 +451,7 @@ static struct scsi_host_template driver_template = {
                 .this_id                 = 7,
                 .unchecked_isa_dma       = 1,
                 .use_clustering          = ENABLE_CLUSTERING
+                .use_sg_chaining         = ENABLE_SG_CHAINING,
                 };
 
 #if !defined(__BIG_ENDIAN_BITFIELD) && !defined(__LITTLE_ENDIAN_BITFIELD)
diff --git a/drivers/scsi/ultrastor.c b/drivers/scsi/ultrastor.c
index c08235d..ea72bbe 100644
--- a/drivers/scsi/ultrastor.c
+++ b/drivers/scsi/ultrastor.c
@@ -1197,5 +1197,6 @@ static struct scsi_host_template driver_template = {
 	.cmd_per_lun       = ULTRASTOR_MAX_CMDS_PER_LUN,
 	.unchecked_isa_dma = 1,
 	.use_clustering    = ENABLE_CLUSTERING,
+	.use_sg_chaining   = ENABLE_SG_CHAINING,
 };
 #include "scsi_module.c"
diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
index d6fd425..255c611 100644
--- a/drivers/scsi/wd7000.c
+++ b/drivers/scsi/wd7000.c
@@ -1671,6 +1671,7 @@ static struct scsi_host_template driver_template = {
 	.cmd_per_lun		= 1,
 	.unchecked_isa_dma	= 1,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 };
 
 #include "scsi_module.c"
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index 88f6871..3ee3805 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -36,6 +36,9 @@ struct blk_queue_tags;
 #define DISABLE_CLUSTERING 0
 #define ENABLE_CLUSTERING 1
 
+#define DISABLE_SG_CHAINING 0
+#define ENABLE_SG_CHAINING 1
+
 enum scsi_eh_timer_return {
 	EH_NOT_HANDLED,
 	EH_HANDLED,
@@ -435,6 +438,15 @@ struct scsi_host_template {
 	unsigned ordered_tag:1;
 
 	/*
+	 * true if the low-level driver can support sg chaining. this
+	 * will be removed eventually when all the drivers are
+	 * converted to support sg chaining.
+	 *
+	 * Status: OBSOLETE
+	 */
+	unsigned use_sg_chaining:1;
+
+	/*
 	 * Countdown for host blocking with no commands outstanding
 	 */
 	unsigned int max_host_blocked;
@@ -577,6 +589,7 @@ struct Scsi_Host {
 	unsigned unchecked_isa_dma:1;
 	unsigned use_clustering:1;
 	unsigned use_blk_tcq:1;
+	unsigned use_sg_chaining:1;
 
 	/*
 	 * Host has requested that no further requests come through for the
-- 
1.5.2.4

Re: 2.6.23-rc4-mm1

[Torsten Kaiser]

On 9/10/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon, 10 Sep 2007 20:59:49 +0200 "Torsten Kaiser" <just.for.lkml@googlemail.com> wrote:
>
> > On 9/10/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > > On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
> > I reported a similar problem on Sep 1, but until now got no response.
>
> You still haven't had a response ;)  Let's add a cc.

But the mail from Andy was a nice point to try to another cc, i.e.
linux-scsi that you added. :)

> Oh, you reported it against 2.6.23-rc4-mm1
> (http://lkml.org/lkml/2007/9/1/92) and I did cc linux-ide in my response.
>
[snip]
> Andy is using qla1280.  You're using sata.  So it's probably a different
> bug, with the same symptoms.

Yes, but you (Andrew) also said in response to Andy: "If it's not that then
perhaps something in scsi core broke, dunno." So I wanted to add that
my problem migth point this bug into the core direction.

> Can you please confirm that this bug is present in -mm and not present in
> mainline (yet)?

Currently using 2.6.23-rc3-mm1, that works for me.
Now downloading 2.6.23-rc5-git1...

Torsten

Re: 2.6.23-rc4-mm1

[FUJITA Tomonori]

On Mon, 10 Sep 2007 12:20:38 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 10 Sep 2007 20:59:49 +0200 "Torsten Kaiser" <just.for.lkml@googlemail.com> wrote:
> 
> > On 9/10/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > > On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
> > >
> > > > I have a couple of old NUMA-Q systems which are unable to read their
> > > > boot disks with 2.6.23-rc4-mm1.  The disks appear to be recognised and
> > > > even the partition tables read correctly, and then they go pop:
> > 
> > I reported a similar problem on Sep 1, but until now got no response.
> 
> You still haven't had a response ;)  Let's add a cc.
> 
> Oh, you reported it against 2.6.23-rc4-mm1
> (http://lkml.org/lkml/2007/9/1/92) and I did cc linux-ide in my response.
> 
> I'll continue to point out where this sort of thing occurs because last
> week I was told that a reson why so many bug reports are ignored is because
> "linux-kernel has too much traffic".

many SCSI people don't subscribe to linux-kernel, I think.


> > The system boots, reads the partition tables, starts the RAID and then
> > kicks one drive out because of errors.
> 
> Andy is using qla1280.  You're using sata.  So it's probably a different
> bug, with the same symptoms.

This might be a sg chaining bug too (probabaly sg chaining libata
patch).

Can you try the following patch that I've just sent:

http://lkml.org/lkml/2007/9/10/251

The patch also disables chaining sg list for libata.

Re: 2.6.23-rc4-mm1

[Torsten Kaiser]

On 9/10/07, FUJITA Tomonori <tomof@acm.org> wrote:
> On Mon, 10 Sep 2007 12:20:38 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Mon, 10 Sep 2007 20:59:49 +0200 "Torsten Kaiser" <just.for.lkml@googlemail.com> wrote:
> > > The system boots, reads the partition tables, starts the RAID and then
> > > kicks one drive out because of errors.
> >
> > Andy is using qla1280.  You're using sata.  So it's probably a different
> > bug, with the same symptoms.
>
> This might be a sg chaining bug too (probabaly sg chaining libata
> patch).
>
> Can you try the following patch that I've just sent:
>
> http://lkml.org/lkml/2007/9/10/251
>
> The patch also disables chaining sg list for libata.
>
With this patch 2.6.23-rc4-mm1 works for me.
Mainline 2.6.23-rc5-git1 works also without needing any patches.

Torsten

Re: 2.6.23-rc4-mm1

[Jens Axboe]

On Mon, Sep 10 2007, Torsten Kaiser wrote:
> On 9/10/07, FUJITA Tomonori <tomof@acm.org> wrote:
> > On Mon, 10 Sep 2007 12:20:38 -0700
> > Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > > On Mon, 10 Sep 2007 20:59:49 +0200 "Torsten Kaiser" <just.for.lkml@googlemail.com> wrote:
> > > > The system boots, reads the partition tables, starts the RAID and then
> > > > kicks one drive out because of errors.
> > >
> > > Andy is using qla1280.  You're using sata.  So it's probably a different
> > > bug, with the same symptoms.
> >
> > This might be a sg chaining bug too (probabaly sg chaining libata
> > patch).
> >
> > Can you try the following patch that I've just sent:
> >
> > http://lkml.org/lkml/2007/9/10/251
> >
> > The patch also disables chaining sg list for libata.
> >
> With this patch 2.6.23-rc4-mm1 works for me.
> Mainline 2.6.23-rc5-git1 works also without needing any patches.

OK, thanks for testing that. I'll merge Tomo's patch so that we can
selectively enable drivers when we KNOW they work, instead of trying to
do this (massive) operation whole sale.

-- 
Jens Axboe

Re: 2.6.23-rc4-mm1

[Andy Whitcroft]

On Tue, Sep 11, 2007 at 04:10:47AM +0900, FUJITA Tomonori wrote:

> > The only patch which touches qla1280 is git-block.patch.  From a quick
> > squizz the change looks OK, although it's tricky and something might have
> > broken.
> 
> Can you try this patch (against 2.6.23-rc4-mm1)?

Yep this patch seems to sort out booting on these boxes.  The other one
is also testing.  Results later.

> >From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Date: Mon, 10 Sep 2007 04:17:13 +0100
> Subject: [PATCH] qla1280: sg chaining fixes
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
>  drivers/scsi/qla1280.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
> index bd805ec..7c1eaec 100644
> --- a/drivers/scsi/qla1280.c
> +++ b/drivers/scsi/qla1280.c
> @@ -2977,8 +2977,8 @@ qla1280_64bit_start_scsi(struct scsi_qla_host *ha, struct srb * sp)
>  						cpu_to_le32(pci_dma_hi32(dma_handle)),
>  						cpu_to_le32(pci_dma_lo32(dma_handle)),
>  						cpu_to_le32(sg_dma_len(s)));
> -					remseg--;
>  				}
> +				remseg -= cnt;
>  				dprintk(5, "qla1280_64bit_start_scsi: "
>  					"continuation packet data - b %i, t "
>  					"%i, l %i \n", SCSI_BUS_32(cmd),
> @@ -3250,6 +3250,8 @@ qla1280_32bit_start_scsi(struct scsi_qla_host *ha, struct srb * sp)
>  
>  				/* Load continuation entry data segments. */
>  				for_each_sg(sg, s, remseg, cnt) {
> +					if (cnt == 7)
> +						break;
>  					*dword_ptr++ =
>  						cpu_to_le32(pci_dma_lo32(sg_dma_address(s)));
>  					*dword_ptr++ =
> @@ -3260,6 +3262,7 @@ qla1280_32bit_start_scsi(struct scsi_qla_host *ha, struct srb * sp)
>  						cpu_to_le32(pci_dma_lo32(sg_dma_address(s))),
>  						cpu_to_le32(sg_dma_len(s)));
>  				}
> +				remseg -= cnt;
>  				dprintk(5, "qla1280_32bit_start_scsi: "
>  					"continuation packet data - "
>  					"scsi(%i:%i:%i)\n", SCSI_BUS_32(cmd),
> -- 
> 1.5.2.4
> 
> 

-apw

Re: 2.6.23-rc4-mm1

[Andy Whitcroft]

On Tue, Sep 11, 2007 at 04:31:12AM +0900, FUJITA Tomonori wrote:
[...]
> > The only patch which touches qla1280 is git-block.patch.  From a quick
> > squizz the change looks OK, although it's tricky and something might have
> > broken.
> > 
> > (the dprintk at line 2929 needs to print remseg, not seg_cnt).
> > 
> > Can you retest with that change reverted (below)?  If it's not that then
> > perhaps something in scsi core broke, dunno.
> 
> Even if we revert the qla1280 patch, scsi-ml still sends chaining sg
> list. So it doesn't work.
> 
> The following patch disables chaining sg list for qla1280. If the fix
> that I've just sent doesn't work, please try this.

Ok, the other patch _did_ work, but this got tested anyhow and it did
_not_ fix things.

> -
> From: FUJITA Tomonori <tomof@acm.org>
> Subject: [PATCH] add use_sg_chaining option to scsi_host_template
> 
> This option is true if a low-level driver can support sg
> chaining. This will be removed eventually when all the drivers are
> converted to support sg chaining. q->max_phys_segments is set to
> SCSI_MAX_SG_SEGMENTS if false.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
>  arch/ia64/hp/sim/simscsi.c            |    1 +
>  drivers/scsi/3w-9xxx.c                |    1 +
>  drivers/scsi/3w-xxxx.c                |    1 +
>  drivers/scsi/BusLogic.c               |    1 +
>  drivers/scsi/NCR53c406a.c             |    3 ++-
>  drivers/scsi/a100u2w.c                |    1 +
>  drivers/scsi/aacraid/linit.c          |    1 +
>  drivers/scsi/aha1740.c                |    1 +
>  drivers/scsi/aic7xxx/aic79xx_osm.c    |    1 +
>  drivers/scsi/aic7xxx/aic7xxx_osm.c    |    1 +
>  drivers/scsi/aic7xxx_old.c            |    1 +
>  drivers/scsi/arcmsr/arcmsr_hba.c      |    1 +
>  drivers/scsi/dc395x.c                 |    1 +
>  drivers/scsi/dpt_i2o.c                |    1 +
>  drivers/scsi/eata.c                   |    3 ++-
>  drivers/scsi/hosts.c                  |    1 +
>  drivers/scsi/hptiop.c                 |    1 +
>  drivers/scsi/ibmmca.c                 |    1 +
>  drivers/scsi/ibmvscsi/ibmvscsi.c      |    1 +
>  drivers/scsi/initio.c                 |    1 +
>  drivers/scsi/ipr.c                    |    1 +
>  drivers/scsi/lpfc/lpfc_scsi.c         |    2 ++
>  drivers/scsi/mac53c94.c               |    1 +
>  drivers/scsi/megaraid.c               |    1 +
>  drivers/scsi/megaraid/megaraid_mbox.c |    1 +
>  drivers/scsi/megaraid/megaraid_sas.c  |    1 +
>  drivers/scsi/mesh.c                   |    1 +
>  drivers/scsi/nsp32.c                  |    1 +
>  drivers/scsi/pcmcia/sym53c500_cs.c    |    1 +
>  drivers/scsi/qla2xxx/qla_os.c         |    2 ++
>  drivers/scsi/qla4xxx/ql4_os.c         |    1 +
>  drivers/scsi/qlogicfas.c              |    1 +
>  drivers/scsi/scsi_lib.c               |    5 ++++-
>  drivers/scsi/stex.c                   |    1 +
>  drivers/scsi/sym53c416.c              |    1 +
>  drivers/scsi/sym53c8xx_2/sym_glue.c   |    1 +
>  drivers/scsi/u14-34f.c                |    1 +
>  drivers/scsi/ultrastor.c              |    1 +
>  drivers/scsi/wd7000.c                 |    1 +
>  include/scsi/scsi_host.h              |   13 +++++++++++++
>  40 files changed, 59 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/ia64/hp/sim/simscsi.c b/arch/ia64/hp/sim/simscsi.c
> index 4552a1c..e711657 100644
> --- a/arch/ia64/hp/sim/simscsi.c
> +++ b/arch/ia64/hp/sim/simscsi.c
> @@ -360,6 +360,7 @@ static struct scsi_host_template driver_template = {
>  	.max_sectors		= 1024,
>  	.cmd_per_lun		= SIMSCSI_REQ_QUEUE_LEN,
>  	.use_clustering		= DISABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  };
>  
>  static int __init
> diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c
> index efd9d8d..fb14014 100644
> --- a/drivers/scsi/3w-9xxx.c
> +++ b/drivers/scsi/3w-9xxx.c
> @@ -1990,6 +1990,7 @@ static struct scsi_host_template driver_template = {
>  	.max_sectors		= TW_MAX_SECTORS,
>  	.cmd_per_lun		= TW_MAX_CMDS_PER_LUN,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.shost_attrs		= twa_host_attrs,
>  	.emulated		= 1
>  };
> diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c
> index c7995fc..a64153b 100644
> --- a/drivers/scsi/3w-xxxx.c
> +++ b/drivers/scsi/3w-xxxx.c
> @@ -2261,6 +2261,7 @@ static struct scsi_host_template driver_template = {
>  	.max_sectors		= TW_MAX_SECTORS,
>  	.cmd_per_lun		= TW_MAX_CMDS_PER_LUN,	
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.shost_attrs		= tw_host_attrs,
>  	.emulated		= 1
>  };
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index 9b20617..49e1ffa 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -3575,6 +3575,7 @@ static struct scsi_host_template Bus_Logic_template = {
>  	.unchecked_isa_dma = 1,
>  	.max_sectors = 128,
>  	.use_clustering = ENABLE_CLUSTERING,
> +	.use_sg_chaining = ENABLE_SG_CHAINING,
>  };
>  
>  /*
> diff --git a/drivers/scsi/NCR53c406a.c b/drivers/scsi/NCR53c406a.c
> index eda8c48..3168a17 100644
> --- a/drivers/scsi/NCR53c406a.c
> +++ b/drivers/scsi/NCR53c406a.c
> @@ -1066,7 +1066,8 @@ static struct scsi_host_template driver_template =
>       .sg_tablesize      	= 32			/*SG_ALL*/ /*SG_NONE*/, 
>       .cmd_per_lun       	= 1			/* commands per lun */, 
>       .unchecked_isa_dma 	= 1			/* unchecked_isa_dma */,
> -     .use_clustering    	= ENABLE_CLUSTERING                               
> +     .use_clustering    	= ENABLE_CLUSTERING,
> +     .use_sg_chaining           = ENABLE_SG_CHAINING,
>  };
>  
>  #include "scsi_module.c"
> diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
> index f608d4a..d3a6d15 100644
> --- a/drivers/scsi/a100u2w.c
> +++ b/drivers/scsi/a100u2w.c
> @@ -1071,6 +1071,7 @@ static struct scsi_host_template inia100_template = {
>  	.sg_tablesize		= SG_ALL,
>  	.cmd_per_lun 		= 1,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  };
>  
>  static int __devinit inia100_probe_one(struct pci_dev *pdev,
> diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
> index a7f42a1..038980b 100644
> --- a/drivers/scsi/aacraid/linit.c
> +++ b/drivers/scsi/aacraid/linit.c
> @@ -944,6 +944,7 @@ static struct scsi_host_template aac_driver_template = {
>  	.cmd_per_lun    		= AAC_NUM_IO_FIB, 
>  #endif	
>  	.use_clustering			= ENABLE_CLUSTERING,
> +	.use_sg_chaining		= ENABLE_SG_CHAINING,
>  	.emulated                       = 1,
>  };
>  
> diff --git a/drivers/scsi/aha1740.c b/drivers/scsi/aha1740.c
> index e4a4f3a..f6722fd 100644
> --- a/drivers/scsi/aha1740.c
> +++ b/drivers/scsi/aha1740.c
> @@ -563,6 +563,7 @@ static struct scsi_host_template aha1740_template = {
>  	.sg_tablesize     = AHA1740_SCATTER,
>  	.cmd_per_lun      = AHA1740_CMDLUN,
>  	.use_clustering   = ENABLE_CLUSTERING,
> +	.use_sg_chaining  = ENABLE_SG_CHAINING,
>  	.eh_abort_handler = aha1740_eh_abort_handler,
>  };
>  
> diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c
> index a055a96..42c0f14 100644
> --- a/drivers/scsi/aic7xxx/aic79xx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
> @@ -766,6 +766,7 @@ struct scsi_host_template aic79xx_driver_template = {
>  	.max_sectors		= 8192,
>  	.cmd_per_lun		= 2,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.slave_alloc		= ahd_linux_slave_alloc,
>  	.slave_configure	= ahd_linux_slave_configure,
>  	.target_alloc		= ahd_linux_target_alloc,
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> index 2e9c38f..7770bef 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> @@ -747,6 +747,7 @@ struct scsi_host_template aic7xxx_driver_template = {
>  	.max_sectors		= 8192,
>  	.cmd_per_lun		= 2,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.slave_alloc		= ahc_linux_slave_alloc,
>  	.slave_configure	= ahc_linux_slave_configure,
>  	.target_alloc		= ahc_linux_target_alloc,
> diff --git a/drivers/scsi/aic7xxx_old.c b/drivers/scsi/aic7xxx_old.c
> index 1a71b02..4025608 100644
> --- a/drivers/scsi/aic7xxx_old.c
> +++ b/drivers/scsi/aic7xxx_old.c
> @@ -11142,6 +11142,7 @@ static struct scsi_host_template driver_template = {
>  	.max_sectors		= 2048,
>  	.cmd_per_lun		= 3,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  };
>  
>  #include "scsi_module.c"
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
> index 0ddfc21..d5039f3 100644
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> @@ -121,6 +121,7 @@ static struct scsi_host_template arcmsr_scsi_host_template = {
>  	.max_sectors    	= ARCMSR_MAX_XFER_SECTORS,
>  	.cmd_per_lun		= ARCMSR_MAX_CMD_PERLUN,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.shost_attrs		= arcmsr_host_attrs,
>  };
>  static struct pci_error_handlers arcmsr_pci_error_handlers = {
> diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
> index 7b8a345..d2a2026 100644
> --- a/drivers/scsi/dc395x.c
> +++ b/drivers/scsi/dc395x.c
> @@ -4765,6 +4765,7 @@ static struct scsi_host_template dc395x_driver_template = {
>  	.eh_bus_reset_handler   = dc395x_eh_bus_reset,
>  	.unchecked_isa_dma      = 0,
>  	.use_clustering         = DISABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  };
>  
>  
> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index bea9d65..8258506 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -3295,6 +3295,7 @@ static struct scsi_host_template adpt_template = {
>  	.this_id		= 7,
>  	.cmd_per_lun		= 1,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  };
>  
>  static s32 adpt_scsi_register(adpt_hba* pHba)
> diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c
> index a83e9f1..2f685cf 100644
> --- a/drivers/scsi/eata.c
> +++ b/drivers/scsi/eata.c
> @@ -523,7 +523,8 @@ static struct scsi_host_template driver_template = {
>  	.slave_configure = eata2x_slave_configure,
>  	.this_id = 7,
>  	.unchecked_isa_dma = 1,
> -	.use_clustering = ENABLE_CLUSTERING
> +	.use_clustering = ENABLE_CLUSTERING,
> +	.use_sg_chaining = ENABLE_SG_CHAINING,
>  };
>  
>  #if !defined(__BIG_ENDIAN_BITFIELD) && !defined(__LITTLE_ENDIAN_BITFIELD)
> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index 96bc312..8c42539 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -342,6 +342,7 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
>  	shost->unchecked_isa_dma = sht->unchecked_isa_dma;
>  	shost->use_clustering = sht->use_clustering;
>  	shost->ordered_tag = sht->ordered_tag;
> +	shost->use_sg_chaining = sht->use_sg_chaining;
>  
>  	if (sht->max_host_blocked)
>  		shost->max_host_blocked = sht->max_host_blocked;
> diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c
> index 8b384fa..8515054 100644
> --- a/drivers/scsi/hptiop.c
> +++ b/drivers/scsi/hptiop.c
> @@ -655,6 +655,7 @@ static struct scsi_host_template driver_template = {
>  	.unchecked_isa_dma          = 0,
>  	.emulated                   = 0,
>  	.use_clustering             = ENABLE_CLUSTERING,
> +	.use_sg_chaining            = ENABLE_SG_CHAINING,
>  	.proc_name                  = driver_name,
>  	.shost_attrs                = hptiop_attrs,
>  	.this_id                    = -1,
> diff --git a/drivers/scsi/ibmmca.c b/drivers/scsi/ibmmca.c
> index bff8252..695941a 100644
> --- a/drivers/scsi/ibmmca.c
> +++ b/drivers/scsi/ibmmca.c
> @@ -1501,6 +1501,7 @@ static struct scsi_host_template ibmmca_driver_template = {
>            .sg_tablesize   = 16,
>            .cmd_per_lun    = 1,
>            .use_clustering = ENABLE_CLUSTERING,
> +          .use_sg_chaining = ENABLE_SG_CHAINING,
>  };
>  
>  static int ibmmca_probe(struct device *dev)
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 93bd01b..084488c 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -1545,6 +1545,7 @@ static struct scsi_host_template driver_template = {
>  	.this_id = -1,
>  	.sg_tablesize = SG_ALL,
>  	.use_clustering = ENABLE_CLUSTERING,
> +	.use_sg_chaining = ENABLE_SG_CHAINING,
>  	.shost_attrs = ibmvscsi_attrs,
>  };
>  
> diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
> index d9dfb69..22d40fd 100644
> --- a/drivers/scsi/initio.c
> +++ b/drivers/scsi/initio.c
> @@ -2831,6 +2831,7 @@ static struct scsi_host_template initio_template = {
>  	.sg_tablesize		= SG_ALL,
>  	.cmd_per_lun		= 1,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  };
>  
>  static int initio_probe_one(struct pci_dev *pdev,
> diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
> index b41dfb5..ba7b567 100644
> --- a/drivers/scsi/ipr.c
> +++ b/drivers/scsi/ipr.c
> @@ -4949,6 +4949,7 @@ static struct scsi_host_template driver_template = {
>  	.max_sectors = IPR_IOA_MAX_SECTORS,
>  	.cmd_per_lun = IPR_MAX_CMD_PER_LUN,
>  	.use_clustering = ENABLE_CLUSTERING,
> +	.use_sg_chaining = ENABLE_SG_CHAINING,
>  	.shost_attrs = ipr_ioa_attrs,
>  	.sdev_attrs = ipr_dev_attrs,
>  	.proc_name = IPR_NAME
> diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
> index cd67493..c075556 100644
> --- a/drivers/scsi/lpfc/lpfc_scsi.c
> +++ b/drivers/scsi/lpfc/lpfc_scsi.c
> @@ -1438,6 +1438,7 @@ struct scsi_host_template lpfc_template = {
>  	.scan_finished		= lpfc_scan_finished,
>  	.this_id		= -1,
>  	.sg_tablesize		= LPFC_SG_SEG_CNT,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.cmd_per_lun		= LPFC_CMD_PER_LUN,
>  	.use_clustering		= ENABLE_CLUSTERING,
>  	.shost_attrs		= lpfc_hba_attrs,
> @@ -1460,6 +1461,7 @@ struct scsi_host_template lpfc_vport_template = {
>  	.sg_tablesize		= LPFC_SG_SEG_CNT,
>  	.cmd_per_lun		= LPFC_CMD_PER_LUN,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.shost_attrs		= lpfc_vport_attrs,
>  	.max_sectors		= 0xFFFF,
>  };
> diff --git a/drivers/scsi/mac53c94.c b/drivers/scsi/mac53c94.c
> index b12ad7c..a035001 100644
> --- a/drivers/scsi/mac53c94.c
> +++ b/drivers/scsi/mac53c94.c
> @@ -402,6 +402,7 @@ static struct scsi_host_template mac53c94_template = {
>  	.sg_tablesize	= SG_ALL,
>  	.cmd_per_lun	= 1,
>  	.use_clustering	= DISABLE_CLUSTERING,
> +	.use_sg_chaining = ENABLE_SG_CHAINING,
>  };
>  
>  static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *match)
> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> index 9023ec6..a0133b5 100644
> --- a/drivers/scsi/megaraid.c
> +++ b/drivers/scsi/megaraid.c
> @@ -4484,6 +4484,7 @@ static struct scsi_host_template megaraid_template = {
>  	.sg_tablesize			= MAX_SGLIST,
>  	.cmd_per_lun			= DEF_CMD_PER_LUN,
>  	.use_clustering			= ENABLE_CLUSTERING,
> +	.use_sg_chaining		= ENABLE_SG_CHAINING,
>  	.eh_abort_handler		= megaraid_abort,
>  	.eh_device_reset_handler	= megaraid_reset,
>  	.eh_bus_reset_handler		= megaraid_reset,
> diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c
> index c6a53dc..e4e4c6a 100644
> --- a/drivers/scsi/megaraid/megaraid_mbox.c
> +++ b/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -361,6 +361,7 @@ static struct scsi_host_template megaraid_template_g = {
>  	.eh_host_reset_handler		= megaraid_reset_handler,
>  	.change_queue_depth		= megaraid_change_queue_depth,
>  	.use_clustering			= ENABLE_CLUSTERING,
> +	.use_sg_chaining		= ENABLE_SG_CHAINING,
>  	.sdev_attrs			= megaraid_sdev_attrs,
>  	.shost_attrs			= megaraid_shost_attrs,
>  };
> diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c
> index ebb948c..e3c5c52 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.c
> +++ b/drivers/scsi/megaraid/megaraid_sas.c
> @@ -1110,6 +1110,7 @@ static struct scsi_host_template megasas_template = {
>  	.eh_timed_out = megasas_reset_timer,
>  	.bios_param = megasas_bios_param,
>  	.use_clustering = ENABLE_CLUSTERING,
> +	.use_sg_chaining = ENABLE_SG_CHAINING,
>  };
>  
>  /**
> diff --git a/drivers/scsi/mesh.c b/drivers/scsi/mesh.c
> index 651d09b..7470ff3 100644
> --- a/drivers/scsi/mesh.c
> +++ b/drivers/scsi/mesh.c
> @@ -1843,6 +1843,7 @@ static struct scsi_host_template mesh_template = {
>  	.sg_tablesize			= SG_ALL,
>  	.cmd_per_lun			= 2,
>  	.use_clustering			= DISABLE_CLUSTERING,
> +	.use_sg_chaining		= ENABLE_SG_CHAINING,
>  };
>  
>  static int mesh_probe(struct macio_dev *mdev, const struct of_device_id *match)
> diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
> index 4215f3b..6da1504 100644
> --- a/drivers/scsi/nsp32.c
> +++ b/drivers/scsi/nsp32.c
> @@ -281,6 +281,7 @@ static struct scsi_host_template nsp32_template = {
>  	.cmd_per_lun			= 1,
>  	.this_id			= NSP32_HOST_SCSIID,
>  	.use_clustering			= DISABLE_CLUSTERING,
> +	.use_sg_chaining		= ENABLE_SG_CHAINING,
>  	.eh_abort_handler       	= nsp32_eh_abort,
>  	.eh_bus_reset_handler		= nsp32_eh_bus_reset,
>  	.eh_host_reset_handler		= nsp32_eh_host_reset,
> diff --git a/drivers/scsi/pcmcia/sym53c500_cs.c b/drivers/scsi/pcmcia/sym53c500_cs.c
> index 961839e..190e2a7 100644
> --- a/drivers/scsi/pcmcia/sym53c500_cs.c
> +++ b/drivers/scsi/pcmcia/sym53c500_cs.c
> @@ -694,6 +694,7 @@ static struct scsi_host_template sym53c500_driver_template = {
>       .sg_tablesize		= 32,
>       .cmd_per_lun		= 1,
>       .use_clustering		= ENABLE_CLUSTERING,
> +     .use_sg_chaining		= ENABLE_SG_CHAINING,
>       .shost_attrs		= SYM53C500_shost_attrs
>  };
>  
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index acca898..3abbbc0 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -132,6 +132,7 @@ struct scsi_host_template qla2x00_driver_template = {
>  	.this_id		= -1,
>  	.cmd_per_lun		= 3,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.sg_tablesize		= SG_ALL,
>  
>  	/*
> @@ -163,6 +164,7 @@ struct scsi_host_template qla24xx_driver_template = {
>  	.this_id		= -1,
>  	.cmd_per_lun		= 3,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.sg_tablesize		= SG_ALL,
>  
>  	.max_sectors		= 0xFFFF,
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> index 8fa5aea..89460d2 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -94,6 +94,7 @@ static struct scsi_host_template qla4xxx_driver_template = {
>  	.this_id		= -1,
>  	.cmd_per_lun		= 3,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.sg_tablesize		= SG_ALL,
>  
>  	.max_sectors		= 0xFFFF,
> diff --git a/drivers/scsi/qlogicfas.c b/drivers/scsi/qlogicfas.c
> index 94baca8..2268ca1 100644
> --- a/drivers/scsi/qlogicfas.c
> +++ b/drivers/scsi/qlogicfas.c
> @@ -197,6 +197,7 @@ static struct scsi_host_template qlogicfas_driver_template = {
>  	.sg_tablesize		= SG_ALL,
>  	.cmd_per_lun		= 1,
>  	.use_clustering		= DISABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  };
>  
>  static __init int qlogicfas_init(void)
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index d0a1028..38eec00 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1685,7 +1685,10 @@ struct request_queue *__scsi_alloc_queue(struct Scsi_Host *shost,
>  	 * converted, so better keep it safe.
>  	 */
>  #ifdef ARCH_HAS_SG_CHAIN
> -	blk_queue_max_phys_segments(q, SCSI_MAX_SG_CHAIN_SEGMENTS);
> +	if (shost->use_sg_chaining)
> +		blk_queue_max_phys_segments(q, SCSI_MAX_SG_CHAIN_SEGMENTS);
> +	else
> +		blk_queue_max_phys_segments(q, SCSI_MAX_SG_SEGMENTS);
>  #else
>  	blk_queue_max_phys_segments(q, SCSI_MAX_SG_SEGMENTS);
>  #endif
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index 72f6d80..e3fab3a 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -1123,6 +1123,7 @@ static struct scsi_host_template driver_template = {
>  	.this_id			= -1,
>  	.sg_tablesize			= ST_MAX_SG,
>  	.cmd_per_lun			= ST_CMD_PER_LUN,
> +	.use_sg_chaining		= ENABLE_SG_CHAINING,
>  };
>  
>  static int stex_set_dma_mask(struct pci_dev * pdev)
> diff --git a/drivers/scsi/sym53c416.c b/drivers/scsi/sym53c416.c
> index 92bfaea..8befab7 100644
> --- a/drivers/scsi/sym53c416.c
> +++ b/drivers/scsi/sym53c416.c
> @@ -854,5 +854,6 @@ static struct scsi_host_template driver_template = {
>  	.cmd_per_lun =		1,
>  	.unchecked_isa_dma =	1,
>  	.use_clustering =	ENABLE_CLUSTERING,
> +	.use_sg_chaining =	ENABLE_SG_CHAINING,
>  };
>  #include "scsi_module.c"
> diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c
> index 764490e..7576c99 100644
> --- a/drivers/scsi/sym53c8xx_2/sym_glue.c
> +++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
> @@ -1827,6 +1827,7 @@ static struct scsi_host_template sym2_template = {
>  	.eh_host_reset_handler	= sym53c8xx_eh_host_reset_handler,
>  	.this_id		= 7,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  	.max_sectors		= 0xFFFF,
>  #ifdef SYM_LINUX_PROC_INFO_SUPPORT
>  	.proc_info		= sym53c8xx_proc_info,
> diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
> index 9e8232a..a0d9ef4 100644
> --- a/drivers/scsi/u14-34f.c
> +++ b/drivers/scsi/u14-34f.c
> @@ -451,6 +451,7 @@ static struct scsi_host_template driver_template = {
>                  .this_id                 = 7,
>                  .unchecked_isa_dma       = 1,
>                  .use_clustering          = ENABLE_CLUSTERING
> +                .use_sg_chaining         = ENABLE_SG_CHAINING,
>                  };
>  
>  #if !defined(__BIG_ENDIAN_BITFIELD) && !defined(__LITTLE_ENDIAN_BITFIELD)
> diff --git a/drivers/scsi/ultrastor.c b/drivers/scsi/ultrastor.c
> index c08235d..ea72bbe 100644
> --- a/drivers/scsi/ultrastor.c
> +++ b/drivers/scsi/ultrastor.c
> @@ -1197,5 +1197,6 @@ static struct scsi_host_template driver_template = {
>  	.cmd_per_lun       = ULTRASTOR_MAX_CMDS_PER_LUN,
>  	.unchecked_isa_dma = 1,
>  	.use_clustering    = ENABLE_CLUSTERING,
> +	.use_sg_chaining   = ENABLE_SG_CHAINING,
>  };
>  #include "scsi_module.c"
> diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
> index d6fd425..255c611 100644
> --- a/drivers/scsi/wd7000.c
> +++ b/drivers/scsi/wd7000.c
> @@ -1671,6 +1671,7 @@ static struct scsi_host_template driver_template = {
>  	.cmd_per_lun		= 1,
>  	.unchecked_isa_dma	= 1,
>  	.use_clustering		= ENABLE_CLUSTERING,
> +	.use_sg_chaining	= ENABLE_SG_CHAINING,
>  };
>  
>  #include "scsi_module.c"
> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
> index 88f6871..3ee3805 100644
> --- a/include/scsi/scsi_host.h
> +++ b/include/scsi/scsi_host.h
> @@ -36,6 +36,9 @@ struct blk_queue_tags;
>  #define DISABLE_CLUSTERING 0
>  #define ENABLE_CLUSTERING 1
>  
> +#define DISABLE_SG_CHAINING 0
> +#define ENABLE_SG_CHAINING 1
> +
>  enum scsi_eh_timer_return {
>  	EH_NOT_HANDLED,
>  	EH_HANDLED,
> @@ -435,6 +438,15 @@ struct scsi_host_template {
>  	unsigned ordered_tag:1;
>  
>  	/*
> +	 * true if the low-level driver can support sg chaining. this
> +	 * will be removed eventually when all the drivers are
> +	 * converted to support sg chaining.
> +	 *
> +	 * Status: OBSOLETE
> +	 */
> +	unsigned use_sg_chaining:1;
> +
> +	/*
>  	 * Countdown for host blocking with no commands outstanding
>  	 */
>  	unsigned int max_host_blocked;
> @@ -577,6 +589,7 @@ struct Scsi_Host {
>  	unsigned unchecked_isa_dma:1;
>  	unsigned use_clustering:1;
>  	unsigned use_blk_tcq:1;
> +	unsigned use_sg_chaining:1;
>  
>  	/*
>  	 * Host has requested that no further requests come through for the
> -- 
> 1.5.2.4

-apw

Re: 2.6.23-rc4-mm1

[Torsten Kaiser]

On 9/14/07, Andy Whitcroft <apw@shadowen.org> wrote:
> On Tue, Sep 11, 2007 at 04:31:12AM +0900, FUJITA Tomonori wrote:
> [...]
> >
> > Even if we revert the qla1280 patch, scsi-ml still sends chaining sg
> > list. So it doesn't work.
> >
> > The following patch disables chaining sg list for qla1280. If the fix
> > that I've just sent doesn't work, please try this.
>
> Ok, the other patch _did_ work, but this got tested anyhow and it did
> _not_ fix things.
>

Sorry to confirm this. My RAID5 got destroyed a second time.
To summarize what worked / not worked / and seems to work for me:

First 2 tries with unpatched rc4-mm1: Both times one sata_sil24-drive got kicked
Then I switched back to rc3-mm1, 18 boots with that kernel worked.
Then I tried the patched rc4-mm1 and it worked too.
The next boot also worked, but the third time kicked a drive out again.
But as nobody reads logs, I did not notice that and keep using the
patched rc4-mm1.
The next 5 times the system worked normally with the two remaining drives.
The sixth boot kicked the second sata_sil24 drive. That I did notice...
After reassembling the RAID, I'm now back to the patch rc4-mm1 that
did boot correctly this time.
So the patch just makes it unlikelier to hit the bug. Instead of
failing 2 out of 2 times, it only failed 2 out of 8 times.
I compared the rc4-mm1 boot from a working case and the case where it
kicked the first drive. Nothing seems to stand out...

< == good rc4-mm1 boot
> == bad rc4-mm1 boot that kicked the drive

145c145
< CPU 0: aperture @ 4000000 size 32 MB
---
> CPU 0: aperture @ b7f0000000 size 32 MB
154c154
< Calibrating delay using timer specific routine.. 5203.23 BogoMIPS
(lpj=26016160)
---
> Calibrating delay using timer specific routine.. 5203.22 BogoMIPS (lpj=26016138)
169c169
< APIC timer calibration result 12499998
---
> APIC timer calibration result 12499994
173c173
< Calibrating delay using timer specific routine.. 5222.40 BogoMIPS
(lpj=26112010)
---
> Calibrating delay using timer specific routine.. 5200.01 BogoMIPS (lpj=26000052)
182c182
< Calibrating delay using timer specific routine.. 5222.73 BogoMIPS
(lpj=26113694)
---
> Calibrating delay using timer specific routine.. 5200.01 BogoMIPS (lpj=26000081)
191c191
< Calibrating delay using timer specific routine.. 5223.07 BogoMIPS
(lpj=26115369)
---
> Calibrating delay using timer specific routine.. 5200.03 BogoMIPS (lpj=26000164)
269d268
< Switched to high resolution mode on CPU 3
270a270
> Switched to high resolution mode on CPU 3
502,509c502,509
< raid6: int64x1   2634 MB/s
< raid6: int64x2   3244 MB/s
< raid6: int64x4   3405 MB/s
< raid6: int64x8   2614 MB/s
< raid6: sse2x1    3607 MB/s
< raid6: sse2x2    4834 MB/s
< raid6: sse2x4    4946 MB/s
< raid6: using algorithm sse2x4 (4946 MB/s)
---
> raid6: int64x1   2680 MB/s
> raid6: int64x2   3232 MB/s
> raid6: int64x4   3411 MB/s
> raid6: int64x8   2620 MB/s
> raid6: sse2x1    3606 MB/s
> raid6: sse2x2    4810 MB/s
> raid6: sse2x4    4910 MB/s
> raid6: using algorithm sse2x4 (4910 MB/s)
567c567
< md1: bitmap initialized from disk: read 10/10 pages, set 96 bits
---
> md1: bitmap initialized from disk: read 10/10 pages, set 104 bits
568a569,655
> ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
>          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> ata1.00: status: {DRDY }
> ata1: soft resetting link
> ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> ata1.00: configured for UDMA/100
> ata1: EH complete
> sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> sd 0:0:0:0: [sda] Write Protect is off
> sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
>          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> ata1.00: status: {DRDY }
> ata1: soft resetting link
> ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> ata1.00: configured for UDMA/100
> ata1: EH complete
> sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> sd 0:0:0:0: [sda] Write Protect is off
> sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
>          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> ata1.00: status: {DRDY }
> ata1: soft resetting link
> ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> ata1.00: configured for UDMA/100
> ata1: EH complete
> sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> sd 0:0:0:0: [sda] Write Protect is off
> sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
>          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> ata1.00: status: {DRDY }
> ata1: soft resetting link
> ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> ata1.00: configured for UDMA/100
> ata1: EH complete
> sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> sd 0:0:0:0: [sda] Write Protect is off
> sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
>          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> ata1.00: status: {DRDY }
> ata1: soft resetting link
> ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> ata1.00: configured for UDMA/100
> ata1: EH complete
> sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> sd 0:0:0:0: [sda] Write Protect is off
> sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
>          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> ata1.00: status: {DRDY }
> ata1: soft resetting link
> ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> ata1.00: configured for UDMA/100
> sd 0:0:0:0: [sda] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE,SUGGEST_OK
> sd 0:0:0:0: [sda] Sense Key : Aborted Command [current] [descriptor]
> Descriptor sense data with sense descriptors (in hex):
>         72 0b 00 00 00 00 00 0c 00 0a 80 00 00 00 00 00
>         00 00 00 af
> sd 0:0:0:0: [sda] Add. Sense: No additional sense information
> end_request: I/O error, dev sda, sector 625137161
> ata1: EH complete
> sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> sd 0:0:0:0: [sda] Write Protect is off
> sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> md: super_written gets error=-5, uptodate=0
> raid5: Disk failure on sda2, disabling device. Operation continuing on 2 devices
571a659,663
> RAID5 conf printout:
>  --- rd:3 wd:2
>  disk 0, o:0, dev:sda2
>  disk 1, o:1, dev:sdb2
>  disk 2, o:1, dev:sdc2
576a669,672
> RAID5 conf printout:
>  --- rd:3 wd:2
>  disk 1, o:1, dev:sdb2
>  disk 2, o:1, dev:sdc2

Another good boot also showed the aperture at a similar high address:
CPU 0: aperture @ b7f2000000 size 32 MB
And that good boot also showed the "correct" BogoMIPS:
Calibrating delay using timer specific routine.. 5205.43 BogoMIPS (lpj=26027183)
Calibrating delay using timer specific routine.. 5200.01 BogoMIPS (lpj=26000052)
Calibrating delay using timer specific routine.. 5200.01 BogoMIPS (lpj=26000082)
Calibrating delay using timer specific routine.. 5200.03 BogoMIPS (lpj=26000166)

Anything more I can provide to help debugging this?

Torsten

Re: 2.6.23-rc4-mm1

[Andrew Morton]

On Fri, 14 Sep 2007 15:01:03 +0200 "Torsten Kaiser" <just.for.lkml@googlemail.com> wrote:

> On 9/14/07, Andy Whitcroft <apw@shadowen.org> wrote:
> > On Tue, Sep 11, 2007 at 04:31:12AM +0900, FUJITA Tomonori wrote:
> > [...]
> > >
> > > Even if we revert the qla1280 patch, scsi-ml still sends chaining sg
> > > list. So it doesn't work.
> > >
> > > The following patch disables chaining sg list for qla1280. If the fix
> > > that I've just sent doesn't work, please try this.
> >
> > Ok, the other patch _did_ work, but this got tested anyhow and it did
> > _not_ fix things.
> >
> 
> Sorry to confirm this. My RAID5 got destroyed a second time.
> To summarize what worked / not worked / and seems to work for me:
> 
> First 2 tries with unpatched rc4-mm1: Both times one sata_sil24-drive got kicked
> Then I switched back to rc3-mm1, 18 boots with that kernel worked.
> Then I tried the patched rc4-mm1 and it worked too.
> The next boot also worked, but the third time kicked a drive out again.
> But as nobody reads logs, I did not notice that and keep using the
> patched rc4-mm1.
> The next 5 times the system worked normally with the two remaining drives.
> The sixth boot kicked the second sata_sil24 drive. That I did notice...
> After reassembling the RAID, I'm now back to the patch rc4-mm1 that
> did boot correctly this time.
> So the patch just makes it unlikelier to hit the bug. Instead of
> failing 2 out of 2 times, it only failed 2 out of 8 times.
> I compared the rc4-mm1 boot from a working case and the case where it
> kicked the first drive. Nothing seems to stand out...
> 
> < == good rc4-mm1 boot
> > == bad rc4-mm1 boot that kicked the drive
> 
> 145c145
> < CPU 0: aperture @ 4000000 size 32 MB
> ---
> > CPU 0: aperture @ b7f0000000 size 32 MB
> 154c154
> < Calibrating delay using timer specific routine.. 5203.23 BogoMIPS
> (lpj=26016160)
> ---
> > Calibrating delay using timer specific routine.. 5203.22 BogoMIPS (lpj=26016138)
> 169c169
> < APIC timer calibration result 12499998
> ---
> > APIC timer calibration result 12499994
> 173c173
> < Calibrating delay using timer specific routine.. 5222.40 BogoMIPS
> (lpj=26112010)
> ---
> > Calibrating delay using timer specific routine.. 5200.01 BogoMIPS (lpj=26000052)
> 182c182
> < Calibrating delay using timer specific routine.. 5222.73 BogoMIPS
> (lpj=26113694)
> ---
> > Calibrating delay using timer specific routine.. 5200.01 BogoMIPS (lpj=26000081)
> 191c191
> < Calibrating delay using timer specific routine.. 5223.07 BogoMIPS
> (lpj=26115369)
> ---
> > Calibrating delay using timer specific routine.. 5200.03 BogoMIPS (lpj=26000164)
> 269d268
> < Switched to high resolution mode on CPU 3
> 270a270
> > Switched to high resolution mode on CPU 3
> 502,509c502,509
> < raid6: int64x1   2634 MB/s
> < raid6: int64x2   3244 MB/s
> < raid6: int64x4   3405 MB/s
> < raid6: int64x8   2614 MB/s
> < raid6: sse2x1    3607 MB/s
> < raid6: sse2x2    4834 MB/s
> < raid6: sse2x4    4946 MB/s
> < raid6: using algorithm sse2x4 (4946 MB/s)
> ---
> > raid6: int64x1   2680 MB/s
> > raid6: int64x2   3232 MB/s
> > raid6: int64x4   3411 MB/s
> > raid6: int64x8   2620 MB/s
> > raid6: sse2x1    3606 MB/s
> > raid6: sse2x2    4810 MB/s
> > raid6: sse2x4    4910 MB/s
> > raid6: using algorithm sse2x4 (4910 MB/s)
> 567c567
> < md1: bitmap initialized from disk: read 10/10 pages, set 96 bits
> ---
> > md1: bitmap initialized from disk: read 10/10 pages, set 104 bits
> 568a569,655
> > ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> > ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> > ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
> >          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> > ata1.00: status: {DRDY }
> > ata1: soft resetting link
> > ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> > ata1.00: configured for UDMA/100
> > ata1: EH complete
> > sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> > sd 0:0:0:0: [sda] Write Protect is off
> > sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> > sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> > ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> > ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> > ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
> >          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> > ata1.00: status: {DRDY }
> > ata1: soft resetting link
> > ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> > ata1.00: configured for UDMA/100
> > ata1: EH complete
> > sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> > sd 0:0:0:0: [sda] Write Protect is off
> > sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> > sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> > ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> > ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> > ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
> >          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> > ata1.00: status: {DRDY }
> > ata1: soft resetting link
> > ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> > ata1.00: configured for UDMA/100
> > ata1: EH complete
> > sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> > sd 0:0:0:0: [sda] Write Protect is off
> > sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> > sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> > ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> > ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> > ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
> >          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> > ata1.00: status: {DRDY }
> > ata1: soft resetting link
> > ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> > ata1.00: configured for UDMA/100
> > ata1: EH complete
> > sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> > sd 0:0:0:0: [sda] Write Protect is off
> > sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> > sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> > ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> > ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> > ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
> >          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> > ata1.00: status: {DRDY }
> > ata1: soft resetting link
> > ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> > ata1.00: configured for UDMA/100
> > ata1: EH complete
> > sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> > sd 0:0:0:0: [sda] Write Protect is off
> > sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> > sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> > ata1.00: exception Emask 0x20 SAct 0x1 SErr 0x0 action 0x2
> > ata1.00: irq_stat 0x00020002, PCI master abort while fetching SGT
> > ata1.00: cmd 61/08:00:09:d6:42/00:00:25:00:00/40 tag 0 cdb 0x0 data 4096 out
> >          res 50/00:00:af:ea:42/00:00:25:00:00/e0 Emask 0x20 (host bus error)
> > ata1.00: status: {DRDY }
> > ata1: soft resetting link
> > ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> > ata1.00: configured for UDMA/100
> > sd 0:0:0:0: [sda] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE,SUGGEST_OK
> > sd 0:0:0:0: [sda] Sense Key : Aborted Command [current] [descriptor]
> > Descriptor sense data with sense descriptors (in hex):
> >         72 0b 00 00 00 00 00 0c 00 0a 80 00 00 00 00 00
> >         00 00 00 af
> > sd 0:0:0:0: [sda] Add. Sense: No additional sense information
> > end_request: I/O error, dev sda, sector 625137161

So do we think it's a sata regression?

> > ata1: EH complete
> > sd 0:0:0:0: [sda] 625142448 512-byte hardware sectors (320073 MB)
> > sd 0:0:0:0: [sda] Write Protect is off
> > sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> > sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> > md: super_written gets error=-5, uptodate=0
> > raid5: Disk failure on sda2, disabling device. Operation continuing on 2 devices
> 571a659,663
> > RAID5 conf printout:
> >  --- rd:3 wd:2
> >  disk 0, o:0, dev:sda2
> >  disk 1, o:1, dev:sdb2
> >  disk 2, o:1, dev:sdc2
> 576a669,672
> > RAID5 conf printout:
> >  --- rd:3 wd:2
> >  disk 1, o:1, dev:sdb2
> >  disk 2, o:1, dev:sdc2
> 
> Another good boot also showed the aperture at a similar high address:
> CPU 0: aperture @ b7f2000000 size 32 MB
> And that good boot also showed the "correct" BogoMIPS:
> Calibrating delay using timer specific routine.. 5205.43 BogoMIPS (lpj=26027183)
> Calibrating delay using timer specific routine.. 5200.01 BogoMIPS (lpj=26000052)
> Calibrating delay using timer specific routine.. 5200.01 BogoMIPS (lpj=26000082)
> Calibrating delay using timer specific routine.. 5200.03 BogoMIPS (lpj=26000166)
> 
> Anything more I can provide to help debugging this?
> 

Let's keep linux-ide cc'ed, please.

Re: 2.6.23-rc4-mm1

[Paul Jackson]

FUJITA Tomonori wrote:
> Can you try this patch (against 2.6.23-rc4-mm1)?
> 
> >From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Date: Mon, 10 Sep 2007 04:17:13 +0100
> Subject: [PATCH] qla1280: sg chaining fixes
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
>  drivers/scsi/qla1280.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)

This patch works for me.

I was getting the scsi errors reported earlier in
this thread, running 2.6.23-rc4-mm1 on one of our
big SGI Altix systems.

Applying this patch fixed it, so far as I can tell,
which is to say my system boots cleanly once again.

Thanks.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

Re: 2.6.23-rc4-mm1

[FUJITA Tomonori]

On Fri, 14 Sep 2007 21:16:35 -0700
Paul Jackson <pj@sgi.com> wrote:

> FUJITA Tomonori wrote:
> > Can you try this patch (against 2.6.23-rc4-mm1)?
> > 
> > >From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
> > From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > Date: Mon, 10 Sep 2007 04:17:13 +0100
> > Subject: [PATCH] qla1280: sg chaining fixes
> > 
> > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > ---
> >  drivers/scsi/qla1280.c |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> This patch works for me.
> 
> I was getting the scsi errors reported earlier in
> this thread, running 2.6.23-rc4-mm1 on one of our
> big SGI Altix systems.
> 
> Applying this patch fixed it, so far as I can tell,
> which is to say my system boots cleanly once again.

Thanks for testing!

Jens, we could enable use_sg_chaining option for qla1280.


From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: [PATCH] qla1280: enable use_sg_chaining option

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
 drivers/scsi/qla1280.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 7c1eaec..83249af 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -4259,6 +4259,7 @@ static struct scsi_host_template qla1280_driver_template = {
 	.sg_tablesize		= SG_ALL,
 	.cmd_per_lun		= 1,
 	.use_clustering		= ENABLE_CLUSTERING,
+	.use_sg_chaining	= ENABLE_SG_CHAINING,
 };
 
 
-- 
1.5.2.4

Re: 2.6.23-rc4-mm1

[Jens Axboe]

On Sat, Sep 15 2007, FUJITA Tomonori wrote:
> On Fri, 14 Sep 2007 21:16:35 -0700
> Paul Jackson <pj@sgi.com> wrote:
> 
> > FUJITA Tomonori wrote:
> > > Can you try this patch (against 2.6.23-rc4-mm1)?
> > > 
> > > >From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
> > > From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > Date: Mon, 10 Sep 2007 04:17:13 +0100
> > > Subject: [PATCH] qla1280: sg chaining fixes
> > > 
> > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > ---
> > >  drivers/scsi/qla1280.c |    5 ++++-
> > >  1 files changed, 4 insertions(+), 1 deletions(-)
> > 
> > This patch works for me.
> > 
> > I was getting the scsi errors reported earlier in
> > this thread, running 2.6.23-rc4-mm1 on one of our
> > big SGI Altix systems.
> > 
> > Applying this patch fixed it, so far as I can tell,
> > which is to say my system boots cleanly once again.
> 
> Thanks for testing!
> 
> Jens, we could enable use_sg_chaining option for qla1280.

Added, thanks!

-- 
Jens Axboe

Re: 2.6.23-rc4-mm1

[FUJITA Tomonori]

On Mon, 17 Sep 2007 15:28:19 +0200
Jens Axboe <jens.axboe@oracle.com> wrote:

> On Sat, Sep 15 2007, FUJITA Tomonori wrote:
> > On Fri, 14 Sep 2007 21:16:35 -0700
> > Paul Jackson <pj@sgi.com> wrote:
> > 
> > > FUJITA Tomonori wrote:
> > > > Can you try this patch (against 2.6.23-rc4-mm1)?
> > > > 
> > > > >From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
> > > > From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > > Date: Mon, 10 Sep 2007 04:17:13 +0100
> > > > Subject: [PATCH] qla1280: sg chaining fixes
> > > > 
> > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > > ---
> > > >  drivers/scsi/qla1280.c |    5 ++++-
> > > >  1 files changed, 4 insertions(+), 1 deletions(-)
> > > 
> > > This patch works for me.
> > > 
> > > I was getting the scsi errors reported earlier in
> > > this thread, running 2.6.23-rc4-mm1 on one of our
> > > big SGI Altix systems.
> > > 
> > > Applying this patch fixed it, so far as I can tell,
> > > which is to say my system boots cleanly once again.
> > 
> > Thanks for testing!
> > 
> > Jens, we could enable use_sg_chaining option for qla1280.
> 
> Added, thanks!

Thanks.

BTW, please don't forget to integrate the following patches:


- revert sg segment size ifdefs

http://marc.info/?l=linux-scsi&m=118881264013097&w=2

- remove sglist_len

http://marc.info/?l=linux-scsi&m=118907920405100&w=2

Re: 2.6.23-rc4-mm1

[Jens Axboe]

On Mon, Sep 17 2007, FUJITA Tomonori wrote:
> On Mon, 17 Sep 2007 15:28:19 +0200
> Jens Axboe <jens.axboe@oracle.com> wrote:
> 
> > On Sat, Sep 15 2007, FUJITA Tomonori wrote:
> > > On Fri, 14 Sep 2007 21:16:35 -0700
> > > Paul Jackson <pj@sgi.com> wrote:
> > > 
> > > > FUJITA Tomonori wrote:
> > > > > Can you try this patch (against 2.6.23-rc4-mm1)?
> > > > > 
> > > > > >From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
> > > > > From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > > > Date: Mon, 10 Sep 2007 04:17:13 +0100
> > > > > Subject: [PATCH] qla1280: sg chaining fixes
> > > > > 
> > > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > > > ---
> > > > >  drivers/scsi/qla1280.c |    5 ++++-
> > > > >  1 files changed, 4 insertions(+), 1 deletions(-)
> > > > 
> > > > This patch works for me.
> > > > 
> > > > I was getting the scsi errors reported earlier in
> > > > this thread, running 2.6.23-rc4-mm1 on one of our
> > > > big SGI Altix systems.
> > > > 
> > > > Applying this patch fixed it, so far as I can tell,
> > > > which is to say my system boots cleanly once again.
> > > 
> > > Thanks for testing!
> > > 
> > > Jens, we could enable use_sg_chaining option for qla1280.
> > 
> > Added, thanks!
> 
> Thanks.
> 
> BTW, please don't forget to integrate the following patches:
> 
> 
> - revert sg segment size ifdefs
> 
> http://marc.info/?l=linux-scsi&m=118881264013097&w=2
> 
> - remove sglist_len
> 
> http://marc.info/?l=linux-scsi&m=118907920405100&w=2

Added, and I rebased the sglist-* branches to current again. So
everything should be fully uptodate once more.

-- 
Jens Axboe

Re: 2.6.23-rc4-mm1

[FUJITA Tomonori]

On Tue, 18 Sep 2007 12:18:40 +0200
Jens Axboe <jens.axboe@oracle.com> wrote:

> On Mon, Sep 17 2007, FUJITA Tomonori wrote:
> > On Mon, 17 Sep 2007 15:28:19 +0200
> > Jens Axboe <jens.axboe@oracle.com> wrote:
> > 
> > > On Sat, Sep 15 2007, FUJITA Tomonori wrote:
> > > > On Fri, 14 Sep 2007 21:16:35 -0700
> > > > Paul Jackson <pj@sgi.com> wrote:
> > > > 
> > > > > FUJITA Tomonori wrote:
> > > > > > Can you try this patch (against 2.6.23-rc4-mm1)?
> > > > > > 
> > > > > > >From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
> > > > > > From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > > > > Date: Mon, 10 Sep 2007 04:17:13 +0100
> > > > > > Subject: [PATCH] qla1280: sg chaining fixes
> > > > > > 
> > > > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > > > > ---
> > > > > >  drivers/scsi/qla1280.c |    5 ++++-
> > > > > >  1 files changed, 4 insertions(+), 1 deletions(-)
> > > > > 
> > > > > This patch works for me.
> > > > > 
> > > > > I was getting the scsi errors reported earlier in
> > > > > this thread, running 2.6.23-rc4-mm1 on one of our
> > > > > big SGI Altix systems.
> > > > > 
> > > > > Applying this patch fixed it, so far as I can tell,
> > > > > which is to say my system boots cleanly once again.
> > > > 
> > > > Thanks for testing!
> > > > 
> > > > Jens, we could enable use_sg_chaining option for qla1280.
> > > 
> > > Added, thanks!
> > 
> > Thanks.
> > 
> > BTW, please don't forget to integrate the following patches:
> > 
> > 
> > - revert sg segment size ifdefs
> > 
> > http://marc.info/?l=linux-scsi&m=118881264013097&w=2
> > 
> > - remove sglist_len
> > 
> > http://marc.info/?l=linux-scsi&m=118907920405100&w=2
> 
> Added, and I rebased the sglist-* branches to current again. So
> everything should be fully uptodate once more.

Thanks, here are a few more things.

- please drop the iscsi patch since Mike has major changes to iscsi
I/O path.

- ipr sg chaining need to be disabled since libata is not ready.

- you can add Doug's ACK to scsi_debug patch:

http://marc.info/?l=linux-scsi&m=118926325931801&w=2

Re: 2.6.23-rc4-mm1

[Jens Axboe]

On Tue, Sep 18 2007, FUJITA Tomonori wrote:
> On Tue, 18 Sep 2007 12:18:40 +0200
> Jens Axboe <jens.axboe@oracle.com> wrote:
> 
> > On Mon, Sep 17 2007, FUJITA Tomonori wrote:
> > > On Mon, 17 Sep 2007 15:28:19 +0200
> > > Jens Axboe <jens.axboe@oracle.com> wrote:
> > > 
> > > > On Sat, Sep 15 2007, FUJITA Tomonori wrote:
> > > > > On Fri, 14 Sep 2007 21:16:35 -0700
> > > > > Paul Jackson <pj@sgi.com> wrote:
> > > > > 
> > > > > > FUJITA Tomonori wrote:
> > > > > > > Can you try this patch (against 2.6.23-rc4-mm1)?
> > > > > > > 
> > > > > > > >From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
> > > > > > > From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > > > > > Date: Mon, 10 Sep 2007 04:17:13 +0100
> > > > > > > Subject: [PATCH] qla1280: sg chaining fixes
> > > > > > > 
> > > > > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > > > > > ---
> > > > > > >  drivers/scsi/qla1280.c |    5 ++++-
> > > > > > >  1 files changed, 4 insertions(+), 1 deletions(-)
> > > > > > 
> > > > > > This patch works for me.
> > > > > > 
> > > > > > I was getting the scsi errors reported earlier in
> > > > > > this thread, running 2.6.23-rc4-mm1 on one of our
> > > > > > big SGI Altix systems.
> > > > > > 
> > > > > > Applying this patch fixed it, so far as I can tell,
> > > > > > which is to say my system boots cleanly once again.
> > > > > 
> > > > > Thanks for testing!
> > > > > 
> > > > > Jens, we could enable use_sg_chaining option for qla1280.
> > > > 
> > > > Added, thanks!
> > > 
> > > Thanks.
> > > 
> > > BTW, please don't forget to integrate the following patches:
> > > 
> > > 
> > > - revert sg segment size ifdefs
> > > 
> > > http://marc.info/?l=linux-scsi&m=118881264013097&w=2
> > > 
> > > - remove sglist_len
> > > 
> > > http://marc.info/?l=linux-scsi&m=118907920405100&w=2
> > 
> > Added, and I rebased the sglist-* branches to current again. So
> > everything should be fully uptodate once more.
> 
> Thanks, here are a few more things.
> 
> - please drop the iscsi patch since Mike has major changes to iscsi
> I/O path.
> 
> - ipr sg chaining need to be disabled since libata is not ready.
> 
> - you can add Doug's ACK to scsi_debug patch:
> 
> http://marc.info/?l=linux-scsi&m=118926325931801&w=2

All done.

-- 
Jens Axboe