All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	"Mark M. Hoffman" <mhoffman@lightlink.com>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] hwmon: Add power meters to
Date: Tue, 11 Sep 2007 16:43:49 +0000	[thread overview]
Message-ID: <20070911164348.GD30825@tree.beaverton.ibm.com> (raw)
In-Reply-To: <20070830115743.4dd8b2d5@hyperion.delvare>


[-- Attachment #1.1: Type: text/plain, Size: 662 bytes --]

On Thu, Aug 30, 2007 at 11:57:43AM +0200, Jean Delvare wrote:
> OK, that's a bit different then, but I'm still not sure that there is
> much value in exporting these values in sysfs, in particular if there
> is no way to reset them.

It turns out there _is_ a way to reset them; the next iteration of the
driver will have it.

> I am also not happy with the names you proposed: power1_max_input and
> power1_min_input are somewhat confusing IMHO, I'd suggest
> power1_input_highest and power1_input_lowest to make them clearly
> different from the min and max limits we have for other sensor types.
> If we have them at all, of course.

Agreed and changed.

--D

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	"Mark M. Hoffman" <mhoffman@lightlink.com>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface
Date: Tue, 11 Sep 2007 09:43:49 -0700	[thread overview]
Message-ID: <20070911164348.GD30825@tree.beaverton.ibm.com> (raw)
In-Reply-To: <20070830115743.4dd8b2d5@hyperion.delvare>

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

On Thu, Aug 30, 2007 at 11:57:43AM +0200, Jean Delvare wrote:
> OK, that's a bit different then, but I'm still not sure that there is
> much value in exporting these values in sysfs, in particular if there
> is no way to reset them.

It turns out there _is_ a way to reset them; the next iteration of the
driver will have it.

> I am also not happy with the names you proposed: power1_max_input and
> power1_min_input are somewhat confusing IMHO, I'd suggest
> power1_input_highest and power1_input_lowest to make them clearly
> different from the min and max limits we have for other sensor types.
> If we have them at all, of course.

Agreed and changed.

--D

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-09-11 16:43 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-27 21:14 [lm-sensors] [PATCH] v1 of IBM power meter driver Darrick J. Wong
2007-08-27 21:14 ` Darrick J. Wong
2007-08-28  1:50 ` [lm-sensors] " Henrique de Moraes Holschuh
2007-08-28  1:50   ` Henrique de Moraes Holschuh
2007-08-28 11:19   ` [lm-sensors] " Jean Delvare
2007-08-28 11:19     ` Jean Delvare
2007-08-28 16:28     ` Darrick J. Wong
2007-08-28 16:28       ` Darrick J. Wong
2007-08-29  9:49       ` Jean Delvare
2007-08-29  9:49         ` Jean Delvare
2007-08-29 12:45         ` Frank Phillips
2007-08-29 12:45           ` Frank Phillips
2007-08-28 16:44     ` [lm-sensors] [PATCH] hwmon: Add power meters to Darrick J. Wong
2007-08-28 16:44       ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-08-29  9:10       ` [lm-sensors] [PATCH] hwmon: Add power meters to Jean Delvare
2007-08-29  9:10         ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Jean Delvare
2007-08-29 14:50         ` [lm-sensors] [PATCH] hwmon: Add power meters to Darrick J. Wong
2007-08-29 14:50           ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-08-30  9:57           ` [lm-sensors] [PATCH] hwmon: Add power meters to Jean Delvare
2007-08-30  9:57             ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-11 16:43             ` Darrick J. Wong [this message]
2007-09-11 16:43               ` Darrick J. Wong
2007-09-01 17:10       ` [lm-sensors] [PATCH] hwmon: Add power meters to Pavel Machek
2007-09-01 17:10         ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Pavel Machek
2007-09-01 18:05         ` [lm-sensors] [PATCH] hwmon: Add power meters to Shem Multinymous
2007-09-01 18:05           ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Shem Multinymous
2007-09-01 19:44           ` [lm-sensors] [PATCH] hwmon: Add power meters Henrique de Moraes Holschuh
2007-09-01 19:44             ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Henrique de Moraes Holschuh
2007-09-02 19:38             ` [lm-sensors] [PATCH] hwmon: Add power meters to Jean Delvare
2007-09-02 19:38               ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-03  2:02               ` [lm-sensors] [PATCH] hwmon: Add power meters Henrique de Moraes Holschuh
2007-09-03  2:02                 ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Henrique de Moraes Holschuh
2007-09-03 16:06                 ` [lm-sensors] [PATCH] hwmon: Add power meters to Jean Delvare
2007-09-03 16:06                   ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-03 23:22                   ` [lm-sensors] [PATCH] hwmon: Add power meters Henrique de Moraes Holschuh
2007-09-03 23:22                     ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Henrique de Moraes Holschuh
2007-09-06  9:34                     ` [lm-sensors] [PATCH] hwmon: Add power meters to Jean Delvare
2007-09-06  9:34                       ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-06 16:29                       ` [lm-sensors] [PATCH] hwmon: Add power meters Henrique de Moraes Holschuh
2007-09-06 16:29                         ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Henrique de Moraes Holschuh
2007-08-28 16:49     ` [lm-sensors] [PATCH] v2 of IBM power meter driver Darrick J. Wong
2007-08-28 16:49       ` Darrick J. Wong
2007-08-28 23:25       ` [lm-sensors] [PATCH] v3 " Darrick J. Wong
2007-08-28 23:25         ` Darrick J. Wong
2007-09-11 13:23         ` [lm-sensors] " Mark M. Hoffman
2007-09-11 13:23           ` Mark M. Hoffman
2007-09-12  1:11           ` [lm-sensors] " Darrick J. Wong
2007-09-12  1:11             ` Darrick J. Wong
2007-09-14 19:29           ` [lm-sensors] [PATCH v2] hwmon: Update Darrick J. Wong
2007-09-14 19:29             ` [PATCH v2] hwmon: Update Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-09-17 17:28             ` [lm-sensors] [PATCH v2] hwmon: Update Jean Delvare
2007-09-17 17:28               ` [PATCH v2] hwmon: Update Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-17 18:43               ` [lm-sensors] [PATCH v2] hwmon: Update Darrick J. Wong
2007-09-17 18:43                 ` [PATCH v2] hwmon: Update Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-09-21  8:43                 ` [lm-sensors] [PATCH v2] hwmon: Update Jean Delvare
2007-09-21  8:43                   ` [PATCH v2] hwmon: Update Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-14 19:33           ` [lm-sensors] [PATCH v4] IBM power meter driver Darrick J. Wong
2007-09-14 19:33             ` Darrick J. Wong
2007-10-09 12:00             ` [lm-sensors] " Mark M. Hoffman
2007-10-09 12:00               ` Mark M. Hoffman
2007-10-09 16:44               ` [lm-sensors] " Roel Kluin
2007-10-09 16:44                 ` Roel Kluin
2007-10-09 20:40                 ` [lm-sensors] " Darrick J. Wong
2007-10-09 20:40                   ` Darrick J. Wong
2007-10-09 22:08                 ` [lm-sensors] [PATCH] ibmpex: Release IPMI user if hwmon Darrick J. Wong
2007-10-09 22:08                   ` [PATCH] ibmpex: Release IPMI user if hwmon registration fails Darrick J. Wong
2007-10-11 11:45                   ` [lm-sensors] [PATCH] ibmpex: Release IPMI user if hwmon Mark M. Hoffman
2007-10-11 11:45                     ` [PATCH] ibmpex: Release IPMI user if hwmon registration fails Mark M. Hoffman
2007-10-13  0:29               ` [lm-sensors] [PATCH v4] IBM power meter driver Darrick J. Wong
2007-10-13  0:29                 ` Darrick J. Wong
2007-09-11 13:59         ` [lm-sensors] [PATCH] v3 of " Jean Delvare
2007-09-11 13:59           ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070911164348.GD30825@tree.beaverton.ibm.com \
    --to=djwong@us.ibm.com \
    --cc=hmh@hmh.eng.br \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mhoffman@lightlink.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.