From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>,
Jean Delvare <khali@linux-fr.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
haveblue@us.ibm.com
Subject: [lm-sensors] [PATCH] ibmpex: Release IPMI user if hwmon
Date: Tue, 09 Oct 2007 22:08:24 +0000 [thread overview]
Message-ID: <20071009220824.GL16752@tree.beaverton.ibm.com> (raw)
In-Reply-To: <470BAFD7.10305@tiscali.nl>
Roel Kluin <12o3l@tiscali.nl> found a minor defect in the init code if
hwmon device registration fails.
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---
drivers/hwmon/ibmpex.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
index fe2c261..c462824 100644
--- a/drivers/hwmon/ibmpex.c
+++ b/drivers/hwmon/ibmpex.c
@@ -498,8 +498,7 @@ static void ibmpex_register_bmc(int iface, struct device *dev)
printk(KERN_ERR DRVNAME ": Error, unable to register hwmon "
"class device for interface %d\n",
data->interface);
- kfree(data);
- return;
+ goto out_user;
}
/* finally add the new bmc data to the bmc data list */
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>,
Jean Delvare <khali@linux-fr.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
haveblue@us.ibm.com
Subject: [PATCH] ibmpex: Release IPMI user if hwmon registration fails
Date: Tue, 9 Oct 2007 15:08:24 -0700 [thread overview]
Message-ID: <20071009220824.GL16752@tree.beaverton.ibm.com> (raw)
In-Reply-To: <470BAFD7.10305@tiscali.nl>
Roel Kluin <12o3l@tiscali.nl> found a minor defect in the init code if
hwmon device registration fails.
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---
drivers/hwmon/ibmpex.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
index fe2c261..c462824 100644
--- a/drivers/hwmon/ibmpex.c
+++ b/drivers/hwmon/ibmpex.c
@@ -498,8 +498,7 @@ static void ibmpex_register_bmc(int iface, struct device *dev)
printk(KERN_ERR DRVNAME ": Error, unable to register hwmon "
"class device for interface %d\n",
data->interface);
- kfree(data);
- return;
+ goto out_user;
}
/* finally add the new bmc data to the bmc data list */
next prev parent reply other threads:[~2007-10-09 22:08 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 21:14 [lm-sensors] [PATCH] v1 of IBM power meter driver Darrick J. Wong
2007-08-27 21:14 ` Darrick J. Wong
2007-08-28 1:50 ` [lm-sensors] " Henrique de Moraes Holschuh
2007-08-28 1:50 ` Henrique de Moraes Holschuh
2007-08-28 11:19 ` [lm-sensors] " Jean Delvare
2007-08-28 11:19 ` Jean Delvare
2007-08-28 16:28 ` Darrick J. Wong
2007-08-28 16:28 ` Darrick J. Wong
2007-08-29 9:49 ` Jean Delvare
2007-08-29 9:49 ` Jean Delvare
2007-08-29 12:45 ` Frank Phillips
2007-08-29 12:45 ` Frank Phillips
2007-08-28 16:44 ` [lm-sensors] [PATCH] hwmon: Add power meters to Darrick J. Wong
2007-08-28 16:44 ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-08-29 9:10 ` [lm-sensors] [PATCH] hwmon: Add power meters to Jean Delvare
2007-08-29 9:10 ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Jean Delvare
2007-08-29 14:50 ` [lm-sensors] [PATCH] hwmon: Add power meters to Darrick J. Wong
2007-08-29 14:50 ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-08-30 9:57 ` [lm-sensors] [PATCH] hwmon: Add power meters to Jean Delvare
2007-08-30 9:57 ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-11 16:43 ` [lm-sensors] [PATCH] hwmon: Add power meters to Darrick J. Wong
2007-09-11 16:43 ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-09-01 17:10 ` [lm-sensors] [PATCH] hwmon: Add power meters to Pavel Machek
2007-09-01 17:10 ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Pavel Machek
2007-09-01 18:05 ` [lm-sensors] [PATCH] hwmon: Add power meters to Shem Multinymous
2007-09-01 18:05 ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Shem Multinymous
2007-09-01 19:44 ` [lm-sensors] [PATCH] hwmon: Add power meters Henrique de Moraes Holschuh
2007-09-01 19:44 ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Henrique de Moraes Holschuh
2007-09-02 19:38 ` [lm-sensors] [PATCH] hwmon: Add power meters to Jean Delvare
2007-09-02 19:38 ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-03 2:02 ` [lm-sensors] [PATCH] hwmon: Add power meters Henrique de Moraes Holschuh
2007-09-03 2:02 ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Henrique de Moraes Holschuh
2007-09-03 16:06 ` [lm-sensors] [PATCH] hwmon: Add power meters to Jean Delvare
2007-09-03 16:06 ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-03 23:22 ` [lm-sensors] [PATCH] hwmon: Add power meters Henrique de Moraes Holschuh
2007-09-03 23:22 ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Henrique de Moraes Holschuh
2007-09-06 9:34 ` [lm-sensors] [PATCH] hwmon: Add power meters to Jean Delvare
2007-09-06 9:34 ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-06 16:29 ` [lm-sensors] [PATCH] hwmon: Add power meters Henrique de Moraes Holschuh
2007-09-06 16:29 ` [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Henrique de Moraes Holschuh
2007-08-28 16:49 ` [lm-sensors] [PATCH] v2 of IBM power meter driver Darrick J. Wong
2007-08-28 16:49 ` Darrick J. Wong
2007-08-28 23:25 ` [lm-sensors] [PATCH] v3 " Darrick J. Wong
2007-08-28 23:25 ` Darrick J. Wong
2007-09-11 13:23 ` [lm-sensors] " Mark M. Hoffman
2007-09-11 13:23 ` Mark M. Hoffman
2007-09-12 1:11 ` [lm-sensors] " Darrick J. Wong
2007-09-12 1:11 ` Darrick J. Wong
2007-09-14 19:29 ` [lm-sensors] [PATCH v2] hwmon: Update Darrick J. Wong
2007-09-14 19:29 ` [PATCH v2] hwmon: Update Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-09-17 17:28 ` [lm-sensors] [PATCH v2] hwmon: Update Jean Delvare
2007-09-17 17:28 ` [PATCH v2] hwmon: Update Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-17 18:43 ` [lm-sensors] [PATCH v2] hwmon: Update Darrick J. Wong
2007-09-17 18:43 ` [PATCH v2] hwmon: Update Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-09-21 8:43 ` [lm-sensors] [PATCH v2] hwmon: Update Jean Delvare
2007-09-21 8:43 ` [PATCH v2] hwmon: Update Documentation/hwmon/sysfs-interface Jean Delvare
2007-09-14 19:33 ` [lm-sensors] [PATCH v4] IBM power meter driver Darrick J. Wong
2007-09-14 19:33 ` Darrick J. Wong
2007-10-09 12:00 ` [lm-sensors] " Mark M. Hoffman
2007-10-09 12:00 ` Mark M. Hoffman
2007-10-09 16:44 ` [lm-sensors] " Roel Kluin
2007-10-09 16:44 ` Roel Kluin
2007-10-09 20:40 ` [lm-sensors] " Darrick J. Wong
2007-10-09 20:40 ` Darrick J. Wong
2007-10-09 22:08 ` Darrick J. Wong [this message]
2007-10-09 22:08 ` [PATCH] ibmpex: Release IPMI user if hwmon registration fails Darrick J. Wong
2007-10-11 11:45 ` [lm-sensors] [PATCH] ibmpex: Release IPMI user if hwmon Mark M. Hoffman
2007-10-11 11:45 ` [PATCH] ibmpex: Release IPMI user if hwmon registration fails Mark M. Hoffman
2007-10-13 0:29 ` [lm-sensors] [PATCH v4] IBM power meter driver Darrick J. Wong
2007-10-13 0:29 ` Darrick J. Wong
2007-09-11 13:59 ` [lm-sensors] [PATCH] v3 of " Jean Delvare
2007-09-11 13:59 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009220824.GL16752@tree.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=12o3l@tiscali.nl \
--cc=haveblue@us.ibm.com \
--cc=hmh@hmh.eng.br \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.