From: Scott Wood <scottwood@freescale.com>
To: Rune Torgersen <runet@innovsys.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH4/4] [POWERPC] Fix cpm_uart driver
Date: Wed, 26 Sep 2007 15:41:56 -0500 [thread overview]
Message-ID: <20070926204156.GA15217@loki.buserror.net> (raw)
In-Reply-To: <DCEAAC0833DD314AB0B58112AD99B93B0368C44B@ismail.innsys.innovsys.com>
On Wed, Sep 26, 2007 at 03:32:29PM -0500, Rune Torgersen wrote:
> > From: Scott Wood
> > Maybe that's how it was, but the current code initializes it (more or
> > less) directly with IMAP_ADDR, which also gets fed into ioremap.
> >
> > One of the two has got to be wrong.
>
> arch/ppc maps the immr area 1:1 into kernel memory, so ioremap and
> physical are the same.
> See arch/ppc/syslib/m8260_setup.c, line 208 (function m8260_map_io)
We were talking about 8xx, not 82xx -- is it always identity mapped there?
If so, then why bother with the ioremap in immr_map_size() in
arch/ppc/8xx_io/commproc.c? And why compare the result from ioremap() with
a raw identity-mapped address?
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Rune Torgersen <runet@innovsys.com>
Cc: Dan Malek <dan@embeddedalley.com>,
linuxppc-embedded@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH4/4] [POWERPC] Fix cpm_uart driver
Date: Wed, 26 Sep 2007 15:41:56 -0500 [thread overview]
Message-ID: <20070926204156.GA15217@loki.buserror.net> (raw)
In-Reply-To: <DCEAAC0833DD314AB0B58112AD99B93B0368C44B@ismail.innsys.innovsys.com>
On Wed, Sep 26, 2007 at 03:32:29PM -0500, Rune Torgersen wrote:
> > From: Scott Wood
> > Maybe that's how it was, but the current code initializes it (more or
> > less) directly with IMAP_ADDR, which also gets fed into ioremap.
> >
> > One of the two has got to be wrong.
>
> arch/ppc maps the immr area 1:1 into kernel memory, so ioremap and
> physical are the same.
> See arch/ppc/syslib/m8260_setup.c, line 208 (function m8260_map_io)
We were talking about 8xx, not 82xx -- is it always identity mapped there?
If so, then why bother with the ioremap in immr_map_size() in
arch/ppc/8xx_io/commproc.c? And why compare the result from ioremap() with
a raw identity-mapped address?
-Scott
next prev parent reply other threads:[~2007-09-26 20:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-23 20:17 [PATCH4/4] [POWERPC] Fix cpm_uart driver Jochen Friedrich
2007-09-23 20:17 ` Jochen Friedrich
2007-09-24 15:57 ` Scott Wood
2007-09-24 15:57 ` Scott Wood
2007-09-24 17:06 ` Jochen Friedrich
2007-09-24 17:06 ` Jochen Friedrich
2007-09-24 18:22 ` Scott Wood
2007-09-24 18:22 ` Scott Wood
2007-09-24 19:16 ` Dan Malek
2007-09-24 19:16 ` Dan Malek
2007-09-24 19:29 ` Scott Wood
2007-09-24 19:29 ` Scott Wood
2007-09-26 20:32 ` Rune Torgersen
2007-09-26 20:32 ` Rune Torgersen
2007-09-26 20:41 ` Scott Wood [this message]
2007-09-26 20:41 ` Scott Wood
2007-09-25 12:09 ` Jochen Friedrich
2007-09-25 12:09 ` Jochen Friedrich
2007-09-25 15:11 ` Scott Wood
2007-09-25 15:11 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070926204156.GA15217@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=runet@innovsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.