From: Scott Wood <scottwood@freescale.com>
To: Dan Malek <dan@embeddedalley.com>
Cc: linuxppc-embedded@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH4/4] [POWERPC] Fix cpm_uart driver
Date: Mon, 24 Sep 2007 14:29:34 -0500 [thread overview]
Message-ID: <46F8101E.1050000@freescale.com> (raw)
In-Reply-To: <FF1A2486-BE77-49F8-99F3-B09B4EEAF50D@embeddedalley.com>
Dan Malek wrote:
>
> On Sep 24, 2007, at 11:22 AM, Scott Wood wrote:
>
>> cpmp is a physical address on arch/ppc?
>
> No, it's a well known ioremaped() address into the IMMR space.
Maybe that's how it was, but the current code initializes it (more or
less) directly with IMAP_ADDR, which also gets fed into ioremap.
One of the two has got to be wrong.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Dan Malek <dan@embeddedalley.com>
Cc: Jochen Friedrich <jochen@scram.de>,
linux-kernel@vger.kernel.org, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH4/4] [POWERPC] Fix cpm_uart driver
Date: Mon, 24 Sep 2007 14:29:34 -0500 [thread overview]
Message-ID: <46F8101E.1050000@freescale.com> (raw)
In-Reply-To: <FF1A2486-BE77-49F8-99F3-B09B4EEAF50D@embeddedalley.com>
Dan Malek wrote:
>
> On Sep 24, 2007, at 11:22 AM, Scott Wood wrote:
>
>> cpmp is a physical address on arch/ppc?
>
> No, it's a well known ioremaped() address into the IMMR space.
Maybe that's how it was, but the current code initializes it (more or
less) directly with IMAP_ADDR, which also gets fed into ioremap.
One of the two has got to be wrong.
-Scott
next prev parent reply other threads:[~2007-09-24 19:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-23 20:17 [PATCH4/4] [POWERPC] Fix cpm_uart driver Jochen Friedrich
2007-09-23 20:17 ` Jochen Friedrich
2007-09-24 15:57 ` Scott Wood
2007-09-24 15:57 ` Scott Wood
2007-09-24 17:06 ` Jochen Friedrich
2007-09-24 17:06 ` Jochen Friedrich
2007-09-24 18:22 ` Scott Wood
2007-09-24 18:22 ` Scott Wood
2007-09-24 19:16 ` Dan Malek
2007-09-24 19:16 ` Dan Malek
2007-09-24 19:29 ` Scott Wood [this message]
2007-09-24 19:29 ` Scott Wood
2007-09-26 20:32 ` Rune Torgersen
2007-09-26 20:32 ` Rune Torgersen
2007-09-26 20:41 ` Scott Wood
2007-09-26 20:41 ` Scott Wood
2007-09-25 12:09 ` Jochen Friedrich
2007-09-25 12:09 ` Jochen Friedrich
2007-09-25 15:11 ` Scott Wood
2007-09-25 15:11 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F8101E.1050000@freescale.com \
--to=scottwood@freescale.com \
--cc=dan@embeddedalley.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.