From: travis@sgi.com
To: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>,
mingo@elte.hu
Cc: Christoph Lameter <clameter@sgi.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Eric Dumazet <dada1@cosmosbay.com>
Subject: [PATCH 1/5] x86: Change size of node ids from u8 to u16 fixup
Date: Fri, 18 Jan 2008 10:30:12 -0800 [thread overview]
Message-ID: <20080118183011.527888000@sgi.com> (raw)
In-Reply-To: 20080118183011.354965000@sgi.com
[-- Attachment #1: big_nodeids-fixup --]
[-- Type: text/plain, Size: 2253 bytes --]
Change the size of node ids for X86_64 from 8 bits to 16 bits
to accomodate more than 256 nodes.
Introduce a "numanode_t" type for x86-generic usage.
Cc: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Mike Travis <travis@sgi.com>
Reviewed-by: Christoph Lameter <clameter@sgi.com>
---
Fixup:
Size of memnode.embedded_map needs to be changed to
accomodate 16-bit node ids as suggested by Eric.
V2->V3:
- changed memnode.embedded_map from [64-16] to [64-8]
(and size comment to 128 bytes)
V1->V2:
- changed pxm_to_node_map to u16
- changed memnode map entries to u16
---
arch/x86/mm/numa_64.c | 2 +-
drivers/acpi/numa.c | 2 +-
include/asm-x86/mmzone_64.h | 6 +++---
include/linux/numa.h | 6 ++++++
4 files changed, 11 insertions(+), 5 deletions(-)
--- a/arch/x86/mm/numa_64.c
+++ b/arch/x86/mm/numa_64.c
@@ -88,7 +88,7 @@ static int __init allocate_cachealigned_
unsigned long pad, pad_addr;
memnodemap = memnode.embedded_map;
- if (memnodemapsize <= 48)
+ if (memnodemapsize <= ARRAY_SIZE(memnode.embedded_map))
return 0;
pad = L1_CACHE_BYTES - 1;
--- a/drivers/acpi/numa.c
+++ b/drivers/acpi/numa.c
@@ -38,7 +38,7 @@ ACPI_MODULE_NAME("numa");
static nodemask_t nodes_found_map = NODE_MASK_NONE;
/* maps to convert between proximity domain and logical node ID */
-static int pxm_to_node_map[MAX_PXM_DOMAINS]
+static numanode_t pxm_to_node_map[MAX_PXM_DOMAINS]
= { [0 ... MAX_PXM_DOMAINS - 1] = NID_INVAL };
static int node_to_pxm_map[MAX_NUMNODES]
= { [0 ... MAX_NUMNODES - 1] = PXM_INVAL };
--- a/include/asm-x86/mmzone_64.h
+++ b/include/asm-x86/mmzone_64.h
@@ -15,9 +15,9 @@
struct memnode {
int shift;
unsigned int mapsize;
- u8 *map;
- u8 embedded_map[64-16];
-} ____cacheline_aligned; /* total size = 64 bytes */
+ u16 *map;
+ u16 embedded_map[64-8];
+} ____cacheline_aligned; /* total size = 128 bytes */
extern struct memnode memnode;
#define memnode_shift memnode.shift
#define memnodemap memnode.map
--- a/include/linux/numa.h
+++ b/include/linux/numa.h
@@ -10,4 +10,10 @@
#define MAX_NUMNODES (1 << NODES_SHIFT)
+#if MAX_NUMNODES > 256
+typedef u16 numanode_t;
+#else
+typedef u8 numanode_t;
+#endif
+
#endif /* _LINUX_NUMA_H */
--
WARNING: multiple messages have this Message-ID (diff)
From: travis@sgi.com
To: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>,
mingo@elte.hu
Cc: Christoph Lameter <clameter@sgi.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Eric Dumazet <dada1@cosmosbay.com>
Subject: [PATCH 1/5] x86: Change size of node ids from u8 to u16 fixup
Date: Fri, 18 Jan 2008 10:30:12 -0800 [thread overview]
Message-ID: <20080118183011.527888000@sgi.com> (raw)
In-Reply-To: 20080118183011.354965000@sgi.com
[-- Attachment #1: big_nodeids-fixup --]
[-- Type: text/plain, Size: 2479 bytes --]
Change the size of node ids for X86_64 from 8 bits to 16 bits
to accomodate more than 256 nodes.
Introduce a "numanode_t" type for x86-generic usage.
Cc: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Mike Travis <travis@sgi.com>
Reviewed-by: Christoph Lameter <clameter@sgi.com>
---
Fixup:
Size of memnode.embedded_map needs to be changed to
accomodate 16-bit node ids as suggested by Eric.
V2->V3:
- changed memnode.embedded_map from [64-16] to [64-8]
(and size comment to 128 bytes)
V1->V2:
- changed pxm_to_node_map to u16
- changed memnode map entries to u16
---
arch/x86/mm/numa_64.c | 2 +-
drivers/acpi/numa.c | 2 +-
include/asm-x86/mmzone_64.h | 6 +++---
include/linux/numa.h | 6 ++++++
4 files changed, 11 insertions(+), 5 deletions(-)
--- a/arch/x86/mm/numa_64.c
+++ b/arch/x86/mm/numa_64.c
@@ -88,7 +88,7 @@ static int __init allocate_cachealigned_
unsigned long pad, pad_addr;
memnodemap = memnode.embedded_map;
- if (memnodemapsize <= 48)
+ if (memnodemapsize <= ARRAY_SIZE(memnode.embedded_map))
return 0;
pad = L1_CACHE_BYTES - 1;
--- a/drivers/acpi/numa.c
+++ b/drivers/acpi/numa.c
@@ -38,7 +38,7 @@ ACPI_MODULE_NAME("numa");
static nodemask_t nodes_found_map = NODE_MASK_NONE;
/* maps to convert between proximity domain and logical node ID */
-static int pxm_to_node_map[MAX_PXM_DOMAINS]
+static numanode_t pxm_to_node_map[MAX_PXM_DOMAINS]
= { [0 ... MAX_PXM_DOMAINS - 1] = NID_INVAL };
static int node_to_pxm_map[MAX_NUMNODES]
= { [0 ... MAX_NUMNODES - 1] = PXM_INVAL };
--- a/include/asm-x86/mmzone_64.h
+++ b/include/asm-x86/mmzone_64.h
@@ -15,9 +15,9 @@
struct memnode {
int shift;
unsigned int mapsize;
- u8 *map;
- u8 embedded_map[64-16];
-} ____cacheline_aligned; /* total size = 64 bytes */
+ u16 *map;
+ u16 embedded_map[64-8];
+} ____cacheline_aligned; /* total size = 128 bytes */
extern struct memnode memnode;
#define memnode_shift memnode.shift
#define memnodemap memnode.map
--- a/include/linux/numa.h
+++ b/include/linux/numa.h
@@ -10,4 +10,10 @@
#define MAX_NUMNODES (1 << NODES_SHIFT)
+#if MAX_NUMNODES > 256
+typedef u16 numanode_t;
+#else
+typedef u8 numanode_t;
+#endif
+
#endif /* _LINUX_NUMA_H */
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-01-18 18:33 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 18:30 [PATCH 0/5] x86: Reduce memory usage for large count NR_CPUs fixup travis
2008-01-18 18:30 ` travis
2008-01-18 18:30 ` travis [this message]
2008-01-18 18:30 ` [PATCH 1/5] x86: Change size of node ids from u8 to u16 fixup travis
2008-01-18 19:56 ` Jan Engelhardt
2008-01-18 19:56 ` Jan Engelhardt
2008-01-18 19:59 ` Mike Travis
2008-01-18 19:59 ` Mike Travis
2008-01-19 4:03 ` Yinghai Lu
2008-01-19 4:03 ` Yinghai Lu
2008-01-19 4:36 ` David Rientjes
2008-01-19 4:36 ` David Rientjes
2008-01-19 4:43 ` Yinghai Lu
2008-01-19 4:43 ` Yinghai Lu
2008-01-19 5:17 ` David Rientjes
2008-01-19 5:17 ` David Rientjes
2008-01-19 6:20 ` Yinghai Lu
2008-01-19 6:20 ` Yinghai Lu
2008-01-19 21:25 ` Mike Travis
2008-01-19 21:25 ` Mike Travis
2008-01-19 22:33 ` David Rientjes
2008-01-19 22:33 ` David Rientjes
2008-01-20 0:41 ` Mike Travis
2008-01-20 0:41 ` Mike Travis
2008-01-20 1:31 ` Yinghai Lu
2008-01-20 1:31 ` Yinghai Lu
2008-01-20 6:22 ` David Rientjes
2008-01-20 6:22 ` David Rientjes
2008-01-18 18:30 ` [PATCH 2/5] x86: Change NR_CPUS arrays in numa_64 fixup travis
2008-01-18 18:30 ` travis
2008-01-18 18:30 ` [PATCH 3/5] x86: Change bios_cpu_apicid to percpu data variable fixup travis
2008-01-18 18:30 ` travis
2008-01-18 18:30 ` [PATCH 4/5] x86: Add config variables for SMP_MAX travis
2008-01-18 18:30 ` travis
2008-01-18 20:04 ` Ingo Oeser
2008-01-18 20:04 ` Ingo Oeser
2008-01-18 20:10 ` Christoph Lameter
2008-01-18 20:10 ` Christoph Lameter
2008-01-18 20:14 ` Mike Travis
2008-01-18 20:14 ` Mike Travis
2008-01-18 20:36 ` Andi Kleen
2008-01-18 20:36 ` Andi Kleen
2008-01-18 20:48 ` Mike Travis
2008-01-18 20:48 ` Mike Travis
2008-01-18 21:02 ` [PATCH 4/5] x86: Add config variables for SMP_MAX II Andi Kleen
2008-01-18 21:02 ` Andi Kleen
2008-01-18 20:48 ` [PATCH 4/5] x86: Add config variables for SMP_MAX Ingo Molnar
2008-01-18 20:48 ` Ingo Molnar
2008-01-18 20:55 ` Mike Travis
2008-01-18 20:55 ` Mike Travis
2008-01-18 20:58 ` Andi Kleen
2008-01-18 20:58 ` Andi Kleen
2008-01-28 16:45 ` Paul Jackson
2008-01-28 16:45 ` Paul Jackson
2008-01-28 17:00 ` Andi Kleen
2008-01-28 17:00 ` Andi Kleen
2008-01-18 20:46 ` Ingo Molnar
2008-01-18 20:46 ` Ingo Molnar
2008-01-19 14:52 ` Ingo Molnar
2008-01-19 15:15 ` Ingo Molnar
2008-01-19 15:15 ` Ingo Molnar
2008-01-19 15:24 ` Ingo Molnar
2008-01-19 15:24 ` Ingo Molnar
2008-01-19 21:52 ` Mike Travis
2008-01-19 21:52 ` Mike Travis
2008-01-19 23:24 ` Mike Travis
2008-01-19 23:24 ` Mike Travis
2008-01-20 1:14 ` Mike Travis
2008-01-20 1:14 ` Mike Travis
2008-01-19 21:39 ` Mike Travis
2008-01-19 21:39 ` Mike Travis
2008-01-18 18:30 ` [PATCH 5/5] x86: Add debug of invalid per_cpu map accesses travis
2008-01-18 18:30 ` travis
2008-01-18 18:33 ` Andi Kleen
2008-01-18 18:33 ` Andi Kleen
2008-01-18 18:49 ` Mike Travis
2008-01-18 18:49 ` Mike Travis
2008-01-18 18:56 ` Christoph Lameter
2008-01-18 18:56 ` Christoph Lameter
2008-01-18 20:49 ` Ingo Molnar
2008-01-18 20:49 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118183011.527888000@sgi.com \
--to=travis@sgi.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.