From: "Daniel P. Berrange" <berrange@redhat.com>
To: Samuel Thibault <samuel.thibault@eu.citrix.com>,
Christoph Egger <Christoph.Egger@amd.com>,
xen-devel@lists.xensource.com
Subject: Re: ioemu: empty vnc passwd
Date: Wed, 23 Jan 2008 16:50:15 +0000 [thread overview]
Message-ID: <20080123165015.GB17258@redhat.com> (raw)
In-Reply-To: <20080123164233.GM4252@implementation.uk.xensource.com>
On Wed, Jan 23, 2008 at 04:42:33PM +0000, Samuel Thibault wrote:
> Daniel P. Berrange, le Wed 23 Jan 2008 16:28:11 +0000, a écrit :
> > VNC password authentication is turned on / off via the ',passwd' flag on
> > the -vnc command line to QEMU. If password auth is on, and a zero length
> > string is found as a password, then all logins are completely disabled -
> > the VNC password auth code will fail all logins. If passwd auth is off on
> > the command line, then any password stored in xenstore is irrelevant, no
> > matter what length it is.
>
> Ok, so the real fix seems to be to take that flag into account (which is
> not the case currently).
Urm, its already processed. See vnc_display_open() in tools/ioemu/vnc.c
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
next prev parent reply other threads:[~2008-01-23 16:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 16:11 ioemu: empty vnc passwd Samuel Thibault
2008-01-23 16:19 ` Christoph Egger
2008-01-23 16:23 ` John Levon
2008-01-23 16:28 ` Daniel P. Berrange
2008-01-23 16:36 ` Christoph Egger
2008-01-23 16:48 ` Daniel P. Berrange
2008-01-23 16:42 ` Samuel Thibault
2008-01-23 16:50 ` Daniel P. Berrange [this message]
2008-01-23 16:58 ` Samuel Thibault
2008-01-23 16:50 ` Samuel Thibault
2008-01-23 16:54 ` Daniel P. Berrange
2008-01-23 16:35 ` Daniel P. Berrange
2008-01-23 17:26 ` John Levon
2008-01-23 17:33 ` Daniel P. Berrange
2008-01-23 17:38 ` John Levon
2008-01-23 17:43 ` Daniel P. Berrange
2008-01-23 17:56 ` John Levon
2008-01-23 18:05 ` Daniel P. Berrange
2008-01-23 17:05 ` [PATCH] ioemu: handle " Samuel Thibault
2008-01-23 17:46 ` Keir Fraser
2008-01-23 17:49 ` Daniel P. Berrange
2008-01-23 18:06 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080123165015.GB17258@redhat.com \
--to=berrange@redhat.com \
--cc=Christoph.Egger@amd.com \
--cc=samuel.thibault@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.