All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] ioemu: handle empty vnc passwd
Date: Wed, 23 Jan 2008 17:05:54 +0000	[thread overview]
Message-ID: <20080123170554.GF5188@implementation.uk.xensource.com> (raw)
In-Reply-To: <20080123161130.GD5188@implementation.uk.xensource.com>

ioemu: handle empty vnc passwd
Have xenstore_read_vncpasswd return -1 when it is unable to read the
passwd from XenStore (and store an empty password).  However, don't exit
in such case since it may just mean that the use didn't set a passwd.
If he really did, xend would have given the passwd flag in the -vnc
option, and the empty passwd would make the vnc authentication reject
any password anyway.

Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>

diff -r 9e92672385a5 tools/ioemu/xenstore.c
--- a/tools/ioemu/xenstore.c	Wed Jan 23 13:37:03 2008 +0000
+++ b/tools/ioemu/xenstore.c	Wed Jan 23 15:53:01 2008 +0000
@@ -518,7 +518,7 @@ int xenstore_read_vncpasswd(int domid, c
         pwbuf[0] = '\0';
         free(uuid);
         free(path);
-        return rc;
+        return -1;
     }
diff -r 9e92672385a5 tools/ioemu/vl.c
--- a/tools/ioemu/vl.c	Wed Jan 23 13:37:03 2008 +0000
+++ b/tools/ioemu/vl.c	Wed Jan 23 15:55:38 2008 +0000
@@ -7756,8 +7756,7 @@ int main(int argc, char **argv)
 	int vnc_display_port;
 	char password[20];
 	vnc_display_init(ds);
-	if (xenstore_read_vncpasswd(domid, password, sizeof(password)) < 0)
-	    exit(0);
+	xenstore_read_vncpasswd(domid, password, sizeof(password));
 	vnc_display_password(ds, password);
 	if ((vnc_display_port = vnc_display_open(ds, vnc_display, vncunused)) < 0) 
 	    exit (0);

  parent reply	other threads:[~2008-01-23 17:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23 16:11 ioemu: empty vnc passwd Samuel Thibault
2008-01-23 16:19 ` Christoph Egger
2008-01-23 16:23   ` John Levon
2008-01-23 16:28   ` Daniel P. Berrange
2008-01-23 16:36     ` Christoph Egger
2008-01-23 16:48       ` Daniel P. Berrange
2008-01-23 16:42     ` Samuel Thibault
2008-01-23 16:50       ` Daniel P. Berrange
2008-01-23 16:58         ` Samuel Thibault
2008-01-23 16:50       ` Samuel Thibault
2008-01-23 16:54         ` Daniel P. Berrange
2008-01-23 16:35 ` Daniel P. Berrange
2008-01-23 17:26   ` John Levon
2008-01-23 17:33     ` Daniel P. Berrange
2008-01-23 17:38       ` John Levon
2008-01-23 17:43         ` Daniel P. Berrange
2008-01-23 17:56           ` John Levon
2008-01-23 18:05             ` Daniel P. Berrange
2008-01-23 17:05 ` Samuel Thibault [this message]
2008-01-23 17:46   ` [PATCH] ioemu: handle " Keir Fraser
2008-01-23 17:49     ` Daniel P. Berrange
2008-01-23 18:06       ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080123170554.GF5188@implementation.uk.xensource.com \
    --to=samuel.thibault@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.