From: "Daniel P. Berrange" <berrange@redhat.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com,
Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [PATCH] ioemu: handle empty vnc passwd
Date: Wed, 23 Jan 2008 17:49:42 +0000 [thread overview]
Message-ID: <20080123174942.GF17258@redhat.com> (raw)
In-Reply-To: <C3BD2DF9.1B5AA%Keir.Fraser@cl.cam.ac.uk>
On Wed, Jan 23, 2008 at 05:46:33PM +0000, Keir Fraser wrote:
> If the only caller of xenstore_read_vncpasswd() is not checking the return
> code, why continue to have xenstore_read_vncpasswd() return an error code at
> all?
>
> If that is fixed, and Daniel Berrange will ack the patch, then I'll take it.
ACK - patch gets my vote.
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
next prev parent reply other threads:[~2008-01-23 17:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 16:11 ioemu: empty vnc passwd Samuel Thibault
2008-01-23 16:19 ` Christoph Egger
2008-01-23 16:23 ` John Levon
2008-01-23 16:28 ` Daniel P. Berrange
2008-01-23 16:36 ` Christoph Egger
2008-01-23 16:48 ` Daniel P. Berrange
2008-01-23 16:42 ` Samuel Thibault
2008-01-23 16:50 ` Daniel P. Berrange
2008-01-23 16:58 ` Samuel Thibault
2008-01-23 16:50 ` Samuel Thibault
2008-01-23 16:54 ` Daniel P. Berrange
2008-01-23 16:35 ` Daniel P. Berrange
2008-01-23 17:26 ` John Levon
2008-01-23 17:33 ` Daniel P. Berrange
2008-01-23 17:38 ` John Levon
2008-01-23 17:43 ` Daniel P. Berrange
2008-01-23 17:56 ` John Levon
2008-01-23 18:05 ` Daniel P. Berrange
2008-01-23 17:05 ` [PATCH] ioemu: handle " Samuel Thibault
2008-01-23 17:46 ` Keir Fraser
2008-01-23 17:49 ` Daniel P. Berrange [this message]
2008-01-23 18:06 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080123174942.GF17258@redhat.com \
--to=berrange@redhat.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=samuel.thibault@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.