Re: ioemu: empty vnc passwd

[Samuel Thibault <samuel.thibault@eu.citrix.com>]

Daniel P. Berrange, le Wed 23 Jan 2008 16:50:15 +0000, a écrit :
> On Wed, Jan 23, 2008 at 04:42:33PM +0000, Samuel Thibault wrote:
> > Daniel P. Berrange, le Wed 23 Jan 2008 16:28:11 +0000, a écrit :
> > > VNC password authentication is turned on / off via the ',passwd' flag on
> > > the -vnc command line to QEMU. If password auth is on, and a zero length 
> > > string is found as a password, then all logins are completely disabled - 
> > > the VNC password auth code will fail all logins. If passwd auth is off on 
> > > the  command line, then any password stored in xenstore is irrelevant, no
> > > matter what length it is.
> > 
> > Ok, so the real fix seems to be to take that flag into account (which is
> > not the case currently).
> 
> Urm, its already processed. See vnc_display_open() in tools/ioemu/vnc.c

Yes, but that doesn't prevent the exit() when the passwd can't be read
from XenStore.

Samuel