From: Jack Steiner <steiner@sgi.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions
Date: Tue, 25 Mar 2008 08:45:00 -0500 [thread overview]
Message-ID: <20080325134459.GA19668@sgi.com> (raw)
In-Reply-To: <87iqzbi0cy.fsf@basil.nowhere.org>
On Tue, Mar 25, 2008 at 11:06:37AM +0100, Andi Kleen wrote:
> Jack Steiner <steiner@sgi.com> writes:
>
> >
> > Signed-off-by: Jack Steiner <steiner@sgi.com>
>
> Not sure why you indent that? Normally it is not.
> Some tools get confused by it I think.
Fixed.
>
> > ---
> > include/asm-x86/uv_mmrs.h | 373 ++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 373 insertions(+)
> >
> > Index: linux/include/asm-x86/uv_mmrs.h
>
> I personally would consider it cleaner to put these into a asm-x86/uv/
> sub directory
Will change...
--- jack
WARNING: multiple messages have this Message-ID (diff)
From: Jack Steiner <steiner@sgi.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions
Date: Tue, 25 Mar 2008 08:45:00 -0500 [thread overview]
Message-ID: <20080325134459.GA19668@sgi.com> (raw)
In-Reply-To: <87iqzbi0cy.fsf@basil.nowhere.org>
On Tue, Mar 25, 2008 at 11:06:37AM +0100, Andi Kleen wrote:
> Jack Steiner <steiner@sgi.com> writes:
>
> >
> > Signed-off-by: Jack Steiner <steiner@sgi.com>
>
> Not sure why you indent that? Normally it is not.
> Some tools get confused by it I think.
Fixed.
>
> > ---
> > include/asm-x86/uv_mmrs.h | 373 ++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 373 insertions(+)
> >
> > Index: linux/include/asm-x86/uv_mmrs.h
>
> I personally would consider it cleaner to put these into a asm-x86/uv/
> sub directory
Will change...
--- jack
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-25 13:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 18:21 [RFC 5/8] x86_64: Add UV specific header for MMR definitions Jack Steiner
2008-03-24 18:21 ` Jack Steiner
2008-03-25 8:27 ` Christoph Hellwig
2008-03-25 8:27 ` Christoph Hellwig
2008-03-25 10:04 ` Andi Kleen
2008-03-25 10:04 ` Andi Kleen
2008-03-26 0:08 ` Christoph Hellwig
2008-03-26 0:08 ` Christoph Hellwig
2008-03-26 3:02 ` Jack Steiner
2008-03-26 3:02 ` Jack Steiner
2008-03-26 5:17 ` Andi Kleen
2008-03-26 5:17 ` Andi Kleen
2008-03-26 22:22 ` Pavel Machek
2008-03-26 22:22 ` Pavel Machek
2008-03-25 10:06 ` Andi Kleen
2008-03-25 10:06 ` Andi Kleen
2008-03-25 13:45 ` Jack Steiner [this message]
2008-03-25 13:45 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325134459.GA19668@sgi.com \
--to=steiner@sgi.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.