From: Andi Kleen <andi@firstfloor.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>, Jack Steiner <steiner@sgi.com>,
mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions
Date: Wed, 26 Mar 2008 06:17:59 +0100 [thread overview]
Message-ID: <20080326051759.GD2170@one.firstfloor.org> (raw)
In-Reply-To: <20080326000820.GA18701@infradead.org>
On Tue, Mar 25, 2008 at 08:08:20PM -0400, Christoph Hellwig wrote:
> On Tue, Mar 25, 2008 at 11:04:22AM +0100, Andi Kleen wrote:
> > bitfields are only problematic on portable code, which this isn't.
>
> it's still crappy to read and a bad example for others.
I personally think bitfield code is actually easier to read
than manual shift/mask etc.
Avoiding bitfields is just a rule of thumb for portability, but that one
does not apply here.
I would say Joern's recent comment on religion vs common sense
for CodingStyle applies very well here.
> And last time
> I heard about UV it also included an ia64 version, but that's been
> loooong ago.
bitfield rules should be 100% the same between x86 and ia64
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>, Jack Steiner <steiner@sgi.com>,
mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions
Date: Wed, 26 Mar 2008 06:17:59 +0100 [thread overview]
Message-ID: <20080326051759.GD2170@one.firstfloor.org> (raw)
In-Reply-To: <20080326000820.GA18701@infradead.org>
On Tue, Mar 25, 2008 at 08:08:20PM -0400, Christoph Hellwig wrote:
> On Tue, Mar 25, 2008 at 11:04:22AM +0100, Andi Kleen wrote:
> > bitfields are only problematic on portable code, which this isn't.
>
> it's still crappy to read and a bad example for others.
I personally think bitfield code is actually easier to read
than manual shift/mask etc.
Avoiding bitfields is just a rule of thumb for portability, but that one
does not apply here.
I would say Joern's recent comment on religion vs common sense
for CodingStyle applies very well here.
> And last time
> I heard about UV it also included an ia64 version, but that's been
> loooong ago.
bitfield rules should be 100% the same between x86 and ia64
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-26 5:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 18:21 [RFC 5/8] x86_64: Add UV specific header for MMR definitions Jack Steiner
2008-03-24 18:21 ` Jack Steiner
2008-03-25 8:27 ` Christoph Hellwig
2008-03-25 8:27 ` Christoph Hellwig
2008-03-25 10:04 ` Andi Kleen
2008-03-25 10:04 ` Andi Kleen
2008-03-26 0:08 ` Christoph Hellwig
2008-03-26 0:08 ` Christoph Hellwig
2008-03-26 3:02 ` Jack Steiner
2008-03-26 3:02 ` Jack Steiner
2008-03-26 5:17 ` Andi Kleen [this message]
2008-03-26 5:17 ` Andi Kleen
2008-03-26 22:22 ` Pavel Machek
2008-03-26 22:22 ` Pavel Machek
2008-03-25 10:06 ` Andi Kleen
2008-03-25 10:06 ` Andi Kleen
2008-03-25 13:45 ` Jack Steiner
2008-03-25 13:45 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326051759.GD2170@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.