From: Andi Kleen <andi@firstfloor.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jack Steiner <steiner@sgi.com>,
mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions
Date: 25 Mar 2008 11:04:22 +0100 [thread overview]
Message-ID: <87myoni0gp.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20080325082756.GA6589@infradead.org>
Christoph Hellwig <hch@infradead.org> writes:
> On Mon, Mar 24, 2008 at 01:21:16PM -0500, Jack Steiner wrote:
> >
> > Definitions of UV MMRs.
> > Note: this file is auto-generated by hardware design tools.
>
> Which is still not an excuse for the crap in there. Please submit a
> proper header with the needed defintions and shift & mask defintions and
> helpers instead of the bitfields.
bitfields are only problematic on portable code, which this isn't.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jack Steiner <steiner@sgi.com>,
mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions
Date: 25 Mar 2008 11:04:22 +0100 [thread overview]
Message-ID: <87myoni0gp.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20080325082756.GA6589@infradead.org>
Christoph Hellwig <hch@infradead.org> writes:
> On Mon, Mar 24, 2008 at 01:21:16PM -0500, Jack Steiner wrote:
> >
> > Definitions of UV MMRs.
> > Note: this file is auto-generated by hardware design tools.
>
> Which is still not an excuse for the crap in there. Please submit a
> proper header with the needed defintions and shift & mask defintions and
> helpers instead of the bitfields.
bitfields are only problematic on portable code, which this isn't.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-25 10:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 18:21 [RFC 5/8] x86_64: Add UV specific header for MMR definitions Jack Steiner
2008-03-24 18:21 ` Jack Steiner
2008-03-25 8:27 ` Christoph Hellwig
2008-03-25 8:27 ` Christoph Hellwig
2008-03-25 10:04 ` Andi Kleen [this message]
2008-03-25 10:04 ` Andi Kleen
2008-03-26 0:08 ` Christoph Hellwig
2008-03-26 0:08 ` Christoph Hellwig
2008-03-26 3:02 ` Jack Steiner
2008-03-26 3:02 ` Jack Steiner
2008-03-26 5:17 ` Andi Kleen
2008-03-26 5:17 ` Andi Kleen
2008-03-26 22:22 ` Pavel Machek
2008-03-26 22:22 ` Pavel Machek
2008-03-25 10:06 ` Andi Kleen
2008-03-25 10:06 ` Andi Kleen
2008-03-25 13:45 ` Jack Steiner
2008-03-25 13:45 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87myoni0gp.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.