Re: [PATCH 1/11] Add generic helpers for arch IPI function calls

[Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

On Sat, Apr 26 2008, Paul E. McKenney wrote:
> On Fri, Apr 25, 2008 at 11:11:00PM -0700, Andrew Morton wrote:
> > > On Tue, 22 Apr 2008 20:50:17 +0200 Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> > > This adds kernel/smp.c which contains helpers for IPI function calls. In
> > > addition to supporting the existing smp_call_function() in a more efficient
> > > manner, it also adds a more scalable variant called smp_call_function_single()
> > > for calling a given function on a single CPU only.
> 
> Where is the new smp_call_function() defined?  I see only the declaration.
> 
> Probably just blind...

kernel/smp.c? Basically just a wrapper around smp_call_function_mask().

> See comments interspersed below.

Thanks a lot! I'll go over these tomorrow, the fallback graceperiod
definitely looks valid.

-- 
Jens Axboe