All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: alan@lxorguk.ukuu.org.uk, James.Bottomley@HansenPartnership.com,
	tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [patch] x86, voyager: fix ioremap_nocache()
Date: Mon, 28 Apr 2008 13:50:57 +0200	[thread overview]
Message-ID: <20080428115057.GA21105@elte.hu> (raw)
In-Reply-To: <20080428.021745.17554887.davem@davemloft.net>


* David Miller <davem@davemloft.net> wrote:

> > So review them. Your comments strike me as the pot calling the 
> > kettle black given the way the network people like to live on their 
> > own mailing list.
> 
> Oh contraire.  Because we networking folks use a seperate mailing list 
> with a lower signal to noise ratio than lkml, and as a result more 
> specialization, more patches get more review by more specialists.

well, then lets go back to the very basis of this whole ... box match.
:) It was about a broken networking patch that i stumbled upon
(unwillingly, via testing), which commit was _not_ posted on netdev and 
_not_ posted on lkml:

   http://lkml.org/lkml/2008/4/19/51

I simply hit a (trivial) regression in the networking code, but i simply 
found no existing discussion of the suspect patch (commit 5e8fbe2a).

the development process is an integral part of the source code of this 
OS and not a private matter of developers or maintainers. It is not a 
religion and it is not taboo to criticise it, it is a crutial part of 
our technology. So i will continue to criticise the development process 
in the future too when i think it has aspects that hurts us. [and will 
try to address all incoming criticism as well.]

> You might want to know that linux-next mainly exists because of how 
> much of this has been going on over the past half year or so.

the problem is that linux-next alone would not have helped much in this 
specific matter. For example the softlockup warnings annoyance you 
reported would have triggered immediately had you booted your Sparc64 
box with linux-next or -mm even just _once_ :-)

But the same holds for me: had i ran linux-next i could have reported 
some of the networking regressions sooner.

So how about making mutual use of linux-next and 'promise' to each other 
to at least minimally build/boot the integrated tree, or at least 
promise to not complain too loudly about bugs that could have been found 
and reported there via reasonable mutual testing of linux-next? Does 
that sound reasonable?

	Ingo

  parent reply	other threads:[~2008-04-28 11:51 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27 20:51 Breakage caused by unreviewed patch in x86 tree James Bottomley
2008-04-27 20:53 ` David Miller
2008-04-27 21:48 ` [patch] x86, voyager: fix ioremap_nocache() Ingo Molnar
2008-04-27 22:05   ` James Bottomley
2008-04-27 22:36     ` Willy Tarreau
2008-04-27 22:41     ` Ingo Molnar
2008-04-27 23:18     ` Ingo Molnar
2008-04-27 23:31       ` David Miller
2008-04-28  0:31         ` Rik van Riel
2008-04-28  0:45           ` Al Viro
2008-04-28  0:52             ` H. Peter Anvin
2008-04-28  9:01         ` Alan Cox
2008-04-28  9:17           ` David Miller
2008-04-28  9:48             ` Adrian Bunk
2008-04-28 11:50             ` Ingo Molnar [this message]
2008-04-28  6:10       ` Christoph Hellwig
2008-04-28 16:55         ` H. Peter Anvin
2008-04-27 22:34   ` James Bottomley
2008-04-27 22:39     ` Jeff Garzik
2008-04-27 22:44       ` H. Peter Anvin
2008-04-27 22:46       ` David Miller
2008-04-27 22:52         ` H. Peter Anvin
2008-04-27 22:58           ` David Miller
2008-04-27 23:04             ` H. Peter Anvin
2008-04-30 20:35               ` Eric W. Biederman
2008-04-27 23:34           ` Jeff Garzik
2008-04-27 23:39             ` H. Peter Anvin
2008-04-27 22:53         ` Jeff Garzik
2008-04-27 22:56           ` H. Peter Anvin
2008-04-27 22:59             ` David Miller
2008-04-27 23:02             ` Jeff Garzik
2008-04-27 23:14               ` Arjan van de Ven
2008-04-27 23:01         ` Arjan van de Ven
2008-04-30 21:44           ` James Bottomley
2008-04-30 22:39             ` H. Peter Anvin
2008-04-27 23:01       ` Thomas Gleixner
2008-04-28 14:10       ` Arjan van de Ven
2008-04-28 14:29         ` James Bottomley
2008-04-28 15:07           ` Arjan van de Ven
2008-04-28 19:59             ` H. Peter Anvin
2008-04-27 22:00 ` Breakage caused by unreviewed patch in x86 tree H. Peter Anvin
2008-04-27 22:10   ` James Bottomley
2008-04-27 22:13     ` H. Peter Anvin
2008-04-27 22:18       ` James Bottomley
2008-04-27 22:31         ` H. Peter Anvin
2008-04-27 22:58 ` Arjan van de Ven
2008-04-27 23:00   ` David Miller
2008-04-27 23:07     ` Arjan van de Ven
2008-04-27 23:03   ` James Bottomley
2008-04-27 23:11     ` Arjan van de Ven
2008-04-27 23:17     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428115057.GA21105@elte.hu \
    --to=mingo@elte.hu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.