All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-mmc@drzeus.cx>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, Gary Jennejohn <garyj@denx.de>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	linux-kernel@vger.kernel.org
Subject: [RFC PATCH 1/2] mmc_spi: export probe and remove functions
Date: Fri, 23 May 2008 22:28:34 +0400	[thread overview]
Message-ID: <20080523182834.GA469@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <20080523182754.GA26891@polina.dev.rtsoft.ru>

...so we'll able to write bindings for the OpenFirmware without
messing with #ifdefs in the driver itself.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/mmc/host/mmc_spi.c |    6 ++++--
 drivers/mmc/host/mmc_spi.h |    7 +++++++
 2 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 drivers/mmc/host/mmc_spi.h

diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 85d9853..f2c4fc2 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -1184,7 +1184,7 @@ static int maybe_count_child(struct device *dev, void *c)
 	return 0;
 }
 
-static int mmc_spi_probe(struct spi_device *spi)
+int mmc_spi_probe(struct spi_device *spi)
 {
 	void			*ones;
 	struct mmc_host		*mmc;
@@ -1366,9 +1366,10 @@ nomem:
 	kfree(ones);
 	return status;
 }
+EXPORT_SYMBOL(mmc_spi_probe);
 
 
-static int __devexit mmc_spi_remove(struct spi_device *spi)
+int __devexit mmc_spi_remove(struct spi_device *spi)
 {
 	struct mmc_host		*mmc = dev_get_drvdata(&spi->dev);
 	struct mmc_spi_host	*host;
@@ -1398,6 +1399,7 @@ static int __devexit mmc_spi_remove(struct spi_device *spi)
 	}
 	return 0;
 }
+EXPORT_SYMBOL(mmc_spi_remove);
 
 
 static struct spi_driver mmc_spi_driver = {
diff --git a/drivers/mmc/host/mmc_spi.h b/drivers/mmc/host/mmc_spi.h
new file mode 100644
index 0000000..d4fcd91
--- /dev/null
+++ b/drivers/mmc/host/mmc_spi.h
@@ -0,0 +1,7 @@
+#ifndef __DRIVERS_MMC_HOST_MMC_SPI_H
+#define __DRIVERS_MMC_HOST_MMC_SPI_H
+
+extern int mmc_spi_probe(struct spi_device *spi);
+extern int __devexit mmc_spi_remove(struct spi_device *spi);
+
+#endif
-- 
1.5.5.1

WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-mmc@drzeus.cx>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Grant Likely <grant.likely@secretlab.ca>
Cc: Gary Jennejohn <garyj@denx.de>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 1/2] mmc_spi: export probe and remove functions
Date: Fri, 23 May 2008 22:28:34 +0400	[thread overview]
Message-ID: <20080523182834.GA469@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <20080523182754.GA26891@polina.dev.rtsoft.ru>

...so we'll able to write bindings for the OpenFirmware without
messing with #ifdefs in the driver itself.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/mmc/host/mmc_spi.c |    6 ++++--
 drivers/mmc/host/mmc_spi.h |    7 +++++++
 2 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 drivers/mmc/host/mmc_spi.h

diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 85d9853..f2c4fc2 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -1184,7 +1184,7 @@ static int maybe_count_child(struct device *dev, void *c)
 	return 0;
 }
 
-static int mmc_spi_probe(struct spi_device *spi)
+int mmc_spi_probe(struct spi_device *spi)
 {
 	void			*ones;
 	struct mmc_host		*mmc;
@@ -1366,9 +1366,10 @@ nomem:
 	kfree(ones);
 	return status;
 }
+EXPORT_SYMBOL(mmc_spi_probe);
 
 
-static int __devexit mmc_spi_remove(struct spi_device *spi)
+int __devexit mmc_spi_remove(struct spi_device *spi)
 {
 	struct mmc_host		*mmc = dev_get_drvdata(&spi->dev);
 	struct mmc_spi_host	*host;
@@ -1398,6 +1399,7 @@ static int __devexit mmc_spi_remove(struct spi_device *spi)
 	}
 	return 0;
 }
+EXPORT_SYMBOL(mmc_spi_remove);
 
 
 static struct spi_driver mmc_spi_driver = {
diff --git a/drivers/mmc/host/mmc_spi.h b/drivers/mmc/host/mmc_spi.h
new file mode 100644
index 0000000..d4fcd91
--- /dev/null
+++ b/drivers/mmc/host/mmc_spi.h
@@ -0,0 +1,7 @@
+#ifndef __DRIVERS_MMC_HOST_MMC_SPI_H
+#define __DRIVERS_MMC_HOST_MMC_SPI_H
+
+extern int mmc_spi_probe(struct spi_device *spi);
+extern int __devexit mmc_spi_remove(struct spi_device *spi);
+
+#endif
-- 
1.5.5.1


  reply	other threads:[~2008-05-23 18:28 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23 18:27 [RFC] OpenFirmware bindings for the MMC-over-SPI driver Anton Vorontsov
2008-05-23 18:27 ` Anton Vorontsov
2008-05-23 18:28 ` Anton Vorontsov [this message]
2008-05-23 18:28   ` [RFC PATCH 1/2] mmc_spi: export probe and remove functions Anton Vorontsov
2008-05-26 12:18   ` Pierre Ossman
2008-05-26 12:25     ` Anton Vorontsov
2008-05-26 12:25       ` Anton Vorontsov
2008-05-26 13:10       ` Anton Vorontsov
2008-05-26 13:10         ` Anton Vorontsov
2008-06-01 10:18         ` Pierre Ossman
2008-06-02 12:53           ` Anton Vorontsov
2008-06-02 12:53             ` Anton Vorontsov
2008-06-05 21:16             ` Pierre Ossman
2008-05-23 18:28 ` [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver Anton Vorontsov
2008-05-23 18:28   ` Anton Vorontsov
2008-05-24  2:35   ` Stephen Rothwell
2008-05-24  2:35     ` Stephen Rothwell
2008-05-26 11:58     ` Anton Vorontsov
2008-05-26 11:58       ` Anton Vorontsov
2008-05-24  5:19   ` Grant Likely
2008-05-24  5:19     ` Grant Likely
2008-05-24 14:32     ` Jochen Friedrich
2008-05-24 14:32       ` Jochen Friedrich
2008-05-24 23:14       ` Segher Boessenkool
2008-05-24 23:14         ` Segher Boessenkool
2008-05-24 23:06     ` Segher Boessenkool
2008-05-24 23:06       ` Segher Boessenkool
2008-05-26 11:49     ` Anton Vorontsov
2008-05-26 11:49       ` Anton Vorontsov
2008-05-26 22:19       ` David Brownell
2008-05-26 22:19         ` David Brownell
2008-05-26 23:15         ` Anton Vorontsov
2008-05-26 23:15           ` Anton Vorontsov
2008-05-24 19:56 ` [RFC] OpenFirmware bindings for the MMC-over-SPI driver David Brownell
2008-05-24 19:56   ` David Brownell
2008-05-25  4:47   ` Grant Likely
2008-05-25  4:47     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080523182834.GA469@polina.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=g.liakhovetski@gmx.de \
    --cc=garyj@denx.de \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.