All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-mmc@drzeus.cx>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
	Gary Jennejohn <garyj@denx.de>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [RFC PATCH 1/2] mmc_spi: export probe and remove functions
Date: Mon, 26 May 2008 16:25:33 +0400	[thread overview]
Message-ID: <20080526122533.GA9595@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <20080526141836.72db0623@mjolnir.drzeus.cx>

On Mon, May 26, 2008 at 02:18:36PM +0200, Pierre Ossman wrote:
> On Fri, 23 May 2008 22:28:34 +0400
> Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> 
> > ...so we'll able to write bindings for the OpenFirmware without
> > messing with #ifdefs in the driver itself.
> > 
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> 
> This looks extremely wrong. Encapsulating probe functions isn't exactly
> in line with the device model and bound to confuse people.
> 
> Your patches doesn't give a complete picture of the OF side of things,
> but can't you solve this by having an init callback somewhere?

Easily, I think this is good (better) idea. Will do.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-mmc@drzeus.cx>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
	Grant Likely <grant.likely@secretlab.ca>,
	Gary Jennejohn <garyj@denx.de>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] mmc_spi: export probe and remove functions
Date: Mon, 26 May 2008 16:25:33 +0400	[thread overview]
Message-ID: <20080526122533.GA9595@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <20080526141836.72db0623@mjolnir.drzeus.cx>

On Mon, May 26, 2008 at 02:18:36PM +0200, Pierre Ossman wrote:
> On Fri, 23 May 2008 22:28:34 +0400
> Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> 
> > ...so we'll able to write bindings for the OpenFirmware without
> > messing with #ifdefs in the driver itself.
> > 
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> 
> This looks extremely wrong. Encapsulating probe functions isn't exactly
> in line with the device model and bound to confuse people.
> 
> Your patches doesn't give a complete picture of the OF side of things,
> but can't you solve this by having an init callback somewhere?

Easily, I think this is good (better) idea. Will do.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2008-05-26 12:25 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23 18:27 [RFC] OpenFirmware bindings for the MMC-over-SPI driver Anton Vorontsov
2008-05-23 18:27 ` Anton Vorontsov
2008-05-23 18:28 ` [RFC PATCH 1/2] mmc_spi: export probe and remove functions Anton Vorontsov
2008-05-23 18:28   ` Anton Vorontsov
2008-05-26 12:18   ` Pierre Ossman
2008-05-26 12:25     ` Anton Vorontsov [this message]
2008-05-26 12:25       ` Anton Vorontsov
2008-05-26 13:10       ` Anton Vorontsov
2008-05-26 13:10         ` Anton Vorontsov
2008-06-01 10:18         ` Pierre Ossman
2008-06-02 12:53           ` Anton Vorontsov
2008-06-02 12:53             ` Anton Vorontsov
2008-06-05 21:16             ` Pierre Ossman
2008-05-23 18:28 ` [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver Anton Vorontsov
2008-05-23 18:28   ` Anton Vorontsov
2008-05-24  2:35   ` Stephen Rothwell
2008-05-24  2:35     ` Stephen Rothwell
2008-05-26 11:58     ` Anton Vorontsov
2008-05-26 11:58       ` Anton Vorontsov
2008-05-24  5:19   ` Grant Likely
2008-05-24  5:19     ` Grant Likely
2008-05-24 14:32     ` Jochen Friedrich
2008-05-24 14:32       ` Jochen Friedrich
2008-05-24 23:14       ` Segher Boessenkool
2008-05-24 23:14         ` Segher Boessenkool
2008-05-24 23:06     ` Segher Boessenkool
2008-05-24 23:06       ` Segher Boessenkool
2008-05-26 11:49     ` Anton Vorontsov
2008-05-26 11:49       ` Anton Vorontsov
2008-05-26 22:19       ` David Brownell
2008-05-26 22:19         ` David Brownell
2008-05-26 23:15         ` Anton Vorontsov
2008-05-26 23:15           ` Anton Vorontsov
2008-05-24 19:56 ` [RFC] OpenFirmware bindings for the MMC-over-SPI driver David Brownell
2008-05-24 19:56   ` David Brownell
2008-05-25  4:47   ` Grant Likely
2008-05-25  4:47     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080526122533.GA9595@polina.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=g.liakhovetski@gmx.de \
    --cc=garyj@denx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.