From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Gary Jennejohn <garyj@denx.de>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Pierre Ossman <drzeus-mmc@drzeus.cx>
Subject: Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver
Date: Sun, 25 May 2008 01:06:08 +0200 [thread overview]
Message-ID: <5779f808f6188a88231bf2a8c49e52d5@kernel.crashing.org> (raw)
In-Reply-To: <fa686aa40805232219x7e888d80y394958f1c0a0fad0@mail.gmail.com>
>> + Required properties:
>> + - #address-cells : should be 0.
>> + - #size-cells : should be 0.
>
> Are these properties required at all? Will this node have any
> children.
You mean, "does this node define a bus". If it doesn't, there
shouldn't be #a and #s; if it does, the binding should describe
what the addressing is. #a = #s = 0 describes a bus without any
addressing; pretty unusual :-)
>> + - linux,mmc-ocr-mask : (optional) Linux-specific MMC OCR mask
>> + (slot voltage).
>
> Should this property be better defined?
Yes please. There's a good chance that it doesn't turn out to be
Linux-specific at all (after some modification, perhaps).
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
Pierre Ossman <drzeus-mmc@drzeus.cx>,
"Anton Vorontsov" <avorontsov@ru.mvista.com>,
David Brownell <dbrownell@users.sourceforge.net>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Gary Jennejohn <garyj@denx.de>,
linuxppc-dev@ozlabs.org
Subject: Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver
Date: Sun, 25 May 2008 01:06:08 +0200 [thread overview]
Message-ID: <5779f808f6188a88231bf2a8c49e52d5@kernel.crashing.org> (raw)
In-Reply-To: <fa686aa40805232219x7e888d80y394958f1c0a0fad0@mail.gmail.com>
>> + Required properties:
>> + - #address-cells : should be 0.
>> + - #size-cells : should be 0.
>
> Are these properties required at all? Will this node have any
> children.
You mean, "does this node define a bus". If it doesn't, there
shouldn't be #a and #s; if it does, the binding should describe
what the addressing is. #a = #s = 0 describes a bus without any
addressing; pretty unusual :-)
>> + - linux,mmc-ocr-mask : (optional) Linux-specific MMC OCR mask
>> + (slot voltage).
>
> Should this property be better defined?
Yes please. There's a good chance that it doesn't turn out to be
Linux-specific at all (after some modification, perhaps).
Segher
next prev parent reply other threads:[~2008-05-24 23:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 18:27 [RFC] OpenFirmware bindings for the MMC-over-SPI driver Anton Vorontsov
2008-05-23 18:27 ` Anton Vorontsov
2008-05-23 18:28 ` [RFC PATCH 1/2] mmc_spi: export probe and remove functions Anton Vorontsov
2008-05-23 18:28 ` Anton Vorontsov
2008-05-26 12:18 ` Pierre Ossman
2008-05-26 12:25 ` Anton Vorontsov
2008-05-26 12:25 ` Anton Vorontsov
2008-05-26 13:10 ` Anton Vorontsov
2008-05-26 13:10 ` Anton Vorontsov
2008-06-01 10:18 ` Pierre Ossman
2008-06-02 12:53 ` Anton Vorontsov
2008-06-02 12:53 ` Anton Vorontsov
2008-06-05 21:16 ` Pierre Ossman
2008-05-23 18:28 ` [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver Anton Vorontsov
2008-05-23 18:28 ` Anton Vorontsov
2008-05-24 2:35 ` Stephen Rothwell
2008-05-24 2:35 ` Stephen Rothwell
2008-05-26 11:58 ` Anton Vorontsov
2008-05-26 11:58 ` Anton Vorontsov
2008-05-24 5:19 ` Grant Likely
2008-05-24 5:19 ` Grant Likely
2008-05-24 14:32 ` Jochen Friedrich
2008-05-24 14:32 ` Jochen Friedrich
2008-05-24 23:14 ` Segher Boessenkool
2008-05-24 23:14 ` Segher Boessenkool
2008-05-24 23:06 ` Segher Boessenkool [this message]
2008-05-24 23:06 ` Segher Boessenkool
2008-05-26 11:49 ` Anton Vorontsov
2008-05-26 11:49 ` Anton Vorontsov
2008-05-26 22:19 ` David Brownell
2008-05-26 22:19 ` David Brownell
2008-05-26 23:15 ` Anton Vorontsov
2008-05-26 23:15 ` Anton Vorontsov
2008-05-24 19:56 ` [RFC] OpenFirmware bindings for the MMC-over-SPI driver David Brownell
2008-05-24 19:56 ` David Brownell
2008-05-25 4:47 ` Grant Likely
2008-05-25 4:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5779f808f6188a88231bf2a8c49e52d5@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dbrownell@users.sourceforge.net \
--cc=drzeus-mmc@drzeus.cx \
--cc=g.liakhovetski@gmx.de \
--cc=garyj@denx.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.