From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Suresh Siddha <suresh.b.siddha@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: merge __acpi_map_table
Date: Wed, 9 Jul 2008 20:16:36 -0700 [thread overview]
Message-ID: <200807092016.36490.yhlu.kernel@gmail.com> (raw)
In-Reply-To: <200807092015.03004.yhlu.kernel@gmail.com>
and let 64bit fallback to use fixmap too
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
arch/x86/kernel/acpi/boot.c | 23 ++++++-----------------
include/asm-x86/fixmap_64.h | 5 +++++
2 files changed, 11 insertions(+), 17 deletions(-)
Index: linux-2.6/arch/x86/kernel/acpi/boot.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/acpi/boot.c
+++ linux-2.6/arch/x86/kernel/acpi/boot.c
@@ -109,21 +109,6 @@ static u64 acpi_lapic_addr __initdata =
*/
enum acpi_irq_model_id acpi_irq_model = ACPI_IRQ_MODEL_PIC;
-#ifdef CONFIG_X86_64
-
-/* rely on all ACPI tables being in the direct mapping */
-char *__init __acpi_map_table(unsigned long phys_addr, unsigned long size)
-{
- if (!phys_addr || !size)
- return NULL;
-
- if (phys_addr+size <= (max_pfn_mapped << PAGE_SHIFT) + PAGE_SIZE)
- return __va(phys_addr);
-
- return NULL;
-}
-
-#else
/*
* Temporarily use the virtual area starting from FIX_IO_APIC_BASE_END,
@@ -142,11 +127,15 @@ char *__init __acpi_map_table(unsigned l
unsigned long base, offset, mapped_size;
int idx;
- if (phys + size < 8 * 1024 * 1024)
+ if (!phys || !size)
+ return NULL;
+
+ if (phys+size <= (max_pfn_mapped << PAGE_SHIFT))
return __va(phys);
offset = phys & (PAGE_SIZE - 1);
mapped_size = PAGE_SIZE - offset;
+ clear_fixmap(FIX_ACPI_END);
set_fixmap(FIX_ACPI_END, phys);
base = fix_to_virt(FIX_ACPI_END);
@@ -158,13 +147,13 @@ char *__init __acpi_map_table(unsigned l
if (--idx < FIX_ACPI_BEGIN)
return NULL; /* cannot handle this */
phys += PAGE_SIZE;
+ clear_fixmap(idx);
set_fixmap(idx, phys);
mapped_size += PAGE_SIZE;
}
return ((unsigned char *)base + offset);
}
-#endif
#ifdef CONFIG_PCI_MMCONFIG
/* The physical address of the MMCONFIG aperture. Set from ACPI tables. */
Index: linux-2.6/include/asm-x86/fixmap_64.h
===================================================================
--- linux-2.6.orig/include/asm-x86/fixmap_64.h
+++ linux-2.6/include/asm-x86/fixmap_64.h
@@ -12,6 +12,7 @@
#define _ASM_FIXMAP_64_H
#include <linux/kernel.h>
+#include <asm/acpi.h>
#include <asm/apicdef.h>
#include <asm/page.h>
#include <asm/vsyscall.h>
@@ -49,6 +50,10 @@ enum fixed_addresses {
#ifdef CONFIG_PARAVIRT
FIX_PARAVIRT_BOOTMAP,
#endif
+#ifdef CONFIG_ACPI
+ FIX_ACPI_BEGIN,
+ FIX_ACPI_END = FIX_ACPI_BEGIN + FIX_ACPI_PAGES - 1,
+#endif
#ifdef CONFIG_PROVIDE_OHCI1394_DMA_INIT
FIX_OHCI1394_BASE,
#endif
next prev parent reply other threads:[~2008-07-10 3:18 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 8:41 [PATCH] x86: introduce page_size_mask for 64bit Yinghai Lu
2008-07-08 8:43 ` [PATCH] x86: not overmap than end in init_memory_mapping - 64bit Yinghai Lu
2008-07-09 7:38 ` Ingo Molnar
2008-07-09 8:34 ` Ingo Molnar
2008-07-09 8:37 ` Yinghai Lu
2008-07-09 8:46 ` Ingo Molnar
2008-07-09 8:58 ` Yinghai Lu
2008-07-09 10:01 ` Yinghai Lu
2008-07-09 10:30 ` Ingo Molnar
2008-07-09 8:45 ` Ingo Molnar
2008-07-10 3:15 ` [PATCh] x86: overmapped fix when 4K pages on tail " Yinghai Lu
2008-07-10 3:16 ` Yinghai Lu [this message]
2008-07-10 3:17 ` [PATCH] x86: make e820_end return end_of_ram again for 64bit Yinghai Lu
2008-07-10 7:00 ` Ingo Molnar
2008-07-10 11:17 ` [PATCH] x86: e820 remove the range instead of update it to reserved Yinghai Lu
2008-07-11 8:20 ` Ingo Molnar
2008-07-11 3:36 ` [PATCH] x86: save slit Yinghai Lu
2008-07-11 8:22 ` Ingo Molnar
2008-07-11 3:38 ` [PATCH] x86: introduce max_low_pfn_mapped for 64bit Yinghai Lu
2008-07-11 8:26 ` Ingo Molnar
2008-07-11 8:39 ` Yinghai Lu
2008-07-11 8:51 ` Ingo Molnar
2008-07-12 1:41 ` [PATCH] x86: let 32bit use apic_ops too Yinghai Lu
2008-07-12 1:43 ` [PATCH] x86: mach_apicdef.h need to include before smp.h Yinghai Lu
2008-07-12 1:44 ` [PATCH] x86: make read_apic_id return final apicid Yinghai Lu
2008-07-12 8:01 ` [PATCH] x86: make 64bit have get_apic_id Yinghai Lu
2008-07-13 6:28 ` Ingo Molnar
2008-07-13 6:59 ` Ingo Molnar
2008-07-13 7:05 ` Yinghai Lu
2008-07-13 9:23 ` Ingo Molnar
2008-07-13 9:28 ` Ingo Molnar
2008-07-13 16:15 ` Suresh Siddha
2008-07-13 1:19 ` [PATCH] x86: make read_apic_id return final apicid Suresh Siddha
2008-07-13 1:08 ` [PATCH] x86: let 32bit use apic_ops too Suresh Siddha
2008-07-13 2:04 ` Yinghai Lu
2008-07-13 16:28 ` Suresh Siddha
2008-07-13 16:51 ` Maciej W. Rozycki
2008-07-13 17:16 ` Cyrill Gorcunov
2008-07-13 23:46 ` Maciej W. Rozycki
2008-07-14 16:48 ` Cyrill Gorcunov
2008-07-14 17:20 ` Maciej W. Rozycki
2008-07-14 18:09 ` Cyrill Gorcunov
2008-07-14 18:24 ` Maciej W. Rozycki
2008-07-14 18:32 ` Cyrill Gorcunov
2008-07-13 1:43 ` Maciej W. Rozycki
2008-07-13 1:45 ` Yinghai Lu
2008-07-13 1:54 ` Maciej W. Rozycki
2008-07-13 16:43 ` Suresh Siddha
2008-07-13 17:05 ` Maciej W. Rozycki
2008-07-14 5:19 ` [PATCH] x86: let 32bit use apic_ops too - fix Yinghai Lu
2008-07-14 7:12 ` Ingo Molnar
2008-07-14 16:49 ` Suresh Siddha
2008-07-14 17:00 ` Yinghai Lu
2008-07-14 18:03 ` Suresh Siddha
2008-07-18 17:06 ` Ingo Molnar
2008-07-15 17:33 ` Suresh Siddha
2008-07-15 18:10 ` Yinghai Lu
2008-07-15 18:27 ` Suresh Siddha
2008-07-18 17:07 ` Ingo Molnar
2008-07-12 21:30 ` [PATCH] x86: max_low_pfn_mapped fix #1 Yinghai Lu
2008-07-13 9:45 ` Ingo Molnar
2008-07-12 21:31 ` [PATCH] x86: max_low_pfn_mapped fix #2 Yinghai Lu
2008-07-12 21:32 ` [PATCH] x86: max_low_pfn_mapped fix #3 Yinghai Lu
2008-07-13 21:29 ` [PATCH] x86: max_low_pfn_mapped fix #4 Yinghai Lu
2008-07-13 21:30 ` [PATCH] x86: get x86_phys_bits early Yinghai Lu
2008-07-13 21:32 ` [PATCH] x86: make 64bit hpet_set_mapping to use ioremap too Yinghai Lu
2008-07-13 21:50 ` [PATCH] x86: make 64bit hpet_set_mapping to use ioremap too v2 Yinghai Lu
2008-07-10 6:54 ` [PATCH] x86: merge __acpi_map_table Ingo Molnar
2008-07-10 6:53 ` [PATCh] x86: overmapped fix when 4K pages on tail - 64bit Ingo Molnar
2008-07-10 6:57 ` Yinghai Lu
2008-07-10 7:20 ` Ingo Molnar
2008-07-10 7:32 ` Yinghai Lu
2008-07-10 14:16 ` Arjan van de Ven
2008-07-13 14:57 ` Andi Kleen
2008-07-13 15:33 ` Arjan van de Ven
2008-07-13 18:25 ` Andi Kleen
2008-07-13 18:17 ` Yinghai Lu
2008-07-13 18:48 ` Andi Kleen
2008-07-13 19:00 ` Yinghai Lu
2008-07-13 20:32 ` Ingo Molnar
2008-07-13 20:51 ` Andi Kleen
2008-07-14 0:04 ` H. Peter Anvin
2008-07-14 6:39 ` Andi Kleen
2008-07-09 7:38 ` [PATCH] x86: introduce page_size_mask for 64bit Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807092016.36490.yhlu.kernel@gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.