Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE (summary)

[Carles Pina i Estany <carles@pina.cat>]

Hello,

On Aug/24/2008, Carles Pina i Estany wrote:

> ChangeLog:
> --------
> 2008-08-24  Carles Pina i Estany  <carles@pina.cat>
> 
> 	* include/grub/powerpc/ieee1275/console.h (GRUB_TERM_NPAGE):
> 	Changed to 0x5100.
> 	(GRUB_TERM_PPAGE): Changed to 0x4900.
> 
> 	* include/grub/sparc64/ieee1275/console.h: Likewise.
> 
> 	* include/grub/i386/pc/console.h: Likewise.
> 
> 	* include/grub/efi/console.h: Likewise.
> --------
> 
> (this new values are the same used in Grub and also the same that one
> can find googling for PGUP and PGDN key codes).
> 
> If everything is correct, could someone please commit it?

summarizing all discussions about this topic (there is three different
issues):

a) This patch fix the incorrect values of GRUB_TERM_PPAGE/NPAGE. In my
opinion, can be committed (so, feel free to commit if you think so).

b) The name of PPAGE/NPAGE/IC/... are ncurses based and not very
intuitive. Discussing if we should change these names in the same
thread.

c) If it's save merging all places where these macros appears (including
a new file with the values). Discussing in the same thread.

I would go patching or not patching these issues one by one or we will
discuss it forever :-)

-- 
Carles Pina i Estany		GPG id: 0x17756391
	http://pinux.info